1. 28 May, 2019 2 commits
  2. 06 May, 2019 1 commit
  3. 01 May, 2019 1 commit
  4. 29 Apr, 2019 1 commit
  5. 25 Apr, 2019 1 commit
  6. 22 Apr, 2019 1 commit
  7. 19 Apr, 2019 2 commits
  8. 16 Apr, 2019 1 commit
  9. 21 Mar, 2019 1 commit
  10. 15 Mar, 2019 1 commit
  11. 09 Mar, 2019 1 commit
  12. 07 Mar, 2019 1 commit
  13. 21 Feb, 2019 1 commit
  14. 16 Feb, 2019 1 commit
  15. 12 Feb, 2019 1 commit
  16. 28 Jan, 2019 1 commit
  17. 25 Jan, 2019 1 commit
  18. 19 Jan, 2019 1 commit
    • Ian Hickson's avatar
      [O] Removing all timeouts (mark II) (#26736) · 31a9626c
      Ian Hickson authored
      These are essentially self-inflicted race conditions. Instead of timeouts we're going to try a more verbose logging mechanism that points out when things are taking a long time.
      31a9626c
  19. 18 Jan, 2019 1 commit
  20. 09 Jan, 2019 1 commit
  21. 21 Dec, 2018 2 commits
    • Ian Hickson's avatar
      Revert "[O] Remove many timeouts. (#23531)" (#25646) · 8426910a
      Ian Hickson authored
      This reverts commit 76f70810.
      8426910a
    • Ian Hickson's avatar
      [O] Remove many timeouts. (#23531) · 76f70810
      Ian Hickson authored
      * Remove many timeouts.
      
      These are essentially self-inflicted race conditions. Instead of timeouts we're going to try a more verbose logging mechanism that points out when things are taking a long time.
      
      * Get the attach tests to pass.
      
      * Apply review comments from Todd
      
      * More review comment fixes
      
      * Put back the extended timeouts here now that I know why we have them...
      76f70810
  22. 14 Dec, 2018 1 commit
    • David Shuckerow's avatar
      Add ipv6 and observatory port support to the attach command (#25303) · 1a60b166
      David Shuckerow authored
      * Add ipv6 and observatory port support to the attach command.
      
      * Remove whitespace
      
      * Explain why a name change is useful here
      
      * Refactor common flags out into the parent
      
      * Add an additional test case for when observatory port is provided but debug port is not
      
      * Remove whitespace
      
      * Fix flag validation
      1a60b166
  23. 12 Dec, 2018 2 commits
  24. 01 Dec, 2018 1 commit
  25. 09 Nov, 2018 1 commit
  26. 06 Nov, 2018 2 commits
  27. 02 Nov, 2018 1 commit
  28. 24 Oct, 2018 1 commit
  29. 17 Oct, 2018 1 commit
    • Michael Klimushyn's avatar
      Set `FlutterDevice.viewFilter` by CLI flag (#23026) · 4f8acd84
      Michael Klimushyn authored
      `FlutterDevice.views` is limited by a filter. Pipe this filter up as an
      option for the commands that instantiate `FlutterDevice`s. This is the
      first change necessary for the CLI tooling to target specific isolates
      (#22009).
      
      More work needs to be done after this patch.
      * Isolate names are dynamically generated and change every restart.
      * This just filters views, not background isolates (`VMService.isolates`).
      4f8acd84
  30. 11 Oct, 2018 1 commit
    • Greg Spencer's avatar
      Re-land text wrapping/color PR (#22831) · 081d2a7a
      Greg Spencer authored
      This attempts to re-land #22656.
      
      There are two changes from the original:
      
      I turned off wrapping completely when not sending output to a terminal. Previously I had defaulted to wrapping at and arbitrary 100 chars in that case, just to keep long messages from being too long, but that turns out the be a bad idea because there are tests that are relying on the specific form of the output. It's also pretty arbitrary, and mostly people sending output to a non-terminal will want unwrapped text.
      
      I found a better way to terminate ANSI color/bold sequences, so that they can be embedded within each other without needed quite as complex a dance with removing redundant sequences.
      
      As part of these changes, I removed the Logger.supportsColor setter so that the one source of truth for color support is in AnsiTerminal.supportsColor.
      
      *     Turn on line wrapping again in usage and status messages, adds ANSI color to doctor and analysis messages. (#22656)
      
          This turns on text wrapping for usage messages and status messages. When on a terminal, wraps to the width of the terminal. When writing to a non-terminal, wrap lines at a default column width (currently defined to be 100 chars). If --no-wrap is specified, then no wrapping occurs. If --wrap-column is specified, wraps to that column (if --wrap is on).
      
          Adds ANSI color to the doctor and analysis output on terminals. This is in this PR with the wrapping, since wrapping needs to know how to count visible characters in the presence of ANSI sequences. (This is just one more step towards re-implementing all of Curses for Flutter. :-)) Will not print ANSI sequences when sent to a non-terminal, or of --no-color is specified.
      
          Fixes ANSI color and bold sequences so that they can be combined (bold, colored text), and a small bug in indentation calculation for wrapping.
      
          Since wrapping is now turned on, also removed many redundant '\n's in the code.
      081d2a7a
  31. 06 Oct, 2018 2 commits
    • Greg Spencer's avatar
      Revert "Turn on line wrapping in usage and status messages, adds ANSI color to... · 2d81adf7
      Greg Spencer authored
      Revert "Turn on line wrapping in usage and status messages, adds ANSI color to doctor and analysis messages. (#22656)" (#22759)
      
      This reverts commit e4386321
      because it breaks 160 benchmarks, and several devicelab tests,
      due to changing the format of the output.
      2d81adf7
    • Greg Spencer's avatar
      Turn on line wrapping in usage and status messages, adds ANSI color to doctor... · e4386321
      Greg Spencer authored
      Turn on line wrapping in usage and status messages, adds ANSI color to doctor and analysis messages. (#22656)
      
      This turns on text wrapping for usage messages and status messages. When on a terminal, wraps to the width of the terminal. When writing to a non-terminal, wrap lines at a default column width (currently defined to be 100 chars). If --no-wrap is specified, then no wrapping occurs. If --wrap-column is specified, wraps to that column (if --wrap is on).
      
      Adds ANSI color to the doctor and analysis output on terminals. This is in this PR with the wrapping, since wrapping needs to know how to count visible characters in the presence of ANSI sequences. (This is just one more step towards re-implementing all of Curses for Flutter. :-)) Will not print ANSI sequences when sent to a non-terminal, or of --no-color is specified.
      
      Fixes ANSI color and bold sequences so that they can be combined (bold, colored text), and a small bug in indentation calculation for wrapping.
      
      Since wrapping is now turned on, also removed many redundant '\n's in the code.
      e4386321
  32. 05 Oct, 2018 1 commit
  33. 12 Sep, 2018 1 commit
  34. 04 Sep, 2018 1 commit