Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
1459b1e9
Unverified
Commit
1459b1e9
authored
Apr 19, 2019
by
Ben Konyi
Committed by
GitHub
Apr 19, 2019
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fixed failing tests caused by introduction of authentication codes (#31315)
parent
eaf058d8
Changes
5
Hide whitespace changes
Inline
Side-by-side
Showing
5 changed files
with
17 additions
and
16 deletions
+17
-16
named_isolates_test.dart
dev/devicelab/bin/tasks/named_isolates_test.dart
+4
-3
run_machine_concurrent_hot_reload.dart
...evicelab/bin/tasks/run_machine_concurrent_hot_reload.dart
+5
-7
service_extensions_test.dart
dev/devicelab/bin/tasks/service_extensions_test.dart
+1
-1
utils.dart
dev/devicelab/lib/framework/utils.dart
+6
-4
attach.dart
packages/flutter_tools/lib/src/commands/attach.dart
+1
-1
No files found.
dev/devicelab/bin/tasks/named_isolates_test.dart
View file @
1459b1e9
...
...
@@ -43,10 +43,11 @@ void main() {
await
device
.
shellExec
(
'am'
,
<
String
>[
'start'
,
'-n'
,
_kActivityId
]);
final
String
observatoryLine
=
await
device
.
adb
(<
String
>[
'logcat'
,
'-e'
,
'Observatory listening on http:'
,
'-m'
,
'1'
,
'-T'
,
currentTime
]);
print
(
'Found observatory line:
$observatoryLine
'
);
final
String
observatory
Port
=
RegExp
(
r'Observatory listening on http://.*:([0-9
]+)'
).
firstMatch
(
observatoryLine
)[
1
];
print
(
'Extracted observatory port:
$observatory
Port
'
);
final
String
observatory
Uri
=
RegExp
(
'Observatory listening on ((http|
\
/
\
/)[a-zA-Z0-9:/=_
\\
-
\
.
\\
[
\\
]
]+)'
).
firstMatch
(
observatoryLine
)[
1
];
print
(
'Extracted observatory port:
$observatory
Uri
'
);
final
Process
attachProcess
=
await
_run
(
device:
device
,
command:
<
String
>[
'attach'
,
'--debug-port'
,
observatoryPort
,
'--isolate-filter'
,
'
$_kSecondIsolateName
'
],
stdoutListener:
(
String
line
)
{
await
_run
(
device:
device
,
command:
<
String
>[
'attach'
,
'--debug-uri'
,
observatoryUri
,
'--isolate-filter'
,
'
$_kSecondIsolateName
'
],
stdoutListener:
(
String
line
)
{
if
(
line
.
contains
(
_kFirstIsolateName
))
{
firstNameFound
.
complete
();
}
else
if
(
line
.
contains
(
_kSecondIsolateName
))
{
...
...
dev/devicelab/bin/tasks/run_machine_concurrent_hot_reload.dart
View file @
1459b1e9
...
...
@@ -31,7 +31,7 @@ void main() {
}
task
(()
async
{
int
vmServicePort
;
Uri
vmServiceUri
;
String
appId
;
final
Device
device
=
await
devices
.
workingDevice
;
...
...
@@ -60,14 +60,14 @@ void main() {
final
dynamic
json
=
parseFlutterResponse
(
line
);
if
(
json
!=
null
)
{
if
(
json
[
'event'
]
==
'app.debugPort'
)
{
vmService
Port
=
Uri
.
parse
(
json
[
'params'
][
'wsUri'
]).
port
;
print
(
'service protocol connection available at
port
$vmServicePort
'
);
vmService
Uri
=
Uri
.
parse
(
json
[
'params'
][
'wsUri'
])
;
print
(
'service protocol connection available at
$vmServiceUri
'
);
}
else
if
(
json
[
'event'
]
==
'app.started'
)
{
appId
=
json
[
'params'
][
'appId'
];
print
(
'application identifier is
$appId
'
);
}
}
if
(
vmService
Port
!=
null
&&
appId
!=
null
&&
!
ready
.
isCompleted
)
{
if
(
vmService
Uri
!=
null
&&
appId
!=
null
&&
!
ready
.
isCompleted
)
{
print
(
'run: ready!'
);
ready
.
complete
();
ok
??=
true
;
...
...
@@ -84,9 +84,7 @@ void main() {
if
(!
ok
)
throw
'Failed to run test app.'
;
final
VMServiceClient
client
=
VMServiceClient
.
connect
(
'ws://localhost:
$vmServicePort
/ws'
);
final
VMServiceClient
client
=
VMServiceClient
.
connect
(
vmServiceUri
);
int
id
=
1
;
Future
<
Map
<
String
,
dynamic
>>
sendRequest
(
String
method
,
dynamic
params
)
async
{
...
...
dev/devicelab/bin/tasks/service_extensions_test.dart
View file @
1459b1e9
...
...
@@ -81,7 +81,7 @@ void main() {
final
Future
<
VMExtensionEvent
>
navigationFuture
=
navigationEvents
.
first
;
// This tap triggers a navigation event.
device
.
tap
(
100
,
1
00
);
device
.
tap
(
100
,
2
00
);
final
VMExtensionEvent
navigationEvent
=
await
navigationFuture
;
// Validate that there are not any fields.
expect
(
navigationEvent
.
data
.
isEmpty
);
...
...
dev/devicelab/lib/framework/utils.dart
View file @
1459b1e9
...
...
@@ -542,10 +542,11 @@ int parseServicePort(String line, {
Pattern
prefix
,
})
{
prefix
??=
_obsRegExp
;
final
Match
prefixMatch
=
prefix
.
matchAsPrefix
(
line
);
if
(
prefixMatch
==
null
)
{
final
Iterable
<
Match
>
matchesIter
=
prefix
.
allMatches
(
line
);
if
(
matchesIter
.
isEmpty
)
{
return
null
;
}
final
Match
prefixMatch
=
matchesIter
.
first
;
final
List
<
Match
>
matches
=
_obsPortRegExp
.
allMatches
(
line
,
prefixMatch
.
end
).
toList
();
return
matches
.
isEmpty
?
null
:
int
.
parse
(
matches
[
0
].
group
(
2
));
...
...
@@ -559,10 +560,11 @@ Uri parseServiceUri(String line, {
Pattern
prefix
,
})
{
prefix
??=
_obsRegExp
;
final
Match
prefixMatch
=
prefix
.
matchAsPrefix
(
line
);
if
(
prefixMatch
==
null
)
{
final
Iterable
<
Match
>
matchesIter
=
prefix
.
allMatches
(
line
);
if
(
matchesIter
.
isEmpty
)
{
return
null
;
}
final
Match
prefixMatch
=
matchesIter
.
first
;
final
List
<
Match
>
matches
=
_obsUriRegExp
.
allMatches
(
line
,
prefixMatch
.
end
).
toList
();
return
matches
.
isEmpty
?
null
:
Uri
.
parse
(
matches
[
0
].
group
(
0
));
...
...
packages/flutter_tools/lib/src/commands/attach.dart
View file @
1459b1e9
...
...
@@ -233,7 +233,7 @@ class AttachCommand extends FlutterCommand {
}
}
else
{
observatoryUri
=
await
_buildObservatoryUri
(
device
,
debugUri
?.
host
??
hostname
,
devicePort
,
debugUri
?.
path
);
debugUri
?.
host
??
hostname
,
devicePort
??
debugUri
.
port
,
debugUri
?.
path
);
}
try
{
final
bool
useHot
=
getBuildInfo
().
isDebug
;
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment