1. 22 Apr, 2019 2 commits
  2. 01 Mar, 2019 1 commit
    • Alexandre Ardhuin's avatar
      Add missing trailing commas (#28673) · 387f8854
      Alexandre Ardhuin authored
      * add trailing commas on list/map/parameters
      
      * add trailing commas on Invocation with nb of arg>1
      
      * add commas for widget containing widgets
      
      * add trailing commas if instantiation contains trailing comma
      
      * revert bad change
      387f8854
  3. 13 Feb, 2019 1 commit
    • KyleWong's avatar
      Refactor build-number/build-name logic. (#27743) · 4b4a9400
      KyleWong authored
      This PR aims at several things:
      
      1. Use pub_semver to check a version in pubspec.yaml meets the requirements specified in https://semver.org/.
      2. Don't limit build-number/build-name as a fixed format. Instead, validate it according to the target(ios/android).
      3. Make sure that build-number/build-name are always validated no matter it's specified by the `flutter command` or version in pubspec.yaml.
      
      Fixes #27589
      4b4a9400
  4. 25 Jan, 2019 2 commits
  5. 19 Jan, 2019 1 commit
    • Ian Hickson's avatar
      [O] Removing all timeouts (mark II) (#26736) · 31a9626c
      Ian Hickson authored
      These are essentially self-inflicted race conditions. Instead of timeouts we're going to try a more verbose logging mechanism that points out when things are taking a long time.
      31a9626c
  6. 17 Jan, 2019 1 commit
  7. 21 Dec, 2018 1 commit
  8. 20 Dec, 2018 1 commit
  9. 23 Oct, 2018 1 commit
  10. 11 Oct, 2018 1 commit
    • Greg Spencer's avatar
      Re-land text wrapping/color PR (#22831) · 081d2a7a
      Greg Spencer authored
      This attempts to re-land #22656.
      
      There are two changes from the original:
      
      I turned off wrapping completely when not sending output to a terminal. Previously I had defaulted to wrapping at and arbitrary 100 chars in that case, just to keep long messages from being too long, but that turns out the be a bad idea because there are tests that are relying on the specific form of the output. It's also pretty arbitrary, and mostly people sending output to a non-terminal will want unwrapped text.
      
      I found a better way to terminate ANSI color/bold sequences, so that they can be embedded within each other without needed quite as complex a dance with removing redundant sequences.
      
      As part of these changes, I removed the Logger.supportsColor setter so that the one source of truth for color support is in AnsiTerminal.supportsColor.
      
      *     Turn on line wrapping again in usage and status messages, adds ANSI color to doctor and analysis messages. (#22656)
      
          This turns on text wrapping for usage messages and status messages. When on a terminal, wraps to the width of the terminal. When writing to a non-terminal, wrap lines at a default column width (currently defined to be 100 chars). If --no-wrap is specified, then no wrapping occurs. If --wrap-column is specified, wraps to that column (if --wrap is on).
      
          Adds ANSI color to the doctor and analysis output on terminals. This is in this PR with the wrapping, since wrapping needs to know how to count visible characters in the presence of ANSI sequences. (This is just one more step towards re-implementing all of Curses for Flutter. :-)) Will not print ANSI sequences when sent to a non-terminal, or of --no-color is specified.
      
          Fixes ANSI color and bold sequences so that they can be combined (bold, colored text), and a small bug in indentation calculation for wrapping.
      
          Since wrapping is now turned on, also removed many redundant '\n's in the code.
      081d2a7a
  11. 09 Oct, 2018 1 commit
  12. 06 Oct, 2018 2 commits
    • Greg Spencer's avatar
      Revert "Turn on line wrapping in usage and status messages, adds ANSI color to... · 2d81adf7
      Greg Spencer authored
      Revert "Turn on line wrapping in usage and status messages, adds ANSI color to doctor and analysis messages. (#22656)" (#22759)
      
      This reverts commit e4386321
      because it breaks 160 benchmarks, and several devicelab tests,
      due to changing the format of the output.
      2d81adf7
    • Greg Spencer's avatar
      Turn on line wrapping in usage and status messages, adds ANSI color to doctor... · e4386321
      Greg Spencer authored
      Turn on line wrapping in usage and status messages, adds ANSI color to doctor and analysis messages. (#22656)
      
      This turns on text wrapping for usage messages and status messages. When on a terminal, wraps to the width of the terminal. When writing to a non-terminal, wrap lines at a default column width (currently defined to be 100 chars). If --no-wrap is specified, then no wrapping occurs. If --wrap-column is specified, wraps to that column (if --wrap is on).
      
      Adds ANSI color to the doctor and analysis output on terminals. This is in this PR with the wrapping, since wrapping needs to know how to count visible characters in the presence of ANSI sequences. (This is just one more step towards re-implementing all of Curses for Flutter. :-)) Will not print ANSI sequences when sent to a non-terminal, or of --no-color is specified.
      
      Fixes ANSI color and bold sequences so that they can be combined (bold, colored text), and a small bug in indentation calculation for wrapping.
      
      Since wrapping is now turned on, also removed many redundant '\n's in the code.
      e4386321
  13. 05 Oct, 2018 1 commit
  14. 01 Oct, 2018 2 commits
    • Jonah Williams's avatar
      224f91e3
    • Chris Bracken's avatar
      Eliminate snapshot, depfile opts from bundle cmd (#22495) · b07d986f
      Chris Bracken authored
      Eliminates the --snapshot and --depfile parameters from the flutter
      bundle command. The snapshot parameter is unused in Dart 2 -- code is
      built to kernel .dill files and for profile/release builds, then AOT
      compiled.
      
      While depfiles are still used in Dart 2 (e.g. by the kernel compiler),
      there are enough assumptions in the code that they lie in the default
      location (e.g. in the Gradle build) and no reasons to support
      user-cusomisation that it makes sense to eliminate the --depfile option
      as well, and always use the default location.
      
      This commit also renames 'depFilePath' to 'depfilePath' for consistency
      across the codebase.
      b07d986f
  15. 28 Sep, 2018 1 commit
    • Stanislav Baranov's avatar
      Implement build flow for hot updates on Android (#22391) · 54c10f44
      Stanislav Baranov authored
      This also involves switching from Core JIT to App JIT snapshot, and replacing per-isolate VM snapshot with the shared VM snapshot.
      
      For now there is no separate update bundle file, as the generated update gets packaged directly into the APK for testing purposes.
      54c10f44
  16. 07 Sep, 2018 2 commits
    • Chris Bracken's avatar
      Revert "Eliminate snapshot/depfile options to build bundle (#21507)" (#21563) · 5ab9e707
      Chris Bracken authored
      This tickled a bug in KernelCompiler.compile() where the fingerprinter
      doesn't include the outputFilePath in its list of dependencies. As such,
      if the output .dill file is missing or corrupted, the fingerprint still
      matches and re-compile is skipped, even though it shouldn't be. I'll fix
      that in a followup, then look at how this triggered that issue. My
      hypothesis is that that it's due to the aot kernel compile and bundle
      kernel compile have separate output directories for the .dill files
      (build/ vs build/aot) but the same output directory for the associated
      depfiles (due to this patch).
      
      This reverts commit 43a106e9.
      5ab9e707
    • Chris Bracken's avatar
      Eliminate snapshot/depfile options to build bundle (#21507) · 43a106e9
      Chris Bracken authored
      The --snapshot argument was only necessary in Dart 1. The --depfile
      argument was only used in Dart 2 mode to pass to the kernel compiler,
      but was inconsistent with the 'build aot' command, where the depfile was
      always set to build/kernel_compile.d.
      
      This patch updates 'build bundle' to emit the depfile to a location
      consistent with the 'build aot' command; since it's not intended to be
      user-configurable and flutter.gradle hardcodes the location to
      build/kernel_compile.d either way, this patch also eliminates the
      ability to configure the filename altogether.
      43a106e9
  17. 04 Sep, 2018 2 commits
    • Chris Bracken's avatar
      Eliminate script snapshot support (#21387) · ed0b8be0
      Chris Bracken authored
      Script snapshots were only every used in Dart 1 mode, which is no longer
      supported.
      ed0b8be0
    • Chris Bracken's avatar
      Eliminate --preview-dart-2 flag (#21304) · 041ff621
      Chris Bracken authored
      This patch eliminates the --preview-dart-2/--no-preview-dart-2 flag,
      hardcoding all uses to true. It also defaults all previewDart2 method
      parameters to true, where they hadn't yet been.
      
      A series of subsequent patches will eliminate all previewDart2
      parameters and the associated code from within the codebase.
      041ff621
  18. 28 Aug, 2018 1 commit
  19. 16 Aug, 2018 1 commit
  20. 15 Jun, 2018 1 commit
  21. 13 Jun, 2018 1 commit
    • Chris Bracken's avatar
      Revert elimination of Dart 1 (#18460) · 2ae48845
      Chris Bracken authored
      fuchsia_tester.dart still assumes Dart 1. Previously, it ran tests directly
      from source, flutter_platform.dart automatically runs a kernel compile when
      operating in Dart 2 mode, but this assumes a functional Dart SDK is available
      in the artifacts directly, and fuchsia_tester.dart mocks out the artifacts
      directory with an empty temp dir.
      
      Remaining work is:
      1. Get the frontend server building as a dependency on Fuchsia.
      2. Patch fuchsia_tester.dart to use a valid Dart SDK and frontend server.
      
      This also reverts migration to Dart 2 typedef syntax.
      
      This reverts commit 6c56bb24. (#18362)
      This reverts commit 3daebd05. (#18316)
      2ae48845
  22. 08 Jun, 2018 3 commits
    • Chris Bracken's avatar
      It's time to #deleteDart1 (again) (#18316) · 3daebd05
      Chris Bracken authored
      * It's time to #deleteDart1 (#18293)
      
      Eliminates support for Dart 1 in flutter_tools, and drops our Dart 1
      benchmarks. All commands now run in Dart 1 mode only.
      
      Eliminates --preview-dart-2 / --no-preview-dart-2 support.
      
      * Fix indentation, remove no longer necessary .toList()
      
      * Only push udpated kernel if >0 invalidated srcs
      3daebd05
    • Chris Bracken's avatar
      Revert "It's time to #deleteDart1 (#18293)" (#18313) · 9495df4b
      Chris Bracken authored
      Several benchmarks started failing during kernel compile:
      1. Timeouts:
         * commands_test
         * hot_mode_dev_cycle__benchmark
         * run_machine_concurrent_hot_reload
         * service_extensions_test
      
      2. Kernel compiler crash:
         * hot_mode_dev_cycle_linux__benchmark
         * routing_test
      
      3. Unexpected termination:
         * hot_mode_dev_cycle_win__benchmark
      
      This reverts commit ed63e708.
      9495df4b
    • Chris Bracken's avatar
      It's time to #deleteDart1 (#18293) · ed63e708
      Chris Bracken authored
      Eliminates support for Dart 1 in flutter_tools, and drops our Dart 1
      benchmarks. All commands now run in Dart 1 mode only.
      
      Eliminates --preview-dart-2 / --no-preview-dart-2 support.
      ed63e708
  23. 05 Jun, 2018 1 commit
  24. 14 May, 2018 1 commit
  25. 12 Apr, 2018 1 commit
  26. 17 Mar, 2018 3 commits
  27. 16 Mar, 2018 3 commits
  28. 14 Feb, 2018 1 commit