- 08 Oct, 2015 2 commits
-
-
Adam Barth authored
It was trying to grab the route's performance before it was created. Now we create the performance eagerly again.
-
Adam Barth authored
-
- 07 Oct, 2015 5 commits
-
-
Hixie authored
Previously, RenderObjectElements didn't support being marked dirty. This is fine, except for MixedViewport and HomogeneousViewport, which have builder functions to which they hand themselves as a BuildContext. If those builder functions call, e.g., Theme.of(), then when the theme changes, the Inherited logic tries to tell the RenderObjectElement object that its dependencies changed and that doesn't go down well. This patch fixes this by making RenderObjectElement a BuildableElement, and making MixedViewport and HomogeneousViewport hook into that to rebuild themselves appropriately. Also, this was only found at all because ThemeData didn't implement operator==, so we were aggressively marking the entire tree dirty all the time. That's fixed here too. Also, I changed card_collection.dart to have more features to make this easier to test. This found bugs #1524, #1522, #1528, #1529, #1530, #1531.
-
Adam Barth authored
Separate Route and PerformanceRoute
-
Chinmay Garde authored
-
Chinmay Garde authored
-
Adam Barth authored
This patch prepares us to create routes that control their performances more closely.
-
- 06 Oct, 2015 24 commits
-
-
Mehmet Akin authored
Make checkbox widget to fit more closely to material design standard. Make changes to remove animation artefacts.
-
Hans Muller authored
Remove PopupMenu margin The margins make using showMenu's menuPosition argument difficult and they're not really needed. I also made a few small gratuitous changes in navigator.dart.
-
Hans Muller authored
The margins make using showMenu's menuPosition argument difficult and they're not really needed. I also made a few small gratuitous changes in navigator.dart.
-
Adam Barth authored
NetworkImage occasionally does not grab the image
-
Viktor Lidholt authored
Improvements to sprite physics
-
Viktor Lidholt authored
-
Adam Barth authored
I haven't been able to reproduce this bug consistently, but my theory is that the ImageDecoder was being garbage collected before it called its completion callback. This patch prevents that by keeping a reference to the image decoder while the callback is in flight. Fixes #801
-
Adam Barth authored
Simplify Scaffold
-
Adam Barth authored
ToolBar with a TabBar shouldn't have a shadow
-
Adam Barth authored
Rather than using a custom render object, we can just use a Stack.
-
Viktor Lidholt authored
-
Viktor Lidholt authored
Fixes to demo game
-
Adam Barth authored
PageableList should take initialPage instead of initialScrollOffset
-
Adam Barth authored
-
Adam Barth authored
This state object has a public API.
-
Viktor Lidholt authored
-
Adam Barth authored
This patch makes the level of the ToolBar configurable. I've also cleaned up the Tab code slightly. For some reason, there's still a hairline between the ToolBar and the TabBar. We might need to rethink how we draw the background a bit here. Fixes #1454
-
Adam Barth authored
In the vast majority of cases, folks should be interacting with the Widget rather than its State. Fixes #267
-
Adam Barth authored
Fixes #900
-
Adam Barth authored
This class has no clients.
-
Ian Hickson authored
Fix Focus
-
Adam Barth authored
Use Navigator to drive SnackBar
-
Adam Barth authored
Instead of waiting until build(), we now create the performance for a route in its constructor.
-
Adam Barth authored
Now SnackBar is an ephemeral route that uses a Placeholder to put itself into the Scaffold. Fixes #673
-
- 05 Oct, 2015 9 commits
-
-
Hixie authored
Focus.at() and company should be on Focus, not FocusState. _notifyDescendants() was using the wrong runtimeType. Let InheritedWidget update the descendants during build. When you setState() during build, assert that you're not markNeedsBuild()ing someone who isn't a descendant. Typo in Widget.toString().
-
Viktor Lidholt authored
-
Ian Hickson authored
Handle a route being dismissed before being popped
-
Ian Hickson authored
Add more debugging information to Widgets.
-
Hixie authored
(These are changes cherry-picked from in-flight branches since they are more independent and could be helpful even without those changes.) - Change RouteBuilder's signature to take a single argument in which the other fields are placed, so that we can keep iterating on those arguments without having to break compatibility each time. Also, this makes defining route builders much simpler (only one argument to ignore rather than a variable number). - Expose the next performance to RouteBuilders, since sometimes the route itself might not be where it's used. - Allow BuildContext to be used to walk children, just like it can for ancestors - Allow BuildContext to be used to get the Widget of the current BuildContext - Allow StatefulComponentElement to be referenced with a type specialisation so that you don't have to cast when you know what the type you're dealing with actually is.
-
Viktor Lidholt authored
Handle removal of sprite physics bodies during the physics simulation
-
Viktor Lidholt authored
-
Hixie authored
Ensure that if a route's performance is dismissed before the route is popped, that we pop the route.
-
Hixie authored
Also, fix comment mentioning syncConstructorArguments.
-