Commits · 5f796b2950959a1311d0dd785bdc75d1c066078d · abdullh.alsoleman / Front-End

12 Oct, 2023 21 commits

Roll Flutter Engine from cb37ebc81939 to dee90f16aacd (3 revisions) (#136502) · 5f796b29

engine-flutter-autoroll authored Oct 12, 2023

https://github.com/flutter/engine/compare/cb37ebc81939...dee90f16aacd

2023-10-12 skia-flutter-autoroll@skia.org Roll Skia from 8b110fd65de9 to bf557aeaaef8 (1 revision) (flutter/engine#46853)
2023-10-12 uysalere@gmail.com [fuchsia] Add fatal error for Vulkan failure (flutter/engine#46831)
2023-10-12 mdebbar@google.com [web] Stop using `flutterViewEmbedder` for platform views (flutter/engine#46046)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

5f796b29

Roll Flutter Engine from 7eb20a09073e to cb37ebc81939 (2 revisions) (#136492) · 856475c0

engine-flutter-autoroll authored Oct 12, 2023

https://github.com/flutter/engine/compare/7eb20a09073e...cb37ebc81939

2023-10-12 skia-flutter-autoroll@skia.org Roll Skia from 222fe6b9b0eb to 8b110fd65de9 (1 revision) (flutter/engine#46852)
2023-10-12 skia-flutter-autoroll@skia.org Roll Skia from fdcbbc4d5c25 to 222fe6b9b0eb (2 revisions) (flutter/engine#46849)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

856475c0

[SingleChildScrollView] Correct the offset pixels if it is out of range during layout (#136239) · 3f722c14

xubaolin authored Oct 12, 2023

Fixes https://github.com/flutter/flutter/issues/105733
FIxes https://github.com/flutter/flutter/issues/135865

The above two issues will not occur on the `ListView` widget, so after analyzing their differences, it was found that the `SingleChildScrollView` pixels were not corrected according to the content dimensions during layout.

### ListView correct the pixels codes
https://github.com/flutter/flutter/blob/5dfd78c2e30483a9a8668ba6b754d089b1e132c8/packages/flutter/lib/src/rendering/viewport.dart#L1462-L1465

We should correct the pixels to prevent the physics ballistic simulations.

This change makes them have the same behavior.

3f722c14

Allow `TapRegion` to consume tap events (#136305) · 22b0a62a

Greg Spencer authored Oct 12, 2023

## Description

In order for `MenuAnchor` menus to be able to not pass on the taps that close their menus, `TapRegion` needed a way to consume them.  This change adds a flag to the `TapRegion`, `consumeOutsideTap` that will consume taps that occur outside of the region if the flag is set (it is false by default). The same flag is added to `MenuAnchor` to allow selecting the behavior for menus.

`TapRegion` consumes the tap event by registering with the gesture arena and immediately resolving the tap as accepted if any regions in a group have `consumeOutsideTap` set to true.

This PR also deprecates `MenuAnchor.anchorTapClosesMenu`, since it is a much more limited version of the same feature that only applied to the anchor itself, and even then only applied to closing the menu, not passing along the tap.  The same functionality can now be implemented by handling a tap on the anchor widget and checking to see if the menu is open before closing it.

## Related Issues
 - https://github.com/flutter/flutter/issues/135327

## Tests
 - Added tests for `TapRegion` to make sure taps are consumed properly.

22b0a62a

Fix doc TODO (#136485) · 7ea5536f

Michael Goderbauer authored Oct 12, 2023

Underlying bug (https://github.com/dart-lang/dartdoc/issues/2276) has been fixed a while ago.

7ea5536f

Roll Flutter Engine from f02006736390 to 7eb20a09073e (4 revisions) (#136478) · 1b797baf

engine-flutter-autoroll authored Oct 12, 2023

https://github.com/flutter/engine/compare/f02006736390...7eb20a09073e

2023-10-12 skia-flutter-autoroll@skia.org Roll Skia from 1d134a8f3ae2 to fdcbbc4d5c25 (7 revisions) (flutter/engine#46844)
2023-10-12 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from 8AXhoo-MMME8NMKt0... to XnH2CtqEH7byTHna7... (flutter/engine#46843)
2023-10-12 chinmaygarde@google.com [Impeller] Specify default border color for texture wrap mode that clamps. (flutter/engine#46806)
2023-10-12 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from giQtXxdSj6NdIViCw... to QLiomHC9D-GWh_gyK... (flutter/engine#46838)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from giQtXxdSj6Nd to QLiomHC9D-GW
fuchsia/sdk/core/mac-amd64 from 8AXhoo-MMME8 to XnH2CtqEH7by

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

1b797baf

Bump file,process,process_runner (#136418) · 43736132
Michael Goderbauer authored Oct 12, 2023

43736132

Roll Flutter Engine from 664657d32992 to f02006736390 (3 revisions) (#136467) · 90b24fb5

engine-flutter-autoroll authored Oct 12, 2023

https://github.com/flutter/engine/compare/664657d32992...f02006736390

2023-10-12 zanderso@users.noreply.github.com Remove the frontend server wrapper (flutter/engine#46440)
2023-10-12 jason-simmons@users.noreply.github.com Roll SwiftShader to include a fix required by the latest Clang toolchain (flutter/engine#46803)
2023-10-12 skia-flutter-autoroll@skia.org Roll Skia from 2dd1579c6921 to 1d134a8f3ae2 (5 revisions) (flutter/engine#46824)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

90b24fb5

Fix PageView API doc sample fails on Desktop and Web (#135910) · e8a0cf3a

huycozy authored Oct 12, 2023

### Description

This PR aims to improve/fix the PageView API doc sample for Web and Desktop platforms. On these platforms, mouse dragging gestures do not provide natural behavior similar to other desktop applications. This PR will add navigation buttons (indicators) so users can interact with the demo.

### Related issue

Fixes https://github.com/flutter/flutter/issues/135188

### Demo video

https://github.com/flutter/flutter/assets/104349824/0f9c60bd-8b18-404e-b5b6-1d594604de31

e8a0cf3a

Add `--trace-to-file` option to `flutter run` (#135713) · 406c4dbf
Derek Xu authored Oct 12, 2023

406c4dbf
[flutter_tools] handle ERROR_INVALID_FUNCTION when trying to symlink across drives (#136424) · 9751fe64
Christopher Fujino authored Oct 12, 2023
```
~~Fixes https://github.com/flutter/flutter/issues/136321~~

edit by @andrewkolos: Fixes https://github.com/flutter/flutter/issues/66224
```
9751fe64

Updates references to `finders.dart` in `controller.dart` to use a namespace. (#136423) · fa827eb2

pdblasi-google authored Oct 12, 2023

Updates references to `finders.dart` in `controller.dart` to use a namespace. This enables us to make use of `finders.dart#find` in `SemanticsController` without anything being shadowed.

Fixes #136421

fa827eb2

Change some tests to run on macs without iOS devices attached (#136463) · d6ec0cf5

Victoria Ashworth authored Oct 12, 2023

Some tests have been running on devicelab bots with iOS devices attached, however, they don't require an iOS device. So moving them to run on bots without iOS devices.

Fixes https://github.com/flutter/flutter/issues/136415.

d6ec0cf5

Roll Packages from 4b483f242936 to 93c3f69fa6c6 (9 revisions) (#136461) · ee7e41fe

engine-flutter-autoroll authored Oct 12, 2023

https://github.com/flutter/packages/compare/4b483f242936...93c3f69fa6c6

2023-10-12 goderbauer@google.com [shared_preferences] update file version constraints (flutter/packages#5121)
2023-10-12 supercionci@hotmail.it [cross_file] Improved documentation about ignored parameters in IO module. (flutter/packages#4416)
2023-10-11 41873024+droidbg@users.noreply.github.com [in_app_purchase] [#135759] Fix. doc reference finishPurchase to completePurchase. (flutter/packages#5081)
2023-10-10 zeucxb@gmail.com Update repo README issues link (flutter/packages#5106)
2023-10-10 43643339+nohli@users.noreply.github.com [flutter_markdown] Fix typo in readme (flutter/packages#5096)
2023-10-10 43054281+camsim99@users.noreply.github.com [camerax] Implements torch mode (flutter/packages#4903)
2023-10-10 25266387+Leptopoda@users.noreply.github.com [shared_preferences] fix documentation wording (flutter/packages#4986)
2023-10-10 katelovett@google.com [two_dimensional_scrollables] Fix paint bug when rows/columns are pinned and axes are reversed (flutter/packages#5038)
2023-10-10 engine-flutter-autoroll@skia.org Roll Flutter from f52fe4f7 to 83134ac7 (25 revisions) (flutter/packages#5104)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

ee7e41fe

Fix typo in function name (#136273) · ddc9b40a
Victoria Ashworth authored Oct 12, 2023
```
Rename `removeIOSimulator` to `removeIOSSimulator`.
```
ddc9b40a

Fix chip widgets don't the apply provided `iconTheme` (#135751) · f65dd3ba

Taha Tesser authored Oct 12, 2023

fixes [`Chip.iconTheme` does not apply the icon theme](https://github.com/flutter/flutter/issues/111828)

### Description
- Fix chip widgets that don't utilize the provided `iconTheme`.
- Prevent `iconTheme` with just color from overriding the default icon size.
- Add some missing M3 tests for the chip and chip theme properties.

### Code sample

<details>
<summary>expand to view the code sample</summary> 

```dart
import 'package:flutter/material.dart';

void main() => runApp(const MyApp());

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      debugShowCheckedModeBanner: false,
      theme: ThemeData(useMaterial3: true),
      home: const Example(),
    );
  }
}

class Example extends StatefulWidget {
  const Example({super.key});

  @override
  State<Example> createState() => _ExampleState();
}

class _ExampleState extends State<Example> {
  final bool _isEnable = true;

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      body: Center(
        child: Column(
          mainAxisAlignment: MainAxisAlignment.spaceEvenly,
          children: <Widget>[
            RawChip(
              iconTheme: const IconThemeData(color: Colors.amber),
              avatar: const Icon(Icons.favorite_rounded),
              label: const Text('RawChip'),
              onPressed: () {},
              isEnabled: _isEnable,
            ),
            const Chip(
              iconTheme: IconThemeData(color: Colors.amber),
              avatar: Icon(Icons.favorite_rounded),
              label: Text('Chip'),
              // onDeleted: () {},
            ),
            FilterChip(
              iconTheme: const IconThemeData(color: Colors.amber),
              avatar: const Icon(Icons.favorite_rounded),
              label: const Text('FilterChip'),
              selected: false,
              onSelected: _isEnable ? (bool value) {} : null,
            ),
            InputChip(
              iconTheme: const IconThemeData(color: Colors.amber),
              avatar: const Icon(Icons.favorite_rounded),
              label: const Text('InputChip'),
              isEnabled: _isEnable,
              onPressed: () {},
            ),
            ActionChip(
              iconTheme: const IconThemeData(color: Colors.amber),
              avatar: const Icon(Icons.favorite_rounded),
              label: const Text('ActionChip'),
              onPressed: _isEnable ? () {} : null,
            ),
            ChoiceChip(
              iconTheme: const IconThemeData(color: Colors.amber),
              avatar: const Icon(Icons.favorite_rounded),
              label: const Text('ChoiceChip'),
              selected: false,
              onSelected: _isEnable ? (bool value) {} : null,
            ),
          ],
        ),
      ),
      floatingActionButton: FloatingActionButton(
        onPressed: () {},
        child: const Icon(Icons.add),
      ),
    );
  }
}

```

</details>

### Before
![Screenshot 2023-09-29 at 16 59 39](https://github.com/flutter/flutter/assets/48603081/4bc32032-cff3-4237-812f-86f17ed95337)

### After

![Screenshot 2023-09-29 at 16 55 24](https://github.com/flutter/flutter/assets/48603081/05a1fc52-fb31-4790-a840-18f2e9718241)

f65dd3ba

Roll Flutter Engine from 33a6d21b3364 to 664657d32992 (2 revisions) (#136450) · fad8bda6

engine-flutter-autoroll authored Oct 12, 2023

https://github.com/flutter/engine/compare/33a6d21b3364...664657d32992

2023-10-12 skia-flutter-autoroll@skia.org Roll Dart SDK from 9afac395dfb1 to 34c06f0bcb29 (1 revision) (flutter/engine#46820)
2023-10-12 skia-flutter-autoroll@skia.org Roll ICU from 985b9a6f70e1 to 995db880cff2 (1 revision) (flutter/engine#46818)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

fad8bda6

Roll Flutter Engine from d00fabf0b919 to 33a6d21b3364 (5 revisions) (#136442) · b89e1df7

engine-flutter-autoroll authored Oct 12, 2023

https://github.com/flutter/engine/compare/d00fabf0b919...33a6d21b3364

2023-10-12 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from Qjz4zE4Oe0AO_7T3f... to 8AXhoo-MMME8NMKt0... (flutter/engine#46814)
2023-10-12 skia-flutter-autoroll@skia.org Roll Skia from 9f5080c58aac to 2dd1579c6921 (1 revision) (flutter/engine#46813)
2023-10-12 skia-flutter-autoroll@skia.org Roll Dart SDK from db2465f106ad to 9afac395dfb1 (1 revision) (flutter/engine#46812)
2023-10-12 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from hMA99PoacaRZVXHgr... to giQtXxdSj6NdIViCw... (flutter/engine#46811)
2023-10-12 skia-flutter-autoroll@skia.org Roll Skia from ff3c2e3d45bd to 9f5080c58aac (1 revision) (flutter/engine#46809)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from hMA99PoacaRZ to giQtXxdSj6Nd
fuchsia/sdk/core/mac-amd64 from Qjz4zE4Oe0AO to 8AXhoo-MMME8

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

b89e1df7

Roll Flutter Engine from 05e26c1b2c79 to d00fabf0b919 (5 revisions) (#136431) · c0d19ca5

engine-flutter-autoroll authored Oct 12, 2023

https://github.com/flutter/engine/compare/05e26c1b2c79...d00fabf0b919

2023-10-12 skia-flutter-autoroll@skia.org Roll Skia from 924df8d87766 to ff3c2e3d45bd (1 revision) (flutter/engine#46807)
2023-10-11 skia-flutter-autoroll@skia.org Roll Dart SDK from 0732be6b823a to db2465f106ad (8 revisions) (flutter/engine#46797)
2023-10-11 bdero@google.com [Impeller] Use triangle strips to dedupe rectangle vertices. (flutter/engine#46610)
2023-10-11 bdero@google.com [Impeller] Bump impeller-cmake (flutter/engine#46764)
2023-10-11 skia-flutter-autoroll@skia.org Roll Skia from 2459d71707e0 to 924df8d87766 (7 revisions) (flutter/engine#46798)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

c0d19ca5

Floating `SnackBar` should always float above the bottom widgets (#136411) · 6388e3d7

Qun Cheng authored Oct 12, 2023

Fixes #136162

This PR is to fix the floating `SnackBar` issue so that when the top of the bottom bar is higher than the top of the FAB, the snack bar will still float and not be clipped.

| Before fix | After fix |
|--------|--------|
| ![Screenshot 2023-10-11 at 1 54 30 PM](https://github.com/flutter/flutter/assets/36861262/dbe02312-1a80-4532-9bad-a8f162a6a942) | ![Screenshot 2023-10-11 at 1 54 52 PM](https://github.com/flutter/flutter/assets/36861262/68211de0-f04f-4b1a-b554-baf6a8e2f947)
 |

6388e3d7

SearchBar should listen to changes to the SearchController and update... · d9c0d3ae

Bryan Olivares authored Oct 12, 2023

SearchBar should listen to changes to the SearchController and update suggestions on change (#134337)

This PR is adding a listener to the `SearchController`, so that the `suggestionBuilder` can be updated when the `SearchController` changes.

Another method we can possibly do is have an update method on `SearchController`, so that the user can manually update the suggestions instead of us doing it automatically.

Fixes #132161

d9c0d3ae

11 Oct, 2023 19 commits

Allow latest pkg:material_color_utilities (#132445) · 3e60999b

Kevin Moore authored Oct 11, 2023

* Allow latest pkg:material_color_utilities
* Bump other dependencies to their latest - including pkg:web

3e60999b

Roll Flutter Engine from 8bf1460892c6 to 05e26c1b2c79 (3 revisions) (#136422) · 69582541

engine-flutter-autoroll authored Oct 11, 2023

https://github.com/flutter/engine/compare/8bf1460892c6...05e26c1b2c79

2023-10-11 jason-simmons@users.noreply.github.com Run the binary size treemap script from the buildroot directory (flutter/engine#46740)
2023-10-11 dnfield@google.com [Impeller] flutter_tester --enable-impeller (flutter/engine#46389)
2023-10-11 jacksongardner@google.com Switch to Chrome For Testing instead of Chromium (flutter/engine#46683)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

69582541

Create template for umbrella issues (#134235) · 6027d5d3

Kevin Chisholm authored Oct 11, 2023

In order to better track features, I propose that we have a unified
template for creating Umbrella issues. This is not required to create
umbrella issue to add to the feature tracker, however for those who
would like a more fleshed out format, this will serve the purpose.

Fixes: https://github.com/flutter/flutter/issues/134234

6027d5d3

[Windows Arm64] Add the 'platform_channel_sample_test_windows' Devicelab test (#136401) · 50b56de2

Loïc Sharma authored Oct 11, 2023

â Successful run: https://ci.chromium.org/raw/build/logs.chromium.org/flutter/led/loicsharma_google.com/2a327123e9b69a21e8219897ddef705066277875590a1266a5807aced1a851fb/+/build.proto?server=chromium-swarm.appspot.com

Part of https://github.com/flutter/flutter/issues/129806

50b56de2

Roll Flutter Engine from 2b1b4b97f787 to 8bf1460892c6 (4 revisions) (#136414) · a44e0862

engine-flutter-autoroll authored Oct 11, 2023

https://github.com/flutter/engine/compare/2b1b4b97f787...8bf1460892c6

2023-10-11 34871572+gmackall@users.noreply.github.com Revert "[Android] Add support for text processing actions (#44579)" (flutter/engine#46788)
2023-10-11 danchevalier@google.com [web] Adds Noto Music fallback font (flutter/engine#46720)
2023-10-11 jason-simmons@users.noreply.github.com Fix some image_external_texture entries in the license golden file (flutter/engine#46790)
2023-10-11 john@johnmccutchan.com Rename HardwareBufferExternalTexture* to ImageExternalTexture* (flutter/engine#46786)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

a44e0862

Stop recommending android sdk root (#136296) · 8ca7d7d1
Christopher Fujino authored Oct 11, 2023
```
Fixes https://github.com/flutter/flutter/issues/117245
```
8ca7d7d1

Roll Flutter Engine from 5fcc16772cdd to 2b1b4b97f787 (1 revision) (#136404) · e83f53e6

engine-flutter-autoroll authored Oct 11, 2023

https://github.com/flutter/engine/compare/5fcc16772cdd...2b1b4b97f787

2023-10-11 skia-flutter-autoroll@skia.org Roll Skia from 6cc9f73ea54e to 2459d71707e0 (1 revision) (flutter/engine#46787)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

e83f53e6

Switch to Chrome for Testing instead of vanilla Chromium. (#136214) · a277c5fa

Jackson Gardner authored Oct 11, 2023

This switches over to using Chrome for Testing instead of Chromium. This should ensure that we are consistently using an official and consistent build of Chrome on all platforms, rather than whatever we can get from the continuous builds archive, which can potentially put platforms out of sync with each other.

a277c5fa

Reland "Switch flutter_tools to run frontend server from AOT snapshot" (#136282) · 1a44710d
Derek Xu authored Oct 11, 2023
```
This reverts commit a1639be4.
```
1a44710d

Roll Flutter Engine from 4b02631b59bf to 5fcc16772cdd (2 revisions) (#136397) · 58701ac2

engine-flutter-autoroll authored Oct 11, 2023

https://github.com/flutter/engine/compare/4b02631b59bf...5fcc16772cdd

2023-10-11 john@johnmccutchan.com Fix 303652511 and add a regression test (flutter/engine#46743)
2023-10-11 skia-flutter-autoroll@skia.org Roll Skia from bfd9af01b785 to 6cc9f73ea54e (1 revision) (flutter/engine#46784)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

58701ac2

Fix some deprecation details (#136385) · 156e3487

Kate Lovett authored Oct 11, 2023

This fixes/notates a few deprecations from an audit for the next tech debt cycle.

- ThemeData errorColor and backgroundColor are notated as deprecated in multiple places, but one usage had a different version tag. Updated to match the rest.
- ThemeData.copyWith useMaterial3 was deprecated because it did not do what developers expected - it did not automatically reassign all of the color values and such. (confirmed with @HansMuller) I added a note so that when we later remove it we don't introduce a bug.
- the describeEnum deprecation was tagged wrong, it was a very long PR so by the time it merged the version it was finally tagged with was much later. (https://github.com/flutter/flutter/pull/125016)

156e3487

Roll Flutter Engine from ed67e8aa9aba to 4b02631b59bf (1 revision) (#136392) · 9a8a2c7f

engine-flutter-autoroll authored Oct 11, 2023

https://github.com/flutter/engine/compare/ed67e8aa9aba...4b02631b59bf

2023-10-11 bdero@google.com [Impeller] Avoid invalid GL depth calls on macOS desktop. (flutter/engine#46758)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

9a8a2c7f

[leak-tracking] Add leak tracking in test/rendering - 1 (#136275) · f84831c1
droidbg authored Oct 11, 2023

f84831c1

Remove the 'Windows_arm64 plugin_test' Devicelab test (#136379) · f2931dbd

Loïc Sharma authored Oct 11, 2023

This removes the `Windows_arm64 plugin_test` as Devicelab tests aren't able to target Android from a Windows Arm64 host yet. I opened https://github.com/flutter/flutter/issues/136378 to track this work.

f2931dbd

Roll Flutter Engine from 68a8ff743539 to ed67e8aa9aba (2 revisions) (#136383) · ea8c6307

engine-flutter-autoroll authored Oct 11, 2023

https://github.com/flutter/engine/compare/68a8ff743539...ed67e8aa9aba

2023-10-11 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from mLc-VlVTg-p18HjiP... to Qjz4zE4Oe0AO_7T3f... (flutter/engine#46778)
2023-10-11 zanderso@users.noreply.github.com Roll goldctl forward (flutter/engine#46771)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from mLc-VlVTg-p1 to Qjz4zE4Oe0AO

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

ea8c6307

extend timeout from default 30 min to 1 hour for windows build tests (#136300) · 5a4497d4
Christopher Fujino authored Oct 11, 2023
```
Fixes https://github.com/flutter/flutter/issues/136299
```
5a4497d4
Add `profilePlatformChannels` service extension (#136051) · a047358c
Kenzie Davisson authored Oct 11, 2023
```
We will expose this from a button in DevTools.
https://github.com/flutter/devtools/issues/6166
```
a047358c

Include size factors when computing the intrinsic size of a `RenderPositionedBox` (#135823) · 6ff02dbc

Maximilian Fischer authored Oct 11, 2023

This PR includes the `widthFactor` and `heightFactor` when computing the intrinsic size of a `RenderPositionedBox`.

<details><summary>Code sample</summary>

Red should have a height of 100, blue one of 200.

```dart
import 'package:flutter/material.dart';
import 'package:flutter/rendering.dart';

void main() {
  runApp(const MyApp());
}

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Intrinsic Bug',
      theme: ThemeData(
        colorScheme: ColorScheme.fromSeed(seedColor: Colors.deepPurple),
        useMaterial3: true,
      ),
      home: Scaffold(
        body: Row(
          crossAxisAlignment: CrossAxisAlignment.start,
          children: [
            Expanded(
              child: IntrinsicHeight(
                child: Align(
                  heightFactor: 0.5,
                  child: Container(
                    height: 200,
                    color: Colors.red,
                  ),
                ),
              ),
            ),
            Expanded(
              child: Container(
                height: 200,
                color: Colors.blue,
              ),
            ),
          ],
        ),
      ),
    );
  }
}
```
</details>

Before:
![grafik](https://github.com/flutter/flutter/assets/45403027/447d8b9b-e7f3-482a-900d-53e436830321)
After:
![grafik](https://github.com/flutter/flutter/assets/45403027/6d1a104b-3327-47e2-8b36-798ed0136793)

Fix #135822

6ff02dbc

[flutter_tool] Delete skipped tests (#136364) · d773c5a9

Zachary Anderson authored Oct 11, 2023

These tests have been skipped due to flakiness for a long time.

Closes https://github.com/dart-lang/webdev/issues/1562
Closes https://github.com/flutter/flutter/issues/124214

d773c5a9