1. 08 Sep, 2016 1 commit
    • Ian Hickson's avatar
      Make tests more realistic (#5762) · 5bc8888e
      Ian Hickson authored
      Previously, pumpWidget() would do a partial pump (it didn't trigger
      Ticker callbacks or post-frame callbacks), and pump() would do a full
      pump. This patch brings them closer together. It also makes runApp run a
      full actual frame, rather than skipping the transient callback part of
      the frame logic. Having "half-frames" in the system was confusing and
      could lead to bugs where code expecting to run before the next layout
      pass didn't because a "half-frame" ran first.
      
      Also, make Tickers start ticking in the frame that they were started in,
      if they were started during a frame. This means we no longer spin a
      frame for t=0, we jump straight to the first actual frame.
      
      Other changes in this patch:
      
      * rename WidgetsBinding._runApp to WidgetsBinding.attachRootWidget, so
        that tests can use it to more accurately mock out runApp.
      
      * allow loadStructuredData to return synchronously.
      
      * make handleBeginFrame handle not being given a time stamp.
      
      * make DataPipeImageProvider.loadAsync protected (rather than private),
        and document it. There wasn't really a reason for it to be private.
      
      * fix ImageConfiguration.toString.
      
      * introduce debugPrintBuildScope and debugPrintScheduleBuildForStacks,
        which can help debug problems with widgets getting marked as dirty but
        not cleaned.
      
      * make debugPrintRebuildDirtyWidgets say "Building" the first time and
        "Rebuilding" the second, to make it clearer when a widget is first
        created. This makes debugging widget lifecycle issues much easier.
      
      * make debugDumpApp more resilient.
      
      * debugPrintStack now takes a label that is printed before the stack.
      
      * improve the banner shown for debugPrintBeginFrameBanner.
      
      * various and sundry documentation fixes
      5bc8888e
  2. 01 Sep, 2016 1 commit
  3. 29 Aug, 2016 1 commit
  4. 11 Aug, 2016 1 commit
    • Ian Hickson's avatar
      Improve our scroll physics on iOS (#5340) · 17cdc889
      Ian Hickson authored
      Changes in this patch:
      - iOS now uses a different scrollDrag constant than Android.
         - ScrollConfigurationDelegate now knows about target platforms.
         - ScrollBehaviors now know about target platforms.
         - RawInputLine now has to be told what platform it's targetting.
         - PageableList now has a concept of target platform.
      - make debugPrintStack filter its stack.
         - move debugPrintStack to `assertions.dart`.
      - add support for limiting the number of frames to debugPrintStack.
      - make defaultTargetPlatform default to android in test environments.
      - remove OverscrollStyle and MaterialApp's overscrollStyle argument. You
        can now control the overscroll style using Theme.platform.
      - the default scroll configuration is now private to avoid people
        relying on the defaultTargetPlatform getter in their subclasses (since
        they really should use Theme.of(context).platform).
      - fix some typos I noticed in some tests.
      - added a test for flinging scrollables, that checks that the behavior
        differs on the two target platforms.
      - made flingFrom and fling in the test API pump the frames.
      - added more docs to the test API.
      - made the TestAsyncUtils.guard() method report uncaught errors to help
        debug errors when using that API.
      17cdc889
  5. 23 May, 2016 2 commits
  6. 20 May, 2016 1 commit
  7. 18 May, 2016 1 commit
    • Ian Hickson's avatar
      Some cleanup of the test framework (#4001) · d2c8c82f
      Ian Hickson authored
      * Add a "build" phase to EnginePhase for completeness.
      * Ignore events from the device during test execution.
      * More dartdocs
      * Slightly more helpful messages about Timers in verifyInvariants.
      * Add widgetList, elementList, stateList, renderObjectList.
      * Send test events asynchronously for consistency with other APIs.
      * Fix a test that was depending on test events being synchronous (or
        rather, scheduled in a microtask that came before the microtask for
        the completer of the future that the tap() function returned).
      d2c8c82f
  8. 16 May, 2016 1 commit
    • Ian Hickson's avatar
      Make it possible to run tests live on a device (#3936) · 32527017
      Ian Hickson authored
      This makes it possible to substitute 'flutter run' for 'flutter test'
      and actually watch a test run on a device.
      
      For any test that depends on flutter_test:
      
      1. Remove any import of 'package:test/test.dart'.
      
      2. Replace `testWidgets('...', (WidgetTester tester) {`
            with `testWidgets('...', (WidgetTester tester) async {`
      
      3. Add an "await" in front of calls to any of the following:
          * tap()
          * tapAt()
          * fling()
          * flingFrom()
          * scroll()
          * scrollAt()
          * pump()
          * pumpWidget()
      
      4. Replace any calls to `tester.flushMicrotasks()` with calls to
         `await tester.idle()`.
      
      There's a guarding API that you can use, if you have particularly
      complicated tests, to get better error messages. Search for
      TestAsyncUtils.
      32527017
  9. 04 May, 2016 1 commit
    • Adam Barth's avatar
      Skip the gallery smoke test (#3736) · 8da98105
      Adam Barth authored
      This test hangs occationally on the bots and the bots aren't smart enough to
      recover, which means the whole project gets blocked.
      
      Filed #3735 about the hang.
      8da98105
  10. 29 Apr, 2016 1 commit
    • Ian Hickson's avatar
      Refactor the test framework (#3622) · 91dd9699
      Ian Hickson authored
      * Refactor widget test framework
      
      Instead of:
      
      ```dart
        test("Card Collection smoke test", () {
          testWidgets((WidgetTester tester) {
      ```
      
      ...you now say:
      
      ```dart
        testWidgets("Card Collection smoke test", (WidgetTester tester) {
      ```
      
      Instead of:
      
      ```dart
        expect(tester, hasWidget(find.text('hello')));
      ```
      
      ...you now say:
      
      ```dart
        expect(find.text('hello'), findsOneWidget);
      ```
      
      Instead of the previous API (exists, widgets, widget, stateOf,
      elementOf, etc), you now have the following comprehensive API. All these
      are functions that take a Finder, except the all* properties.
      
      * `any()` - true if anything matches, c.f. `Iterable.any`
      * `allWidgets` - all the widgets in the tree
      * `widget()` - the one and only widget that matches the finder
      * `firstWidget()` - the first widget that matches the finder
      * `allElements` - all the elements in the tree
      * `element()` - the one and only element that matches the finder
      * `firstElement()` - the first element that matches the finder
      * `allStates` - all the `State`s in the tree
      * `state()` - the one and only state that matches the finder
      * `firstState()` - the first state that matches the finder
      * `allRenderObjects` - all the render objects in the tree
      * `renderObject()` - the one and only render object that matches the finder
      * `firstRenderObject()` - the first render object that matches the finder
      
      There's also `layers' which returns the list of current layers.
      
      `tap`, `fling`, getCenter, getSize, etc, take Finders, like the APIs
      above, and expect there to only be one matching widget.
      
      The finders are:
      
       * `find.text(String text)`
       * `find.widgetWithText(Type widgetType, String text)`
       * `find.byKey(Key key)`
       * `find.byType(Type type)`
       * `find.byElementType(Type type)`
       * `find.byConfig(Widget config)`
       * `find.byWidgetPredicate(WidgetPredicate predicate)`
       * `find.byElementPredicate(ElementPredicate predicate)`
      
      The matchers (for `expect`) are:
      
       * `findsNothing`
       * `findsWidgets`
       * `findsOneWidget`
       * `findsNWidgets(n)`
       * `isOnStage`
       * `isOffStage`
       * `isInCard`
       * `isNotInCard`
      
      Benchmarks now use benchmarkWidgets instead of testWidgets.
      
      Also, for those of you using mockers, `serviceMocker` now automatically
      handles the binding initialization.
      
      This patch also:
      
      * changes how tests are run so that we can more easily swap the logic
        out for a "real" mode instead of FakeAsync.
      
      * introduces CachingIterable.
      
      * changes how flutter_driver interacts with the widget tree to use the
        aforementioned new API rather than ElementTreeTester, which is gone.
      
      * removes ElementTreeTester.
      
      * changes the semantics of a test for scrollables because we couldn't
        convince ourselves that the old semantics made sense; it only worked
        before because flushing the microtasks after every event was broken.
      
      * fixes the flushing of microtasks after every event.
      
      * Reindent the tests
      
      * Fix review comments
      91dd9699
  11. 28 Apr, 2016 1 commit
  12. 26 Apr, 2016 1 commit
    • Adam Barth's avatar
      Delay win-by-default in gesture arena (#3552) · 51b1550d
      Adam Barth authored
      Wait until the end of the microtask to tell gesture recognizers that
      they've won in the gesture arena. This lets recognizers dispose reject
      themselves at arbitrary times without triggering gestures in awkward
      call stacks.
      
      Fixes #3183
      51b1550d
  13. 25 Apr, 2016 1 commit
  14. 22 Apr, 2016 1 commit
  15. 21 Apr, 2016 5 commits
    • Ian Hickson's avatar
      Minor widget_tester refactoring and docs (#3472) · c167efca
      Ian Hickson authored
      This reorders some classes so that this file makes more sense, and adds
      a bunch of docs. It also makes the following changes:
      
      * Move allElements from Instrumentation to TestWidgets. (Instrumentation
        is going away.)
      
      * Remove findElements.
      
      * Rename byElement to byElementPredicate
      
      * Rename byPredicate to byWidgetPredicate
      
      * Implement _WidgetPredicateFinder so that byWidgetPredicate has good
        messages
      
      * Fix one use of byElementPredicate to use byWidgetPredicate.
      c167efca
    • Ian Hickson's avatar
      Make the widgets binding reusable. (#3479) · 0e11b0e6
      Ian Hickson authored
      Previously the widgets layer only provided a concrete binding, which
      makes it awkward to extend it compared to other bindings. This moves
      widgets to the same style as the other layers.
      
      In a subsequent patch I'll use this to make the tests layer saner.
      0e11b0e6
    • Ian Hickson's avatar
      Refactor TestGesture (#3461) · b7af64ee
      Ian Hickson authored
      Moves TestGesture into test_pointer.dart and makes it more
      self-contained.
      
      This is part of a general refactoring of flutter_test.
      
      Depends on https://github.com/flutter/flutter/pull/3459
      b7af64ee
    • Hans Muller's avatar
      Enhance Finder toString() (#3458) · 22e8d85d
      Hans Muller authored
      * Enhance Finder toString()
      22e8d85d
    • Adam Barth's avatar
      Add a route table to Material Gallery (#3457) · 248960a7
      Adam Barth authored
      Use the route table to generate the list of screens to test in the smoke test.
      248960a7
  16. 20 Apr, 2016 1 commit
    • Ian Hickson's avatar
      Reset _simulation at the end of a fling (#3435) · 112f2cc3
      Ian Hickson authored
      Also a bit of code cleanup.
      
      The key part of this patch is the addition in `_endScroll` to reset
      `_simulation`. It seems like this was the one place where it's possible
      for us to end the animation but not reset our state. Since we assert
      that are state is coherent, we were hitting asserts when a fling
      finished and then you interacted with the widget again.
      112f2cc3
  17. 16 Apr, 2016 1 commit
  18. 15 Apr, 2016 1 commit
  19. 14 Apr, 2016 1 commit
  20. 13 Apr, 2016 1 commit
    • Ian Hickson's avatar
      Fix dependency skew. (#3306) · 7861d029
      Ian Hickson authored
      ...by adding tests to our examples that don't import flutter_test, which
      pins the relevant dependencies.
      
      Also, provide more information when complaining about leaked transient
      callbacks in tests.
      
      Also, make tests display full information when they have an exception,
      by bypassing the throttling we have for Android logging in tests.
      
      Also, make the word wrapping not wrap stack traces if they happen to
      be included in exception output.
      
      Also, fix a leaked transient callback in the checkbox code.
      7861d029
  21. 02 Apr, 2016 1 commit
    • Ian Hickson's avatar
      Rationalise all our exception handling. · ee703da9
      Ian Hickson authored
      - Create a FlutterErrorDetails struct-like class that describes an
      
        exception along with more details that aren't in the exception, like
      
        where it was caught and what was going on when it was caught.
      
      
      
      - Provide a FlutterError static API for handling these objects:
      
      
      
        - FlutterError.onError which is called whenever Flutter catches an
      
          error.
      
      
      
        - FlutterError.reportError() which handles an error.
      
      
      
        - FlutterError.dumpErrorToConsole() which is the default behavior
      
          for onError.
      
      
      
      - Removes all the existing exception handler callbacks.
      
      
      
      - Replaces all the existing places that described exceptions using
      
        debugPrint with calls to FlutterError.reportError().
      
      
      
      - Extend lockState() to also catch exceptions, so that we catch
      
        exceptions that happen during finalizers.
      
      
      
      - Make the test framework catch errors and treat them as failures.
      
      
      
      - Provide a mechanism to override this behavior in the test framework.
      
      
      
      - Make the tests that used to depend on the exception handler
      
        callbacks use this new mechanism.
      
      
      
      - Make pump() also support the phase argument.
      
      
      
      - Improve some tests using these new features.
      
      
      
      Fixes #2356, #2988, #2985, #2220.
      ee703da9
  22. 31 Mar, 2016 1 commit
    • Kris Giesing's avatar
      Part 2 of independent layout pipelines · 9dfd5d40
      Kris Giesing authored
      Adds BuildOwner to manage the dirty list and build processing for
      widgets/elements, and adds a widget unit test to make sure separation
      is enforced.
      
      Fixes #2723
      9dfd5d40
  23. 24 Mar, 2016 1 commit
  24. 14 Mar, 2016 1 commit
  25. 09 Mar, 2016 1 commit
  26. 07 Mar, 2016 1 commit
  27. 04 Mar, 2016 2 commits
  28. 25 Feb, 2016 1 commit
    • Hixie's avatar
      Remove size observers from scrollables. · f8080557
      Hixie authored
      Also:
       - add operator==/hashCode/toString to ViewportDimensions
       - add toString to BindingBase
       - add toString and debugFillDescription to ScrollBehavior
       - fix a bug in the RawGestureDetectorState's replaceGestureRecognizers
       - rename MixedViewport's onExtentsUpdate to onExtentChanged
       - replace ExtentsUpdateCallback with ValueChanged<double>
       - remove a microtask for dispatching scroll start, since it
         did not appear to have any purpose
       - added dartdocs to Instrumentation until I understood it
       - made all event dispatch in Instrumentation drain microtasks
      f8080557
  29. 14 Feb, 2016 1 commit
  30. 11 Feb, 2016 1 commit
    • Ian Hickson's avatar
      Clean up imports and exports. · a94999ba
      Ian Hickson authored
      Each layer is supposed to reexport the parts of the previous layer
      that are part of its API.
      
      - In painting.dart, export from dart:ui all the Canvas-related APIs
        that make sense to be used at higher levels, e.g. PaintingStyle.
      
      - Delete painting/shadows.dart. It was dead code.
      
      - In rendering/object.dart, export all of painting.dart.
      
      - In widgets/basic.dart, export all of painting.dart and
        animation.dart. Some classes in animation/ are renamed to make this
        less disruptive and confusing to the namespace.
      
      - Split out Stocks back into an import model rather than a part model,
        so that it's easier to manage its dependencies on a per-file basis.
      
      - Move Ticker to scheduler library.
      
      - Remove as many redundant imports as possible now.
      
      - Some minor nit picking cleanup in various files.
      a94999ba
  31. 14 Dec, 2015 2 commits
  32. 09 Dec, 2015 1 commit
    • Eric Seidel's avatar
      Add a test to stocks for changing the locale · 09894ec5
      Eric Seidel authored
      I had to add a setLocale method to WidgetTester and
      split the code in FlutterBinding which handled locale
      changes to allow me to dispatch a locale change w/o actually
      changing what the c++ code reports as the locale.
      
      Also added the test to Travis.
      
      @abarth @jason-simmons
      09894ec5
  33. 05 Dec, 2015 1 commit
    • Ian Hickson's avatar
      PointerInput refactor · f1625556
      Ian Hickson authored
      Instead of PointerInputEvent having a "type" field, we now have a
      different class for each pointer type.
      
      This has ripple effects throughout the system.
      
      I also did code cleanup in affected files while I was there.
      f1625556