- 05 Mar, 2015 1 commit
-
-
Adam Barth authored
This CL changes how events work in fn. Previously, event listeners were passed in as constructor arguments. Now Nodes hold an |events| object, which contains all the event registrations. When a Component renders, all its |events| are copied onto the Node it produces. When an Element syncs, it walks its |events| and adds them as event listeners on the underlying sky.Element. The net result of this change is increased flexibility in how events are registered. Now components don't need to enumerate all the possible events that they support. Instead, the parent component can listen for whatever events it likes. Also, I've cleaned up the association between DrawerAnimation and Drawer. Now the constructor for Drawer accepts an |animation| object and wires up its internal event handlers itself instead of requiring the constructor to do all the wiring. R=rafaelw@chromium.org Review URL: https://codereview.chromium.org/975863003
-
- 04 Mar, 2015 3 commits
-
-
Adam Barth authored
This CL adds license blocks and cleans up a number of Dart idioms in fn. Specifically, I've marked several fields as |final| and used Map#putIfAbsent in some appropriate places. R=rafaelw@chromium.org Review URL: https://codereview.chromium.org/973613004
-
Rafael Weinstein authored
-
Adam Barth authored
R=rafaelw@chromium.org Review URL: https://codereview.chromium.org/970393002
-
- 03 Mar, 2015 6 commits
-
-
Adam Barth authored
If there is jank, we might not get a frame time that's just after the last frame, which means we'll stop generating animation frames before hitting 1.0 exactly. In this CL, we introduce state to takeWhile to cancel the stream after emitting the 1.0. R=rafaelw@chromium.org Review URL: https://codereview.chromium.org/975153002
-
Rafael Weinstein authored
TBR=abarth Review URL: https://codereview.chromium.org/975203002
-
Hixie authored
TBR=raf Review URL: https://codereview.chromium.org/974903005
-
Adam Barth authored
R=rafaelw@chromium.org Review URL: https://codereview.chromium.org/975913002
-
Eric Seidel authored
R=abarth@chromium.org Review URL: https://codereview.chromium.org/973133002
-
Rafael Weinstein authored
This is just a proof of concept. If we like this direction, it will move out of the examples directory (likely re-written) and be committed in smaller pieces with unit tests and formal reviews. TBR=abarth BUG= Review URL: https://codereview.chromium.org/971183002
-
- 02 Mar, 2015 2 commits
-
-
Adam Barth authored
double is a built-in type in Dart. float isn't... TBR=eseidel@chromium.org Review URL: https://codereview.chromium.org/968293003
-
Eric Seidel authored
The touch demo needs some basic smoothing, right now it looks rather jittery after this change. But the pressure code is definitely working! R=abarth@chromium.org BUG= Review URL: https://codereview.chromium.org/970493003
-
- 28 Feb, 2015 1 commit
-
-
Adam Barth authored
We need to create a new service provider when we navigate to a new page otherwise the new page is sad that the old page took its service provider. R=eseidel@chromium.org Review URL: https://codereview.chromium.org/962383003
-
- 27 Feb, 2015 2 commits
-
-
Adam Barth authored
Apps can import this library if they wish to reload on shake. R=eseidel@chromium.org Review URL: https://codereview.chromium.org/963303004
-
Adam Barth authored
This CL adds a sensor_service to sky/services and wires it into SkyShell The plan is to eventually use this data to implement shake-to-refresh. R=eseidel@chromium.org Review URL: https://codereview.chromium.org/962043002
-
- 26 Feb, 2015 1 commit
-
-
Eric Seidel authored
Before this patch it crashed. Also updated the touch-demo to support multi-touch. R=abarth@chromium.org BUG= Review URL: https://codereview.chromium.org/961483004
-
- 25 Feb, 2015 1 commit
-
-
Zachary Anderson authored
This improves consistency with the convention that the dart: scheme is only for things from the Dart standard library. BUG= R=erg@chromium.org Review URL: https://codereview.chromium.org/951783004
-
- 24 Feb, 2015 10 commits
-
-
Adam Barth authored
These aren't 100% correct, but they look somewhat reasonable. R=eseidel@chromium.org Review URL: https://codereview.chromium.org/954023002
-
Adam Barth authored
This CL makes the list view in the stocks app more consistent with the material spec by using a colored circle instead of color-coding the percentage change. R=eseidel@chromium.org Review URL: https://codereview.chromium.org/932103004
-
Adam Barth authored
R=eseidel@chromium.org Review URL: https://codereview.chromium.org/950353003
-
Adam Barth authored
The menu items don't quite make sense for this app, but they're closer in visual styling. R=eseidel@chromium.org Review URL: https://codereview.chromium.org/951413002
-
Adam Barth authored
R=eseidel@chromium.org Review URL: https://codereview.chromium.org/953903004
-
Adam Barth authored
This CL updates the Sky widgets to be closer to the material design spec. There's still a long way to go, but this CL is a start. R=eseidel@chromium.org Review URL: https://codereview.chromium.org/951823002
-
Adam Barth authored
R=eseidel@chromium.org Review URL: https://codereview.chromium.org/956463002
-
Adam Barth authored
R=eseidel@chromium.org Review URL: https://codereview.chromium.org/947383002
-
Eric Seidel authored
Also made the background a MD color. R=abarth@chromium.org BUG= Review URL: https://codereview.chromium.org/951653004
-
Eric Seidel authored
http://www.google.com/design/spec/components/lists.html#lists-specs http://www.google.com/design/spec/style/color.html# R=abarth@chromium.org Review URL: https://codereview.chromium.org/930193004
-
- 23 Feb, 2015 7 commits
-
-
Adam Barth authored
None of this code runs in the current Sky. Some of it never ran. R=eseidel@chromium.org Review URL: https://codereview.chromium.org/951673003
-
Eric Seidel authored
TBR=abarth@chromium.org Review URL: https://codereview.chromium.org/953593002
-
Eric Seidel authored
I removed the green background and added display of percent change (which is random for now). I also display a random assortment of stocks every time instead of always the top 100. R=rafaelw@chromium.org Review URL: https://codereview.chromium.org/950073002
-
Eric Seidel authored
R=abarth@chromium.org Review URL: https://codereview.chromium.org/954513003
-
Adam Barth authored
We'll flesh this example out over time to demo a bunch of our widgets. TBR=eseidel@chromium.org Review URL: https://codereview.chromium.org/954503002
-
Adam Barth authored
Also, port the "appish" example to exercise the drawer. R=eseidel@chromium.org Review URL: https://codereview.chromium.org/942413002
-
Adam Barth authored
This CL updates sky-box, sky-button, sky-checkbox, sky-input, and sky-radio to work in Dart. We don't have a data binding system yet, so there's a bit more plumbing in the code. This CL adds support for sky-element@attributes, which lets you specify which attributes your element supports. We use this information to synthesize getters and setters for those attributes and to dispatch to mumbleChanged methods when the attributes change. I've also wrapped the widgets demo itself in a sky-scrollable so the whole thing scrolls. R=eseidel@chromium.org Review URL: https://codereview.chromium.org/946813005
-
- 21 Feb, 2015 2 commits
-
-
Adam Barth authored
This CL ports sky-scrollable to the new sky-element. R=esprehn@chromium.org Review URL: https://codereview.chromium.org/950603002
-
Adam Barth authored
After this CL, you can use <sky-element> to describe custom elements. The current iteration is very basic and is hardcoded to "example", but its a start. This CL renames the |init| function to |_init| to prevent importers from calling it directly. Also, we now pass the <script> element to |_init| to give some context. R=ojan@chromium.org, eseidel@chromium.org Review URL: https://codereview.chromium.org/950493003
-
- 20 Feb, 2015 3 commits
-
-
Eric Seidel authored
TBR=abarth@chromium.org Review URL: https://codereview.chromium.org/950503002
-
Eric Seidel authored
TBR=abarth@chromium.org Review URL: https://codereview.chromium.org/942923002
-
Adam Barth authored
These now appear on internals as takeServicesProvidedToEmbedder and takeServicesProvidedByEmbedder. When you call these functions, you get back the raw int that represents the handle. We'll need to wrap them up inside the Dart VM with the appropriate types. We can create a nice wrapper for that in a future CL. R=hansmuller@google.com, hansmuller@chromium.org Review URL: https://codereview.chromium.org/944733002
-
- 19 Feb, 2015 1 commit
-
-
Hans Muller authored
I haven't removed the JS color picker code yet. R=abarth@chromium.org Review URL: https://codereview.chromium.org/940233002
-