• Adam Barth's avatar
    Don't hardcode the list of events types in fn · 50c2f883
    Adam Barth authored
    This CL changes how events work in fn. Previously, event listeners were passed
    in as constructor arguments. Now Nodes hold an |events| object, which contains
    all the event registrations. When a Component renders, all its |events| are
    copied onto the Node it produces. When an Element syncs, it walks its |events|
    and adds them as event listeners on the underlying sky.Element.
    
    The net result of this change is increased flexibility in how events are
    registered. Now components don't need to enumerate all the possible events that
    they support. Instead, the parent component can listen for whatever events it
    likes.
    
    Also, I've cleaned up the association between DrawerAnimation and Drawer. Now
    the constructor for Drawer accepts an |animation| object and wires up its
    internal event handlers itself instead of requiring the constructor to do all
    the wiring.
    
    R=rafaelw@chromium.org
    
    Review URL: https://codereview.chromium.org/975863003
    50c2f883
Name
Last commit
Last update
examples Loading commit data...