1. 14 Jul, 2023 2 commits
  2. 13 Jul, 2023 6 commits
  3. 12 Jul, 2023 1 commit
  4. 10 Jul, 2023 2 commits
  5. 08 Jul, 2023 1 commit
  6. 07 Jul, 2023 2 commits
  7. 06 Jul, 2023 1 commit
  8. 05 Jul, 2023 2 commits
  9. 29 Jun, 2023 2 commits
  10. 27 Jun, 2023 1 commit
    • Ben Konyi's avatar
      Reland "Fix issue where DevTools would not be immediately available when using... · 5ea2be69
      Ben Konyi authored
      Reland "Fix issue where DevTools would not be immediately available when using --start-paused (#126698)" (#129368)
      
      **Original Description:**
      
      > Service extensions are unable to handle requests when the isolate they
      were registered on is paused. The DevTools launcher logic was waiting
      for some service extension invocations to complete before advertising
      the already active DevTools instance, but when --start-paused was
      provided these requests would never complete, preventing users from
      using DevTools to resume the paused isolate.
      > 
      > Fixes https://github.com/flutter/flutter/issues/126691
      
      **Additional changes in this PR:**
      
      The failures listed in https://github.com/flutter/flutter/pull/128117
      appear to be related to a shutdown race. It's possible for the test to
      complete while the tool is in the process of starting and advertising
      DevTools, so we need to perform a check of `_shutdown` in
      `FlutterResidentDevtoolsHandler` before advertising DevTools.
      
      Before the original fix, this check was being performed immediately
      after invoking the service extensions, which creates an asynchronous gap
      in execution. With #126698, the callsite of the service extensions was
      moved and the `_shutdown` check wasn't, allowing for the tool to attempt
      to advertise DevTools after the DevTools server had been cleaned up.
      
      ---------
      Co-authored-by: 's avatarZachary Anderson <zanderso@users.noreply.github.com>
      5ea2be69
  11. 23 Jun, 2023 1 commit
    • David Iglesias's avatar
      [web] Hides that Flutter uses requireJS in debug. (#129032) · 34b42acf
      David Iglesias authored
      Flutter web uses requireJS in `debug` mode to assemble a DDC-compiled app from a bunch of small files ("modules").
      
      This caused that `canvaskit.js` (and all other modules that used a browserify-like loading header) didn't work because they attempted to use the `define` function provided by Flutter's instance of `requireJS` (which kept the defined modules private, rather than as globals on the page, as the users of the JS expected).
      
      A [fix](https://github.com/flutter/engine/pull/27342) was added to `flutter/engine` to trick loaders into *not* using the `requireJS` module loader, but a recent change in the fix's js-interop layer *subtly* changed its JS output on the page (objects went from `undefined` to `null`), causing this:
      
      * https://github.com/flutter/flutter/issues/126131 (and others)
      
      This PR hides a bit of code that is commonly used by module loaders to decide that they may use the `define` function provided by requireJS (so the engine workaround can be removed).
      
      ## Next steps
      
      * https://github.com/flutter/engine/pull/42941
      
      ## Issues
      
      Partially addresses: https://github.com/flutter/flutter/issues/126131 (and others)
      
      ## Tests
      
      * Added a unit test to ensure the `delete` stays
      * Manually tested with the Gallery app in `debug` mode with a bunch of user-supplied scripts that currently fail to load.
        * Also tested hot restart as suggested by @nshahan
      34b42acf
  12. 22 Jun, 2023 2 commits
  13. 21 Jun, 2023 1 commit
  14. 20 Jun, 2023 3 commits
    • Victoria Ashworth's avatar
      Fix duplicate devices from xcdevice with iOS 17 (#128802) · 25e98b54
      Victoria Ashworth authored
      This PR fixes issue of duplicate entries from `xcdevice list` cause devices to not show in `flutter devices`, `flutter run`, etc.
      
      When a duplicate entry is found, use the entry without errors as the authority. If both have errors, use the one with the higher SDK as the authority.
      
      Fixes https://github.com/flutter/flutter/issues/128719.
      25e98b54
    • Lau Ching Jun's avatar
      Use the new `getIsolatePauseEvent` method from VM service to check for pause event. (#128834) · 32917500
      Lau Ching Jun authored
      The `getIsolate` method returns the full list of libraries which can be huge for large apps. Using the more speficic API to only fetch what we need improves hot reload performance.
      
      *Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.*
      
      *List which issues are fixed by this PR. You must list at least one issue.*
      
      *If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
      32917500
    • Tae Hyung Kim's avatar
      Refactor generate_localizations_test.dart (#128974) · 48ba9c41
      Tae Hyung Kim authored
      The file was becoming harder to deal with as it manually sets up a /lib/l10n directory with a `MemoryFileSystem` in every single test. This PR wraps this process in a helper function `setupLocalizations` and also provides a helper function `getGeneratedFileContent` which helps fetch the respective output file given the locale string.
      48ba9c41
  15. 19 Jun, 2023 1 commit
  16. 16 Jun, 2023 2 commits
  17. 15 Jun, 2023 4 commits
  18. 14 Jun, 2023 2 commits
  19. 13 Jun, 2023 1 commit
  20. 12 Jun, 2023 1 commit
  21. 09 Jun, 2023 2 commits