- 08 Mar, 2019 12 commits
-
-
Jonah Williams authored
-
Jonah Williams authored
-
Justin McCandless authored
* Create new TextField attribute to control maxLength behaviour * Create test case for maxLinesIncrementalHeight * fix maxLinesIncrementalHeight set method * fix editable_test.dart * Just introducing some proposed API additions, renaming to expands * Pass minLines and expands through to child widgets and validate * minLines can't be null, and expands can't be true when maxLines is 1 * Implement minLines and maxLines height sizing logic * Simplify minLines validation logic * expands parameter proof of concept * min/max mixup bug fix, and tests work with expands false * Test expands=true cases, and fix textPainter.height being out of date * Test all behavior matrix cases * min/max assertion more strict, can't be equal * Tests work that were missing expands serialization * Action sheet tests no longer fail due to rounding error * TextFieldFocus test no longer mysteriously fails * TODOs for making expands nullable. Will depend on how Expanded wrapping works * Expanded growth happens when expanded is true and maxLines is null * Test Expanded wrapper * No more overflow when wrapped in Expanded * Docs improvements * expands can be null * Simplify error cases to support existing behavior * Docs examples and other docs cleanup * Expansion up to perfectly meet the parent size * Fix analyze null error * Fix test after move to nullable expands * minLines defaults to null * expands is now exclusively for expanding to parent height and not growth between min and max * _layout rewritten to handle max height. Need to fix prefix tests and reenable expands * Tests for textfield overflowing parent * layoutLineBox is documented and private * expands works in new _layout * _layout return numbers seem to perfectly match original _layout * inputWidth comment after trying it out and failing tests * Fix analyze errors * WIP prefix/suffix do affect height * Prefix/suffix and icons affect height, tests pass, but I'm still visually verifying identical to original * Tall prefix test that verifies pixel perfect layout * Fix overflowing edge case and test it * Clean up comments, old code, and todos * Changing _expands causes relayout. Wasnt able to figure out how to test though... * Clean up code review comments * Fix misalignment when tall prefix and border, and clean up related test * Simple code review cleanup * Bring back inputWidth to _layout method * Fix rounding errors showing up in mac tests * Fix flake by reordering tests. Without this, the dreaded intrinsicwidth flake is reproducible 50% of the time on my machine. * Fix more rounding error mac tests
-
Greg Spencer authored
This removes references to SemanticsSortOrder, which was removed a long time ago.
-
Greg Spencer authored
In anticipation of changing a lot of the focus code, I'm adding some tests for the FocusScope. As a result, I was able to find and fix a bug where there was an incorrect assert. I also added some more documentation. Several of the tests enforce what I think is incorrect behavior related to passing focus off when the widget tree gets rebuilt without focus nodes that were previously there, but I'm not going to change that behavior in this PR. I also renamed focus_test.dart to focus_scope_test.dart to be more in line with our naming conventions.
-
Dan Field authored
* update readme for LUCI * Update README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/a48cd16e0777...60314077846c git log a48cd16e077778a7aa5908e4faa4da07714260f2..60314077846c123f45c5aaef911c5ea48343d569 --no-merges --oneline 603140778 Roll src/third_party/skia 88b8d1124b72..3d1b941f3a7d (27 commits) (flutter/engine#8082) 95ef58cf4 Add script to help generate PR messages (flutter/engine#8074) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff (mklim@google.com), and stop the roller if necessary.
-
Dan Field authored
-
Jonah Williams authored
This reverts commit 6a7f231d.
-
Jonah Williams authored
-
Gary Qian authored
git log --oneline --no-merges f4951df193a7966f9ed4da43d555eee0913d84d1..a48cd16e077778a7aa5908e4faa4da07714260f2 a48cd16e0 Update a11y word forward/back enum names (https://github.com/flutter/engine/pull/8073) b5f59ed89 Delay the vsync callback till the frame start time specified by embedder. (https://github.com/flutter/engine/pull/8072) 7426305f5 Mark const extern (https://github.com/flutter/engine/pull/8077) d3f6d7a21 only partial rule revert (https://github.com/flutter/engine/pull/8078) d71bfe58d Only build a full Dart SDK when building for the host system (https://github.com/flutter/engine/pull/8071) de90dbff7 Refactor web configuration/ Add dartdevc (https://github.com/flutter/engine/pull/7978) ff46dd38f Roll src/third_party/skia 4c1ea43a79b5..88b8d1124b72 (8 commits) (https://github.com/flutter/engine/pull/8070) 80c6dd286 Roll src/third_party/skia 692122e3ef23..4c1ea43a79b5 (3 commits) (https://github.com/flutter/engine/pull/8069) 68ed654ea Roll src/third_party/skia 3c957d575c58..692122e3ef23 (6 commits) (https://github.com/flutter/engine/pull/8067) ca0bac4fb Revert "add signal to pointer kinds" (https://github.com/flutter/engine/pull/8066) 3fb627f2c add signal to pointer kinds (https://github.com/flutter/engine/pull/8065) 5a06afa2a Roll src/third_party/skia 801a9c16d81e..3c957d575c58 (19 commits) (https://github.com/flutter/engine/pull/8063) a93d99db9 A11y callback (https://github.com/flutter/engine/pull/8005) 3661d5e43 Re-land "Buffer lifecycle in WindowData" (https://github.com/flutter/engine/pull/8032) 471a2c89a Send scroll events from the macOS shell (https://github.com/flutter/engine/pull/8056) 2fe9c9b5f Roll src/third_party/skia 72542816cadb..801a9c16d81e (46 commits) (https://github.com/flutter/engine/pull/8060) 3335764ae Skip skp files in license check (https://github.com/flutter/engine/pull/8050) 7f16789b2 Remove redundant thread checker in FML. (https://github.com/flutter/engine/pull/8053) 840c5233a Correct URL for Cirrus CI build status badge (https://github.com/flutter/engine/pull/8054) 57c120a29 remove extra source files (https://github.com/flutter/engine/pull/8052) 4773375c6 Used named conditionals for platform specific dependencies and suppress Android and Windows hooks on Mac. (https://github.com/flutter/engine/pull/8051) 70a18b515 Add clang static analysis support to gn wrapper (https://github.com/flutter/engine/pull/8047) b30f9897b Improve elevation bounds for physical shape layers (https://github.com/flutter/engine/pull/8044) e37bd27b4 Fix weak pointer use violations in shell and platform view. (https://github.com/flutter/engine/pull/8046) dd80fc9ff Add engine support for scrollwheel events (https://github.com/flutter/engine/pull/7494)
-
Dan Field authored
-
- 07 Mar, 2019 9 commits
-
-
Jonah Williams authored
-
Kate Lovett authored
* Added code snippet for Form Class. ref:#21136 * Formatting adjustments. * Changed wording related to GlobalKey.
-
xster authored
-
liyuqian authored
Fix issues in https://github.com/flutter/flutter/pull/28687
-
Alexandre Ardhuin authored
* fix indentof statements in BlockFunctionBody * fix indentof statements in BlockFunctionBody in tests
-
Dan Field authored
* Fix coverage shard * clarify * Make sure we print test results * Actually report test results before exiting * revert unintended changes
-
Jonah Williams authored
-
Dan Field authored
-
Jonah Williams authored
This reverts commit 1b14339e.
-
- 06 Mar, 2019 16 commits
-
-
Tong Mu authored
* First impl with StopwatchWithZone * Clean up params and name * Remove outdated TODO * Fix style * Fix a missing param. Add @require * Fix import meta * Fix code style * Add missing require. Fix comment style. * Fix code style * Fix code style
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/f4951df193a7...471a2c89a689 git log f4951df193a7966f9ed4da43d555eee0913d84d1..471a2c89a689ff1d5c70a5deb4565f646380bce6 --no-merges --oneline 471a2c89a Send scroll events from the macOS shell (flutter/engine#8056) 2fe9c9b5f Roll src/third_party/skia 72542816cadb..801a9c16d81e (46 commits) (flutter/engine#8060) 3335764ae Skip skp files in license check (flutter/engine#8050) 7f16789b2 Remove redundant thread checker in FML. (flutter/engine#8053) 840c5233a Correct URL for Cirrus CI build status badge (flutter/engine#8054) 57c120a29 remove extra source files (flutter/engine#8052) 4773375c6 Used named conditionals for platform specific dependencies and suppress Android and Windows hooks on Mac. (flutter/engine#8051) 70a18b515 Add clang static analysis support to gn wrapper (flutter/engine#8047) b30f9897b Improve elevation bounds for physical shape layers (flutter/engine#8044) e37bd27b4 Fix weak pointer use violations in shell and platform view. (flutter/engine#8046) dd80fc9ff Add engine support for scrollwheel events (flutter/engine#7494) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff (mklim@google.com), and stop the roller if necessary.
-
xster authored
-
Muhammed Salih Guler authored
-
TruongSinh Tran-Nguyen authored
-
Ivan authored
-
Jonah Williams authored
-
Dan Field authored
* Fix for post submit on cirrus
-
Dan Field authored
* Wrap test.main with a custom processor * Report test results to bigquery table
-
Jason Simmons authored
flutter_shared was used to package the icudtl.dat file, but that data is now embedded inside libflutter.so
-
Phil Quitslund authored
-
Dan Field authored
* doc update
-
Reece Dunham authored
This switches the Cirrus macOS images to use Mojave, since Cirrus has deprecated the High Sierra images.
-
Chris Bracken authored
When running git update-packages, if the goldens repo is dirty, the flutter tool currently crashes and logs the failure from git pull. This adds a check for a dirty git client and emits a friendlier error message in the case where it's not clean, and avoid the crash by catching the NonZeroExitCode exception and rethrowing as toolExit instead. Fixes: https://github.com/flutter/flutter/issues/28915
-
Alexandre Ardhuin authored
* fix some formatting issues * address review comments * fix indent
-
Chris Bracken authored
flutter/engine@f4951df19 (upstream/master) Minor cleanups to CONTRIBUTING.md (flutter/engine#8043) flutter/engine@effee2f80 remove extra statement (flutter/engine#8041) flutter/engine@14e082fa0 (master) add lint script for Android with baseline (flutter/engine#8036) flutter/engine@5fed42197 Roll src/third_party/skia 25bc174cf682..72542816cadb (14 commits) (flutter/engine#8040) flutter/engine@e6a5201f0 Add missing values to semantics action enums (flutter/engine#8033) flutter/engine@75d4db31d Roll src/third_party/skia fbc887df72ec..25bc174cf682 (7 commits) (flutter/engine#8039) flutter/engine@c46226980 Roll src/third_party/skia 0a57971f0544..fbc887df72ec (1 commits) (flutter/engine#8037) flutter/engine@ed628da00 Add missing kHasImplicitScrolling enum value (flutter/engine#8030) flutter/engine@052774e1c Roll src/third_party/skia e3e80b7edfd1..0a57971f0544 (16 commits) (flutter/engine#8035) flutter/engine@2cd9b41ba Select MPL instead of LGPL (flutter/engine#7991) flutter/engine@629c0d836 Roll src/third_party/dart 7d8ffe0daf..571ea80e11 (3 commits) flutter/engine@8f1fdcd19 Android Embedding PR 14: Almost done with FlutterFragment. (flutter/engine#8000) flutter/engine@fb3e35d6a Android Embedding PR15: Add Viewport Metrics to FlutterView (flutter/engine#8029) flutter/engine@36ca5740c (flutter/engine#8026) flutter/engine@3d53e2026 Roll src/third_party/skia 5800f2e8a920..e3e80b7edfd1 (2 commits) (flutter/engine#8028) flutter/engine@f3d4a7f71 Roll src/third_party/dart 7c70ab1817..7d8ffe0daf (77 commits) flutter/engine@a2246c199 Start of linting Android embedding (flutter/engine#8023) flutter/engine@48bf4803e [fuchsia] Fix snapshot BUILD.gn file for Fuchsia roll (flutter/engine#8024)
-
- 04 Mar, 2019 3 commits
-
-
Amir Hardon authored
When a touch event that is in the bounds of a RenderUiKitView is absorbed by another render object, the RenderUiKitView's handleEvent is not called for that object. On the platform side, the touch event hits the FlutterTouchInterceptingView which is waiting for a framework decision that never arrived on whether to reject or accept the gesture. This change fixes the issue by having RenderUiKitView register a global PointerRoute, that is used to reject absorbed touch events.
-
Kate Lovett authored
* Added code snippets for FloatingActionButton Class. ref:#21136 * Extraneous white spaces. Co-Authored-By: Piinks <katelovett@google.com> * Alignment correction. * The analyze result wasn't showing on github interface. Checked through Cirrus and it's all-green. Co-Authored-By: Piinks <katelovett@google.com>
-
Hans Muller authored
-