Revert "re-enable dart2js test (#29010)" (#29030)

This reverts commit 6a7f231d.

dev/bots/test.dart

@@ -191,21 +191,22 @@ Future<void> _runBuildTests() async {
     await _flutterBuildApk(path);
     await _flutterBuildIpa(path);
   }
-  await _flutterBuildDart2js(path.join('dev', 'integration_tests', 'web'));
+  // TODO(jonahwilliams): re-enable when engine rolls.
+  //await _flutterBuildDart2js(path.join('dev', 'integration_tests', 'web'));
 
   print('${bold}DONE: All build tests successful.$reset');
 }
 
-Future<void> _flutterBuildDart2js(String relativePathToApplication) async {
-  print('Running Dart2JS build tests...');
-  await runCommand(flutter,
-    <String>['build', 'web', '-v'],
-    workingDirectory: path.join(flutterRoot, relativePathToApplication),
-    expectNonZeroExit: false,
-    timeout: _kShortTimeout,
-  );
-  print('Done.');
-}
+// Future<void> _flutterBuildDart2js(String relativePathToApplication) async {
+//   print('Running Dart2JS build tests...');
+//   await runCommand(flutter,
+//     <String>['build', 'web', '-v'],
+//     workingDirectory: path.join(flutterRoot, relativePathToApplication),
+//     expectNonZeroExit: false,
+//     timeout: _kShortTimeout,
+//   );
+//   print('Done.');
+// }
 
 Future<void> _flutterBuildAot(String relativePathToApplication) async {
   print('Running AOT build tests...');

packages/flutter_tools/lib/src/artifacts.dart

@@ -73,9 +73,9 @@ String _artifactToFileName(Artifact artifact, [ TargetPlatform platform, BuildMo
     case Artifact.engineDartBinary:
       return 'dart';
     case Artifact.dart2jsSnapshot:
-      return 'dart2js.dart.snapshot';
+      return 'flutter_dart2js.dart.snapshot';
     case Artifact.kernelWorkerSnapshot:
-      return 'kernel_worker.dart.snapshot';
+      return 'flutter_kernel_worker.dart.snapshot';
   }
   assert(false, 'Invalid artifact $artifact.');
   return null;

packages/flutter_tools/lib/src/commands/build_web.dart

@@ -4,11 +4,10 @@
 
 import 'dart:async';
 
-import '../base/common.dart';
 import '../base/logger.dart';
 import '../build_info.dart';
 import '../globals.dart';
-import '../runner/flutter_command.dart' show FlutterCommandResult;
+import '../runner/flutter_command.dart' show ExitStatus, FlutterCommandResult;
 import '../web/compile.dart';
 import 'build.dart';
 
@@ -34,9 +33,6 @@ class BuildWebCommand extends BuildSubCommand {
     final Status status = logger.startProgress('Compiling $target to JavaScript...', timeout: null);
     final int result = await webCompiler.compile(target: target);
     status.stop();
-    if (result != 0) {
-      throwToolExit('JavaScript compilation failed.');
-    }
-    return null;
+    return FlutterCommandResult(result == 0 ? ExitStatus.success : ExitStatus.fail);
   }
 }