Commits · 3f34b480c8999466b6a3489e71a2359cbfd408f6 · abdullh.alsoleman / Front-End

17 Aug, 2023 19 commits

[Framework] Add Share to selection controls (#132599) · 3f34b480

LouiseHsu authored Aug 17, 2023

In native iOS, users are able to select text and initiate a share menu, which provides several standard services, such as copy, sharing to social media, direct ability to send to various contacts through messaging apps, etc.

https://github.com/flutter/engine/assets/36148254/d0af7034-31fd-412e-8636-a06bbff54765

This PR is the framework portion of the changes that will allow Share to be implemented.
The corresponding merged engine PR is [here](https://github.com/flutter/engine/pull/44554)
This PR addresses https://github.com/flutter/flutter/issues/107578
More details are available in this [design doc](https://github.com/flutter/engine/pull/flutter.dev/go/add-missing-features-to-selection-controls)

3f34b480

Roll Packages from 9bf208f4beb6 to 3b602e77e69a (3 revisions) (#132784) · ac66bdb7

engine-flutter-autoroll authored Aug 17, 2023

https://github.com/flutter/packages/compare/9bf208f4beb6...3b602e77e69a

2023-08-16 ian@hixie.ch Add advice on code review for this repo (flutter/packages#4698)
2023-08-16 stuartmorgan@google.com [platform] Import the `platform` package (flutter/packages#4613)
2023-08-16 engine-flutter-autoroll@skia.org Roll Flutter from f0e7c518 to 2502b51f (15 revisions) (flutter/packages#4722)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

ac66bdb7

Roll Flutter Engine from 533670269c99 to 5019d6da655c (15 revisions) (#132797) · fb7baa9e

engine-flutter-autoroll authored Aug 17, 2023

https://github.com/flutter/engine/compare/533670269c99...5019d6da655c

2023-08-17 dkwingsmt@users.noreply.github.com Basic view management for engine classes (flutter/engine#42991)
2023-08-17 skia-flutter-autoroll@skia.org Roll Skia from d0d390f9310d to bfd45173e5e3 (5 revisions) (flutter/engine#44820)
2023-08-17 matanlurey@users.noreply.github.com Implement 2 suggested Clang Tidy fixes we don't look for yet. (flutter/engine#44816)
2023-08-17 louiseh0313@gmail.com Add share to selection controls (flutter/engine#44554)
2023-08-17 zanderso@users.noreply.github.com Adds new builders for partial clang-tidy checks. (flutter/engine#44811)
2023-08-17 41930132+hellohuanlin@users.noreply.github.com [ios][ios17]fix auto correction highlight on top left corner (flutter/engine#44779)
2023-08-17 109111084+yaakovschectman@users.noreply.github.com [Windows] Delay enabling app lifecycle states until requested (flutter/engine#44238)
2023-08-17 dkwingsmt@users.noreply.github.com Move `viewConfiguration` parsing from `PlatformDispatcher` to `_hooks` (flutter/engine#44787)
2023-08-17 skia-flutter-autoroll@skia.org Roll Dart SDK from 92c32df13d31 to 7e4e5796ee99 (2 revisions) (flutter/engine#44810)
2023-08-17 skia-flutter-autoroll@skia.org Roll Skia from c4805a975ab3 to d0d390f9310d (2 revisions) (flutter/engine#44807)
2023-08-17 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from cPncZK6z8HmuOmQr_... to 7xOzci7fempFgHNk9... (flutter/engine#44809)
2023-08-17 skia-flutter-autoroll@skia.org Roll Skia from efb5a5e0b78b to c4805a975ab3 (2 revisions) (flutter/engine#44795)
2023-08-17 skia-flutter-autoroll@skia.org Roll Skia from 11cb8cdd37c1 to efb5a5e0b78b (1 revision) (flutter/engine#44792)
2023-08-17 matanlurey@users.noreply.github.com Passthrough stderr results of clang_tidy when --enable-check-profile. (flutter/engine#44789)
2023-08-17 skia-flutter-autoroll@skia.org Roll Dart SDK from d6e1fca5dbdf to 92c32df13d31 (1 revision) (flutter/engine#44788)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from cPncZK6z8Hmu to 7xOzci7fempF

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

fb7baa9e

Run gsutil with full python3 and full path. (#132805) · a70a852c
godofredoc authored Aug 17, 2023
```
This is to prevent failures when the gsutil.py is not executable.
```
a70a852c
Leaks fix. (#132778) · aa1bacb3
Polina Cherkasova authored Aug 17, 2023
```
Fixes https://github.com/flutter/flutter/issues/132769
```
aa1bacb3
Send `examples/api` PRs to the framework review queue (#132768) · f0bfd7d6
Michael Goderbauer authored Aug 17, 2023

f0bfd7d6
Update the tracing_tests Dart SDK version constraint to fix an analyzer error (#132753) · f1fa9e34
Jason Simmons authored Aug 17, 2023

f1fa9e34
Update `Scrollable` on `ScrollBehaviour` change. (#131164) · f1d04a46
Chinmoy authored Aug 17, 2023
```
Fixes: #130793
```
f1d04a46

[Windows] Allow overwriting the cache's Dart SDK archive license file… (#132777) · 9e67e0e4

Loïc Sharma authored Aug 17, 2023

Relands https://github.com/flutter/flutter/pull/132669 after it was reverted by https://github.com/flutter/flutter/pull/132773. The test failures were fixed separately by https://github.com/flutter/flutter/pull/132766

Tracking issue: https://github.com/flutter/flutter/issues/132592
Cherrypick issue: https://github.com/flutter/flutter/issues/132718

9e67e0e4

Run new_gallery__transition_perf on Pixel 7 and Samsung A02 (#132772) · 6a024830
Zachary Anderson authored Aug 17, 2023

6a024830
Disable test order randomization on some leak tracker tests that are failing... · 609382a8
Jason Simmons authored Aug 17, 2023
```
Disable test order randomization on some leak tracker tests that are failing with today's seed (#132766)
```
609382a8

Revert "[Windows] Allow overwriting the cache's Dart SDK archive license file" (#132773) · e10d74b4

yaakovschectman authored Aug 17, 2023

Reverts flutter/flutter#132669

Introduced failure on `windows/mac/linux framework_library_tests`.

```
05:41 +7318 ~22 -1: /b/s/w/ir/x/w/flutter/packages/flutter/test/material/menu_bar_theme_test.dart: (tearDownAll) [E]                                                                                   
  Expected: leak free
    Actual: <Instance of 'Leaks'>
     Which: contains leaks:
            # The text is generated by leak_tracker.
            # For leak troubleshooting tips open:
            # https://github.com/dart-lang/leak_tracker/blob/main/doc/TROUBLESHOOT.md
            notDisposed:
              total: 3
              objects:
                ValueNotifier<_OverlayEntryWidgetState?>:
                  test: Constructor parameters override theme parameters
                  identityHashCode: 407433615
                FocusScopeNode:
                  test: Constructor parameters override theme parameters
                  identityHashCode: 513181650
                FocusScopeNode:
                  test: Constructor parameters override theme parameters
                  identityHashCode: 704743556
            
  package:matcher                                                                   expect
  package:flutter_test/src/widget_tester.dart 458:18                                expect
  package:leak_tracker_flutter_testing/src/leak_tracking_flutter_testing.dart 81:5  _tearDownTestingWithLeakTracking
  ===== asynchronous gap ===========================
  dart:async                                                                        _CustomZone.registerBinaryCallback
  package:leak_tracker_flutter_testing/src/leak_tracking_flutter_testing.dart 59:9  configureLeakTrackingTearDown.<fn>
```

e10d74b4

[Windows] Allow overwriting the cache's Dart SDK archive license file (#132669) · 7ee864ee

Loïc Sharma authored Aug 17, 2023

https://github.com/flutter/engine/pull/43974 added a license file to the Dart SDK's ZIP archive. As a result, extracting the Dart SDK now needs to overwrite the cache's `LICENSE.dart_sdk_archive.md` file.

This is a short-term solution that will be cherry-picked for the next [3.14 beta release](https://github.com/flutter/flutter/issues/132267). Addresses https://github.com/flutter/flutter/issues/132592.

The long-term solution is tracked by https://github.com/flutter/flutter/issues/132702

7ee864ee

Improve and optimize non-uniform Borders. (#124417) · b7046b32

Bernardo Ferrari authored Aug 17, 2023

~~Using the same priority order as a Border without borderRadius, it is possible to draw them on top of each other. This is better than the current behavior (crash!) and would work well for a "one color on top, another on bottom" scenario.~~

~~With this, if approved, we move the current number of possible exceptions from 4 to 1 (`BoxShape.circle` + `borderRadius`).~~

~~It is kind of odd how `borderRadius.zero` to `borderRadius != BorderRadius.zero` change, but I think it is better than crashing. Alternatively, we just remove the "original function" and see if any goldens are affected.~~

<img width="448" alt="image" src="https://user-images.githubusercontent.com/351125/236550350-7499d758-5b44-40e6-9105-32671eb21998.png">

Another one for @gspencergoog. If this works, we could make the paint method public and re-use in the InputBorder PR (if that's also approved). Single line fix.

b7046b32

Roll Flutter Engine from dbfe71c898b6 to 533670269c99 (15 revisions) (#132717) · fe9c7f4f

engine-flutter-autoroll authored Aug 17, 2023

https://github.com/flutter/engine/compare/dbfe71c898b6...533670269c99

2023-08-16 skia-flutter-autoroll@skia.org Roll Skia from 233c4f26427a to 11cb8cdd37c1 (1 revision) (flutter/engine#44786)
2023-08-16 jason-simmons@users.noreply.github.com Revert "Conditionally enable HardwareBuffer backed platform views (#44744)" (flutter/engine#44785)
2023-08-16 dnfield@google.com [Impeller] Update docstring on layer.presentsWithTransaction (flutter/engine#44782)
2023-08-16 john@johnmccutchan.com Switch some ERROR logs to WARNING logs (flutter/engine#44784)
2023-08-16 skia-flutter-autoroll@skia.org Roll Skia from 02870a1df818 to 233c4f26427a (1 revision) (flutter/engine#44780)
2023-08-16 skia-flutter-autoroll@skia.org Roll Dart SDK from cc5eeac65f89 to d6e1fca5dbdf (1 revision) (flutter/engine#44770)
2023-08-16 skia-flutter-autoroll@skia.org Roll Skia from e65aabc26c86 to 02870a1df818 (7 revisions) (flutter/engine#44778)
2023-08-16 matanlurey@users.noreply.github.com Add an optional '--enable-check-profile' to 'tools/clang_tidy'. (flutter/engine#44773)
2023-08-16 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from Zp9or9YwxZHHPeQbA... to VW7WAVPT3Cj5erlae... (flutter/engine#44777)
2023-08-16 louiseh0313@gmail.com Fix search web test (flutter/engine#44704)
2023-08-16 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from GpKKtPGPMiRcY0kcz... to cPncZK6z8HmuOmQr_... (flutter/engine#44769)
2023-08-16 godofredoc@google.com Remove duplicated v1 builds. (flutter/engine#44767)
2023-08-16 skia-flutter-autoroll@skia.org Roll Skia from d029f149a806 to e65aabc26c86 (4 revisions) (flutter/engine#44768)
2023-08-16 zanderso@users.noreply.github.com Split lint.sh into separate scripts for clang-tidy and pylint (flutter/engine#44763)
2023-08-16 john@johnmccutchan.com Conditionally enable HardwareBuffer backed platform views (flutter/engine#44744)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from GpKKtPGPMiRc to cPncZK6z8Hmu
fuchsia/sdk/core/mac-amd64 from Zp9or9YwxZHH to VW7WAVPT3Cj5

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

fe9c7f4f

Fix lower bound of children from TwoDimensionalChildBuilderDelegate (#132713) · ca319278

Kate Lovett authored Aug 17, 2023

Found in https://github.com/flutter/packages/pull/4536

The max x and max y index should allow for a case where there are no children in the viewport.
This should be CP'd into stable once it lands.

ca319278

Improvements to EditableText documentation (#132532) · 88643950
Ian Hickson authored Aug 17, 2023

88643950

Treat missing --local-engine-host as fatal on CI-like systems. (#132707) · b66878a6

Matan Lurey authored Aug 17, 2023

Partial work towards https://github.com/flutter/flutter/issues/132245.

The goal here is to "sniff" out any missing pieces that would block engine builds, rolls, benchmarks and so on before requiring humans to provide the parameter. The implementation is based on a [short discussion with @christopherfujino](https://discord.com/channels/608014603317936148/608022056616853515/1141503921546875110):

@matanlurey:

> Not sure whether to post here or â hackers-infra-ð¡ , but is there a way to (and is it advisable to) detect whether the tool is running in a CI environment? I'd like to "soft enforce" --local-engine-host being provided strictly on CI, make sure that lands well, and then "upgrade" it to being non-CI invocations as well (re: https://github.com/flutter/flutter/issues/132245).
>
> Also happy to get talked out of this idea ð

@christopherfujino:

> we have a check, lemme find it
> whether or not it is advisable, idk
> https://github.com/flutter/flutter/blob/flutter-3.14-candidate.0/packages/flutter_tools/lib/src/base/bot_detector.dart#L30
>
> (...)
>
> is your desire to get early signal before enforcing t his for humans to prevent functionality churn of landing and reverting and re-landing? 
>
> (yes)
>
> uhh, sure, that's advisable ð

b66878a6

Fix bad pattern in 2D tests (#132709) · af0ca978

Kate Lovett authored Aug 17, 2023

Fixes some poor tests choices in the 2D tests that were identified in https://github.com/flutter/packages/pull/4536

af0ca978

16 Aug, 2023 21 commits

Upgrade flutter packages. (#132697) · 1a0077dc
Polina Cherkasova authored Aug 16, 2023

1a0077dc

Triple tap selection should not move beyond text boundary at the tapped location (#132357) · 0e15ab54

Renzo Olivares authored Aug 16, 2023

This PR makes sure we do not select beyond the text boundary at the tapped position unless, we tap at the end of the text which in that case we should select the previous text boundary.

```dart
    // if x is a boundary defined by `textBoundary`, most textBoundaries (except
    // LineBreaker) guarantees `x == textBoundary.getLeadingTextBoundaryAt(x)`.
    // Use x - 1 here to make sure we don't get stuck at the fixed point x.
    final int start = textBoundary.getLeadingTextBoundaryAt(extent.offset - 1) ?? 0;
```

This was originally carried over from https://github.com/flutter/flutter/blob/f468f3366c26a5092eb964a230ce7892fda8f2f8/packages/flutter/lib/src/widgets/editable_text.dart#L4167-L4179 which used this `x - 1` to be able to move to the previous word boundary when navigating with a keyboard. When selecting by tapping/clicking we do not want to move past the text boundary at the tapped position so this adjustment is not needed.

Fixes #132126

0e15ab54

fixed documentation error input decorator (#132124) · 2cb762d1

Faisal Ansari authored Aug 16, 2023

In the documentation of _Shaker in InputDecoration "Used to "shake" the floating label to the left and right"
to the left was twice I have removed it.

2cb762d1

Fix not-disposed _InputBorderGap. (#132694) · 0ea523cf
Polina Cherkasova authored Aug 16, 2023
```
Fixes: https://github.com/flutter/flutter/issues/132620
```
0ea523cf

Add support for LOCAL_ENGINE_HOST to Linux/Mac/Win builds. (#132579) · 223ae5d3

Matan Lurey authored Aug 16, 2023

Partial work towards https://github.com/flutter/flutter/issues/132245.

I also couldn't help myself to do a very minor refactor and add some comments to `LocalEngineInfo` because I was getting confused myself implementing it.

223ae5d3

Analyze doc code snippets for all packages for which we publish docs (#132607) · 14f9ed28
Michael Goderbauer authored Aug 16, 2023
```
Fixes TODO in the analyzer script :)
```
14f9ed28
Revert "Roll Flutter Engine from dbfe71c898b6 to 12cafaeb9e31 (1 revision)" (#132698) · e52e8da3
yaakovschectman authored Aug 16, 2023
```
Reverts flutter/flutter#132677

Causes failure for `Linux firebase_abstract_method_smoke_test`
```
e52e8da3

Roll Flutter Engine from dbfe71c898b6 to 12cafaeb9e31 (1 revision) (#132677) · 8617a185

engine-flutter-autoroll authored Aug 16, 2023

https://github.com/flutter/engine/compare/dbfe71c898b6...12cafaeb9e31

2023-08-16 john@johnmccutchan.com Conditionally enable HardwareBuffer backed platform views (flutter/engine#44744)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

8617a185

Roll Flutter Engine from 8f5f8b34c374 to dbfe71c898b6 (1 revision) (#132673) · 06cb9a67

engine-flutter-autoroll authored Aug 16, 2023

https://github.com/flutter/engine/compare/8f5f8b34c374...dbfe71c898b6

2023-08-16 zanderso@users.noreply.github.com Adds runIf to linux_clang_tidy (flutter/engine#44759)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

06cb9a67

Fix some leaks and add test to test cover remaining in a simple way. (#131373) · 112f4293
Polina Cherkasova authored Aug 16, 2023
```
Contributes to https://github.com/flutter/flutter/issues/130467

Filed issue: https://github.com/flutter/flutter/issues/132620
```
112f4293

Roll Flutter Engine from 70b5700b79f6 to 8f5f8b34c374 (2 revisions) (#132665) · 371a9fc8

engine-flutter-autoroll authored Aug 16, 2023

https://github.com/flutter/engine/compare/70b5700b79f6...8f5f8b34c374

2023-08-16 skia-flutter-autoroll@skia.org Roll Skia from f30893561924 to d029f149a806 (1 revision) (flutter/engine#44764)
2023-08-16 skia-flutter-autoroll@skia.org Roll Skia from 3ab12f40c2a4 to f30893561924 (1 revision) (flutter/engine#44761)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

371a9fc8

Add more use cases to a11y assessments (#132325) · 99790cc8
chunhtai authored Aug 16, 2023
```
see [go/flutter-gar-reporting-q3-2023](http://go/flutter-gar-reporting-q3-2023)
```
99790cc8

Roll Packages from 84218b9d834c to 9bf208f4beb6 (7 revisions) (#132659) · 33ef5e41

engine-flutter-autoroll authored Aug 16, 2023

https://github.com/flutter/packages/compare/84218b9d834c...9bf208f4beb6

2023-08-16 engine-flutter-autoroll@skia.org Manual roll Flutter from 9b6945b4 to f0e7c518 (63 revisions) (flutter/packages#4719)
2023-08-15 31859944+LongCatIsLooong@users.noreply.github.com Update palette_generator_test.dart (flutter/packages#4720)
2023-08-15 mit@google.com [pigeon] Fix typo in README.md (flutter/packages#4707)
2023-08-15 43054281+camsim99@users.noreply.github.com [camerax] Explicitly remove READ_EXTERNAL_STORAGE permission (flutter/packages#4716)
2023-08-15 10687576+bparrishMines@users.noreply.github.com [webview_flutter_platform_interface] Adds support for retrieving user agent (flutter/packages#4563)
2023-08-15 43054281+camsim99@users.noreply.github.com [camerax] Wrap classes to implement resolution configuration for video capture (flutter/packages#4620)
2023-08-15 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 2.21.3 to 2.21.4 (flutter/packages#4706)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

33ef5e41

Roll Flutter Engine from f186f1e9dc88 to 70b5700b79f6 (1 revision) (#132655) · 2502b51f

engine-flutter-autoroll authored Aug 16, 2023

https://github.com/flutter/engine/compare/f186f1e9dc88...70b5700b79f6

2023-08-16 skia-flutter-autoroll@skia.org Roll Dart SDK from 80b9a90ae563 to cc5eeac65f89 (1 revision) (flutter/engine#44758)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

2502b51f

Roll Flutter Engine from e8670f03a9b1 to f186f1e9dc88 (2 revisions) (#132649) · 9f46ed74

engine-flutter-autoroll authored Aug 16, 2023

https://github.com/flutter/engine/compare/e8670f03a9b1...f186f1e9dc88

2023-08-16 skia-flutter-autoroll@skia.org Roll Skia from cb3451491f11 to 3ab12f40c2a4 (1 revision) (flutter/engine#44756)
2023-08-16 skia-flutter-autoroll@skia.org Roll Skia from 586a6309e3a1 to cb3451491f11 (2 revisions) (flutter/engine#44755)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

9f46ed74

Fix flutter_tools use of --local-engine-host (#132648) · 34232269

William Hesse authored Aug 16, 2023

PR #132346 added the use of --local-engine-host to flutter_tools internals, and had an error on one line. Fix that error, to use the correct field name.

The error occurs when building plugins with the changed tools.

34232269

Roll Flutter Engine from 7cc6a5832a0e to e8670f03a9b1 (3 revisions) (#132623) · 5fd9fc17

engine-flutter-autoroll authored Aug 16, 2023

https://github.com/flutter/engine/compare/7cc6a5832a0e...e8670f03a9b1

2023-08-16 skia-flutter-autoroll@skia.org Roll Dart SDK from e6bf503b36fe to 80b9a90ae563 (2 revisions) (flutter/engine#44753)
2023-08-16 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from orVLXMF7ak2qfFkGs... to GpKKtPGPMiRcY0kcz... (flutter/engine#44751)
2023-08-16 skia-flutter-autoroll@skia.org Roll Skia from 8f0238837ee4 to 586a6309e3a1 (2 revisions) (flutter/engine#44752)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from orVLXMF7ak2q to GpKKtPGPMiRc

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

5fd9fc17

Roll Flutter Engine from decaccfc421d to 7cc6a5832a0e (1 revision) (#132621) · 03aa95be

engine-flutter-autoroll authored Aug 16, 2023

https://github.com/flutter/engine/compare/decaccfc421d...7cc6a5832a0e

2023-08-16 skia-flutter-autoroll@skia.org Roll Skia from 3d2b84e28e79 to 8f0238837ee4 (1 revision) (flutter/engine#44748)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

03aa95be

Roll Flutter Engine from 659cdfc5a568 to decaccfc421d (6 revisions) (#132618) · c70d1843

engine-flutter-autoroll authored Aug 16, 2023

https://github.com/flutter/engine/compare/659cdfc5a568...decaccfc421d

2023-08-16 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from 7iuIq3PsSkuCmuEMr... to Zp9or9YwxZHHPeQbA... (flutter/engine#44747)
2023-08-16 godofredoc@google.com Move cache builders to prod. (flutter/engine#44739)
2023-08-16 26625149+0xZOne@users.noreply.github.com Enabling the host application to control the timing of attaching the |FlutterView| to the engine (flutter/engine#43595)
2023-08-16 skia-flutter-autoroll@skia.org Roll Skia from 9fc1c628456a to 3d2b84e28e79 (1 revision) (flutter/engine#44746)
2023-08-16 skia-flutter-autoroll@skia.org Roll Dart SDK from b36934aae968 to e6bf503b36fe (1 revision) (flutter/engine#44745)
2023-08-16 matanlurey@users.noreply.github.com [Skia] Only respect ui.Paint.dither when the colorSource is a gradient (flutter/engine#44730)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from 7iuIq3PsSkuC to Zp9or9YwxZHH

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

c70d1843

Roll Flutter Engine from 7409ce4ba0a8 to 659cdfc5a568 (1 revision) (#132612) · e1880435

engine-flutter-autoroll authored Aug 16, 2023

https://github.com/flutter/engine/compare/7409ce4ba0a8...659cdfc5a568

2023-08-16 jonahwilliams@google.com [Impeller] Cache render target texture allocations across frames. (flutter/engine#44527)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

e1880435

Revert "Reorganize and clarify API doc generator" (#132613) · 909400dc

Jonah Williams authored Aug 16, 2023

Reverts flutter/flutter#132353

Educated guess that this is causing the docs failures: https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8772644466113801713/+/u/Docs/Deploy_docs/Firebase_deploy/stdout

909400dc