Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
aa1bacb3
Unverified
Commit
aa1bacb3
authored
Aug 17, 2023
by
Polina Cherkasova
Committed by
GitHub
Aug 17, 2023
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Leaks fix. (#132778)
Fixes
https://github.com/flutter/flutter/issues/132769
parent
f0bfd7d6
Changes
4
Hide whitespace changes
Inline
Side-by-side
Showing
4 changed files
with
3 additions
and
8 deletions
+3
-8
menu_anchor.dart
packages/flutter/lib/src/material/menu_anchor.dart
+2
-0
focus_manager.dart
packages/flutter/lib/src/widgets/focus_manager.dart
+1
-0
menu_bar_theme_test.dart
packages/flutter/test/material/menu_bar_theme_test.dart
+0
-4
menu_theme_test.dart
packages/flutter/test/material/menu_theme_test.dart
+0
-4
No files found.
packages/flutter/lib/src/material/menu_anchor.dart
View file @
aa1bacb3
...
...
@@ -303,6 +303,7 @@ class _MenuAnchorState extends State<MenuAnchor> {
_anchorChildren
.
clear
();
_menuController
.
_detach
(
this
);
_internalMenuController
=
null
;
_menuScopeNode
.
dispose
();
super
.
dispose
();
}
...
...
@@ -551,6 +552,7 @@ class _MenuAnchorState extends State<MenuAnchor> {
}
_closeChildren
(
inDispose:
inDispose
);
_overlayEntry
?.
remove
();
_overlayEntry
?.
dispose
();
_overlayEntry
=
null
;
if
(!
inDispose
)
{
// Notify that _childIsOpen changed state, but only if not
...
...
packages/flutter/lib/src/widgets/focus_manager.dart
View file @
aa1bacb3
...
...
@@ -1480,6 +1480,7 @@ class FocusManager with DiagnosticableTreeMixin, ChangeNotifier {
@override
void
dispose
()
{
_highlightManager
.
dispose
();
rootScope
.
dispose
();
super
.
dispose
();
}
...
...
packages/flutter/test/material/menu_bar_theme_test.dart
View file @
aa1bacb3
...
...
@@ -2,10 +2,6 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
// Fails with "flutter test --test-randomize-ordering-seed=20230817"
@Tags
(<
String
>[
'no-shuffle'
])
library
;
import
'package:flutter/material.dart'
;
import
'package:flutter_test/flutter_test.dart'
;
import
'package:leak_tracker_flutter_testing/leak_tracker_flutter_testing.dart'
;
...
...
packages/flutter/test/material/menu_theme_test.dart
View file @
aa1bacb3
...
...
@@ -2,10 +2,6 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
// Fails with "flutter test --test-randomize-ordering-seed=20230817"
@Tags
(<
String
>[
'no-shuffle'
])
library
;
import
'package:flutter/material.dart'
;
import
'package:flutter_test/flutter_test.dart'
;
import
'package:leak_tracker_flutter_testing/leak_tracker_flutter_testing.dart'
;
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment