Unverified Commit af0ca978 authored by Kate Lovett's avatar Kate Lovett Committed by GitHub

Fix bad pattern in 2D tests (#132709)

Fixes some poor tests choices in the 2D tests that were identified in https://github.com/flutter/packages/pull/4536
parent 1a0077dc
...@@ -1514,7 +1514,7 @@ void main() { ...@@ -1514,7 +1514,7 @@ void main() {
maxXIndex: 5, maxXIndex: 5,
maxYIndex: 5, maxYIndex: 5,
builder: (BuildContext context, ChildVicinity vicinity) { builder: (BuildContext context, ChildVicinity vicinity) {
childKeys[vicinity] = UniqueKey(); childKeys[vicinity] = childKeys[vicinity] ?? UniqueKey();
return SizedBox.square(key: childKeys[vicinity], dimension: 200); return SizedBox.square(key: childKeys[vicinity], dimension: 200);
} }
); );
...@@ -1602,7 +1602,7 @@ void main() { ...@@ -1602,7 +1602,7 @@ void main() {
maxXIndex: 5, maxXIndex: 5,
maxYIndex: 5, maxYIndex: 5,
builder: (BuildContext context, ChildVicinity vicinity) { builder: (BuildContext context, ChildVicinity vicinity) {
childKeys[vicinity] = UniqueKey(); childKeys[vicinity] = childKeys[vicinity] ?? UniqueKey();
return SizedBox.square(key: childKeys[vicinity], dimension: 200); return SizedBox.square(key: childKeys[vicinity], dimension: 200);
} }
); );
...@@ -1731,7 +1731,7 @@ void main() { ...@@ -1731,7 +1731,7 @@ void main() {
maxXIndex: 5, maxXIndex: 5,
maxYIndex: 5, maxYIndex: 5,
builder: (BuildContext context, ChildVicinity vicinity) { builder: (BuildContext context, ChildVicinity vicinity) {
childKeys[vicinity] = UniqueKey(); childKeys[vicinity] = childKeys[vicinity] ?? UniqueKey();
return SizedBox.square(key: childKeys[vicinity], dimension: 200); return SizedBox.square(key: childKeys[vicinity], dimension: 200);
} }
); );
...@@ -1897,7 +1897,7 @@ void main() { ...@@ -1897,7 +1897,7 @@ void main() {
maxXIndex: 19, maxXIndex: 19,
maxYIndex: 19, maxYIndex: 19,
builder: (BuildContext context, ChildVicinity vicinity) { builder: (BuildContext context, ChildVicinity vicinity) {
childKeys[vicinity] = UniqueKey(); childKeys[vicinity] = childKeys[vicinity] ?? UniqueKey();
return SizedBox.square( return SizedBox.square(
dimension: 200, dimension: 200,
child: Center( child: Center(
...@@ -1965,7 +1965,7 @@ void main() { ...@@ -1965,7 +1965,7 @@ void main() {
maxXIndex: 5, maxXIndex: 5,
maxYIndex: 5, maxYIndex: 5,
builder: (BuildContext context, ChildVicinity vicinity) { builder: (BuildContext context, ChildVicinity vicinity) {
childKeys[vicinity] = UniqueKey(); childKeys[vicinity] = childKeys[vicinity] ?? UniqueKey();
return SizedBox.square(key: childKeys[vicinity], dimension: 200); return SizedBox.square(key: childKeys[vicinity], dimension: 200);
} }
); );
...@@ -2001,7 +2001,7 @@ void main() { ...@@ -2001,7 +2001,7 @@ void main() {
maxXIndex: 5, maxXIndex: 5,
maxYIndex: 5, maxYIndex: 5,
builder: (BuildContext context, ChildVicinity vicinity) { builder: (BuildContext context, ChildVicinity vicinity) {
childKeys[vicinity] = UniqueKey(); childKeys[vicinity] = childKeys[vicinity] ?? UniqueKey();
return SizedBox.square(key: childKeys[vicinity], dimension: 200); return SizedBox.square(key: childKeys[vicinity], dimension: 200);
} }
); );
...@@ -2119,7 +2119,7 @@ void main() { ...@@ -2119,7 +2119,7 @@ void main() {
maxXIndex: 5, maxXIndex: 5,
maxYIndex: 5, maxYIndex: 5,
builder: (BuildContext context, ChildVicinity vicinity) { builder: (BuildContext context, ChildVicinity vicinity) {
childKeys[vicinity] = UniqueKey(); childKeys[vicinity] = childKeys[vicinity] ?? UniqueKey();
return SizedBox.square(key: childKeys[vicinity], dimension: 200); return SizedBox.square(key: childKeys[vicinity], dimension: 200);
} }
); );
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment