- 10 Aug, 2023 1 commit
-
-
Christopher Fujino authored
Fixes: https://github.com/flutter/flutter/issues/124970 Part of https://github.com/flutter/flutter/issues/47161 Before this change, there were two places we overrode the `Artifacts` in a Zone: 1. if/when we parse local-engine CLI options: https://github.com/flutter/flutter/blob/1cf3907407cbc91be7cec2c38b348a2d66041dd5/packages/flutter_tools/lib/src/runner/flutter_command_runner.dart#L281 2. an additional override for fuchsia platform dill (no longer used, deleted in this PR): https://github.com/flutter/flutter/blob/1cf3907407cbc91be7cec2c38b348a2d66041dd5/packages/flutter_tools/lib/src/commands/attach.dart#L274 Note 1 above creates a new instance of `Artifacts.getLocalEngine()`. In this flow, there exist two instances of `Artifacts`: 1. The default fallback instance of `CachedArtifacts` (which gets all artifacts from flutter/bin/cache), instantiated in context_runner.dart: https://github.com/flutter/flutter/blob/1cf3907407cbc91be7cec2c38b348a2d66041dd5/packages/flutter_tools/lib/src/context_runner.dart#L137 2. An instance of `CachedLocalEngineArtifacts` created in the command runner once the CLI options have been parsed: https://github.com/flutter/flutter/blob/1cf3907407cbc91be7cec2c38b348a2d66041dd5/packages/flutter_tools/lib/src/runner/flutter_command_runner.dart#L281 The regression happened when we direct injected the Artifacts 1 from above BEFORE we parsed the local-engine flag, and then used this in the second zone override, and then when creating the `FlutterDevice` there are multiple calls to `globals.artifacts` returned it when it should have returned Artifacts 2: https://github.com/flutter/flutter/blob/1cf3907407cbc91be7cec2c38b348a2d66041dd5/packages/flutter_tools/lib/src/resident_runner.dart#L80 Device.artifactOverrides was originally introduced in https://github.com/flutter/flutter/pull/32071, but is no longer used, so I deleted it. I also removed direct injection of `Artifacts` to the attach sub-command, because that class now no longer references artifacts. I believe the ideal true fix for this would be to: 1. Migrate all leaf calls to `globals.artifacts` to use direct injection (in this case, the offending invocations were in [`FlutterDevice.create()`](https://github.com/flutter/flutter/blob/1cf3907407cbc91be7cec2c38b348a2d66041dd5/packages/flutter_tools/lib/src/resident_runner.dart#L80-L218), but I'm not sure that something else would not have broken later) 2. Ensure we are always direct injecting the desired instance of `Artifacts`--that is, if the user desires local engine artifacts, that we are passing an instance of `CachedLocalEngineArtifacts`. a. Alternatively, and probably simpler, teach `CachedArtifacts` to know about the local engine. This would mean parsing the global CLI options BEFORE we ever construct any instance of `Artifacts`. As an overall recommendation for implementing https://github.com/flutter/flutter/issues/47161, in the overall tree of tool function calls, we should probably migrate the leaves first (that is, migrate the sub-commands last). We should also audit and reconsider any usage of `runZoned()` or `context.run()` for the purpose overriding zoneValues.
-
- 22 Mar, 2023 1 commit
-
-
Christopher Fujino authored
Revert "[flutter_tools] Remove sound null safety flag (#123031)"
-
- 20 Mar, 2023 1 commit
-
-
Christopher Fujino authored
[flutter_tools] Remove sound null safety flag #2
-
- 17 Mar, 2023 2 commits
-
-
Christopher Fujino authored
This reverts commit 7c3088cf.
-
Christopher Fujino authored
[flutter_tools] Remove sound null safety flag
-
- 09 Feb, 2023 1 commit
-
-
Michael Thomsen authored
-
- 08 Nov, 2022 1 commit
-
-
Jesús S Guerrero authored
* update flutter build command * update tests * fix analyze suggestions
-
- 18 Oct, 2022 1 commit
-
-
Jesús S Guerrero authored
-
- 08 Sep, 2022 1 commit
-
-
Liam Appelbe authored
* Migrate packages/flutter_tools/test/general.shard, part 1/2 * Fix most of the tests * Fix analysis * Fix analysis * Fix test * Fix analysis * Fix analysis * Fix nit
-
- 07 Sep, 2022 1 commit
-
-
Michael Thomsen authored
-
- 22 Jul, 2022 1 commit
-
-
Rich Kadel authored
Fuchsia will soon remove all support for Component Framework version 1 components (recognized by component manifests ending in `.cmx`). Notably, some of the `flutter` tool commands for Fuchsia devices-- notably, but not limited to, those related to CFv1--are outdated, and either do not work today or soon won't work. This PR removes the outdated components and commands, replacing some with the newer version, or simply removing the non-working features, in some cases.
-
- 11 Nov, 2021 1 commit
-
-
Greg Spencer authored
-
- 02 Nov, 2021 1 commit
-
-
Jenn Magder authored
-
- 08 Oct, 2021 3 commits
-
-
Ian Hickson authored
-
Zachary Anderson authored
This reverts commit 5fd259be.
-
Ian Hickson authored
-
- 22 Jul, 2021 1 commit
-
-
Ahmed Ashour authored
-
- 08 Jul, 2021 2 commits
-
-
Zachary Anderson authored
This reverts commit 84e57678.
-
Ahmed Ashour authored
-
- 24 May, 2021 1 commit
-
-
Jenn Magder authored
-
- 12 Feb, 2021 1 commit
-
-
Hidenori Matsubayashi authored
-
- 27 Jan, 2021 1 commit
-
-
Jonah Williams authored
* opt out the flutter tool * oops EOF * fix import * Update tool_backend.dart * Update daemon_client.dart * fix more
-
- 20 Jan, 2021 1 commit
-
-
Michael Thomsen authored
-
- 07 Jan, 2021 1 commit
-
-
Jonah Williams authored
-
- 09 Oct, 2020 1 commit
-
-
Jenn Magder authored
-
- 25 Jun, 2020 1 commit
-
-
Jonah Williams authored
Missed this one. Needed for google3 and add2app workflows
-
- 23 Jun, 2020 1 commit
-
-
Jenn Magder authored
-
- 18 Jun, 2020 1 commit
-
-
Jonah Williams authored
Some of the null-safety commands were missing - plumb them through. Ensure that verbose mode shows their output, and clean up the messaging around sound-null-safety. Fixes #59769 Adds a test that validate each of the null safety supporting build commands has everything plumbed through.
-