Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
c8c86214
Unverified
Commit
c8c86214
authored
2 years ago
by
Michael Thomsen
Committed by
GitHub
2 years ago
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Clean up null safety messages (#120350)
parent
3fdd6ee4
Changes
7
Hide whitespace changes
Inline
Side-by-side
Showing
7 changed files
with
6 additions
and
35 deletions
+6
-35
build.dart
packages/flutter_tools/lib/src/commands/build.dart
+2
-7
resident_web_runner.dart
...s/flutter_tools/lib/src/isolated/resident_web_runner.dart
+2
-4
run_hot.dart
packages/flutter_tools/lib/src/run_hot.dart
+2
-4
build_test.dart
...flutter_tools/test/general.shard/commands/build_test.dart
+0
-10
resident_runner_test.dart
...lutter_tools/test/general.shard/resident_runner_test.dart
+0
-4
resident_web_runner_test.dart
...er_tools/test/general.shard/resident_web_runner_test.dart
+0
-2
overall_experience_test.dart
...tools/test/integration.shard/overall_experience_test.dart
+0
-4
No files found.
packages/flutter_tools/lib/src/commands/build.dart
View file @
c8c86214
...
...
@@ -110,13 +110,8 @@ abstract class BuildSubCommand extends FlutterCommand {
/// This is similar to the run message in run_hot.dart
@protected
void
displayNullSafetyMode
(
BuildInfo
buildInfo
)
{
_logger
.
printStatus
(
''
);
if
(
buildInfo
.
nullSafetyMode
==
NullSafetyMode
.
sound
)
{
_logger
.
printStatus
(
'💪 Building with sound null safety 💪'
,
emphasis:
true
,
);
}
else
{
if
(
buildInfo
.
nullSafetyMode
!=
NullSafetyMode
.
sound
)
{
_logger
.
printStatus
(
''
);
_logger
.
printStatus
(
'Building without sound null safety ⚠️'
,
emphasis:
true
,
...
...
This diff is collapsed.
Click to expand it.
packages/flutter_tools/lib/src/isolated/resident_web_runner.dart
View file @
c8c86214
...
...
@@ -608,10 +608,8 @@ class ResidentWebRunner extends ResidentRunner {
..
writeAsStringSync
(
websocketUri
.
toString
());
}
_logger
.
printStatus
(
'Debug service listening on
$websocketUri
'
);
_logger
.
printStatus
(
''
);
if
(
debuggingOptions
.
buildInfo
.
nullSafetyMode
==
NullSafetyMode
.
sound
)
{
_logger
.
printStatus
(
'💪 Running with sound null safety 💪'
,
emphasis:
true
);
}
else
{
if
(
debuggingOptions
.
buildInfo
.
nullSafetyMode
!=
NullSafetyMode
.
sound
)
{
_logger
.
printStatus
(
''
);
_logger
.
printStatus
(
'Running without sound null safety ⚠️'
,
emphasis:
true
,
...
...
This diff is collapsed.
Click to expand it.
packages/flutter_tools/lib/src/run_hot.dart
View file @
c8c86214
...
...
@@ -1029,10 +1029,8 @@ class HotRunner extends ResidentRunner {
}
commandHelp
.
c
.
print
();
commandHelp
.
q
.
print
();
globals
.
printStatus
(
''
);
if
(
debuggingOptions
.
buildInfo
.
nullSafetyMode
==
NullSafetyMode
.
sound
)
{
globals
.
printStatus
(
'💪 Running with sound null safety 💪'
,
emphasis:
true
);
}
else
{
if
(
debuggingOptions
.
buildInfo
.
nullSafetyMode
!=
NullSafetyMode
.
sound
)
{
globals
.
printStatus
(
''
);
globals
.
printStatus
(
'Running without sound null safety ⚠️'
,
emphasis:
true
,
...
...
This diff is collapsed.
Click to expand it.
packages/flutter_tools/test/general.shard/commands/build_test.dart
View file @
c8c86214
...
...
@@ -105,21 +105,11 @@ void main() {
nullSafetyMode:
NullSafetyMode
.
unsound
,
treeShakeIcons:
false
,
);
const
BuildInfo
sound
=
BuildInfo
(
BuildMode
.
debug
,
''
,
treeShakeIcons:
false
,
);
final
BufferLogger
logger
=
BufferLogger
.
test
();
FakeBuildSubCommand
(
logger
).
test
(
unsound
);
expect
(
logger
.
statusText
,
contains
(
'Building without sound null safety ⚠️'
));
logger
.
clear
();
FakeBuildSubCommand
(
logger
).
test
(
sound
);
expect
(
logger
.
statusText
,
contains
(
'💪 Building with sound null safety 💪'
));
});
testUsingContext
(
'Include only supported sub commands'
,
()
{
...
...
This diff is collapsed.
Click to expand it.
packages/flutter_tools/test/general.shard/resident_runner_test.dart
View file @
c8c86214
...
...
@@ -1492,8 +1492,6 @@ flutter:
commandHelp
.
c
,
commandHelp
.
q
,
''
,
'💪 Running with sound null safety 💪'
,
''
,
'An Observatory debugger and profiler on FakeDevice is available at: null'
,
''
,
].
join
(
'
\n
'
)
...
...
@@ -1523,8 +1521,6 @@ flutter:
commandHelp
.
c
,
commandHelp
.
q
,
''
,
'💪 Running with sound null safety 💪'
,
''
,
'An Observatory debugger and profiler on FakeDevice is available at: null'
,
''
,
].
join
(
'
\n
'
)
...
...
This diff is collapsed.
Click to expand it.
packages/flutter_tools/test/general.shard/resident_web_runner_test.dart
View file @
c8c86214
...
...
@@ -547,8 +547,6 @@ void main() {
'Waiting for connection from debug service on FakeDevice...
\n
'
'Debug service listening on ws://127.0.0.1/abcd/
\n
'
'
\n
'
'💪 Running with sound null safety 💪
\n
'
'
\n
'
'first
\n
'
'
\n
'
'second
\n
'
...
...
This diff is collapsed.
Click to expand it.
packages/flutter_tools/test/integration.shard/overall_experience_test.dart
View file @
c8c86214
...
...
@@ -591,8 +591,6 @@ void main() {
'c Clear the screen'
,
'q Quit (terminate the application on the device).'
,
''
,
contains
(
'Running with sound null safety'
),
''
,
startsWith
(
'An Observatory debugger and profiler on Flutter test device is available at: http://'
),
startsWith
(
'The Flutter DevTools debugger and profiler on Flutter test device is available at: http://'
),
''
,
...
...
@@ -620,8 +618,6 @@ void main() {
'c Clear the screen'
,
'q Quit (terminate the application on the device).'
,
''
,
contains
(
'Running with sound null safety'
),
''
,
startsWith
(
'An Observatory debugger and profiler on Flutter test device is available at: http://'
),
startsWith
(
'The Flutter DevTools debugger and profiler on Flutter test device is available at: http://'
),
''
,
...
...
This diff is collapsed.
Click to expand it.
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment