Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
c8e53b38
Unverified
Commit
c8e53b38
authored
Jun 23, 2020
by
Jenn Magder
Committed by
GitHub
Jun 23, 2020
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Add null safety options to build ios-framework (#60111)
parent
8fce4ce9
Changes
4
Hide whitespace changes
Inline
Side-by-side
Showing
4 changed files
with
19 additions
and
3 deletions
+19
-3
build.dart
packages/flutter_tools/lib/src/commands/build.dart
+1
-0
build_ios_framework.dart
...s/flutter_tools/lib/src/commands/build_ios_framework.dart
+4
-0
build_ios_framework_test.dart
...est/commands.shard/hermetic/build_ios_framework_test.dart
+11
-3
build_test.dart
...flutter_tools/test/general.shard/commands/build_test.dart
+3
-0
No files found.
packages/flutter_tools/lib/src/commands/build.dart
View file @
c8e53b38
...
...
@@ -28,6 +28,7 @@ class BuildCommand extends FlutterCommand {
addSubcommand
(
BuildIOSCommand
(
verboseHelp:
verboseHelp
));
addSubcommand
(
BuildIOSFrameworkCommand
(
buildSystem:
globals
.
buildSystem
,
verboseHelp:
verboseHelp
,
));
addSubcommand
(
BuildBundleCommand
(
verboseHelp:
verboseHelp
));
addSubcommand
(
BuildWebCommand
(
verboseHelp:
verboseHelp
));
...
...
packages/flutter_tools/lib/src/commands/build_ios_framework.dart
View file @
c8e53b38
...
...
@@ -37,6 +37,7 @@ class BuildIOSFrameworkCommand extends BuildSubCommand {
BuildIOSFrameworkCommand
({
FlutterVersion
flutterVersion
,
// Instantiating FlutterVersion kicks off networking, so delay until it's needed, but allow test injection.
@required
BuildSystem
buildSystem
,
@required
bool
verboseHelp
,
Cache
cache
,
Platform
platform
})
:
_flutterVersion
=
flutterVersion
,
...
...
@@ -51,6 +52,9 @@ class BuildIOSFrameworkCommand extends BuildSubCommand {
addSplitDebugInfoOption
();
addDartObfuscationOption
();
usesExtraFrontendOptions
();
addNullSafetyModeOptions
(
hide:
!
verboseHelp
);
addEnableExperimentation
(
hide:
!
verboseHelp
);
argParser
..
addFlag
(
'debug'
,
negatable:
true
,
...
...
packages/flutter_tools/test/commands.shard/hermetic/build_ios_framework_test.dart
View file @
c8e53b38
...
...
@@ -66,7 +66,8 @@ void main() {
buildSystem:
MockBuildSystem
(),
platform:
fakePlatform
,
flutterVersion:
mockFlutterVersion
,
cache:
mockCache
cache:
mockCache
,
verboseHelp:
false
,
);
expect
(()
=>
command
.
produceFlutterPodspec
(
BuildMode
.
debug
,
outputDirectory
),
...
...
@@ -90,7 +91,8 @@ void main() {
buildSystem:
MockBuildSystem
(),
platform:
fakePlatform
,
flutterVersion:
mockFlutterVersion
,
cache:
mockCache
cache:
mockCache
,
verboseHelp:
false
,
);
expect
(()
=>
command
.
produceFlutterPodspec
(
BuildMode
.
debug
,
outputDirectory
),
...
...
@@ -111,7 +113,8 @@ void main() {
buildSystem:
MockBuildSystem
(),
platform:
fakePlatform
,
flutterVersion:
mockFlutterVersion
,
cache:
mockCache
cache:
mockCache
,
verboseHelp:
false
,
);
expect
(()
=>
command
.
produceFlutterPodspec
(
BuildMode
.
debug
,
outputDirectory
),
...
...
@@ -149,6 +152,7 @@ void main() {
platform:
fakePlatform
,
flutterVersion:
mockFlutterVersion
,
cache:
mockCache
,
verboseHelp:
false
,
);
command
.
produceFlutterPodspec
(
BuildMode
.
debug
,
outputDirectory
,
force:
true
);
...
...
@@ -171,6 +175,7 @@ void main() {
platform:
fakePlatform
,
flutterVersion:
mockFlutterVersion
,
cache:
mockCache
,
verboseHelp:
false
,
);
command
.
produceFlutterPodspec
(
BuildMode
.
debug
,
outputDirectory
);
...
...
@@ -190,6 +195,7 @@ void main() {
platform:
fakePlatform
,
flutterVersion:
mockFlutterVersion
,
cache:
mockCache
,
verboseHelp:
false
,
);
command
.
produceFlutterPodspec
(
BuildMode
.
debug
,
outputDirectory
);
...
...
@@ -207,6 +213,7 @@ void main() {
platform:
fakePlatform
,
flutterVersion:
mockFlutterVersion
,
cache:
mockCache
,
verboseHelp:
false
,
);
command
.
produceFlutterPodspec
(
BuildMode
.
profile
,
outputDirectory
);
...
...
@@ -224,6 +231,7 @@ void main() {
platform:
fakePlatform
,
flutterVersion:
mockFlutterVersion
,
cache:
mockCache
,
verboseHelp:
false
,
);
command
.
produceFlutterPodspec
(
BuildMode
.
release
,
outputDirectory
);
...
...
packages/flutter_tools/test/general.shard/commands/build_test.dart
View file @
c8e53b38
...
...
@@ -9,10 +9,12 @@ import 'package:flutter_tools/src/commands/build_apk.dart';
import
'package:flutter_tools/src/commands/build_appbundle.dart'
;
import
'package:flutter_tools/src/commands/build_fuchsia.dart'
;
import
'package:flutter_tools/src/commands/build_ios.dart'
;
import
'package:flutter_tools/src/commands/build_ios_framework.dart'
;
import
'package:flutter_tools/src/commands/build_linux.dart'
;
import
'package:flutter_tools/src/commands/build_macos.dart'
;
import
'package:flutter_tools/src/commands/build_web.dart'
;
import
'package:flutter_tools/src/commands/build_windows.dart'
;
import
'package:flutter_tools/src/globals.dart'
as
globals
;
import
'../../src/common.dart'
;
import
'../../src/context.dart'
;
...
...
@@ -29,6 +31,7 @@ void main() {
BuildAppBundleCommand
(
verboseHelp:
false
),
BuildFuchsiaCommand
(
verboseHelp:
false
),
BuildAarCommand
(
verboseHelp:
false
),
BuildIOSFrameworkCommand
(
verboseHelp:
false
,
buildSystem:
globals
.
buildSystem
),
];
for
(
final
BuildSubCommand
command
in
commands
)
{
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment