- 01 Feb, 2018 2 commits
-
-
Ian Hickson authored
-
amirh authored
0672055a changed the Material widget to always use Paths for representing the outline. These paths are later used for clipping and drawing a shadow. This changed introduced a performance regression, see: https://github.com/flutter/flutter/issues/14403 We did not expect a path that is a rounded rectangle to be less performant than a rounded rectangle, as Skia should be able to tell the path is just a rounded rectangle. Until we find a solution for this regression, we keep using RRect when we can represent the shape with it.
-
- 31 Jan, 2018 10 commits
-
-
Michael Goderbauer authored
-
Chris Bracken authored
In a scaffold, snackbars are positioned above the BottomNavigationBar and/or PersistentBottomButtons, if present. In such cases, they should not apply bottom media padding to their widget sub-tree.
-
Michael Goderbauer authored
With a little refactor and unification of how availability of copy/cut/paste is determined across platforms. Minor remaining issue: https://github.com/flutter/flutter/issues/14331. Fixes https://github.com/flutter/flutter/issues/13501.
-
Ian Hickson authored
-
xster authored
* first round fastlane working on Android * clean up and start ios * Partial iOS * Got a fastfile that works on iOS * Finalize Android push instructions * Finalize instructions for iOS * Extra cleanup and optipng * Disable readme autogen and add a default readme
-
jensjoha authored
* [kernel/flutter] Improve speed of first hot reload * [kernel/flutter] Improve speed of first hot reload * Revert "[kernel/flutter] Improve speed of first hot reload" This reverts commit f3dc133878ec7405a8efb5715f1cfe720f4ea05f. * Revert "[kernel/flutter] Improve speed of first hot reload" This reverts commit f7bcb082b01cf9cf48f02c6aad9e5c79705def8f. * Revert "Revert "[kernel/flutter] Improve speed of first hot reload"" This reverts commit 73c7a1a8e85a4c0397984d8b65a98b2f71bf84f3. * [kernel/flutter] Improve speed of first hot reload Do so by not evicting unnecessary paths (while still evicting paths that was changed between the generation of the package file and the initial upload). * Fix grammar in method name * Fix bad merge * Add method to super class
-
amirh authored
This triggered an analysis failure only on the devicelab.
-
amirh authored
For backward compatibility we keep supporting specifying the shape as a combination of MaterialType and borderRadius, and we just use that as a default when shapeBorder is null. To cleanup the implementation if shapeBorder was not specified we just translate the specified shape to a shapeBorder internally. I benchmarked paint, layout and hit testing, with the specialized shape clippers vs. the equivalent path clippers and did not see any significant performance difference. For testing, I extended the clippers/physicalShape matchers to match either the specialized shape or the equivalent shape.
-
Vyacheslav Egorov authored
-
Greg Spencer authored
This updates the CupertinoAlertDialog to respect text scale factor more properly. Before this, it would scale, but would clip the action buttons at large scales, and would draw in the safe area. It also didn't match the iOS alert because the content didn't scroll. Now it does those properly. I didn't address the fact that buttons should lay out properly (Issue #14345), but that's probably pretty low priority. Fixes #12484
-
- 30 Jan, 2018 16 commits
-
-
Chris Bracken authored
Includes: * Only implement application:performActionForShortcutItem:completionHandler on iOS 9.0+ (flutter/engine#4600) * [fuchsia] Remove MessageLoopHandler dependency (flutter/engine#4618) * Use @available checks for iOS 11 features (#4619)
-
amirh authored
-
Ian Hickson authored
* Try to make transitioning channels actually work. * Update upgrade.dart
-
xster authored
-
Ian Hickson authored
-
Ian Hickson authored
-
Ian Hickson authored
-
Alexander Markov authored
-
Chris Bracken authored
Includes: * Roll Dart SDK (flutter/engine#4613)
-
Greg Spencer authored
This script will update release metadata in the cloud, and copy the already-built package to the right location and name on cloud storage. The release metadata will be located in gs://flutter_infra/releases/releases.json, and the published packages will end up in gs://flutter_infra/releases/<channel>/<platform>/flutter_<platform>_<version><archive suffix>, where <channel>, <platform>, <version>, and <archive suffix> are determined by the script. At the moment, it only supports dev rolls, but (once we know how those will work) should easily support beta rolls as well.
-
Tom Larsen authored
* Add a callback that fires when a Draggable leaves a DragTarget. This enables the DragTarget to manage its state from entry to exit. * It helps to have a null check here * Add test for onLeave callback and add verbiage to onWillAccept explaining the callback lifecycle of a DragTarget.
-
Ankur Kedia authored
* adds crossAxisEndOffset and rollbackDuration properties to dismissible widget * re-added removed license comment * corrected license comments * Adds test for rollbackDuration and crossAxisEndOffset * added tests and comments * modified tests for dismissible widgets
-
Chris Bracken authored
Includes: * Remove unnecessary trim (#4616)
-
Ian Hickson authored
It adds lines like `SHARD=analyze` to each shard, and a message like `Contents of packages/flutter_localizations/lib/src/l10n/localizations.dart matches output of gen_localizations.dart script.` to the analysis shard.
-
Chris Bracken authored
Includes: * Extract common iOS asset path lookup code: #4594 * Introduce VulkanProvider fb9782a5294e700e45e372da0cd25165697b2e45 * Transition render target images before submit 0de8218778f1bb5d913db8b8a67789a44f8bb28f * Update buildtools to Fuchsia HEAD #4599
-
Tom Larsen authored
* Add onCancelled callback to PopupMenu * Fix spelling, don't call onCanceled if disposed, improve documentation.
-
- 29 Jan, 2018 5 commits
-
-
amirh authored
-
amirh authored
-
Todd Volkert authored
* Make the current command injected into the AppContext, allowing other classes to inject the current command. * Introduce `AssetBundleFactory`, an injected factory class for spawning instances of `AssetBundle`. This allows other run contexts to use custom asset bundling logic. * Clean up RunCommand by removing a 'packages' argument that duplicated a global argument by the same name (and for the same purpose). Duplicate arguments are confusing and error-prone.
-
amirh authored
-
xster authored
-
- 27 Jan, 2018 7 commits
-
-
Martin Kustermann authored
This was overlooked in 5e18c076
-
Ian Hickson authored
* Fix shadows in NestedScrollView The previous logic (and especially the previous test) wasn't quite right. * Update nested_scroll_view.dart
-
amirh authored
This widget evolved over time by multiple people, I'm just trying to explain in a more direct way what the widget is currently doing.
-
Chris Bracken authored
When running with --preview-dart-2, host variant of the engine is required. Simulator builds, like device builds, should resolve host_RUNTIMEVARIANT_OPTVARIANT, not host_RUNTIMEVARIANT_sim_OPTVARIANT.
-
Ian Hickson authored
-
Ian Hickson authored
Fixes https://github.com/flutter/flutter/issues/14232 (I haven't tested this with older versions of git, I'm just going on what @jason-simmons wrote in the bug.)
-
Seth Ladd authored
* Point to master API docs I _think_ this is the right place, since people contributing and working on master might care about where the API docs are for master branch. * Update CONTRIBUTING.md update from review comment
-