Commits · 15a7e07395ed0701e3f2393d57d0159ef5a66529 · abdullh.alsoleman / Front-End

12 May, 2023 5 commits

Fix `showDatePicker` in input mode throws an `ArgumentError` (#126525) · 15a7e073

Taha Tesser authored May 12, 2023

fixes https://github.com/flutter/flutter/issues/126397

The `parseCompactDate` method in `material_localizations.dart` with long text throws an argument error before the date picker could handle it to show a validation error while the date picker is on autovalidate.

This PR adds `try/catch` in the `parseCompactDate` to return null on the argument error.

15a7e073

Increase test timeout for analyzer_benchmark to 60 minutes (#126586) · 468512e0
Zachary Anderson authored May 12, 2023
```
Fixes https://github.com/flutter/flutter/issues/126451
```
468512e0

Fix TextSpan gc regression (#126382) · 4eefced8

LongCatIsLooong authored May 12, 2023

`for (final InlineSpan child in children ?? const <InlineSpan>[])` bad

Fixes https://github.com/flutter/flutter/issues/126337

4eefced8

Roll Flutter Engine from 748ef964b993 to ef5c349f04d8 (1 revision) (#126624) · 5e459380

engine-flutter-autoroll authored May 12, 2023

https://github.com/flutter/engine/compare/748ef964b993...ef5c349f04d8

2023-05-11 leroux_bruno@yahoo.fr [Linux - TextInput] Do not add new line for send action (flutter/engine#41895)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

5e459380

Roll Flutter Engine from f38f46f66e9a to 748ef964b993 (13 revisions) (#126622) · 43b2b658

engine-flutter-autoroll authored May 12, 2023

https://github.com/flutter/engine/compare/f38f46f66e9a...748ef964b993

2023-05-11 skia-flutter-autoroll@skia.org Roll Skia from aed81125e6bc to ccec5093ca38 (10 revisions) (flutter/engine#41963)
2023-05-11 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from 2tQjI0g3aDmjHAtMw... to MjcKzcsqMDkuRKopu... (flutter/engine#41960)
2023-05-11 smartercallum@gmail.com iPhone floating cursor selection (flutter/engine#36643)
2023-05-11 vashworth@google.com Update README.md (flutter/engine#41953)
2023-05-11 skia-flutter-autoroll@skia.org Roll Clang from 5344d8e10bb7 to 6d667d4b261e (flutter/engine#41949)
2023-05-11 kjlubick@users.noreply.github.com Use moved SkImage procs (flutter/engine#41947)
2023-05-11 msgh@selfisekai.rocks allow supplying custom gn args in gn wrapper (flutter/engine#41794)
2023-05-11 68549184+Mayb3Nots@users.noreply.github.com fix: platform_dispatcher documentation typo (flutter/engine#41739)
2023-05-11 lhkbob@gmail.com Remove GN staging flag for save layer bounds (flutter/engine#41940)
2023-05-11 flar@google.com switch MockTexture off of MockCanvas calls (flutter/engine#41906)
2023-05-11 gspencergoog@users.noreply.github.com [Android] Lifecycle defaults to focused instead of unfocused (flutter/engine#41875)
2023-05-11 skia-flutter-autoroll@skia.org Roll Skia from ccf73af6ca91 to aed81125e6bc (9 revisions) (flutter/engine#41946)
2023-05-11 godofredoc@google.com Clobber caches in licenses test. (flutter/engine#41942)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from 2tQjI0g3aDmj to MjcKzcsqMDku

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

43b2b658

11 May, 2023 11 commits

Add dimensions to release builds. (#126117) · fa117aad

godofredoc authored May 11, 2023

Release builds running in dart internal require the dimensions to be set explicitly at the target level in ci.yaml.

Bug: https://github.com/flutter/flutter/issues/126116

fa117aad

Revert "[tool] Move Java functions to their own file" (#126569) · 5b2f658f

Andrew Kolos authored May 11, 2023

Reverts flutter/flutter#126086.

This PR changed the interfaces of some classes, namely `AndroidSdk`, and deleted a global.

These classes had custom overrides in g3 that were not updated with a g3fix, so this PR has broken tests. See https://b.corp.google.com/issues/281945232 (non-public link)

5b2f658f

Manual roll Flutter Engine from a0925f158198 to f38f46f66e9a (8 revisions) (#126554) · 37fe1e9d

engine-flutter-autoroll authored May 11, 2023

Manual roll requested by zra@google.com

https://github.com/flutter/engine/compare/a0925f158198...f38f46f66e9a

2023-05-11 whesse@google.com Add pkg:protobuf as a dependency for
testing/dart (flutter/engine#41938)
2023-05-11 skia-flutter-autoroll@skia.org Roll Skia from 0c979da775be to
ccf73af6ca91 (1 revision) (flutter/engine#41937)
2023-05-11 skia-flutter-autoroll@skia.org Roll Skia from a12a999cbd09 to
0c979da775be (1 revision) (flutter/engine#41935)
2023-05-11 skia-flutter-autoroll@skia.org Roll Skia from 9cbc2c578e10 to
a12a999cbd09 (2 revisions) (flutter/engine#41933)
2023-05-11 skia-flutter-autoroll@skia.org Roll Skia from 1a29bd9a0147 to
9cbc2c578e10 (10 revisions) (flutter/engine#41932)
2023-05-11 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from
a3rrULFaXlwS8mfjW... to 2tQjI0g3aDmjHAtMw... (flutter/engine#41931)
2023-05-11 jacksongardner@google.com Return fonts in a deterministic
order. (flutter/engine#41907)
2023-05-11 58529443+srujzs@users.noreply.github.com Turn @staticInterop
tear-off into closure (flutter/engine#41885)

Also rolling transitive DEPS:
  fuchsia/sdk/core/mac-amd64 from a3rrULFaXlwS to 2tQjI0g3aDmj

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the
revert to ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

37fe1e9d

Add `cpu: x86` dimension and xcode dependency for Mac_build_test targets (#126482) · a7a1ddfb

keyonghan authored May 11, 2023

This is a follow up of https://github.com/flutter/flutter/pull/111164.

My local LED was based on `cpu: x86` dimension and `xcode` dependency. But these are missed in the above PR, which caused test failure: https://ci.chromium.org/ui/p/flutter/builders/staging/Mac_build_test%20flutter_gallery__transition_perf_e2e_ios/19/overview

a7a1ddfb

Make dpr available during Scrollable disposal (#126535) · dc3d6603

Michael Goderbauer authored May 11, 2023

Fixes https://github.com/flutter/flutter/issues/126454.

In certain situations (see linked bug) the Scrollable needs access to the DPR of the View it is drawn into during disposal. Since inherited widget lookups are not allowed during disposal, we cannot look up the DPR dynamically in these situations. Instead, we have to cache the DPR when lookups are still allowed.

dc3d6603

Fix `MultiChildLayoutDelegate.hasChild` doc (#126433) · 12659f2a

Taha Tesser authored May 11, 2023

fixes https://github.com/flutter/flutter/issues/115898

`hasChild` checks `_idToChild` map.  `_idToChild` is not assigned until `_callPerformLayout` is called.
So `hasChild` shouldn't be called in `getSize`.

https://github.com/flutter/flutter/blob/df789c9e76098e82f80f2c5de8b5560f360afa40/packages/flutter/lib/src/rendering/custom_layout.dart#L400-L404

Updated docs and example class names.

12659f2a

Sync lints (#126316) · 42d9a2b3

Michael Goderbauer authored May 11, 2023

Sync lints with https://github.com/dart-lang/linter/blob/master/example/all.yaml and enable `implicit_reopen` and `type_literal_in_constant_pattern` (which have no violations). Also contains some clean-up work towards enabling `matching_super_parameters`, which is not quite ready yet due to its handling of "private" arguments.

42d9a2b3

[tool] Move Java functions to their own file (#126086) · 0a63cd70

Andrew Kolos authored May 11, 2023

This is the first step in unifying Java-finding logic across the tool. If curious, see #126029 for an example of what all the changes will probably entail.

Moves java-related functionality like `AndroidSdk.findJavaHome` to a new class, `Java`.

See tracking issue https://github.com/flutter/flutter/issues/126126 for more.

0a63cd70

Roll Flutter Engine from ef771f95e928 to a0925f158198 (1 revision) (#126486) · a308666d

engine-flutter-autoroll authored May 11, 2023

https://github.com/flutter/engine/compare/ef771f95e928...a0925f158198

2023-05-10 mdebbar@google.com [web] Expose PlatformLocation and HashUrlStrategy through ui_web (flutter/engine#41163)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

a308666d

Roll Flutter Engine from de6e130f77fc to ef771f95e928 (3 revisions) (#126481) · 224c8b92

engine-flutter-autoroll authored May 11, 2023

https://github.com/flutter/engine/compare/de6e130f77fc...ef771f95e928

2023-05-10 chris@bracken.jp [macos] Disable background colour tests (flutter/engine#41904)
2023-05-10 yjbanov@google.com [web] generalize focusability in semantics (flutter/engine#41831)
2023-05-10 skia-flutter-autoroll@skia.org Roll Skia from 32f4cfc2460b to 1a29bd9a0147 (12 revisions) (flutter/engine#41905)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

224c8b92

Reorder `materialStateProperty` defaults (#125905) · 4e7e4512

Qun Cheng authored May 11, 2023

Fixes #122250. This PR is to make sure all the MaterialStateProperty defaults are able to correctly resolve different states. 
* When a widget is pressed, it is also hovered, so we need to put the `MaterialState.pressed` check before `MaterialState.hovered`. 
* When a widget is focused, the widget should still be able to be hovered, so we should check `MaterialState.hovered` before `MaterialState.focused`.
* There are also cases like in _InputDecoratorDefaultsM3, the `MaterialState.disabled` should be checked before `MaterialState.error`.

 the order should be disabled, (error), pressed, hovered, focused.

4e7e4512

10 May, 2023 9 commits

Roll Flutter Engine from 406b3546a2ac to de6e130f77fc (2 revisions) (#126472) · a48cc240

engine-flutter-autoroll authored May 10, 2023

https://github.com/flutter/engine/compare/406b3546a2ac...de6e130f77fc

2023-05-10 godofredoc@google.com Revert "Move linux_license to engine v2." (flutter/engine#41903)
2023-05-10 41930132+hellohuanlin@users.noreply.github.com [backdrop_filter]Avoid relying on internal class details (flutter/engine#41873)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

a48cc240

✨ Add `strokeAlign` to `CircularProgressIndicator` and `RefreshProgressIndicator` (#125945) · d01d8aee
Alex Li authored May 10, 2023

d01d8aee

Roll Flutter Engine from 10ac36c52f08 to 406b3546a2ac (13 revisions) (#126468) · a3257ca5

engine-flutter-autoroll authored May 10, 2023

https://github.com/flutter/engine/compare/10ac36c52f08...406b3546a2ac

2023-05-10 mdebbar@google.com [web] Re-enable history tests on Safari
(flutter/engine#41901)
2023-05-10 flar@google.com switch from MockCanvas to DisplayListBuilder
in layer unit tests (flutter/engine#41889)
2023-05-10 zanderso@users.noreply.github.com Revert "Move linux fuchsia
engine v2 build to prod." (flutter/engine#41902)
2023-05-10 godofredoc@google.com Migrate mac host clang tidy to engine
v2. (flutter/engine#41824)
2023-05-10 jonahwilliams@google.com [Impeller] delete special handling
of RRect. (flutter/engine#41872)
2023-05-10 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from
JiOACcaGrDphuHIql... to a3rrULFaXlwS8mfjW... (flutter/engine#41898)
2023-05-10 109111084+yaakovschectman@users.noreply.github.com Only
register top level window message listener upon registering service
binding (flutter/engine#41733)
2023-05-10 skia-flutter-autoroll@skia.org Roll Skia from 8c936fb9ba8e to
32f4cfc2460b (27 revisions) (flutter/engine#41891)
2023-05-10 yjbanov@google.com [web] dialog a11y fixes
(flutter/engine#41681)
2023-05-10 skia-flutter-autoroll@skia.org Roll Dart SDK from
2cf089614e1c to 7ad028c26344 (2 revisions) (flutter/engine#41882)
2023-05-10 jonahwilliams@google.com [Impeller] Increase minimum size of
alpha glyph atlas. (flutter/engine#41880)
2023-05-10 jonahwilliams@google.com [Impeller] Use separate atlases and
shaders for color and alpha (flutter/engine#41780)
2023-05-10 godofredoc@google.com Move linux fuchsia engine v2 build to
prod. (flutter/engine#41865)

Also rolling transitive DEPS:
  fuchsia/sdk/core/mac-amd64 from JiOACcaGrDph to a3rrULFaXlwS

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the
revert to ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

a3257ca5

Manual roll Flutter Engine from 10ac36c52f08 to 892f88d2513f (11 revisions) (#126455) · ce3b4f88

engine-flutter-autoroll authored May 10, 2023

Manual roll requested by aaclarke@google.com

Cannot build log URL because revision "892f88d2513f" is invalid: Luci
builds of "Linux Fuchsia FEMU" for
892f88d2513f4a60ebd6d1496c4ac272e53c55ba was STARTED

2023-05-10 zanderso@users.noreply.github.com Revert "Move linux fuchsia
engine v2 build to prod." (flutter/engine#41902)
2023-05-10 godofredoc@google.com Migrate mac host clang tidy to engine
v2. (flutter/engine#41824)
2023-05-10 jonahwilliams@google.com [Impeller] delete special handling
of RRect. (flutter/engine#41872)
2023-05-10 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from
JiOACcaGrDphuHIql... to a3rrULFaXlwS8mfjW... (flutter/engine#41898)
2023-05-10 109111084+yaakovschectman@users.noreply.github.com Only
register top level window message listener upon registering service
binding (flutter/engine#41733)
2023-05-10 skia-flutter-autoroll@skia.org Roll Skia from 8c936fb9ba8e to
32f4cfc2460b (27 revisions) (flutter/engine#41891)
2023-05-10 yjbanov@google.com [web] dialog a11y fixes
(flutter/engine#41681)
2023-05-10 skia-flutter-autoroll@skia.org Roll Dart SDK from
2cf089614e1c to 7ad028c26344 (2 revisions) (flutter/engine#41882)
2023-05-10 jonahwilliams@google.com [Impeller] Increase minimum size of
alpha glyph atlas. (flutter/engine#41880)
2023-05-10 jonahwilliams@google.com [Impeller] Use separate atlases and
shaders for color and alpha (flutter/engine#41780)
2023-05-10 godofredoc@google.com Move linux fuchsia engine v2 build to
prod. (flutter/engine#41865)

Also rolling transitive DEPS:
  fuchsia/sdk/core/mac-amd64 from JiOACcaGrDph to a3rrULFaXlwS

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the
revert to ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

ce3b4f88

tool/web: correctly log all options to web wasm compile (#126379) · 1b831a2c
Kevin Moore authored May 10, 2023
```
Filtering on 'true' omitted non-bool values
```
1b831a2c

Manual roll Flutter Engine from 78f41a8f2f06 to 10ac36c52f08 (6 revisions) (#126445) · 01ac99aa

engine-flutter-autoroll authored May 10, 2023

Manual roll requested by zra@google.com

https://github.com/flutter/engine/compare/78f41a8f2f06...10ac36c52f08

2023-05-09 jacksongardner@google.com Implement text rendering in Skwasm
(flutter/engine#41832)
2023-05-09 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from
leCRDVJ8szOS2LsPV... to lf8VcONMWlne4oa3H... (flutter/engine#41876)
2023-05-09 30870216+gaaclarke@users.noreply.github.com [Impeller]
started cleaning up pools when devices are deleted
(flutter/engine#41857)
2023-05-09 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from
c4JvQUEOBHgtRdNPc... to JiOACcaGrDphuHIql... (flutter/engine#41874)
2023-05-09 godofredoc@google.com Move linux_license to engine v2.
(flutter/engine#41863)
2023-05-09 godofredoc@google.com Replace Windows Unopt with the engine
v2 version. (flutter/engine#41861)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from leCRDVJ8szOS to lf8VcONMWlne
  fuchsia/sdk/core/mac-amd64 from c4JvQUEOBHgt to JiOACcaGrDph

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the
revert to ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

01ac99aa

Manual roll Flutter Engine from 8ca16cba8c38 to 78f41a8f2f06 (2 revisions) (#126392) · a76dbe44

engine-flutter-autoroll authored May 10, 2023

Manual roll requested by zra@google.com

https://github.com/flutter/engine/compare/8ca16cba8c38...78f41a8f2f06

2023-05-09 skia-flutter-autoroll@skia.org Roll Dart SDK from
4b4c0325fd5b to 2cf089614e1c (3 revisions) (flutter/engine#41866)
2023-05-09 lhkbob@gmail.com Remove staging flag (flutter/engine#41843)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the
revert to ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

a76dbe44

Roll flutter/packages to 0167d834e937 (#126427) · df789c9e
stuartmorgan authored May 10, 2023
```
Manual package roll to fix tree.

Fixes https://github.com/flutter/flutter/issues/126393
```
df789c9e
Migrate gallery ios tests to build+test (#111164) · 8ab782d0
keyonghan authored May 10, 2023
```
Part of https://github.com/flutter/flutter/issues/103542
```
8ab782d0

09 May, 2023 9 commits

Roll Flutter Engine from 824cd09b8c62 to 8ca16cba8c38 (5 revisions) (#126360) · b269eb52

engine-flutter-autoroll authored May 09, 2023

https://github.com/flutter/engine/compare/824cd09b8c62...8ca16cba8c38

2023-05-09 jonahwilliams@google.com [Impeller] track path convexity and
use it to simplify fill tessellation. (flutter/engine#41834)
2023-05-09 skia-flutter-autoroll@skia.org Roll Skia from 9ba374e0b0f0 to
8c936fb9ba8e (7 revisions) (flutter/engine#41854)
2023-05-09 skia-flutter-autoroll@skia.org Roll Skia from 485cd3d0f9ca to
9ba374e0b0f0 (3 revisions) (flutter/engine#41849)
2023-05-09 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from
oGF4h14qc40l5ANL3... to c4JvQUEOBHgtRdNPc... (flutter/engine#41848)
2023-05-09 skia-flutter-autoroll@skia.org Roll Dart SDK from
498cfa57165b to 4b4c0325fd5b (2 revisions) (flutter/engine#41847)

Also rolling transitive DEPS:
  fuchsia/sdk/core/mac-amd64 from oGF4h14qc40l to c4JvQUEOBHgt

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the
revert to ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

b269eb52

Revert "Provide default constraints for M3 dialogs" (#126355) · a153d6da
Kevin Chisholm authored May 09, 2023
```
Reverts flutter/flutter#120082

Causing breakages: b/281181985
```
a153d6da

Roll Packages from 4800d6512ebb to 1f917101d486 (8 revisions) (#126352) · ce579326

engine-flutter-autoroll authored May 09, 2023

https://github.com/flutter/packages/compare/4800d6512ebb...1f917101d486

2023-05-09 43054281+camsim99@users.noreply.github.com [camerax] Update README with plugin overview (flutter/packages#3891)
2023-05-09 jmccandless@google.com Fix nullability in docs (flutter/packages#3876)
2023-05-08 stuartmorgan@google.com [tools] Check version ranges when pathifying deps (flutter/packages#3943)
2023-05-08 stuartmorgan@google.com [quick_actions] Update minimum iOS version to 11 (flutter/packages#3946)
2023-05-08 stuartmorgan@google.com [shared_preferences] Update minimum iOS version to 11 (flutter/packages#3945)
2023-05-08 stuartmorgan@google.com [path_provider] Update minimum iOS version to 11 (flutter/packages#3944)
2023-05-08 34871572+gmackall@users.noreply.github.com Adding setup for TestInstanceManagerHostApi in zoom and exposure tests (flutter/packages#3947)
2023-05-08 engine-flutter-autoroll@skia.org Roll Flutter from 43ac23b4 to 4ed1c923 (16 revisions) (flutter/packages#3942)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

ce579326

[github] Add labeler action (#126012) · bf88f605

Casey Hillers authored May 09, 2023

Part of https://github.com/flutter/flutter/issues/126002

Migrate the [Cocoon logic for labelling](https://cs.opensource.google/flutter/cocoon/+/main:app_dart/lib/src/request_handlers/github/webhook_subscription.dart;l=352) directly into the repo under test

bf88f605

Fix platformLocation path and search dropping (#126232) · cab29b20

Severin authored May 09, 2023

This PR fixes the dropping of both the `path` and `search` fields from the platform location in the URL when using Flutter Web and brings it in par with similar technologies (e.g. React Router).
It allows developers to keep the original path and/or search parameters in the URL, which are perfectly valid even while fragment routing is present.

**Example use case:**
Call a Flutter Web app with initial config parameters in the URL: 
`http://my-flutter.app/?skipIntro=true`

**Example:**
Before initial routing:
`http://localhost:45389/?foo=bar`
After routing:
`http://localhost:45389/#/menu`
After routing (with fix):
`http://localhost:45389/?foo=bar#menu`

Fixes #116415

cab29b20

Roll Flutter Engine from 8d3a8162b3ab to 824cd09b8c62 (10 revisions) (#126309) · 8a7ded7b

engine-flutter-autoroll authored May 09, 2023

https://github.com/flutter/engine/compare/8d3a8162b3ab...824cd09b8c62

2023-05-09 godofredoc@google.com Increase timeout of orchestrator. (flutter/engine#41839)
2023-05-09 ianloic@google.com [fuchsia] Stop calling FIDL from Dart in Flutter integration tests (flutter/engine#41669)
2023-05-09 wez@google.com [tests] Remove unused fuchsia.sys protocol reference (flutter/engine#41826)
2023-05-09 skia-flutter-autoroll@skia.org Roll Skia from 7736fbaf84f0 to 485cd3d0f9ca (6 revisions) (flutter/engine#41840)
2023-05-09 30870216+gaaclarke@users.noreply.github.com [Impeller] introduces DeviceHolder to avoid accessing a dead Device (flutter/engine#41748)
2023-05-08 jacksongardner@google.com Get rid of "outrageous" default text styles for HTML renderer. (flutter/engine#41822)
2023-05-08 flar@google.com Adjust DL filter bounds tests to not rely on exact Skia results (flutter/engine#41792)
2023-05-08 skia-flutter-autoroll@skia.org Roll Dart SDK from a8b6687327d6 to 498cfa57165b (1 revision) (flutter/engine#41823)
2023-05-08 JonathanPeterCole@gmail.com [Android] Fix incorrect viewInsets during keyboard animation with EdgeToEdge (flutter/engine#39391)
2023-05-08 skia-flutter-autoroll@skia.org Roll Skia from 951eb9653163 to 7736fbaf84f0 (1 revision) (flutter/engine#41821)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

8a7ded7b

Update FocusNode documentation (#126331) · a800edff

Bruno Leroux authored May 09, 2023

## Description

This PR adds some details in FocusNode documentation to explain more precisely when listeners are notified.

## Related Issue

Fixes https://github.com/flutter/flutter/issues/126149

## Tests

Documentation only.

a800edff

Remove dead code (#126266) · 58454e9e

Michael Goderbauer authored May 09, 2023

Dead code was flagged by `unreachable_from_main` lint, which is still experimental and not ready to be enabled yet.

58454e9e

fix AppBar's docs for backgroundColor (#126194) · 5b87e4fb
Viren Khatri authored May 09, 2023

5b87e4fb

08 May, 2023 6 commits

tool/web: tiniest tweak to wasm help content (#126284) · 8c5a1ea7
Kevin Moore authored May 08, 2023
```
Missing "tick"
```
8c5a1ea7

Roll Flutter Engine from d9184ce4ffa0 to 8d3a8162b3ab (7 revisions) (#126288) · 8ceec452

engine-flutter-autoroll authored May 08, 2023

https://github.com/flutter/engine/compare/d9184ce4ffa0...8d3a8162b3ab

2023-05-08 skia-flutter-autoroll@skia.org Roll Skia from 30a368d502bf to 951eb9653163 (4 revisions) (flutter/engine#41820)
2023-05-08 jacksongardner@google.com Reland "Skwasm Font Loading (flutter/engine#41756)
2023-05-08 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from KZrdNPIOcs5m2MqV_... to oGF4h14qc40l5ANL3... (flutter/engine#41819)
2023-05-08 skia-flutter-autoroll@skia.org Roll Dart SDK from 855e2764c295 to a8b6687327d6 (1 revision) (flutter/engine#41817)
2023-05-08 skia-flutter-autoroll@skia.org Roll Skia from 64ba57381c94 to 30a368d502bf (1 revision) (flutter/engine#41816)
2023-05-08 godofredoc@google.com Add linux license engine v2 build. (flutter/engine#41797)
2023-05-08 godofredoc@google.com Windows unopt configuration. (flutter/engine#41785)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from KZrdNPIOcs5m to oGF4h14qc40l

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

8ceec452

Fix that `flutter test` does not understand `concurrency` (#125942) · 2a9530f3

fzyzcjy authored May 08, 2023

Close https://github.com/flutter/flutter/issues/125940

I will add tests if this PR looks roughly OK :)

The fix mainly mimics https://github.com/flutter/flutter/pull/115160 - just remove the default argument.

p.s. I ran into this bug when wanting to set concurrency in my dart_test.yaml for one set of my tests which I need to be executed without parallalization.

2a9530f3

Fix that `flutter test` does not understand `concurrency` (#125942) · 742a1b49

fzyzcjy authored May 08, 2023

Close https://github.com/flutter/flutter/issues/125940

I will add tests if this PR looks roughly OK :)

The fix mainly mimics https://github.com/flutter/flutter/pull/115160 - just remove the default argument.

p.s. I ran into this bug when wanting to set concurrency in my dart_test.yaml for one set of my tests which I need to be executed without parallalization.

742a1b49

Improve the format in `asset_bundle.dart` (#126229) · 6b756ab5

Alex Li authored May 08, 2023

Just found these extra intents and the very long line which might be improved.

Related git blame: https://github.com/flutter/flutter/blame/master/packages/flutter/lib/src/services/asset_bundle.dart#L337.

6b756ab5

Tiny cleanup for Navigator code (without introducing dependency) (#125628) · 431dfc83

fzyzcjy authored May 08, 2023

Close https://github.com/flutter/flutter/issues/125724

> The `navigator.dart` has ~10 repeats of things like:
> 
> ```dart
>     final _RouteEntry? currentRouteEntry = _navigator!._history.cast<_RouteEntry?>().lastWhere(
>       (_RouteEntry? e) => e != null && _RouteEntry.isPresentPredicate(e),
>       orElse: () => null,
>     );
> ```
> 
> while it can be greatly simplified as:
> 
> ```dart
>     final _RouteEntry? currentRouteEntry = _navigator!._history.lastWhereOrNull(_RouteEntry.isPresentPredicate);
> ```
> 
> Thus, it seems that we can beautify the code a little bit.

Same as https://github.com/flutter/flutter/pull/125099, but without external dependency

For more detailed explanation why it does not introduce external dependency: https://github.com/flutter/flutter/pull/125099#discussion_r1174230502

431dfc83