- 03 May, 2023 19 commits
-
-
Kevin Moore authored
-
gmackall authored
[Reland] Add migrator to upgrade gradle version when conflict with Android Studio bundled Java version is detected (#125836) This is an attempt to reland https://github.com/flutter/flutter/pull/124085. Differences from this attempt and the last: 1. Adds a check for null android studio versions and a test for this case. 2. Wraps the migrate code in a try-catch [per the suggestion here](https://github.com/flutter/flutter/pull/125728/files#r1181747899). Old PR description: This PR adds an android project migrator that checks the version of android studio and the version of gradle for conflicts, and upgrades to 7.4 if a conflict is detected. For more detail about the particular conflict, see https://github.com/flutter/flutter/issues/122376. The PR also upgrades older gradle versions being used in integration testing to 7.4. Fixes/related to: https://github.com/flutter/flutter/issues/122376 and https://github.com/flutter/flutter/issues/123636
-
Kevin Moore authored
-
LongCatIsLooong authored
I'd like to find out the `fontSize` of a `PlaceholderSpan`, and currently there doesn't seem to be a way to do `TextStyle` cascading in the framework: `InlineSpan.visitChildren` traverses the entire `InlineSpan` tree using a preorder traversal, and nodes that don't have "content" will be skipped (https://master-api.flutter.dev/flutter/painting/InlineSpan/visitChildren.html): > Walks this [InlineSpan](https://master-api.flutter.dev/flutter/painting/InlineSpan-class.html) and any descendants in pre-order and calls visitor for each span that has content. which makes it impossible to do `TextStyle` cascading in the framework: - `InlineSpan`s with a non-null `TextStyle` but has no content will be skipped - `visitChildren` doesn't directly expose the hierarchy, it only gives information about the flattened tree. This doesn't look like a breaking change, most internal customers are extending `WidgetSpan` which has a concrete implementation of the new method. Alternatively I could create a fake `ui.ParagraphBuilder` and record the `ui.TextStyle` at the top of the stack when `addPlaceholder` is called. But `ui.TextStyle` properties are not exposed to the framework.
-
godofredoc authored
Adds SLSA L1 badge
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/b71728bee873...7d70dc81cfa5 2023-05-03 skia-flutter-autoroll@skia.org Roll Dart SDK from 342dff83c38e to 3cfcfb24bc6a (1 revision) (flutter/engine#41698) 2023-05-03 joshualitt@google.com [web] Add `dart:js_interop_unsafe` to SDK. (flutter/engine#41591) 2023-05-03 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 9T4mGpfsJZO0KPtfp... to n1UnzmslAzt04yRv6... (flutter/engine#41697) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from 9T4mGpfsJZO0 to n1UnzmslAzt0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/packages/compare/f163786731b8...407b7da0079e 2023-05-03 vashworth@google.com Update Cirrus to Xcode 14.3 (flutter/packages#3890) 2023-05-03 stuartmorgan@google.com [file_selector] Deprecates `macUTIs` (flutter/packages#3888) 2023-05-03 41930132+hellohuanlin@users.noreply.github.com [pigeon]enable treat warning as errors for swift code in unit test (flutter/packages#3889) 2023-05-02 vashworth@google.com Update xcode to 14e222b (flutter/packages#3868) 2023-05-02 41930132+hellohuanlin@users.noreply.github.com [pigeon]fix "as Any" workaround due to nested optional (flutter/packages#3658) 2023-05-02 10687576+bparrishMines@users.noreply.github.com [webview_flutter_android] Adds support to accept third party cookies (flutter/packages#3834) 2023-05-02 10687576+bparrishMines@users.noreply.github.com [webview_flutter_wkwebview] Fixes an exception caused by the `onUrlChange` callback returning a null url (flutter/packages#3848) 2023-05-02 pateltirth454@gmail.com [google_maps_flutter] [Docs] Note regarding usage within a bounded & an unbound widget (flutter/packages#3691) 2023-05-02 evace93@gmail.com [local_auth_android] Fix Android lint warnings (flutter/packages#3764) 2023-05-02 koji.wakamiya@gmail.com [go_router_builder] Support go_router v7 (flutter/packages#3858) 2023-05-02 10687576+bparrishMines@users.noreply.github.com [webview_flutter_wkwebview] Fixes internal enum type and adds unknown enum values (flutter/packages#3812) 2023-05-02 stuartmorgan@google.com [file_selector] Add MIME type support on macOS (flutter/packages#3862) 2023-05-02 engine-flutter-autoroll@skia.org Roll Flutter from 828a0404 to db6074ad (12 revisions) (flutter/packages#3881) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Flutter GitHub Bot authored
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY. { "name": "Linux_android slider_perf_android" } --> The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Linux_android%20slider_perf_android%22). This test can be marked as unflaky. -
Elias Yishak authored
Adding a `printOnFailure` call into the flakey test to help debug the cause for future failures. - Reference issue: https://github.com/flutter/flutter/issues/125512
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/bc8f14001d7a...b71728bee873 2023-05-03 skia-flutter-autoroll@skia.org Roll Dart SDK from 4d084f5b8f91 to 342dff83c38e (2 revisions) (flutter/engine#41692) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/99e5184c7aa8...bc8f14001d7a 2023-05-03 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from ubfKertFqqUj0WD8I... to WAfNudyWPOGyWSpZD... (flutter/engine#41691) 2023-05-03 skia-flutter-autoroll@skia.org Roll Skia from b58340991480 to 887e58fff02f (2 revisions) (flutter/engine#41690) Also rolling transitive DEPS: fuchsia/sdk/core/mac-amd64 from ubfKertFqqUj to WAfNudyWPOGy If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/0407a16a9b5e...99e5184c7aa8 2023-05-03 skia-flutter-autoroll@skia.org Roll Skia from 3c1ecab42cd4 to b58340991480 (1 revision) (flutter/engine#41689) 2023-05-03 skia-flutter-autoroll@skia.org Roll Skia from 7781dda8104f to 3c1ecab42cd4 (2 revisions) (flutter/engine#41688) 2023-05-03 skia-flutter-autoroll@skia.org Roll Dart SDK from 7c061d8c9dc0 to 4d084f5b8f91 (1 revision) (flutter/engine#41686) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
fzyzcjy authored
Close #125385 - please see explanations there :) If you think this PR looks OK, I will polish it (e.g. copy-and-paste-and-modify the tests shown in #125385 into here and make CI pass)
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/228da31894f7...0407a16a9b5e 2023-05-03 skia-flutter-autoroll@skia.org Roll Skia from 54c32e41eced to 7781dda8104f (1 revision) (flutter/engine#41684) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
LouiseHsu authored
Adds the ability to rename Runner.xcodeproj and Runner.xcworkspace - fixes https://github.com/flutter/flutter/issues/9767. To rename a project: 1. Open Runner.xcodeproj in Xcode 2. In the left panel, left click "Show File Inspector" <img width="441" alt="Screenshot 2023-04-17 at 11 41 07 PM" src="https://user-images.githubusercontent.com/36148254/232692957-8743742d-c3ef-42e5-833f-dff31aeb2b6a.png"> 3. In the right panel, the name of the project, "Runner", should be visible under "Identity and Type". Change the name and press enter. <img width="299" alt="Screenshot 2023-04-17 at 11 40 43 PM" src="https://user-images.githubusercontent.com/36148254/232693315-b6a71165-f5e3-4a0f-8954-2f3eee5b67cf.png"> 4. A wizard should pop up. Click Rename. <img width="573" alt="Screenshot 2023-04-17 at 11 44 01 PM" src="https://user-images.githubusercontent.com/36148254/232693381-bb9cf026-2a75-4844-b42d-ae0036ae9fdd.png"> To rename the workspace: 1. Make sure Xcode is closed. 2. Rename the .xcworkspace to your new name. If you also renamed the project 3. Reopen the .xcworkspace in Xcode. If the selected project is the old name and in red, update it to match the new project name. Tests for schemeFor were changed as with Xcode 14, in some cases the scheme will be renamed along with the project. Thus we will get the best match scheme for either the project name, or the default name Runner. However if a flavor is present, the scheme should always match the flavor.
-
Zachary Anderson authored
Not sure why this wasn't already being reported.
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/fb3002443fcc...228da31894f7 2023-05-03 skia-flutter-autoroll@skia.org Roll Skia from 089b9cca26fe to 54c32e41eced (3 revisions) (flutter/engine#41683) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/7e77d838df3a...fb3002443fcc 2023-05-03 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from g_6rn9e-GBQGQGwgt... to 9T4mGpfsJZO0KPtfp... (flutter/engine#41679) 2023-05-02 skia-flutter-autoroll@skia.org Roll Dart SDK from ea1fce8e0aa7 to 7c061d8c9dc0 (1 revision) (flutter/engine#41677) 2023-05-02 ianloic@google.com [fuchsia] fix run_integration_test.sh (flutter/engine#41668) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from g_6rn9e-GBQG to 9T4mGpfsJZO0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/c4a2712e8f4d...7e77d838df3a 2023-05-02 skia-flutter-autoroll@skia.org Roll Skia from 644e199b6832 to 089b9cca26fe (14 revisions) (flutter/engine#41675) 2023-05-02 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from moQlKaNgpc0WD3sjC... to ubfKertFqqUj0WD8I... (flutter/engine#41674) Also rolling transitive DEPS: fuchsia/sdk/core/mac-amd64 from moQlKaNgpc0W to ubfKertFqqUj If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
- 02 May, 2023 21 commits
-
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/cd989fbc80bf...c4a2712e8f4d 2023-05-02 leroux_bruno@yahoo.fr Web - Fix selection jump on Chrome for Android (flutter/engine#41202) 2023-05-02 skia-flutter-autoroll@skia.org Roll Dart SDK from 84f3080c3165 to ea1fce8e0aa7 (1 revision) (flutter/engine#41672) 2023-05-02 magder@google.com Stop specifiying Macmini8,1 in ci builders, use inherited mac_model dimension (flutter/engine#41223) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Chris Yang authored
Framework part of https://github.com/flutter/flutter/issues/125814
-
Loïc Sharma authored
Update `flutter doctor` to clarify that Visual Studio is needed only if creating Windows apps. Windows users targeting Android do not need to install Visual Studio.
-
Jenn Magder authored
This hasn't flaked for > 50 commits which is our threshhold. Marking as unflaky.
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/6fe3f5079792...cd989fbc80bf 2023-05-02 godofredoc@google.com Migrate Linux Android AOT Engine to engine V2. (flutter/engine#41638) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
godofredoc authored
They require an additional dimension to be passed as part of the .ci.yaml configuration. Bug: https://github.com/flutter/flutter/issues/125897 ## Pre-launch Checklist - [X] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [X] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [X] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [X] I signed the [CLA]. - [X] I listed at least one issue that this PR fixes in the description above. - [X] I updated/added relevant documentation (doc comments with `///`). - [X] I added new tests to check the change I am making, or this PR is [test-exempt]. - [X] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene [test-exempt]: https://github.com/flutter/flutter/wiki/Tree-hygiene#tests [Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo [Features we expect every widget to implement]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/wiki/Chat
-
Valentin Vignal authored
Align the `PopupMenu` under its child. Before:  After:  *List which issues are fixed by this PR. You must list at least one issue.* Fixes https://github.com/flutter/flutter/issues/125474 *If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/53c192f41f96...6fe3f5079792 2023-05-02 skia-flutter-autoroll@skia.org Roll Skia from c574ba686a93 to 644e199b6832 (1 revision) (flutter/engine#41666) 2023-05-02 jason-simmons@users.noreply.github.com Clone the parent Android engine's asset provider into a spawned engine (flutter/engine#41642) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Polina Cherkasova authored
-
Jonah Williams authored
Engine PR: https://github.com/flutter/engine/pull/41593 This must land first We should remove these, as they've been deprecated for a while. On the engine side of things, the physical model layer is the only one which requires the device pixel ratio, so deleting it will allow us to simplify the layer tree code in https://github.com/flutter/engine/pull/41559
-
engine-flutter-autoroll authored
https://github.com/flutter/packages/compare/de6131dbe4f7...f163786731b8 2023-05-01 43054281+camsim99@users.noreply.github.com [camerax] Retrieve exposure and zoom camera information (flutter/packages#3798) 2023-05-01 engine-flutter-autoroll@skia.org Manual roll Flutter from 66fa4c5d to 828a0404 (79 revisions) (flutter/packages#3874) 2023-05-01 vashworth@google.com [video_player, google_sign_in] Updates functions without a prototype to avoid deprecation warning (flutter/packages#3873) 2023-05-01 reidbaker@google.com [various] Speed up build-examples (flutter/packages#3849) 2023-05-01 stuartmorgan@google.com [file_selector] Remove uses of `macUTIs` (flutter/packages#3859) 2023-05-01 stuartmorgan@google.com [file_selector] Add getDirectoryPaths implementation for macOS (flutter/packages#3703) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Bruno Leroux authored
## Description This PR adds a new debug flag named `debugPrintKeyboardEvents` to help debugging keyboard issues. Keyboard code has some useful asserts but sometimes an assertion failure is related to the handling of previous key events. This debug flag will help understanding the flow of key events which leads to an assertion failure. ## Related Issue Fixes https://github.com/flutter/flutter/issues/125627 ## Tests Adds 1 test.
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/44376e8cd3de...53c192f41f96 2023-05-02 skia-flutter-autoroll@skia.org Roll Dart SDK from 0c4f93a82e0b to 84f3080c3165 (1 revision) (flutter/engine#41665) 2023-05-02 skia-flutter-autoroll@skia.org Roll Skia from e71bd40af2bb to c574ba686a93 (1 revision) (flutter/engine#41664) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/46d5ce4784b8...44376e8cd3de 2023-05-02 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from ur2ymZJCZSj64s6Q2... to g_6rn9e-GBQGQGwgt... (flutter/engine#41663) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from ur2ymZJCZSj6 to g_6rn9e-GBQG If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/a687d62ff631...46d5ce4784b8 2023-05-02 zhongwuzw@qq.com [macOS] Add lookupKeyForAsset to FlutterPluginRegistrar (flutter/engine#37421) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/d0ed35b7bf67...a687d62ff631 2023-05-02 skia-flutter-autoroll@skia.org Roll Skia from d2c85cb8aa2f to e71bd40af2bb (1 revision) (flutter/engine#41662) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/c0d68c36c376...d0ed35b7bf67 2023-05-02 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from u7iIoiSX4y8WV6Of1... to moQlKaNgpc0WD3sjC... (flutter/engine#41661) Also rolling transitive DEPS: fuchsia/sdk/core/mac-amd64 from u7iIoiSX4y8W to moQlKaNgpc0W If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/a9e38dd0510d...c0d68c36c376 2023-05-02 skia-flutter-autoroll@skia.org Roll Skia from e18b7415188c to d2c85cb8aa2f (2 revisions) (flutter/engine#41660) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/024bf946232d...a9e38dd0510d 2023-05-02 skia-flutter-autoroll@skia.org Roll Skia from c9e0992be00b to e18b7415188c (1 revision) (flutter/engine#41659) 2023-05-02 skia-flutter-autoroll@skia.org Roll Dart SDK from 25c29435f73e to 0c4f93a82e0b (2 revisions) (flutter/engine#41657) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Casey Rogers authored
cc'ing existing conversation participants: @domesticmouse @srawlins cc'ing to request review: @goderbauer This PR makes the following constructor arguments required: 1. `FutureBuilder.future` 2. `StreamBuilderBase.stream` 3. `StreamBuilder.stream` This fixes: https://github.com/flutter/flutter/issues/83081 https://github.com/flutter/flutter/issues/125188 (dupe of 83081) This obviates: https://github.com/dart-lang/linter/issues/4309 (I suggest we skip straight to merging this PR as this should be a low impact breaking change-assuming few to no devs are intentionally using the builders without their relevant arguments, however we could always merge 4309 first and then this) https://github.com/flutter/flutter/pull/83101 (The above PR required that at least one of future and initial data be non-null, this is undesirable as there are plenty of valid reasons to have both arguments be null) See above issues for a deeper dive, but here is a summary: It is very easy for a developer to forget to specify `future` or `stream` when using the respective `*Builder` widgets. This produces a non-obvious failure where the UI sits in a "no data yet received" state. It is easy for a dev to misinterpret this as the async work backing the future/stream hanging and they thus waste a lot of time trying to debug the async work. As such, we should require these two constructor arguments to make it impossible/much harder for devs to make this time-wasting mistake. This is a breaking change. However, it should break only a small number of active projects given that using a builder without specifying `future` or `stream` seems highly niche. The only place I've found non-accidental examples of this is in widget tests where you're calling `pumpWidget` with and without these arguments to test `*Builder.didUpdateWidget`'s behavior. In this and similar cases, it is a trivial fix to add `future: null`/`stream: null`. *If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/7d87410a51d5...024bf946232d 2023-05-02 skia-flutter-autoroll@skia.org Roll Skia from 38e56b6da8f9 to c9e0992be00b (3 revisions) (flutter/engine#41655) 2023-05-02 skia-flutter-autoroll@skia.org Roll Dart SDK from dc4a048e3cf7 to 25c29435f73e (1 revision) (flutter/engine#41654) 2023-05-01 flar@google.com [Impeller] take advantage of DisplayList culling (flutter/engine#41606) 2023-05-01 godofredoc@google.com Use os_dimension in framework tests. (flutter/engine#41649) 2023-05-01 58529443+srujzs@users.noreply.github.com Turn @staticInterop tear-off into closure (flutter/engine#41643) 2023-05-01 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from SJOgKviZ-kwWd1Z1u... to ur2ymZJCZSj64s6Q2... (flutter/engine#41648) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from SJOgKviZ-kwW to ur2ymZJCZSj6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
