1. 11 Jun, 2018 1 commit
    • Greg Spencer's avatar
      Update typedef syntax to use Function notation and turn on lint for old notation. (#18362) · 6c56bb24
      Greg Spencer authored
      Now that Dart 1 is turned off, reapplying my change to turn on the prefer_generic_function_type_aliases analysis option, and fix all the typedefs to Dart 2 preferred syntax.
      
      Also eliminated the unused analysis_options_repo.yaml file and turned on public_member_api_docs in analysys_options.yaml.
      
      No logic changes, just changing the typedef syntax for all typedefs, and updating analysis options.
      6c56bb24
  2. 09 Jun, 2018 2 commits
  3. 08 Jun, 2018 3 commits
    • Chris Bracken's avatar
      It's time to #deleteDart1 (again) (#18316) · 3daebd05
      Chris Bracken authored
      * It's time to #deleteDart1 (#18293)
      
      Eliminates support for Dart 1 in flutter_tools, and drops our Dart 1
      benchmarks. All commands now run in Dart 1 mode only.
      
      Eliminates --preview-dart-2 / --no-preview-dart-2 support.
      
      * Fix indentation, remove no longer necessary .toList()
      
      * Only push udpated kernel if >0 invalidated srcs
      3daebd05
    • Chris Bracken's avatar
      Revert "It's time to #deleteDart1 (#18293)" (#18313) · 9495df4b
      Chris Bracken authored
      Several benchmarks started failing during kernel compile:
      1. Timeouts:
         * commands_test
         * hot_mode_dev_cycle__benchmark
         * run_machine_concurrent_hot_reload
         * service_extensions_test
      
      2. Kernel compiler crash:
         * hot_mode_dev_cycle_linux__benchmark
         * routing_test
      
      3. Unexpected termination:
         * hot_mode_dev_cycle_win__benchmark
      
      This reverts commit ed63e708.
      9495df4b
    • Chris Bracken's avatar
      It's time to #deleteDart1 (#18293) · ed63e708
      Chris Bracken authored
      Eliminates support for Dart 1 in flutter_tools, and drops our Dart 1
      benchmarks. All commands now run in Dart 1 mode only.
      
      Eliminates --preview-dart-2 / --no-preview-dart-2 support.
      ed63e708
  4. 05 Jun, 2018 2 commits
  5. 04 Jun, 2018 2 commits
  6. 30 May, 2018 2 commits
  7. 14 May, 2018 1 commit
  8. 11 May, 2018 1 commit
    • Chris Bracken's avatar
      Update a TODO with issue number (#17494) · f685568d
      Chris Bracken authored
      Further digging revealed that the reason --no-sim-use-hardfp was
      required to be specified explicitly was that Android engine gen_snapshot
      binaries are built on Windows with target_os=win.
      f685568d
  9. 10 May, 2018 1 commit
    • Chris Bracken's avatar
      Explicitly specify softfp ABI for armv7 builds (#17453) · 28e644e8
      Chris Bracken authored
      This reverts #17147, which was safe under the assumption that
      getArtifactPath() returns a platform-specific gen_snapshot instance
      (which have the correct default set for this flag) -- it turns out that
      though we pass the platform to getArtifactPath(), we always return the
      host gen_snapshot for Android.
      
      A followup patch will update getArtifactPath and revert this patch.
      28e644e8
  10. 09 May, 2018 3 commits
    • Chris Bracken's avatar
      Correct profile-mode AOT snapshot flags (#17435) · 1c27a458
      Chris Bracken authored
      Previously, in non-release (i.e. profile) AOT builds, we were setting
      --no-checked and --conditional_directives flags. --no-checked is the
      default, and we don't make use of conditional directives in Flutter.
      1c27a458
    • Chris Bracken's avatar
      Add pathFilter to Fingerprinter (#17412) · e4f55332
      Chris Bracken authored
      Allows users of Fingerprinter to filter the set of paths collected from
      the explicitly-specified paths and those collected from depfiles.
      
      In some cases, depfiles are emitted with files that are not present on
      the local disk (e.g. the frontend compiler currently emits buildbot
      paths for the dart core libraries and dart:ui). These files will not
      materially affect whether we need to re-run a build action for which
      they are inputs, since they're not present in the filesystem and
      therefore cannot change.
      e4f55332
    • Chris Bracken's avatar
      Replace --prefer-shared-library with --build-shared-library (#17394) · 8b8d368d
      Chris Bracken authored
      This replaces the --prefer-shared-library flag, which falls back to
      regular (non-shared-lib) compile if the NDK is not found, with the
      --build-shared-library flag, which exits with an error message if the
      NDK is not found.
      
      This simplifies the set of allowed code paths through AOT compile,
      resulting in better testability and easier-to-follow logic. It also
      results in more predictable behaviour for continuous integration and
      other scenarios.
      8b8d368d
  11. 08 May, 2018 1 commit
  12. 07 May, 2018 1 commit
    • Chris Bracken's avatar
      Support multi-arch iOS binaries (#17312) · 849676fc
      Chris Bracken authored
      This change adds support for armv7, arm64, and universal iOS apps.
      
      This change eliminates iOS target architecture hardcoding (previously
      arm64 only) and uses the target architecture(s) specified in Xcode's
      ARCHS setting ('Architectures' in Xcode Build Settings).
      
      For universal binaries, set ARCHS to its default value, $(ARCHS_STANDARD).
      
      Note that after changing the architecture in Xcode, developers should
      run 'pod install' from the ios subdirectory of their project. A separate
      change (that will land before this one) will add support for
      automatically detecting project file and Podfile changes and re-running
      pod install if necessary.
      
      This change also adds an --ios-arch option to flutter build aot. In iOS
      AOT builds (in profile and release mode), this dictates which
      architectures are built into App.framework. This flag should generally
      be unnecessary to set manually since flutter build aot is typically only
      invoked internally by flutter itself.
      849676fc
  13. 04 May, 2018 3 commits
    • Todd Volkert's avatar
      Use deprecated io constants (#17278) · d820e5f3
      Todd Volkert authored
      The new values are not ready for use yet inside Google
      d820e5f3
    • Yegor's avatar
      Roll engine to e976be13c51448f89107d082ec81e2b6731671fa (#17266) · b2c98f9a
      Yegor authored
      * Roll engine to e976be13c51448f89107d082ec81e2b6731671fa
      
      * move away from deprecated constants
      b2c98f9a
    • Chris Bracken's avatar
      Add Fingerprinter class (#17255) · 66c7b6a9
      Chris Bracken authored
      Adds a Fingerprinter utility class that can be used to compute unique
      fingerprints for a set of input paths and build options, compare to the
      output of a previous run, and skip the build action if no inputs or
      options have changed. The existing Fingerprint class still does all the
      heavy lifting. Fingerprinter adds common operations such as
      reading/writing/comparing fingerprints and parsing depfiles.
      
      This migrates existing uses of Fingerprint over to Fingerprinter.
      
      This also adds better fingerprinting to AOT snapshotting, which
      previously failed to include several options in its fingerprint
      (--preview-dart-2, --prefer-shared-library).
      66c7b6a9
  14. 02 May, 2018 1 commit
  15. 01 May, 2018 8 commits
  16. 30 Apr, 2018 2 commits
  17. 29 Apr, 2018 1 commit
    • Chris Bracken's avatar
      Extract kernel compile from buildAotSnapshot (#17062) · cdbb2385
      Chris Bracken authored
      Moves the kernel compile step to the beginning of the AOT build in a
      separate method. This is pre-factoring for iOS universal builds where
      the kernel build happens once, but we then snapshot twice: once for
      armv7 and once for arm64.
      
      This also writes dependencies to build/kernel_compile.d rather than
      build/aot/snapshot.d, since that is immediately overwritten by
      gen_snapshot.
      cdbb2385
  18. 27 Apr, 2018 3 commits
    • Chris Bracken's avatar
      Eliminate unnecessary buildAotSnapshot parameter (#17056) · fe0de001
      Chris Bracken authored
      This isn't user-specifiable through a flag, so no need to pass it as a
      parameter.
      fe0de001
    • Chris Bracken's avatar
      Improve AOT build fingerprinting (#17053) · 549acac6
      Chris Bracken authored
      This is a simple refactoring with no functional changes. We now reuse
      the existing _isBuildRequired() and _writeFingerprint() functions and
      share them with script snapshotting rather than reimplementing their
      logic.
      
      Changes the signatures of both to support multiple output files (as
      required for AOT snapshotting).
      549acac6
    • Chris Bracken's avatar
      Eliminate build aot --interpreter flag (#17025) (#17033) · ebcd08c6
      Chris Bracken authored
      This is required for iOS debug builds, but unused otherwise. In theory,
      Android debug builds could be run in this mode, but this is historically
      untested and adds unnecessary complexity to the code. If ad-hoc testing
      is required, it can be patched in when necessary.
      
      This re-lands 8c4f0c0d with a fix to
      xcode_backend.sh to eliminate the use of --interpreter.
      ebcd08c6
  19. 26 Apr, 2018 2 commits