• Taha Tesser's avatar
    Fix `TimePicker` defaults for `hourMinuteTextStyle` and `dayPeriodTextColor`... · 7d89617a
    Taha Tesser authored
    Fix `TimePicker` defaults for `hourMinuteTextStyle` and `dayPeriodTextColor` for Material 3 (#131253)
    
    fixes [`TimePicker` color and visual issues](https://github.com/flutter/flutter/issues/127035)
    
    ## Description
    
    - fixes default text style for `TimePicker`s  `hourMinuteTextStyle` and added a todo for https://github.com/flutter/flutter/issues/131247
    - fixes correct default color not being accessed for  `dayPeriodTextColor`
    -  Updates tests
    
    ### Code sample
    
    <details> 
    <summary>expand to view the code sample</summary> 
    
    ```dart
    import 'package:flutter/material.dart';
    
    void main() => runApp(const MyApp());
    
    class MyApp extends StatelessWidget {
      const MyApp({super.key});
    
      @override
      Widget build(BuildContext context) {
        return MaterialApp(
          debugShowCheckedModeBanner: false,
          theme: ThemeData(useMaterial3: true),
          home: const Example(),
        );
      }
    }
    
    class Example extends StatelessWidget {
      const Example({super.key});
    
      @override
      Widget build(BuildContext context) {
        return Scaffold(
          appBar: AppBar(
            title: const Text('Sample'),
          ),
          body: Center(
            child: ElevatedButton(
              onPressed: () {
                showTimePicker(
                  context: context,
                  orientation: Orientation.portrait,
                  initialEntryMode: TimePickerEntryMode.input,
                  initialTime: TimeOfDay.now(),
                  builder: (BuildContext context, Widget? child) {
                    return MediaQuery(
                      data: MediaQuery.of(context)
                          .copyWith(alwaysUse24HourFormat: true),
                      child: child!,
                    );
                  },
                );
              },
              child: const Text('Open Time Picker'),
            ),
          ),
        );
      }
    }
    
    ``` 
    	
    </details>
    
    ### Before
    
    ![ezgif com-video-to-gif](https://github.com/flutter/flutter/assets/48603081/b791501f-aed3-44f3-8f75-70a1e28038c6)
    
    ### After
    
    ![ezgif com-video-to-gif (1)](https://github.com/flutter/flutter/assets/48603081/1bb32064-a9b1-416d-8290-7d22b0d4fdb9)
    7d89617a
Name
Last commit
Last update
..
automated_tests Loading commit data...
benchmarks Loading commit data...
bots Loading commit data...
ci Loading commit data...
conductor Loading commit data...
customer_testing Loading commit data...
devicelab Loading commit data...
docs Loading commit data...
forbidden_from_release_tests Loading commit data...
integration_tests Loading commit data...
manual_tests Loading commit data...
missing_dependency_tests Loading commit data...
snippets/config Loading commit data...
tools Loading commit data...
tracing_tests Loading commit data...
README.md Loading commit data...
analysis_options.yaml Loading commit data...