• Chris Bracken's avatar
    [Windows] Fix signed/unsigned int comparison (#142341) · 9f8fe3f0
    Chris Bracken authored
    Previously, we were comparing the signed int `target_length` (returned by WideCharToMultiByte) to a size_t string length, resulting in a signed/unsigned comparison warning as follows:
    
    ```
    windows\runner\utils.cpp(54,43): warning C4018:  '>': signed/unsigned mismatch
    ```
    
    WideCharToMultiByte returns:
    * 0 on error
    * the number of bytes written to the buffer pointed to by its fifth parameter, lpMultiByteStr, on success.
    
    As a result it's safe to store the return value in an unsigned int, which eliminates the warning.
    
    No changes to tests since this is dependent on end-user project settings/modifications and does not trigger a warning with default project settings.
    
    Fixes: https://github.com/flutter/flutter/issues/134227
    9f8fe3f0
Name
Last commit
Last update
..
abstract_method_smoke_test Loading commit data...
android_custom_host_app Loading commit data...
android_embedding_v2_smoke_test Loading commit data...
android_host_app/.gradle Loading commit data...
android_host_app_v2_embedding Loading commit data...
android_module_host_with_custom_build_v2_embedding/app/src/main/java/io/flutter/addtoapp Loading commit data...
android_semantics_testing Loading commit data...
android_verified_input Loading commit data...
android_views Loading commit data...
channels Loading commit data...
deferred_components_test Loading commit data...
external_textures Loading commit data...
flavors Loading commit data...
flutter_gallery Loading commit data...
gradle_deprecated_settings Loading commit data...
hybrid_android_views Loading commit data...
ios_add2app_life_cycle Loading commit data...
ios_app_with_extensions Loading commit data...
ios_host_app Loading commit data...
ios_host_app_swift Loading commit data...
ios_platform_view_tests Loading commit data...
module_host_with_custom_build/.gradle Loading commit data...
module_host_with_custom_build_v2_embedding Loading commit data...
non_nullable Loading commit data...
platform_interaction Loading commit data...
release_smoke_test Loading commit data...
spell_check Loading commit data...
ui Loading commit data...
web Loading commit data...
web_compile_tests Loading commit data...
web_e2e_tests Loading commit data...
wide_gamut_test Loading commit data...
windows_startup_test Loading commit data...
README.md Loading commit data...