• Chris Bracken's avatar
    [Windows] Fix signed/unsigned int comparison (#142341) · 9f8fe3f0
    Chris Bracken authored
    Previously, we were comparing the signed int `target_length` (returned by WideCharToMultiByte) to a size_t string length, resulting in a signed/unsigned comparison warning as follows:
    
    ```
    windows\runner\utils.cpp(54,43): warning C4018:  '>': signed/unsigned mismatch
    ```
    
    WideCharToMultiByte returns:
    * 0 on error
    * the number of bytes written to the buffer pointed to by its fifth parameter, lpMultiByteStr, on success.
    
    As a result it's safe to store the return value in an unsigned int, which eliminates the warning.
    
    No changes to tests since this is dependent on end-user project settings/modifications and does not trigger a warning with default project settings.
    
    Fixes: https://github.com/flutter/flutter/issues/134227
    9f8fe3f0
Name
Last commit
Last update
.github Loading commit data...
.vscode Loading commit data...
bin Loading commit data...
dev Loading commit data...
examples Loading commit data...
packages Loading commit data...
.ci.yaml Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
AUTHORS Loading commit data...
CODEOWNERS Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
CONTRIBUTING.md Loading commit data...
LICENSE Loading commit data...
PATENT_GRANT Loading commit data...
README.md Loading commit data...
TESTOWNERS Loading commit data...
analysis_options.yaml Loading commit data...
dartdoc_options.yaml Loading commit data...
flutter_console.bat Loading commit data...