• auto-submit[bot]'s avatar
    Reverts "Refactor `external_ui` → `external_textures`" (#142173) · 54e9f2db
    auto-submit[bot] authored
    Reverts flutter/flutter#142062
    Initiated by: eliasyishak
    This change reverts the following previous change:
    Original Description:
    This PR makes no _behavioral_ changes to executed code, and instead focuses on organization and naming:
    
    1. Almost[^1] anything named `external_ui` is renamed `external_textures`
    1. Extended the README to explain the intent of the test, as well as how to run it
    1. Renamed `main.dart` and `main_test.dart` to `frame_rate_main.dart` and `frame_rate_test.dart` (we'll add more)
    1. Did some refactoring of the test to make it more obvious what is being asserted (i.e. `widgetBuilds` and friends)
    
    Given how complex (and in-flux) this directory is, I'm also requesting either John, Jonah or I review any changes.
    
    [^1]: Except the name of the `.ci.yaml` task, i.e. `name: Linux_pixel_7pro external_ui_integration_test` because I'm apparently not able to change that without creating a new task as `bringup: true` and playing a bit of a dance. Maybe that's worth doing though (in future PRs)?
    54e9f2db
Name
Last commit
Last update
..
analyzer_benchmark.dart Loading commit data...
android_choreographer_do_frame_test.dart Loading commit data...
android_defines_test.dart Loading commit data...
android_lifecycles_test.dart Loading commit data...
android_obfuscate_test.dart Loading commit data...
android_picture_cache_complexity_scoring_perf__timeline_summary.dart Loading commit data...
android_semantics_integration_test.dart Loading commit data...
android_stack_size_test.dart Loading commit data...
android_verified_input_test.dart Loading commit data...
android_view_scroll_perf__timeline_summary.dart Loading commit data...
animated_advanced_blend_perf__timeline_summary.dart Loading commit data...
animated_advanced_blend_perf_ios__timeline_summary.dart Loading commit data...
animated_advanced_blend_perf_opengles__timeline_summary.dart Loading commit data...
animated_blur_backdrop_filter_perf__timeline_summary.dart Loading commit data...
animated_blur_backdrop_filter_perf_ios__timeline_summary.dart Loading commit data...
animated_blur_backdrop_filter_perf_opengles__timeline_summary.dart Loading commit data...
animated_complex_image_filtered_perf__e2e_summary.dart Loading commit data...
animated_complex_opacity_perf__e2e_summary.dart Loading commit data...
animated_complex_opacity_perf_ios__e2e_summary.dart Loading commit data...
animated_complex_opacity_perf_macos__e2e_summary.dart Loading commit data...
animated_image_gc_perf.dart Loading commit data...
animated_placeholder_perf__e2e_summary.dart Loading commit data...
animation_with_microtasks_perf_ios__timeline_summary.dart Loading commit data...
backdrop_filter_perf__e2e_summary.dart Loading commit data...
backdrop_filter_perf__timeline_summary.dart Loading commit data...
backdrop_filter_perf_ios__timeline_summary.dart Loading commit data...
basic_material_app_android__compile.dart Loading commit data...
basic_material_app_ios__compile.dart Loading commit data...
basic_material_app_macos__compile.dart Loading commit data...
basic_material_app_win__compile.dart Loading commit data...
build_aar_module_test.dart Loading commit data...
build_ios_framework_module_test.dart Loading commit data...
channels_integration_test.dart Loading commit data...
channels_integration_test_ios.dart Loading commit data...
channels_integration_test_macos.dart Loading commit data...
channels_integration_test_win.dart Loading commit data...
clipper_cache_perf__e2e_summary.dart Loading commit data...
color_filter_and_fade_perf__e2e_summary.dart Loading commit data...
color_filter_and_fade_perf__timeline_summary.dart Loading commit data...
color_filter_and_fade_perf_ios__e2e_summary.dart Loading commit data...
color_filter_cache_perf__e2e_summary.dart Loading commit data...
color_filter_with_unstable_child_perf__e2e_summary.dart Loading commit data...
complex_layout__start_up.dart Loading commit data...
complex_layout_android__scroll_smoothness.dart Loading commit data...
complex_layout_ios__start_up.dart Loading commit data...
complex_layout_macos__start_up.dart Loading commit data...
complex_layout_scroll_perf__devtools_memory.dart Loading commit data...
complex_layout_scroll_perf__memory.dart Loading commit data...
complex_layout_scroll_perf__timeline_summary.dart Loading commit data...
complex_layout_scroll_perf_bad_ios__timeline_summary.dart Loading commit data...
complex_layout_scroll_perf_impeller__timeline_summary.dart Loading commit data...
complex_layout_scroll_perf_impeller_gles__timeline_summary.dart Loading commit data...
complex_layout_scroll_perf_ios__timeline_summary.dart Loading commit data...
complex_layout_scroll_perf_macos__timeline_summary.dart Loading commit data...
complex_layout_semantics_perf.dart Loading commit data...
complex_layout_win_desktop__start_up.dart Loading commit data...
cubic_bezier_perf__e2e_summary.dart Loading commit data...
cubic_bezier_perf__timeline_summary.dart Loading commit data...
cull_opacity_perf__e2e_summary.dart Loading commit data...
cull_opacity_perf__timeline_summary.dart Loading commit data...
dart_plugin_registry_test.dart Loading commit data...
devtools_profile_start_test.dart Loading commit data...
draw_atlas_perf__timeline_summary.dart Loading commit data...
draw_atlas_perf_ios__timeline_summary.dart Loading commit data...
draw_atlas_perf_opengles__timeline_summary.dart Loading commit data...
draw_points_perf_ios__timeline_summary.dart Loading commit data...
draw_vertices_perf__timeline_summary.dart Loading commit data...
draw_vertices_perf_ios__timeline_summary.dart Loading commit data...
draw_vertices_perf_opengles__timeline_summary.dart Loading commit data...
drive_perf_debug_warning.dart Loading commit data...
dynamic_path_tessellation_perf__timeline_summary.dart Loading commit data...
dynamic_path_tessellation_perf_ios__timeline_summary.dart Loading commit data...
embedded_android_views_integration_test.dart Loading commit data...
engine_dependency_proxy_test.dart Loading commit data...
entrypoint_dart_registrant.dart Loading commit data...
external_ui_integration_test.dart Loading commit data...
external_ui_integration_test_ios.dart Loading commit data...
fading_child_animation_perf__timeline_summary.dart Loading commit data...
fast_scroll_heavy_gridview__memory.dart Loading commit data...
fast_scroll_large_images__memory.dart Loading commit data...
flavors_test.dart Loading commit data...
flavors_test_ios.dart Loading commit data...
flavors_test_ios_xcode_debug.dart Loading commit data...
flavors_test_macos.dart Loading commit data...
flutter_engine_group_performance.dart Loading commit data...
flutter_gallery__back_button_memory.dart Loading commit data...
flutter_gallery__image_cache_memory.dart Loading commit data...
flutter_gallery__memory_nav.dart Loading commit data...
flutter_gallery__start_up.dart Loading commit data...
flutter_gallery__start_up_delayed.dart Loading commit data...
flutter_gallery__transition_perf.dart Loading commit data...
flutter_gallery__transition_perf_e2e.dart Loading commit data...
flutter_gallery__transition_perf_e2e_ios.dart Loading commit data...
flutter_gallery__transition_perf_hybrid.dart Loading commit data...
flutter_gallery__transition_perf_with_semantics.dart Loading commit data...
flutter_gallery_android__compile.dart Loading commit data...
flutter_gallery_ios__compile.dart Loading commit data...
flutter_gallery_ios__start_up.dart Loading commit data...
flutter_gallery_ios__start_up_xcode_debug.dart Loading commit data...
flutter_gallery_macos__compile.dart Loading commit data...
flutter_gallery_macos__start_up.dart Loading commit data...
flutter_gallery_v2_chrome_run_test.dart Loading commit data...
flutter_gallery_v2_web_compile_test.dart Loading commit data...
flutter_gallery_win__compile.dart Loading commit data...
flutter_gallery_win_desktop__compile.dart Loading commit data...
flutter_gallery_win_desktop__start_up.dart Loading commit data...
flutter_test_performance.dart Loading commit data...
flutter_tool_startup.dart Loading commit data...
flutter_view__start_up.dart Loading commit data...
flutter_view_ios__start_up.dart Loading commit data...
flutter_view_macos__start_up.dart Loading commit data...
flutter_view_win_desktop__start_up.dart Loading commit data...
frame_policy_delay_test_android.dart Loading commit data...
fullscreen_textfield_perf.dart Loading commit data...
fullscreen_textfield_perf__e2e_summary.dart Loading commit data...
fullscreen_textfield_perf__timeline_summary.dart Loading commit data...
fullscreen_textfield_perf_ios__e2e_summary.dart Loading commit data...
gradient_consistent_perf__e2e_summary.dart Loading commit data...
gradient_dynamic_perf__e2e_summary.dart Loading commit data...
gradient_static_perf__e2e_summary.dart Loading commit data...
gradle_desugar_classes_test.dart Loading commit data...
gradle_java8_compile_test.dart Loading commit data...
gradle_non_android_plugin_test.dart Loading commit data...
gradle_plugin_bundle_test.dart Loading commit data...
gradle_plugin_fat_apk_test.dart Loading commit data...
gradle_plugin_light_apk_test.dart Loading commit data...
hello_world__memory.dart Loading commit data...
hello_world_android__compile.dart Loading commit data...
hello_world_impeller.dart Loading commit data...
hello_world_ios__compile.dart Loading commit data...
hello_world_macos__compile.dart Loading commit data...
hello_world_win_desktop__compile.dart Loading commit data...
home_scroll_perf__timeline_summary.dart Loading commit data...
hot_mode_dev_cycle__benchmark.dart Loading commit data...
hot_mode_dev_cycle_ios__benchmark.dart Loading commit data...
hot_mode_dev_cycle_ios_simulator.dart Loading commit data...
hot_mode_dev_cycle_linux__benchmark.dart Loading commit data...
hot_mode_dev_cycle_linux_target__benchmark.dart Loading commit data...
hot_mode_dev_cycle_macos_target__benchmark.dart Loading commit data...
hot_mode_dev_cycle_win__benchmark.dart Loading commit data...
hot_mode_dev_cycle_win_target__benchmark.dart Loading commit data...
hybrid_android_views_integration_test.dart Loading commit data...
image_list_jit_reported_duration.dart Loading commit data...
image_list_reported_duration.dart Loading commit data...
imagefiltered_transform_animation_perf__timeline_summary.dart Loading commit data...
imagefiltered_transform_animation_perf_ios__timeline_summary.dart Loading commit data...
integration_test_test.dart Loading commit data...
integration_test_test_ios.dart Loading commit data...
integration_ui_driver.dart Loading commit data...
integration_ui_frame_number.dart Loading commit data...
integration_ui_ios_driver.dart Loading commit data...
integration_ui_ios_driver_xcode_debug.dart Loading commit data...
integration_ui_ios_frame_number.dart Loading commit data...
integration_ui_ios_keyboard_resize.dart Loading commit data...
integration_ui_ios_screenshot.dart Loading commit data...
integration_ui_ios_textfield.dart Loading commit data...
integration_ui_keyboard_resize.dart Loading commit data...
integration_ui_screenshot.dart Loading commit data...
integration_ui_test_test_macos.dart Loading commit data...
integration_ui_textfield.dart Loading commit data...
ios_app_with_extensions_test.dart Loading commit data...
ios_content_validation_test.dart Loading commit data...
ios_defines_test.dart Loading commit data...
ios_platform_view_tests.dart Loading commit data...
large_image_changer_perf_android.dart Loading commit data...
large_image_changer_perf_ios.dart Loading commit data...
linux_chrome_dev_mode.dart Loading commit data...
list_text_layout_impeller_perf__e2e_summary.dart Loading commit data...
list_text_layout_perf__e2e_summary.dart Loading commit data...
macos_chrome_dev_mode.dart Loading commit data...
microbenchmarks.dart Loading commit data...
microbenchmarks_ios.dart Loading commit data...
microbenchmarks_ios_xcode_debug.dart Loading commit data...
module_custom_host_app_name_test.dart Loading commit data...
module_host_with_custom_build_test.dart Loading commit data...
module_test.dart Loading commit data...
module_test_ios.dart Loading commit data...
multi_widget_construction_perf__e2e_summary.dart Loading commit data...
native_assets_android.dart Loading commit data...
native_assets_ios.dart Loading commit data...
native_assets_ios_simulator.dart Loading commit data...
native_platform_view_ui_tests_ios.dart Loading commit data...
native_ui_tests_macos.dart Loading commit data...
new_gallery__crane_perf.dart Loading commit data...
new_gallery__transition_perf.dart Loading commit data...
new_gallery_impeller__transition_perf.dart Loading commit data...
new_gallery_impeller_old_zoom__transition_perf.dart Loading commit data...
new_gallery_ios__transition_perf.dart Loading commit data...
new_gallery_opengles_impeller__transition_perf.dart Loading commit data...
new_gallery_skia_ios__transition_perf.dart Loading commit data...
old_gallery__transition_perf.dart Loading commit data...
opacity_peephole_col_of_alpha_savelayer_rows_perf__e2e_summary.dart Loading commit data...
opacity_peephole_col_of_rows_perf__e2e_summary.dart Loading commit data...
opacity_peephole_fade_transition_text_perf__e2e_summary.dart Loading commit data...
opacity_peephole_grid_of_alpha_savelayers_perf__e2e_summary.dart Loading commit data...
opacity_peephole_grid_of_opacity_perf__e2e_summary.dart Loading commit data...
opacity_peephole_one_rect_perf__e2e_summary.dart Loading commit data...
opacity_peephole_opacity_of_grid_perf__e2e_summary.dart Loading commit data...
openpay_benchmarks__scroll_perf.dart Loading commit data...
picture_cache_perf__e2e_summary.dart Loading commit data...
picture_cache_perf__timeline_summary.dart Loading commit data...
platform_channel_sample_test.dart Loading commit data...
platform_channel_sample_test_ios.dart Loading commit data...
platform_channel_sample_test_macos.dart Loading commit data...
platform_channel_sample_test_swift.dart Loading commit data...
platform_channel_sample_test_windows.dart Loading commit data...
platform_channels_benchmarks.dart Loading commit data...
platform_channels_benchmarks_ios.dart Loading commit data...
platform_interaction_test.dart Loading commit data...
platform_interaction_test_ios.dart Loading commit data...
platform_view__start_up.dart Loading commit data...
platform_view_ios__start_up.dart Loading commit data...
platform_view_macos__start_up.dart Loading commit data...
platform_view_win_desktop__start_up.dart Loading commit data...
platform_views_scroll_perf__timeline_summary.dart Loading commit data...
platform_views_scroll_perf_impeller__timeline_summary.dart Loading commit data...
platform_views_scroll_perf_ios__timeline_summary.dart Loading commit data...
platform_views_scroll_perf_non_intersecting_impeller_ios__timeline_summary.dart Loading commit data...
plugin_dependencies_test.dart Loading commit data...
plugin_lint_mac.dart Loading commit data...
plugin_test.dart Loading commit data...
plugin_test_ios.dart Loading commit data...
plugin_test_linux.dart Loading commit data...
plugin_test_macos.dart Loading commit data...
plugin_test_windows.dart Loading commit data...
post_backdrop_filter_perf_ios__timeline_summary.dart Loading commit data...
raster_cache_use_memory_perf__e2e_summary.dart Loading commit data...
route_test_ios.dart Loading commit data...
routing_test.dart Loading commit data...
run_debug_test_android.dart Loading commit data...
run_debug_test_linux.dart Loading commit data...
run_debug_test_macos.dart Loading commit data...
run_debug_test_windows.dart Loading commit data...
run_release_test.dart Loading commit data...
run_release_test_linux.dart Loading commit data...
run_release_test_macos.dart Loading commit data...
run_release_test_windows.dart Loading commit data...
service_extensions_test.dart Loading commit data...
shader_mask_cache_perf__e2e_summary.dart Loading commit data...
simple_animation_perf_ios.dart Loading commit data...
slider_perf_android.dart Loading commit data...
smoke_test_build_test.dart Loading commit data...
smoke_test_device.dart Loading commit data...
smoke_test_failure.dart Loading commit data...
smoke_test_setup_failure.dart Loading commit data...
smoke_test_success.dart Loading commit data...
smoke_test_throws.dart Loading commit data...
spell_check_test.dart Loading commit data...
spell_check_test_ios.dart Loading commit data...
static_path_tessellation_perf__timeline_summary.dart Loading commit data...
static_path_tessellation_perf_ios__timeline_summary.dart Loading commit data...
technical_debt__cost.dart Loading commit data...
textfield_perf__e2e_summary.dart Loading commit data...
textfield_perf__timeline_summary.dart Loading commit data...
tiles_scroll_perf__timeline_summary.dart Loading commit data...
tiles_scroll_perf_ios__timeline_summary.dart Loading commit data...
very_long_picture_scrolling_perf__e2e_summary.dart Loading commit data...
very_long_picture_scrolling_perf_ios__e2e_summary.dart Loading commit data...
web_benchmarks_canvaskit.dart Loading commit data...
web_benchmarks_html.dart Loading commit data...
web_benchmarks_skwasm.dart Loading commit data...
web_size__compile_test.dart Loading commit data...
wide_gamut_ios.dart Loading commit data...
windows_chrome_dev_mode.dart Loading commit data...
windows_home_scroll_perf__timeline_summary.dart Loading commit data...
windows_startup_test.dart Loading commit data...