- 24 Jan, 2024 27 commits
-
-
auto-submit[bot] authored
Reverts flutter/flutter#142062 Initiated by: eliasyishak This change reverts the following previous change: Original Description: This PR makes no _behavioral_ changes to executed code, and instead focuses on organization and naming: 1. Almost[^1] anything named `external_ui` is renamed `external_textures` 1. Extended the README to explain the intent of the test, as well as how to run it 1. Renamed `main.dart` and `main_test.dart` to `frame_rate_main.dart` and `frame_rate_test.dart` (we'll add more) 1. Did some refactoring of the test to make it more obvious what is being asserted (i.e. `widgetBuilds` and friends) Given how complex (and in-flux) this directory is, I'm also requesting either John, Jonah or I review any changes. [^1]: Except the name of the `.ci.yaml` task, i.e. `name: Linux_pixel_7pro external_ui_integration_test` because I'm apparently not able to change that without creating a new task as `bringup: true` and playing a bit of a dance. Maybe that's worth doing though (in future PRs)?
-
Matan Lurey authored
This PR makes no _behavioral_ changes to executed code, and instead focuses on organization and naming: 1. Almost[^1] anything named `external_ui` is renamed `external_textures` 1. Extended the README to explain the intent of the test, as well as how to run it 1. Renamed `main.dart` and `main_test.dart` to `frame_rate_main.dart` and `frame_rate_test.dart` (we'll add more) 1. Did some refactoring of the test to make it more obvious what is being asserted (i.e. `widgetBuilds` and friends) Given how complex (and in-flux) this directory is, I'm also requesting either John, Jonah or I review any changes. [^1]: Except the name of the `.ci.yaml` task, i.e. `name: Linux_pixel_7pro external_ui_integration_test` because I'm apparently not able to change that without creating a new task as `bringup: true` and playing a bit of a dance. Maybe that's worth doing though (in future PRs)?
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/0b9fce355df9...4bc368ee5f74 2024-01-24 jonahwilliams@google.com [Impeller] use const std::unique_ptr ref for Sampler type. (flutter/engine#49974) 2024-01-24 skia-flutter-autoroll@skia.org Roll Skia from c353c00a4dcb to 9ea7cb490804 (1 revision) (flutter/engine#50005) 2024-01-24 mbrase@google.com Replace Fuchsia logging macros (FX_LOG*) with FML logging (flutter/engine#49970) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
hangyu authored
fixes: https://github.com/flutter/flutter/issues/141997
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/b65556fa543e...0b9fce355df9 2024-01-24 skia-flutter-autoroll@skia.org Roll Skia from 26ac196b95c4 to c353c00a4dcb (1 revision) (flutter/engine#50004) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Flutter GitHub Bot authored
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY. { "name": "Mac_arm64 build_tests_2_4" } --> The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Mac_arm64%20build_tests_2_4%22). This test can be marked as unflaky.
-
Flutter GitHub Bot authored
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY. { "name": "Mac_x64 build_tests_2_4" } --> The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Mac_x64%20build_tests_2_4%22). This test can be marked as unflaky.
-
Flutter GitHub Bot authored
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY. { "name": "Mac_x64 build_tests_1_4" } --> The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Mac_x64%20build_tests_1_4%22). This test can be marked as unflaky.
-
Flutter GitHub Bot authored
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY. { "name": "Mac_x64 build_tests_3_4" } --> The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Mac_x64%20build_tests_3_4%22). This test can be marked as unflaky.
-
Greg Price authored
Much of the new wording here is borrowed from [ChipTheme], [SliderTheme], or [RadioThemeData], which I think are pretty good. I believe a lot of other theme classes have similar wording too. I've also made some tweaks of my own, notably the references to [MaterialApp.theme]. This started from a desire to have clearer cross-references pointing at what to do with a FooThemeData to make it take effect: https://github.com/flutter/flutter/pull/135879#discussion_r1355851481 but then as I started writing I kept finding more and more small things I wanted to adjust, including a couple of bits that were extraneous or obsolete.
-
godofredoc authored
This is part of the process to start running tests on either arm64 or x64 if the host architecture is not important for the test.
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/ba3a70ce7722...b65556fa543e 2024-01-24 skia-flutter-autoroll@skia.org Roll Dart SDK from 8307fb417cb9 to 0f7c49da26da (1 revision) (flutter/engine#50001) 2024-01-24 skia-flutter-autoroll@skia.org Roll Skia from 6556502887bf to 26ac196b95c4 (1 revision) (flutter/engine#50000) 2024-01-24 skia-flutter-autoroll@skia.org Roll Dart SDK from 8115d045c95d to 8307fb417cb9 (1 revision) (flutter/engine#49999) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
LongCatIsLooong authored
Fixes #138773, port autocomplete to OverlayPortal
-
Jesús S Guerrero authored
Revert "[web] - Fix broken `TextField` in semantics mode when it's a sibling of `Navigator`" (#142129) Reverts flutter/flutter#138446 b/322136071
-
Flutter GitHub Bot authored
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY. { "name": "Mac_arm64 build_tests_1_4" } --> The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Mac_arm64%20build_tests_1_4%22). This test can be marked as unflaky.
-
engine-flutter-autoroll authored
https://github.com/flutter/packages/compare/841fe901fe2b...8fbdf65d0235 2024-01-23 stuartmorgan@google.com [webview_flutter] Use a local web server for legacy web integration tests (flutter/packages#5956) 2024-01-23 engine-flutter-autoroll@skia.org Roll Flutter from 3ee8ff28 to 5b673c28 (28 revisions) (flutter/packages#5965) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Flutter GitHub Bot authored
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY. { "name": "Mac_arm64 build_tests_3_4" } --> The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Mac_arm64%20build_tests_3_4%22). This test can be marked as unflaky.
-
Flutter GitHub Bot authored
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY. { "name": "Mac_x64 build_tests_4_4" } --> The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Mac_x64%20build_tests_4_4%22). This test can be marked as unflaky.
-
Flutter GitHub Bot authored
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY. { "name": "Mac_arm64 build_tests_4_4" } --> The test has been passing for [50 consecutive runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Mac_arm64%20build_tests_4_4%22). This test can be marked as unflaky.
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/7c592dbfa032...ba3a70ce7722 2024-01-24 skia-flutter-autoroll@skia.org Roll Dart SDK from 69af2ca8332f to 8115d045c95d (1 revision) (flutter/engine#49998) 2024-01-24 skia-flutter-autoroll@skia.org Roll Skia from 1af4f1216478 to 6556502887bf (1 revision) (flutter/engine#49997) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/700235c85d4a...7c592dbfa032 2024-01-24 matanlurey@users.noreply.github.com Fix a typo in `geometry.cc#ComputeUVGeometryForRect`. (flutter/engine#49986) 2024-01-24 skia-flutter-autoroll@skia.org Roll Skia from be4b398b4f2e to 1af4f1216478 (1 revision) (flutter/engine#49993) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/da96f9de3f69...700235c85d4a 2024-01-24 skia-flutter-autoroll@skia.org Roll Dart SDK from 838cd732e56a to 69af2ca8332f (1 revision) (flutter/engine#49990) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/220416cfa6ca...da96f9de3f69 2024-01-24 skia-flutter-autoroll@skia.org Roll Skia from c396b2171b16 to be4b398b4f2e (2 revisions) (flutter/engine#49988) 2024-01-24 skia-flutter-autoroll@skia.org Roll Dart SDK from 5646ac9669f8 to 838cd732e56a (3 revisions) (flutter/engine#49982) 2024-01-24 jonahwilliams@google.com [ui] hold a strong reference to fragment program objects. (flutter/engine#49868) 2024-01-23 skia-flutter-autoroll@skia.org Roll Skia from 4e42423c7f6f to c396b2171b16 (1 revision) (flutter/engine#49987) 2024-01-23 skia-flutter-autoroll@skia.org Roll Skia from e7d10257ffb5 to 4e42423c7f6f (4 revisions) (flutter/engine#49985) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
yim authored
Fixes #141448
-
Polina Cherkasova authored
-
Xilai Zhang authored
This should finally (with high confidence) fix https://github.com/flutter/flutter/issues/141980, the mysterious error where git push sometimes fail. **Root cause**: When a pull request merges onto flutter's master branch, it is actually a merge from a branch on a flutter contributor's repository, to flutter's repository. Therefore, the [actor](https://stackoverflow.com/questions/58737785/github-actions-empty-env-secrets) of the pull request event, is the user that opened the pull request. And this actor would not have write access to repo and therefore the repo secret resolves to empty. Therefore [running your pull_request workflow when a pull request merges](https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#running-your-pull_request-workflow-when-a-pull-request-merges) doesn't work because even though we are not running our workflows on a forked repository, the **actor** of the pull_request event comes from a forked repository, and secrets are not passed to this actor. The correct way is using [pull_request_target](https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#pull_request_target) event instead of pull_request event. In workflows triggered by this event, GITHUB_TOKEN is granted read/write repository permission unless the permissions key is specified and the workflow **can** access secrets, even when the actor of the workflow trigger comes from a fork. Note that workflows of this event runs in the context of the base commit and not the merge commit. But this doesn't matter for our use case since we are good with using the actions file from the base commit in the pull request event. **Tested**: I was finally able to reproduce the error by: 1. create a pull request under the username of different user other than the repository owner 2. merge and label the pull request, and use the token of this different user, but use it as repository secrets in the workflow [reproduced error](https://github.com/XilaiZhang/miscellaneous-side-project/actions/runs/7619699924/job/20753210562) previously I wasn't able to reproduce this error on my personal repo because the actors in my tests are the same user. Also tested on my personal repo, following the steps mentioned above, that using the pull_request_event type fixes the error. [succeeded run](https://github.com/XilaiZhang/miscellaneous-side-project/actions/runs/7630017020/job/20784762242) **The Debug Process**: spent quite a while looking at other things during debugging, but they turned out to be unrelated. things that we experimented with are workflow conditions, ssh setup, git push url, manual trigger, workflow env, secret setup, dependency on market place actions (actions/checkout and peter-evans/create-pullrequest)
-
Jackson Gardner authored
Reverts flutter/flutter#135529 This had some failures in postsubmit: https://ci.chromium.org/ui/p/flutter/builders/prod/Linux%20gradle_plugin_light_apk_test/17054/overview and https://ci.chromium.org/ui/p/flutter/builders/prod/Linux%20gradle_plugin_fat_apk_test/17262/overview We should revert and then investigate.
-
- 23 Jan, 2024 13 commits
-
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/0b9b538bd458...220416cfa6ca 2024-01-23 matanlurey@users.noreply.github.com Geometry Wars: Documentation Edition (flutter/engine#49910) 2024-01-23 jason-simmons@users.noreply.github.com Exclude the Dart SDK sdk/lib/svg/dart2js directory from the license crawl (flutter/engine#49977) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Gray Mackall authored
Fixes https://github.com/flutter/flutter/issues/135173, and could also be interpreted as fixing https://github.com/flutter/flutter/issues/83596 based on @chinmaygarde 's comment.
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/11a16d83ab6c...0b9b538bd458 2024-01-23 zanderso@users.noreply.github.com Roll buildroot to 5d969bd98e31ec90c23ccb982666ace80559f442 (flutter/engine#49956) 2024-01-23 skia-flutter-autoroll@skia.org Roll Skia from 59a70a1efc39 to e7d10257ffb5 (3 revisions) (flutter/engine#49978) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
dependabot[bot] authored
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 4.2.0 to 4.3.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/actions/upload-artifact/releases">actions/upload-artifact's releases</a>.</em></p> <blockquote> <h2>v4.3.0</h2> <h2>What's Changed</h2> <ul> <li>Reorganize upload code in prep for merge logic & add more tests by <a href="https://github.com/robherley"><code>@ârobherley</code></a> in <a href="https://redirect.github.com/actions/upload-artifact/pull/504">actions/upload-artifact#504</a></li> <li>Add sub-action to merge artifacts by <a href="https://github.com/robherley"><code>@ârobherley</code></a> in <a href="https://redirect.github.com/actions/upload-artifact/pull/505">actions/upload-artifact#505</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/actions/upload-artifact/compare/v4...v4.3.0">https://github.com/actions/upload-artifact/compare/v4...v4.3.0</a></p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/actions/upload-artifact/commit/26f96dfa697d77e81fd5907df203aa23a56210a8"><code>26f96df</code></a> Merge pull request <a href="https://redirect.github.com/actions/upload-artifact/issues/505">#505</a> from actions/robherley/merge-artifacts</li> <li><a href="https://github.com/actions/upload-artifact/commit/530ed2c9b8e7b46db7acf98b7e543836a040586e"><code>530ed2c</code></a> use correct artifact name in test</li> <li><a href="https://github.com/actions/upload-artifact/commit/53ef6987b3562a24090358abb83a07f2c2bfec26"><code>53ef698</code></a> add additional integration test for merge all behavior</li> <li><a href="https://github.com/actions/upload-artifact/commit/90b0f8eed8fd7a9e62025ff26858a0f618d12b53"><code>90b0f8e</code></a> add workflow to test merging</li> <li><a href="https://github.com/actions/upload-artifact/commit/199a58f54fa418c391917374e9d11f5a5e618ae9"><code>199a58f</code></a> more docs</li> <li><a href="https://github.com/actions/upload-artifact/commit/3f353f9d9ee7e6a8313bfb227f44aa283e6832c9"><code>3f353f9</code></a> ncc</li> <li><a href="https://github.com/actions/upload-artifact/commit/997fffa3558d08f16f0c12036708e1ce7c0a7430"><code>997fffa</code></a> add merge artifact sub-action</li> <li><a href="https://github.com/actions/upload-artifact/commit/52899c8c02604e1c6c9ea56b52ead4671321bd05"><code>52899c8</code></a> Merge pull request <a href="https://redirect.github.com/actions/upload-artifact/issues/504">#504</a> from actions/robherley/reorganize</li> <li><a href="https://github.com/actions/upload-artifact/commit/da58a3f7b2ea3d2db018d82fe856b2d4b297de35"><code>da58a3f</code></a> ncc</li> <li><a href="https://github.com/actions/upload-artifact/commit/1f64adb8530b493d492e8084db08a55f3856e94e"><code>1f64adb</code></a> fix import</li> <li>Additional commits viewable in <a href="https://github.com/actions/upload-artifact/compare/694cdabd8bdb0f10b2cea11669e1bf5453eed0a6...26f96dfa697d77e81fd5907df203aa23a56210a8">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=actions/upload-artifact&package-manager=github_actions&previous-version=4.2.0&new-version=4.3.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details>
-
Andrew Kolos authored
consolidate AssetBundle::entries and AssetBundle::entryKinds into a new type, `AssetBundleEntry` (#142029) Part of work on https://github.com/flutter/flutter/pull/141194 The [`AssetBundle`](https://github.com/flutter/flutter/blob/0833929c997c8a9db11c1e0df9a731ab17b77606/packages/flutter_tools/lib/src/asset.dart#L80) class contains two members, `entries` and `entryKinds`. `entries` contains asset data indexed by asset key. `entryKinds` contains the "kinds" of these assets, again indexed by asset key. **Change.** Rather than have two separate maps, this PR proposes combining these maps into one by wrapping the asset data and kind into a single data type `AssetBundleEntry`. **Purpose.** In https://github.com/flutter/flutter/pull/141194, I am considering associating more information with an asset. In particular, what transformers are meant to be applied to it when copying it to the build output. Rather than adding another map member onto `AssetBundle` (e.g. `entryTransformers`), I decided to make things neater by introducing the `AssetBundleEntry` type.
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/57d6b518f920...11a16d83ab6c 2024-01-23 leroux_bruno@yahoo.fr [Web] Fix an assertion error due to synthesized keyboard events (flutter/engine#49087) 2024-01-23 737941+loic-sharma@users.noreply.github.com [Windows] Introduce egl::Context (flutter/engine#49954) 2024-01-23 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from uQK4l0QeH_PlZO6cF... to kYC2-fFgjbb36mukB... (flutter/engine#49976) 2024-01-23 skia-flutter-autoroll@skia.org Roll Skia from 58973cca0edd to 59a70a1efc39 (17 revisions) (flutter/engine#49975) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from uQK4l0QeH_Pl to kYC2-fFgjbb3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/994054143fc3...57d6b518f920 2024-01-23 jonahwilliams@google.com [Impeller] fix validation error for playground texture upload. (flutter/engine#49957) 2024-01-23 bdero@google.com [Impeller] Fix runtime effect pipeline depth/stencil. (flutter/engine#49953) 2024-01-23 zanderso@users.noreply.github.com Exclude prebuilts/Library from Mac builder_cache (flutter/engine#49971) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Christopher Fujino authored
Part of https://github.com/flutter/flutter/issues/85160
-
Ian Hickson authored
This is part 1 of a broken down version of the #140101 refactor.
-
Lau Ching Jun authored
This is used when the native assets are built by a separate build system. Context: b/286799303
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/b229878c57f5...994054143fc3 2024-01-23 30870216+gaaclarke@users.noreply.github.com [Impeller] turned on validation errors for one golden image test (flutter/engine#49955) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
hangyu authored
fixes: https://github.com/flutter/flutter/issues/142012
-
Qun Cheng authored
Fixes #141347 This PR is to add a "clear text" tooltip for the clear button on `SearchAnchor`'s search view and also add a `clearButtonTooltip` entry for `material_localizations`.
-