• Hixie's avatar
    Make the checkbox in the stocks popup menu work. · 066768f0
    Hixie authored
    Tapping on the menu item didn't animate the checkbox because the menu
    takes 300ms to animate entirely away while the checkbox takes 200ms to
    animate checked, and since the item with the checkbox was at the bottom,
    we were only seeing about 60ms of the entire checkbox animation, which
    isn't enough to notice it. So I moved it to the top of the menu.
    
    Tapping on the checkbox didn't animate because nothing caused the menu
    to rebuild when the callback was invoked. To trigger a rebuild, I now
    call navigator.setState() explicitly, after changing out local state.
    
    To make tapping the checkbox remove the menu, I also explicitly call
    navigator.pop() in the code that handles the check. (I still explicitly
    change the checkbox to show that that's possible. In principle one could
    just treat the checkbox as an inert widget that happens to trigger pop,
    and do all the checking/unchecking in the switch statement.)
    
    I also made some minor style tweaks to files I was looking at while
    dealing with this issue.
    066768f0
Name
Last commit
Last update
..
doc Loading commit data...
lib Loading commit data...
.gitignore Loading commit data...
CHANGELOG.md Loading commit data...
LICENSE Loading commit data...
README.md Loading commit data...
pubspec.yaml Loading commit data...