- 31 Jan, 2023 23 commits
-
-
Ian Hickson authored
...so remove the assert
-
Tanay Neotia authored
* Add support for image insertion on Android * Fix checks * Use proper Dart syntax on snippet * Specify type annotation on list * Fix nits, add some asserts, and improve example code * Add missing import * Fix nullsafety error * Fix nullsafety error * Remove reference to contentCommitMimeTypes in docs * Fix nits * Fix warnings and import * Add test for content commit in editable_text_test.dart * Check that URIs are equal in test * Fix nits and rename functions / classes to be more self-explanatory * Fix failing debugFillProperties tests * Add empty implementation to `insertContent` in TextInputClient * Tweak documentation slightly * Improve docs for contentInsertionMimeTypes and fix assert * Rework contentInsertionMimeType asserts * Add test for onContentInserted example * Switch implementation to a configuration class for more granularity in setting mime types * Fix nits * Improve docs and fix doc tests * Fix more nits (LongCatIsLooong) * Fix failing tests * Make parameters (guaranteed by platform to be non-nullable) non-nullable * Fix analysis issues
-
engine-flutter-autoroll authored
1aaf3db31 Roll Dart SDK from 4fdbc7c28141 to 9bcc1773ebf0 (1 revision) (flutter/engine#39290) (#119640)
-
Bruno Leroux authored
* Fix CupertinoNavigationBar should create a backward compatible AnnotatedRegion * Remove extra space
-
Michael Goderbauer authored
-
engine-flutter-autoroll authored
* 707458b92 Roll Dart SDK from 52dc94238144 to c64a3f0c9fea (5 revisions) (flutter/engine#39281) * 0aec06abd Roll Dart SDK from c64a3f0c9fea to 4fdbc7c28141 (1 revision) (flutter/engine#39282) * 95a65fcbb Roll Fuchsia Mac SDK from CNkyuFjzxZhOxLNRS... to IdMSzll1VeWJMV6v8... (flutter/engine#39283) * 957412921 Python compatibility fix (flutter/engine#39286) * 3147334f2 Roll Skia from 3c6eb76a683a to c29211525dac (2 revisions) (flutter/engine#39289) * cd2e8885e Roll Fuchsia Linux SDK from cTwkXiHcuqwrumaJ5... to 71lEeibIyrq0V8jId... (flutter/engine#39284)
-
Michael Goderbauer authored
* Remove MediaQuery from WidgetsApp * more * fix test * more deprecation notices.
-
Ian Hickson authored
The default implementation returns EdgeInsets.zero, the ShapeDecoration subclass already makes it non-nullable, and there isn't any benefit to returning null as far as I can tell.
-
Victoria Ashworth authored
* fix when duplicate mdns results are found * put mdns auth code in it's own function and update tests * add comments, refactor auth code parsing, other small tweaks
-
engine-flutter-autoroll authored
-
Chris Bracken authored
* Reland: [macos] add flavor options to tool commands Adds --flavor option to flutter run and flutter build. Running against preexisting devicelab flavor tests for feature parity between macOS, iOS, and Android. This relands #118421 by alex-wallen which was reverted in #118858 due to the following test failures: The bail-out with "Host and target are the same. Nothing to install." added in `packages/flutter_tools/lib/src/commands/install.dart` triggered failures in the following tests, which unconditionally attempt to install the built app, which is unsupported on desktop since the host and target are the same: * https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8791495589540422465/+/u/run_flutter_view_macos__start_up/test_stdout * https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8791496218824259121/+/u/run_complex_layout_win_desktop__start_up/test_stdout * https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8791496218165602641/+/u/run_flutter_gallery_win_desktop__start_up/test_stdout Fixes #64088 * Partial revert: eliminate install check on desktop The original flavour support patch included a check that triggered a failure when flutter install is run on desktop OSes. This was intentional, since the host and target devices are the same and installation is unnecessary to launch the app on currently-supported desktop OSes. Note that Windows UWP apps *do* require installation to run, and we used to have an install command for those apps, though UWP is no longer supported. Since that part of the change was orthogonal to flavour support itself, I'm reverting that component of the change and we can deal with it separately if so desired.
-
Danny Tuppeny authored
* [flutter_tools] Fix parsing of existing DDS URIs from exceptions Fixes #118609. * Fix formatting Co-authored-by:
Christopher Fujino <fujino@google.com> * Fix formatting Co-authored-by:
-
engine-flutter-autoroll authored
* 90f447313 [ci] Increase timeouts for platform_tests (flutter/plugins#7036) * f5568e4b1 [google_sign_in] Add doc for iOS auth with SERVER_CLIENT_ID (flutter/plugins#4747) * 0c05e8d91 Roll Flutter from a815ee63 to 75680ae9 (58 revisions) (flutter/plugins#7048) * a4c320902 [camera]: Bump camerax_version from 1.3.0-alpha02 to 1.3.0-alpha03 in /packages/camera/camera_android_camerax/android (flutter/plugins#7061) * 8f12b27b6 [ci] Add LUCI versions of macOS ARM tests (flutter/plugins#6984) * 3843b38e2 [tool] Improve main-branch detection (flutter/plugins#7038) * d39e7569c [in_app_purchase] Prep for more const widgets (flutter/plugins#7030) * ddb9777ee [ci] Switch remaining macOS host tests to LUCI (flutter/plugins#7063) * 2edf56324 [ci] Part 1 of swapping iOS platform test arch (flutter/plugins#7064) * 35f0b1a49 [camerax] Add system services to plugin (flutter/plugins#6986) * 5dd0f41a2 [webview]: Bump mockito-inline (flutter/plugins#7056) * 1896f10ca [webview_flutter_wkwebview][webview_flutter_android] Fixes bug where the `WebView`s could not be released (flutter/plugins#6996) * a494825fa [camerax] Allow instance manager to create identical objects (flutter/plugins#7034) * 6ef73da26 [ci] Increase heavy workload memory (flutter/plugins#7065) * 9da327ca3 [various] Update to use sharedDarwinSource (flutter/plugins#7027)
-
engine-flutter-autoroll authored
* a80741c39 Roll Skia from 3c4cd77c5e5d to fc31f43cc40a (1 revision) (flutter/engine#39278) * b7f152d50 Download emsdk for web framework tests. (flutter/engine#39268) * 72abe0e4b Remove useless variable in Canvas.drawCircle. (flutter/engine#39250)
-
Casey Hillers authored
This reverts commit 530c3f2d.
-
engine-flutter-autoroll authored
* 999e5e5fc Rebase all (flutter/engine#38855) * 9cc2a8e8f Update bytes str code (flutter/engine#39275) * 9448f2966 Revert "[fuchsia] Diagnostics directory rights are R* (#39203)" (flutter/engine#39271)
-
Michael Goderbauer authored
-
Michael Goderbauer authored
* Remove deprecated AnimatedSize.vsync parameter * add dartfix * Update packages/flutter/lib/fix_data/fix_widgets/fix_widgets.yaml * Update packages/flutter/lib/fix_data/fix_widgets/fix_widgets.yaml --------- Co-authored-by:Kate Lovett <katelovett@google.com>
-
engine-flutter-autoroll authored
* e67a30e00 [web] @JS('Intl') (flutter/engine#39211) * 7cb1f0ce7 [web] Use our own icu_bidi (flutter/engine#39200) * 772188181 @alwaysThrows is deprecated. Return `Never` instead. (flutter/engine#39269) -
LongCatIsLooong authored
* PostFrameCallbacks -> compositionCallbacks * review * review
-
engine-flutter-autoroll authored
* 033514b3d [Windows] Remove dead code from FlutterWindow tests (flutter/engine#39216) * daa8eeb7f [Windows] Use 'FlutterWindowsEngineBuilder' in keyboard unit tests (flutter/engine#39209)
-
engine-flutter-autoroll authored
* 46adc3f5b Roll Skia from 59dcffca9061 to 3c4cd77c5e5d (22 revisions) (flutter/engine#39264) * a1c06a5c8 Roll Fuchsia Mac SDK from EAFnGijD0l5QxaPxF... to CNkyuFjzxZhOxLNRS... (flutter/engine#39263) * 5011144c0 Roll Fuchsia Linux SDK from xTXbcsPr5GJvFSLha... to cTwkXiHcuqwrumaJ5... (flutter/engine#39265)
-
Renzo Olivares authored
* remove textTheme usage from AppBar SliverAppBar and AppBarTheme and migrate usages in the framework * Fix test * update _PackageLicensePageTitle to accept titleTextStyle * Fix test --------- Co-authored-by:Renzo Olivares <roliv@google.com>
-
- 30 Jan, 2023 17 commits
-
-
Flutter GitHub Bot authored
-
engine-flutter-autoroll authored
-
LongCatIsLooong authored
-
Loïc Sharma authored
-
hangyu authored
* Update input_decorator.dart * Update text_field_test.dart * Update time_picker.dart Update time_picker.dart
-
Renzo Olivares authored
* attempt to extend to paragraph * second attempt * clean up implementation * clean up * updates * updates * Fix implementation * remove old * update docs * update docs * fix analyzer * Fix bug where new line character was selected and backwards selection failed * remove print * Add test for paragraph boundary * Add text editing test for extending selection to paragraph for mac and ios * rename to ExtendSelectionToParagraphBoundaryIntent * fix analyzer * Should default to downstream when collapsing selection * get rid of _getParagraphAtOffset and move into getTextBoundaryAt * Search for all line terminators * iterate through code units instead of characters * Address some reviewer comments" * Add separate implementations for leading and trailing paragraph boundary methods * Do not break after a carriage return if it is followed by a line feed * test carriage return followed by a line feed * more tests * Do not continue if the line terminator is at the target text offset * add hack to extend highlight to line terminator * Revert "add hack to extend highlight to line terminator" This reverts commit b4d3c434539b66c3c81c215e87c645b425902825. * Revert "Do not continue if the line terminator is at the target text offset" This reverts commit 789e1b838e54e7c25600bfa8852e59431ccaf5dc. * Update ParagraphBoundary with latest TextBoundary changes * Update implementation to iterate through indexes * update getTrailingTextBoundaryAt to include the line terminator * Updates * more updates * more updates * updates * updates * Lets try this again * clean up * updates * more updates * updates * fix * Re-implement using custom paragraph boundary applying method * Revert "Re-implement using custom paragraph boundary applying method" This reverts commit cd2f7f4b6eb6726b28f82a43708812e06a49df95. * Revert "fix" This reverts commit 8ec1f8f58935cfb3eb86dc6afd2894537af4cf7b. * updates * Revert "updates" This reverts commit 9dcca4a0031fe18ada9d6ffbbe77ba09918e82ae. * Revert "Revert "fix"" This reverts commit 9cc1332cd3041badc472d0d223a106203e46afb8. * Revert "Revert "Re-implement using custom paragraph boundary applying method"" This reverts commit 1acb606fb743fd840da20cca26d9a7c26accb71d. * Fix paragraph boundaries * Add failing test * Address some comments * group tests and fix analyzer * fix typo * fix remaining test * updates * more fixes and logs * clean up and add another test * Fix last test * Add new test * Clean up * more clean up * clean up comments * address comments * updates * return null when position is out of bounds and 0 or end of text if appropriate * Clean up cases * Do not return null when OOB in the direction of iteration * clean up * simplify implementation thanks to LongCatIsLooong feedback * Address comments * Add line and paragraph separator * Use _moveBeyondTextBoundary instead of custom _moveToParagraphBoundary * Change some intent names and revert fromPosition change * clean up docs --------- Co-authored-by: -
-
engine-flutter-autoroll authored
-
Kate Lovett authored
* Maybe maybe * Nit * One more nit * ++ * Fix test * REview feedback * Add comment about ios * ++ * Doc nit * Handle trackpads * Review feedback
-
chunhtai authored
* fixes PointerEventConverter to handle malformed scrolling event * update
-
Elias Yishak authored
* refactoring to use `ver` command instead of `systeminfo` * fix tests to match new approach * adding another valid validator using brazil locale text * refactor tests to use generic fake class `ver` arg + showing output from `ver` if unsuccessful * update reason text in test * fix reason text to be hard coded
-
Camille Simon authored
* Add exported tag * Undo testing changes
-
Flutter GitHub Bot authored
-
Flutter GitHub Bot authored
-
Justin McCandless authored
Enables custom context menus on web
-
Eilidh Southren authored
* init scaled changes * add correct padding values for M3 * revert unneeded change * Update packages/flutter/lib/src/material/text_button.dart Co-authored-by:
Pierre-Louis <6655696+guidezpl@users.noreply.github.com> * Update packages/flutter/lib/src/material/text_button.dart Co-authored-by:
Gray Mackall <mackall@google.com> * Added expandIconColor property on ExpansionPanelList Widget (#115950) * Create expanIconColor doc template * Add expandIconColor property to ExpansionPanelList * Added tests for expandIconColor on ExpansionPanelList & radio * Removed trailing spaces * Update docstring (#118072) Co-authored-by:
a-wallen <stephenwallen@google.com> * Fix out-of-sync ExpansionPanel animation (#105024) * Increase minimum height of headerWidget in ExpansionPanel to smooth the animation. Signed-off-by:
Morris Kurz <morriskurz@gmail.com> * Add regression tests that check for equal height of header elements in ExpansionPanel. Signed-off-by:
dependabot[bot] <support@github.com> Signed-off-by:
dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump actions/checkout from 3.1.0 to 3.3.0 (#118052) Bumps [actions/checkout](https://github.com/actions/checkout) from 3.1.0 to 3.3.0. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](https://github.com/actions/checkout/compare/93ea575cb5d8a053eaa0ac8fa3b40d7e05a33cc8...ac593985615ec2ede58e132d2e21d2b1cbd6127c) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by:
Jonah Williams <jonahwilliams@google.com> * add regexp comment * rescope int list comparison function * update packages Co-authored-by:
Deokgyu Yang <secugyu@gmail.com> Signed-off-by:
engine-flutter-autoroll <engine-flutter-autoroll@skia.org> Co-authored-by:
Jesús S Guerrero <jesus_sguerrero@hotmail.com> Co-authored-by:
Darren Austin <darrenaustin@google.com> Co-authored-by:
Ahmed Ashour <asashour@yahoo.com> Co-authored-by:
Michael Goderbauer <goderbauer@google.com> Co-authored-by:
Greg Price <gnprice@gmail.com> Co-authored-by:
CicadaCinema <52425971+CicadaCinema@users.noreply.github.com> Co-authored-by:
Tae Hyung Kim <thkim1011@users.noreply.github.com> Co-authored-by:
Renzo Olivares <rmolivares@renzo-olivares.dev> Co-authored-by:
Sam Rawlins <srawlins@google.com> Co-authored-by:
Peixin Li <pageli328@gmail.com> Co-authored-by:
Callum Moffat <smartercallum@gmail.com> Co-authored-by:
Vyacheslav Egorov <vegorov@google.com> Co-authored-by:
Christopher Fujino <christopherfujino@gmail.com> Co-authored-by:
Flutter GitHub Bot <fluttergithubbot@gmail.com> Co-authored-by:
Camille Simon <43054281+camsim99@users.noreply.github.com> Co-authored-by:
LongCatIsLooong <31859944+LongCatIsLooong@users.noreply.github.com> Co-authored-by:
Drew Roen <102626803+drewroengoogle@users.noreply.github.com> Co-authored-by:
Jason Simmons <jason-simmons@users.noreply.github.com> Co-authored-by:
Nehal Patel <nehalvpatel@users.noreply.github.com> Co-authored-by:
gmackall <34871572+gmackall@users.noreply.github.com> Co-authored-by:
Mohammed CHAHBOUN <69054810+M97Chahboun@users.noreply.github.com> Co-authored-by:
Alex Wallen <wallenstephen@outlook.com> Co-authored-by:
Lucas.Xu <tsuiyuenhong@gmail.com> Co-authored-by:
Jenn Magder <magder@google.com> Co-authored-by:
Helin Shiah <helinx@google.com> Co-authored-by:
Taha Tesser <tessertaha@gmail.com> Co-authored-by:
Nicholas Shahan <nshahan@google.com> Co-authored-by:
Yegor <yjbanov@google.com> Co-authored-by:
Bruno Leroux <leroux_bruno@yahoo.fr> Co-authored-by:
Brandon DeRosier <bdero@google.com> Co-authored-by:
Loïc Sharma <737941+loic-sharma@users.noreply.github.com> Co-authored-by:
Youchen Du <youchen.du@gmail.com> Co-authored-by:
Sigurd Meldgaard <sigurdm@google.com> Co-authored-by:
Rydmike <m.rydstrom@gmail.com> Co-authored-by:
Suhwan Cha <suhw4n@gmail.com> Co-authored-by:
Andrew Kolos <andrewrkolos@gmail.com> Co-authored-by:
Qun Cheng <36861262+QuncCccccc@users.noreply.github.com> Co-authored-by:
joshualitt <joshualitt@google.com> Co-authored-by:
Peixin Li <peixinli@google.com> Co-authored-by:
Parker Lougheed <parlough@gmail.com> Co-authored-by:
Ivo Beckers <35917382+IvoB1987@users.noreply.github.com> Co-authored-by:
godofredoc <godofredoc@google.com> Co-authored-by:
Bernardo Ferrari <bernaferrari2@gmail.com> Co-authored-by:
Dennis Kugelmann <kugelmann.dennis@gmail.com> Co-authored-by:
Hans Muller <hans.muller@gmail.com> Co-authored-by:
Victoria Ashworth <vashworth@google.com>
-
engine-flutter-autoroll authored
a7bb0e410 Roll Fuchsia Linux SDK from 1D63BqURfJdG4r3CK... to xTXbcsPr5GJvFSLha... (flutter/engine#39238) (#119482)
-
