Commits · fc8856eb80d306ac40563582a1212a07141d9001 · abdullh.alsoleman / Front-End

16 Jun, 2023 3 commits

[web] Don't crash on `const HtmlElementView()` (#128965) · fc8856eb

Mouad Debbar authored Jun 16, 2023

Previously, when the code contained `const HtmlElementView()` it would break even if it's guarded by `if (kIsWeb)`.

This PR makes it such that `const HtmlElementView()` is allowed but it still throws if it gets inserted into the widget tree by mistake on non-web platforms.

One improvement we can make in the future is to have a conditional import:
- `_html_element_view_web.dart` that contains the real `HtmlElementView` that can only be instantiated on web.
- `_html_element_view_io.dart` that contains a stub with an unimplemented `build()` method.

Fixes https://github.com/flutter/flutter/issues/43532

fc8856eb

Roll Packages from 050729760b25 to f9314a3b833a (3 revisions) (#128878) · 5cb27998

engine-flutter-autoroll authored Jun 16, 2023

https://github.com/flutter/packages/compare/050729760b25...f9314a3b833a

2023-06-14 stuartmorgan@google.com [tool] Support running main.dart
(flutter/packages#4208)
2023-06-13 stuartmorgan@google.com [tool] Allow running from anywhere
(flutter/packages#4199)
2023-06-13 62033170+Khalidm98@users.noreply.github.com [go_router]
#127016 preserved route name case when caching `_nameToPath`
(flutter/packages#4196)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert
to ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

5cb27998

Update getProperties to handle Diagnosticable as input. (#128897) · dd4a8150
Polina Cherkasova authored Jun 16, 2023

dd4a8150

15 Jun, 2023 13 commits

Roll Flutter Engine from 48e0b4e66422 to fb5fed432e59 (1 revision) (#128967) · e87b2021

engine-flutter-autoroll authored Jun 15, 2023

https://github.com/flutter/engine/compare/48e0b4e66422...fb5fed432e59

2023-06-15 skia-flutter-autoroll@skia.org Roll Skia from 2d531d020c26 to 794b6f9240a8 (3 revisions) (flutter/engine#42888)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

e87b2021

Fix dart pub cache clean command on pub.dart (#128171) · 6b5766d4

Dery Rahman Ahaddienata authored Jun 15, 2023

Command instruction for clearing dart pub cache is somewhat wrong. Instead of `clear`, `clean` is the correct one. Ref: https://dart.dev/tools/pub/cmd/pub-cache

Fixes https://github.com/flutter/flutter/issues/128663

(Edited by @andrewkolos. Changed "related to" issue to "fixes" to link this PR to the issue).

6b5766d4

[flutter_tools] Migrate more integration tests to process result matcher (#128737) · cc83f038
Christopher Fujino authored Jun 15, 2023
```
Part of https://github.com/flutter/flutter/issues/127135
```
cc83f038

[flutter_tools] refactor license collector (#128748) · 735fc296

Christopher Fujino authored Jun 15, 2023

Improve debugging for https://github.com/flutter/flutter/issues/128680

In the linked issue, I cannot explain how we are getting a type error. However, this refactor eliminates the null check operator (by iterating over `MapEntries` rather than the keys) in hopes that there will be a more descriptive error in the future. The correctness of this change is verified by the existing tests in https://github.com/flutter/flutter/blob/master/packages/flutter_tools/test/general.shard/license_collector_test.dart

735fc296

Set Semantics.button to true for date widget (#128824) · f8e8d89b

Qun Cheng authored Jun 15, 2023

Fixes #127863

This PR is to set `Semantics.button` to true for date widget in `DatePicker`.

https://github.com/flutter/flutter/assets/36861262/b366f25a-6bf3-4e3f-b944-ab71197b73e5

f8e8d89b

Update golden tests (#128914) · c3b2175a
Qun Cheng authored Jun 15, 2023

c3b2175a

Roll Flutter Engine from 9934c0de738c to 48e0b4e66422 (26 revisions) (#128959) · c7167765

engine-flutter-autoroll authored Jun 15, 2023

https://github.com/flutter/engine/compare/9934c0de738c...48e0b4e66422

2023-06-15 skia-flutter-autoroll@skia.org Roll Skia from 0b66c6928dcf to 2d531d020c26 (3 revisions) (flutter/engine#42883)
2023-06-15 matej.knopp@gmail.com Raster cache should preserve RTree for overlay layers (flutter/engine#42552)
2023-06-15 skia-flutter-autoroll@skia.org Roll Skia from c0c74b433117 to 0b66c6928dcf (1 revision) (flutter/engine#42879)
2023-06-15 leroux_bruno@yahoo.fr [Linux] Allow BasicMessageChannel sending and responding to null message (flutter/engine#42808)
2023-06-15 skia-flutter-autoroll@skia.org Roll Skia from 12375fb6f3c8 to c0c74b433117 (1 revision) (flutter/engine#42876)
2023-06-15 skia-flutter-autoroll@skia.org Roll Skia from d62221bd33a6 to 12375fb6f3c8 (1 revision) (flutter/engine#42873)
2023-06-15 skia-flutter-autoroll@skia.org Roll Skia from e2e0256d4c6a to d62221bd33a6 (1 revision) (flutter/engine#42871)
2023-06-15 skia-flutter-autoroll@skia.org Roll Skia from c3abd540c7f9 to e2e0256d4c6a (1 revision) (flutter/engine#42869)
2023-06-15 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from uvmDF7KM34dWGdsuK... to 53EjCyuRu91oFTBf2... (flutter/engine#42868)
2023-06-15 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from h3-8RUVrC889UXou7... to P7QA6bfO_Ij5dre7B... (flutter/engine#42867)
2023-06-15 skia-flutter-autoroll@skia.org Roll Skia from 2718866006d2 to c3abd540c7f9 (1 revision) (flutter/engine#42866)
2023-06-15 skia-flutter-autoroll@skia.org Roll Skia from 19051bc5fc90 to 2718866006d2 (33 revisions) (flutter/engine#42864)
2023-06-15 skia-flutter-autoroll@skia.org Roll Dart SDK from 922c315b2c34 to 8eaed3382237 (1 revision) (flutter/engine#42862)
2023-06-15 godofredoc@google.com Add missing artifact to the android_arm64_profile config. (flutter/engine#42858)
2023-06-14 hterkelsen@users.noreply.github.com Build skia with expat (flutter/engine#42859)
2023-06-14 ychris@google.com [ios] use interfaceOrientation orientation on iOS 13 and above (flutter/engine#42846)
2023-06-14 skia-flutter-autoroll@skia.org Manual roll Dart SDK from f1387834bfd9 to 922c315b2c34 (4 revisions) (flutter/engine#42855)
2023-06-14 jonahwilliams@google.com [Impeller] Make interleaved layout (more) explicit in generated headers. (flutter/engine#42628)
2023-06-14 30870216+gaaclarke@users.noreply.github.com Renamed validation layers build (flutter/engine#42826)
2023-06-14 ychris@google.com [ios] view controller based status bar (flutter/engine#42643)
2023-06-14 skia-flutter-autoroll@skia.org Roll Skia from 6d5dc31d88e2 to 19051bc5fc90 (25 revisions) (flutter/engine#42828)
2023-06-14 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from Xi3c5nti2LKnEOqYt... to uvmDF7KM34dWGdsuK... (flutter/engine#42842)
2023-06-14 43091780+utzcoz@users.noreply.github.com Fix generateLockfiles running directory for documentation (flutter/engine#42734)
2023-06-14 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from Cld7-rm6ZmCOO8j-K... to h3-8RUVrC889UXou7... (flutter/engine#42839)
2023-06-14 skia-flutter-autoroll@skia.org Roll ANGLE from 7e075469ff02 to 3a3a3c655a96 (8 revisions) (flutter/engine#42834)
2023-06-14 skia-flutter-autoroll@skia.org Roll Dart SDK from c4e9794df8af to f1387834bfd9 (1 revision) (flutter/engine#42833)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from Xi3c5nti2LKn to 53EjCyuRu91o
fuchsia/sdk/core/mac-amd64 from Cld7-rm6ZmCO to P7QA6bfO_Ij5

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

c7167765

flutter update-packages --cherry-pick-package (#128917) · 8c5a70f3
Ian Hickson authored Jun 15, 2023
```
Fixes https://github.com/flutter/flutter/issues/101525
```
8c5a70f3

add .pub-cache back to .gitignore (#128894) · d3e771c8

Christopher Fujino authored Jun 15, 2023

Fixes https://github.com/flutter/flutter/issues/128635

In https://github.com/flutter/flutter/commit/1fd84f88e915427c88fb1d38c052150c76e27b4f, we renamed the `.pub-cache` entry in the `.gitignore` file to `.pub-preload-cache`, and ensured the packaging script was now populating that directory. However, for users who already had this directory from downloading an earlier archive but used `flutter upgrade` to get the latest code, they now had a `.gitignore` file that was no longer ignoring their `.pub-cache` directory.

Now, when these users try to `flutter upgrade` again, the tool tries to verify if their checkout is clean, and will exit early if not directing the user to either stash or commit these changes, or do `flutter upgrade --force` which will try to update their branch anyway (and which would succeed since there would be no git conflict). These change adds back the `.pub-cache` entry to `.gitignore`, which won't retroactively fix broken releases, but will at least ensure if they `flutter upgrade --force` once to get this fix, they won't need to again.

d3e771c8

Roll Flutter Engine from 2d8d5ecfe4a8 to 9934c0de738c (2 revisions) (#128849) · 12f2cbcb

engine-flutter-autoroll authored Jun 15, 2023

https://github.com/flutter/engine/compare/2d8d5ecfe4a8...9934c0de738c

2023-06-14 skia-flutter-autoroll@skia.org Roll Dart SDK from
2465228c0c21 to c4e9794df8af (1 revision) (flutter/engine#42831)
2023-06-14 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from
kQbij6Tvqe7F9-PhR... to Xi3c5nti2LKnEOqYt... (flutter/engine#42832)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from kQbij6Tvqe7F to Xi3c5nti2LKn

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on
the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

12f2cbcb

flutter update-packages --force-upgrade (#128908) · a162d754

Mouad Debbar authored Jun 15, 2023

- Bumps `vm_service` from `11.6.0` to `11.7.1`
- Bumps `web` from `0.1.3-beta` to `0.1.4-beta` and adds it everywhere.
- Moves `js` from `dependencies` to `dev_dependencies`

a162d754

[web] Pass creation params to the platform view factory (#128146) · b0188cd1

Mouad Debbar authored Jun 15, 2023

This concludes step 1 of the `HtmlElementView` improvements. It's now possible to pass creation params to platform view factories directly from `HtmlElementView`.

Here's a sample app using a single factory to render platform views in different colors:

<details>
  <summary>Code sample</summary>
  
  ```dart
import 'dart:js_interop';
import 'dart:ui_web' as ui_web;
import 'package:flutter/material.dart';
import 'package:web/web.dart' as web;

void main() {
  runApp(MyApp());
}

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Platform View Demo',
      home: Scaffold(
        appBar: AppBar(
          title: Text('Platform View Demo'),
        ),
        body: Center(
          child: Column(
            mainAxisAlignment: MainAxisAlignment.spaceEvenly,
            children: [
              BoxWrapper('red'),
              BoxWrapper(null),
              BoxWrapper('blue'),
            ],
          ),
        ),
      ),
    );
  }
}

bool isRegistered = false;

class BoxWrapper extends StatelessWidget {
  const BoxWrapper(this.cssColor);

  final String? cssColor;

  void register() {
    if (isRegistered) return;
    isRegistered = true;

    ui_web.platformViewRegistry.registerViewFactory('my-platform-view', (
      id, {
      Object? params,
    }) {
      params as String?;

      final element = web.document.createElement('div'.toJS) as web.HTMLElement;
      element.textContent = 'Platform View'.toJS;
      element.style
        ..lineHeight = '100px'.toJS
        ..fontSize = '24px'.toJS
        ..backgroundColor = (params ?? 'pink').toJS
        ..textAlign = 'center'.toJS;
      return element;
    });
  }

  @override
  Widget build(BuildContext context) {
    register();
    return SizedBox(
      width: 200,
      height: 100,
      child: Card(
        child: HtmlElementView(
          viewType: 'my-platform-view',
          creationParams: cssColor,
        ),
      ),
    );
  }
}
  ```
</details>

![image](https://github.com/flutter/flutter/assets/1278212/4b62ed8b-2314-49d6-9b4a-5da849bf2a48)

Depends on https://github.com/flutter/engine/pull/42255

Part of https://github.com/flutter/flutter/issues/127030

b0188cd1

[flutter_tools] cache flutter sdk version to disk (#124558) · 3246808c

Christopher Fujino authored Jun 15, 2023

Fixes https://github.com/flutter/flutter/issues/112833

Most of the actual changes here are in [packages/flutter_tools/lib/src/version.dart](https://github.com/flutter/flutter/pull/124558/files#diff-092e00109d9e1589fbc7c6de750e29a6ae512b2dd44e85d60028953561201605), while the rest is largely just addressing changes to the constructor of `FlutterVersion` which now has different dependencies.

This change makes `FlutterVersion` an interface with two concrete implementations:

1. `_FlutterVersionGit` which is mostly the previous implementation, and
2. `_FlutterVersionFromFile` which will read a new `.version.json` file from the root of the repo

The [`FlutterVersion` constructor](https://github.com/flutter/flutter/pull/124558/files#diff-092e00109d9e1589fbc7c6de750e29a6ae512b2dd44e85d60028953561201605R70) is now a factory that first checks if `.version.json` exists, and if so returns an instance of `_FlutterVersionFromGit` else it returns the fallback `_FlutterVersionGit` which will end up writing `.version.json` so that we don't need to re-calculate the version on the next invocation.

`.version.json` will be deleted in the bash/batch entrypoints any time we need to rebuild he tool (this will usually be because the user did `flutter upgrade` or `flutter channel`, or manually changed the commit with git).

3246808c

14 Jun, 2023 14 commits

Fix inconsistently suffixed macOS flavored bundle directory (#127997) · 6d2b5ea3

Arne Molland authored Jun 14, 2023

The current implementation of macOS flavor support (#119564) assumes a bundle directory that differs from both the iOS implementation and the official documentation. The [documentation](https://docs.flutter.dev/deployment/flavors) instructs developers to suffix their Xcode build configurations with `-<flavor>`, but the implementation assumes a space:

https://github.com/flutter/flutter/blob/5fd9ef4240d3fc239f042f49b8eb1ad24260091f/packages/flutter_tools/lib/src/macos/application_package.dart#L174-L178

Whereas the iOS implementation, which is the reference for the docs, assumes a `-<flavor>` suffix:

https://github.com/flutter/flutter/blob/a257efc2841ed7042322fbd043f0983e705d7da2/packages/flutter_tools/lib/src/ios/xcodeproj.dart#L482-L488

This change replaces the empty space with the `-` character which is in line with the documentation and iOS implementation, as well as removing the sentence-casing applied to the flavor name; every bundle built with a flavor keeps the original flavor name in its filename.

*List which issues are fixed by this PR. You must list at least one issue.*
#122684.

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*

6d2b5ea3

Update golden tests for material (#128839) · 7d950864
Qun Cheng authored Jun 14, 2023

7d950864
Update getChildrenSummaryTree to handle Diagnosticable as input. (#128833) · ed3d4630
Polina Cherkasova authored Jun 14, 2023

ed3d4630
Improve the error message for non-normalized constraints (#127906) · d64332a0
Ian Hickson authored Jun 14, 2023
```
We probably added RenderBox.layout after this error was created and of course we weren't writing tests back then...
```
d64332a0
ContextAction.isEnabled needs a context (#127721) · 34f39a20
Ian Hickson authored Jun 14, 2023
```
...and lots of things that fall out from that
```
34f39a20

Remove temporary default case for PointerSignalKind (#128900) · 4effd9c4

LouiseHsu authored Jun 14, 2023

This PR cleans up some prep that was added as part of
https://github.com/flutter/flutter/pull/120731 which was done to unblock
https://github.com/flutter/engine/pull/39637
Since the work done in that PR was reverted, this should be removed.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] All existing and new tests are passing.

4effd9c4

Respect allowlisted count of leaks. (#128823) · d520b64c
Polina Cherkasova authored Jun 14, 2023
```
Contributes to https://github.com/dart-lang/leak_tracker/issues/59
```
d520b64c

Unpin flutter_plugin_android_lifecycle (#128898) · 944d6c8f

gmackall authored Jun 14, 2023

Unpins flutter_plugin_android_lifecycle where it is pinned. I then
1. ran `flutter update-packages --force-upgrade` (but only committed the changes within `dev/integration_tests/gradle_deprecated_settings/`, which is where it had been pinned)
2. followed by `./gradlew :generateLockfiles` from `dev/integration_tests/gradle_deprecated_settings/android/` (the lockfile was what was causing the CI dependency resolution failure, so this second step is the fix for that).

See the reason it was pinned: https://github.com/flutter/flutter/pull/121847#discussion_r1124797112 followed by the PR that pinned it: https://github.com/flutter/flutter/pull/122043

Fixes https://github.com/flutter/flutter/issues/122039

944d6c8f

[web] Migrate framework away from dart:html and package:js (#128580) · 95be76ab
Mouad Debbar authored Jun 14, 2023
```
Use `package:web` and `dart:js_interop` instead.

Part of https://github.com/flutter/flutter/issues/127030
```
95be76ab

Fixed slider value indicator not disappearing after a bit on desktop platform... · 52c4db8d

cruiser-baxter authored Jun 14, 2023

Fixed slider value indicator not disappearing after a bit on desktop platform when slider is clicked not dragged (#128137)

In slider.dart within the _startInteraction method and within the below conditional.

"if (!_active && !hasFocus &&
_state.valueIndicatorController.status == AnimationStatus.completed)"

**Changed to:**

"f (!_active &&
_state.valueIndicatorController.status == AnimationStatus.completed)"
This allows the value indicator to disappear after a bit when clicked instead of dragged on Desktop platform. 

I also added a test in slider_test.dart to detect the bug if it ever returns.

Fixes https://github.com/flutter/flutter/issues/123313

52c4db8d

Inline AbstractNode into SemanticsNode and Layer (#128467) · 16e6be8b
Michael Goderbauer authored Jun 14, 2023

16e6be8b

Roll Flutter Engine from 727b4413fe6f to 2d8d5ecfe4a8 (5 revisions) (#128842) · 40bb615b

engine-flutter-autoroll authored Jun 14, 2023

https://github.com/flutter/engine/compare/727b4413fe6f...2d8d5ecfe4a8

2023-06-13 skia-flutter-autoroll@skia.org Roll Skia from 6bdb0ef30cb6 to 6d5dc31d88e2 (7 revisions) (flutter/engine#42790)
2023-06-13 dnfield@google.com Make validation logs ERROR level (flutter/engine#42825)
2023-06-13 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from J-zU9HGYXYU5UWJO9... to Cld7-rm6ZmCOO8j-K... (flutter/engine#42824)
2023-06-13 skia-flutter-autoroll@skia.org Manual roll ICU from 1eea59cabae0 to a2961dc659b4 (0 revision) (flutter/engine#42817)
2023-06-13 ychris@google.com Remove some trivial deprecated symbol usages in iOS Embedder (flutter/engine#42711)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from J-zU9HGYXYU5 to Cld7-rm6ZmCO

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

40bb615b

Roll Flutter Engine from 66a5761412f9 to 727b4413fe6f (10 revisions) (#128841) · 4fe84d7a

engine-flutter-autoroll authored Jun 14, 2023

https://github.com/flutter/engine/compare/66a5761412f9...727b4413fe6f

2023-06-13 ychris@google.com Reland "[ios_platform_view] only recycle maskView when the view is applying mutators #42115" (flutter/engine#42823)
2023-06-13 skia-flutter-autoroll@skia.org Roll Dart SDK from 41234fa4b22d to 2465228c0c21 (1 revision) (flutter/engine#42822)
2023-06-13 30870216+gaaclarke@users.noreply.github.com [Impeller] Added cache for command buffers in vulkan (flutter/engine#42793)
2023-06-13 47866232+chunhtai@users.noreply.github.com setupDefultFontManager correctly clear out cache (flutter/engine#42178)
2023-06-13 jonahwilliams@google.com [Impeller] Reland attempt Vulkan setup and fallback to GLES. (flutter/engine#42820)
2023-06-13 30870216+gaaclarke@users.noreply.github.com Added CI step for building with validation layers (flutter/engine#42724)
2023-06-13 jason-simmons@users.noreply.github.com [Impeller] Null check for the device holder in the Vulkan context destructor (flutter/engine#42821)
2023-06-13 tamird@google.com Add missing includes (flutter/engine#42812)
2023-06-13 skia-flutter-autoroll@skia.org Roll Dart SDK from 4dce1093ad94 to 41234fa4b22d (1 revision) (flutter/engine#42810)
2023-06-13 2539699336@qq.com [iOS][Keyboard] Wait vsync on UI thread and update viewport inset to avoid jitter. (flutter/engine#42312)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

4fe84d7a

Roll Flutter Engine from b6bf3a6f1ccd to 66a5761412f9 (1 revision) (#128813) · 7c9193ce

engine-flutter-autoroll authored Jun 14, 2023

https://github.com/flutter/engine/compare/b6bf3a6f1ccd...66a5761412f9

2023-06-13 34871572+gmackall@users.noreply.github.com Capture additional final inset states in ImeSyncDeferringInsetsCallback (flutter/engine#42700)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

7c9193ce

13 Jun, 2023 10 commits

Fix syntax error in docstring (#128692) · a9f17c87
William Oprandi authored Jun 13, 2023

a9f17c87

Update unit tests in material library for Material 3 (#128725) · a5f8b64e

Qun Cheng authored Jun 13, 2023

Updates most of the unit tests in the packages/flutter/test/material folder so that they'll pass if ThemeData.useMaterial3 defaults to true.

All of the tests have wired useMaterial3 to false and will need to be updated with a M3 version.

related to #127064

a5f8b64e

[flutter_tools] Suppress git output in flutter channel (#128475) · d4995336
Christopher Fujino authored Jun 13, 2023
```
Fixes https://github.com/flutter/flutter/issues/128025
```
d4995336

Fix ensureVisible and default focus traversal for reversed scrollables (#128756) · a0bfde9b

Kate Lovett authored Jun 13, 2023

Fixes https://github.com/flutter/flutter/issues/128749

The ScrollPositionAlignmentPolicy does not account for AxisDirection, which meant default focus traversal of reversed scrollables did not work. The policy doesn't know about the axis direction, so this is corrected in the ScrollPosition where all the information is available before calling on the viewport for the new target scroll offset.

This fixes that by flipping the policy (unless explicit) so that focus traversal works.

a0bfde9b

Roll Flutter Engine from f9a0a0dafeea to b6bf3a6f1ccd (2 revisions) (#128797) · 79bdc6dd

engine-flutter-autoroll authored Jun 13, 2023

https://github.com/flutter/engine/compare/f9a0a0dafeea...b6bf3a6f1ccd

2023-06-13 skia-flutter-autoroll@skia.org Roll ANGLE from 057b8b61b2f2 to 7e075469ff02 (1 revision) (flutter/engine#42809)
2023-06-13 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from r0hMbc7UJwTJkxjbt... to kQbij6Tvqe7F9-PhR... (flutter/engine#42807)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from r0hMbc7UJwTJ to kQbij6Tvqe7F

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

79bdc6dd

Update rest of the unit tests in material library for Material 3 (#128747) · 130749e4
Qun Cheng authored Jun 13, 2023

130749e4
Update tests in material library for Material 3 by default (#128300) · cea728af
Qun Cheng authored Jun 13, 2023

cea728af
Update misc tests for Material3 (#128712) · ce248e87
Hans Muller authored Jun 13, 2023

ce248e87

Roll Packages from c9865e8c63dc to 050729760b25 (6 revisions) (#128796) · 09b7e561

engine-flutter-autoroll authored Jun 13, 2023

https://github.com/flutter/packages/compare/c9865e8c63dc...050729760b25

2023-06-12 49699333+dependabot[bot]@users.noreply.github.com [camera]: Bump com.google.guava:guava from 32.0.0-android to 32.0.1-android in /packages/camera/camera_android_camerax/android (flutter/packages#4195)
2023-06-12 stuartmorgan@google.com [ci] Finish migrating Pigeon tests to LUCI (flutter/packages#3192)
2023-06-12 49699333+dependabot[bot]@users.noreply.github.com [local_auth]: Bump androidx.fragment:fragment from 1.5.7 to 1.6.0 in /packages/local_auth/local_auth_android/android (flutter/packages#4186)
2023-06-12 49699333+dependabot[bot]@users.noreply.github.com [sign_in]: Bump com.google.guava:guava from 32.0.0-android to 32.0.1-android in /packages/google_sign_in/google_sign_in_android/android (flutter/packages#4184)
2023-06-12 hashirshoaeb@gmail.com [go_router] Fixes a bug in `debugLogDiagnostics` to support StatefulShellRoute (flutter/packages#4177)
2023-06-12 engine-flutter-autoroll@skia.org Roll Flutter from 3df163ff to 353b8bc8 (10 revisions) (flutter/packages#4198)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

09b7e561

Roll Flutter Engine from 346f051ac062 to f9a0a0dafeea (1 revision) (#128786) · 4e706975

engine-flutter-autoroll authored Jun 13, 2023

https://github.com/flutter/engine/compare/346f051ac062...f9a0a0dafeea

2023-06-13 skia-flutter-autoroll@skia.org Roll Dart SDK from 7bbe02a4ecc6 to 4dce1093ad94 (1 revision) (flutter/engine#42805)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

4e706975