Commits · f92637d7c4374df5585bab4e032924eb54b0c217 · abdullh.alsoleman / Front-End

20 Jul, 2023 15 commits

Fix chip delete button tap target spilling into the label. (#130896) · f92637d7

Taha Tesser authored Jul 20, 2023

fixes [Chip's delete button tap target is too big](https://github.com/flutter/flutter/issues/129986)

### Description 

This PR fixes the issue where the chip delete button is tappable within the label. 

### Code sample

<details> 
<summary>expand to view the code sample</summary> 

```dart
import 'package:flutter/material.dart';

void main() => runApp(const MyApp());

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      debugShowCheckedModeBanner: false,
      theme: ThemeData(useMaterial3: true),
      home: const Example(),
    );
  }
}

class Example extends StatelessWidget {
  const Example({super.key});

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        title: const Text('Sample'),
      ),
      body: Center(
        child: Chip(
          label: const Text('Really Long Label'),
          onDeleted: () {},
        ),
      ),
    );
  }
}
``` 
	
</details>

### Before

https://github.com/flutter/flutter/assets/48603081/14b369c5-c740-4dfc-a512-779bd3a1a46b

### After

https://github.com/flutter/flutter/assets/48603081/08c6e232-0237-4ab2-9829-66ee8e5cead2

f92637d7

Fix IconButton leaks its internal MaterialStatesController (#130720) · 0aba94f4

Bruno Leroux authored Jul 20, 2023

## Description

This PR adds a call to dispose the internal `MaterialStatesController` instantiated by `_SelectableIconButtonState`.

I found this memory leak while working on M2/M3 test update for `about_test.dart`. This memory leak only happens when using M3 because `IconButton` relies on `_SelectableIconButton` only when useMaterial3 is true:

https://github.com/flutter/flutter/blob/3a1190a5a85c3e6a0cf3a9c30f34548fdd48ac1e/packages/flutter/lib/src/material/icon_button.dart#L671-L721

## Related Issue

Fixes https://github.com/flutter/flutter/issues/130708

## Tests

Adds 1 test.

0aba94f4

Update banner_theme_test.dart for M3 (#130884) · ec508319

Bruno Leroux authored Jul 20, 2023

This PR updates unit tests from banner_theme_test.dart for M3 migration.

More info in https://github.com/flutter/flutter/issues/127064

Just added some `Material`prefixes.

ec508319

Roll Flutter Engine from 204625490ca1 to b494143fb0bc (1 revision) (#130966) · 4cd9fd00

engine-flutter-autoroll authored Jul 20, 2023

https://github.com/flutter/engine/compare/204625490ca1...b494143fb0bc

2023-07-20 skia-flutter-autoroll@skia.org Roll Dart SDK from 368a205aa1d4 to 603aacd8400f (1 revision) (flutter/engine#43843)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

4cd9fd00

Make PollingDeviceDiscovery start the initial poll faster. (#130755) · d1d78bc9
Lau Ching Jun authored Jul 20, 2023
```
This will speed up the initial population of the device list.
```
d1d78bc9

Roll Flutter Engine from c902fec1e3ce to 204625490ca1 (1 revision) (#130962) · 86c8abf8

engine-flutter-autoroll authored Jul 20, 2023

https://github.com/flutter/engine/compare/c902fec1e3ce...204625490ca1

2023-07-20 john@johnmccutchan.com Add a PlatformViewRenderTarget abstraction (flutter/engine#43813)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

86c8abf8

More documentation for MediaQuery and friends (#130509) · a1b13863
Ian Hickson authored Jul 20, 2023
```
Fixes https://github.com/flutter/flutter/issues/11697
```
a1b13863

Roll Flutter Engine from 56e88e8b0eef to c902fec1e3ce (1 revision) (#130960) · 64edc55a

engine-flutter-autoroll authored Jul 20, 2023

https://github.com/flutter/engine/compare/56e88e8b0eef...c902fec1e3ce

2023-07-20 skia-flutter-autoroll@skia.org Roll Dart SDK from 677bbf64d4d7 to 368a205aa1d4 (1 revision) (flutter/engine#43841)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

64edc55a

Automatically create the layer when setting hints in PaintingContext (#130364) · 3a1300e0
Ian Hickson authored Jul 20, 2023
```
Fixes https://github.com/flutter/flutter/issues/92722
```
3a1300e0

Roll Flutter Engine from e2a36be2f084 to 56e88e8b0eef (1 revision) (#130959) · 123413b0

engine-flutter-autoroll authored Jul 20, 2023

https://github.com/flutter/engine/compare/e2a36be2f084...56e88e8b0eef

2023-07-20 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from -SNz0augjLKFVsUWn... to ZwCUlo28olVzLlqTl... (flutter/engine#43839)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from -SNz0augjLKF to ZwCUlo28olVz

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

123413b0

Further clarify Stack documentation on overflowing (#130776) · 17b732bb
Ian Hickson authored Jul 20, 2023
```
Fixes #75731
```
17b732bb

Roll Flutter Engine from eff70f7287f9 to e2a36be2f084 (2 revisions) (#130956) · 3d7f5752

engine-flutter-autoroll authored Jul 20, 2023

https://github.com/flutter/engine/compare/eff70f7287f9...e2a36be2f084

2023-07-19 skia-flutter-autoroll@skia.org Roll ANGLE from 4515b270772e to 5e38a31bd76a (1 revision) (flutter/engine#43836)
2023-07-19 skia-flutter-autoroll@skia.org Roll Skia from 8413c82dea43 to b238c09fe959 (1 revision) (flutter/engine#43835)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

3d7f5752

Can traverse if current focused node skips traversal (#130812) · 4763be74

chunhtai authored Jul 20, 2023

Currently if the focus is on a focusnode that `skipTraversal = true`, the tab won't be able to traverse focus out of the node.

this pr fixes it

4763be74

Document that you can't change initialRoute usefully (#130450) · 9c8ee4fa
Ian Hickson authored Jul 20, 2023
```
Fixes https://github.com/flutter/flutter/issues/12454
```
9c8ee4fa

Roll Flutter Engine from 7671e2f2a9fc to eff70f7287f9 (3 revisions) (#130953) · 28dfd836

engine-flutter-autoroll authored Jul 20, 2023

https://github.com/flutter/engine/compare/7671e2f2a9fc...eff70f7287f9

2023-07-19 skia-flutter-autoroll@skia.org Roll Dart SDK from 936824d49aa7 to 677bbf64d4d7 (1 revision) (flutter/engine#43833)
2023-07-19 flar@google.com Reland "Add non-rendering operation culling to DisplayListBuilder" (#41463) (flutter/engine#43831)
2023-07-19 skia-flutter-autoroll@skia.org Roll Skia from bf75ae2f6eec to 8413c82dea43 (1 revision) (flutter/engine#43832)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

28dfd836

19 Jul, 2023 23 commits

Roll Flutter Engine from 938140a974b0 to 7671e2f2a9fc (3 revisions) (#130948) · 1c569e9c

engine-flutter-autoroll authored Jul 19, 2023

https://github.com/flutter/engine/compare/938140a974b0...7671e2f2a9fc

2023-07-19 skia-flutter-autoroll@skia.org Roll Skia from b1d6eab1f590 to bf75ae2f6eec (2 revisions) (flutter/engine#43829)
2023-07-19 skia-flutter-autoroll@skia.org Roll ANGLE from 4dcaad2a894d to 4515b270772e (2 revisions) (flutter/engine#43830)
2023-07-19 737941+loic-sharma@users.noreply.github.com Add the 'affects: desktop' label to labeler.yml (flutter/engine#43827)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

1c569e9c

Roll Flutter Engine from 0af285219809 to 938140a974b0 (1 revision) (#130943) · 76017e26

engine-flutter-autoroll authored Jul 19, 2023

https://github.com/flutter/engine/compare/0af285219809...938140a974b0

2023-07-19 skia-flutter-autoroll@skia.org Roll Skia from 30d458aea0b9 to b1d6eab1f590 (2 revisions) (flutter/engine#43826)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

76017e26

Add docs to Route.maintainState (#130638) · 10f46489
Ian Hickson authored Jul 19, 2023
```
Fixes https://github.com/flutter/flutter/issues/44836
```
10f46489

Bump github/codeql-action from 2.20.4 to 2.21.0 (#130941) · 910e87eb

dependabot[bot] authored Jul 19, 2023

Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2.20.4 to 2.21.0.
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/github/codeql-action/blob/main/CHANGELOG.md">github/codeql-action's changelog</a>.</em></p>
<blockquote>
<h1>CodeQL Action Changelog</h1>
<p>See the <a href="https://github.com/github/codeql-action/releases">releases page</a> for the relevant changes to the CodeQL CLI and language packs.</p>
<h2>[UNRELEASED]</h2>
<p>No user facing changes.</p>
<h2>2.21.0 - 19 Jul 2023</h2>
<ul>
<li>CodeQL Action now requires CodeQL CLI 2.9.4 or later. For more information, see the corresponding changelog entry for CodeQL Action version 2.20.4. <a href="https://redirect.github.com/github/codeql-action/pull/1724">#1724</a></li>
</ul>
<h2>2.20.4 - 14 Jul 2023</h2>
<ul>
<li>This is the last release of the Action that supports CodeQL CLI versions 2.8.5 to 2.9.3. These versions of the CodeQL CLI were deprecated on June 20, 2023 alongside GitHub Enterprise Server 3.5 and will not be supported by the next release of the CodeQL Action (2.21.0).
<ul>
<li>If you are using one of these versions, please update to CodeQL CLI version 2.9.4 or later. For instance, if you have specified a custom version of the CLI using the 'tools' input to the 'init' Action, you can remove this input to use the default version.</li>
<li>Alternatively, if you want to continue using a version of the CodeQL CLI between 2.8.5 and 2.9.3, you can replace 'github/codeql-action/<em><a href="https://github.com/v2"><code>@âv2</code></a>' by 'github/codeql-action/</em><a href="https://github.com/v2"><code>@âv2</code></a>.20.4' in your code scanning workflow to ensure you continue using this version of the CodeQL Action.</li>
</ul>
</li>
<li>We are rolling out a feature in July 2023 that will slightly reduce the default amount of RAM used for query execution, in proportion to the runner's total memory. This will help to avoid out-of-memory failures on larger runners. <a href="https://redirect.github.com/github/codeql-action/pull/1760">#1760</a></li>
<li>Update default CodeQL bundle version to 2.14.0. <a href="https://redirect.github.com/github/codeql-action/pull/1762">#1762</a></li>
</ul>
<h2>2.20.3 - 06 Jul 2023</h2>
<ul>
<li>Update default CodeQL bundle version to 2.13.5. <a href="https://redirect.github.com/github/codeql-action/pull/1743">#1743</a></li>
</ul>
<h2>2.20.2 - 03 Jul 2023</h2>
<p>No user facing changes.</p>
<h2>2.20.1 - 21 Jun 2023</h2>
<ul>
<li>Update default CodeQL bundle version to 2.13.4. <a href="https://redirect.github.com/github/codeql-action/pull/1721">#1721</a></li>
<li>Experimental: add a new <code>resolve-environment</code> action which attempts to infer a configuration for the build environment that is required to build a given project. Do not use this in production as it is part of an internal experiment and subject to change at any time.</li>
</ul>
<h2>2.20.0 - 13 Jun 2023</h2>
<ul>
<li>Bump the version of the Action to 2.20.0. This ensures that users who received a Dependabot upgrade to <a href="https://github.com/github/codeql-action/commit/cdcdbb579706841c47f7063dda365e292e5cad7a"><code>cdcdbb5</code></a>, which was mistakenly marked as Action version 2.13.4, continue to receive updates to the CodeQL Action. Full details in <a href="https://redirect.github.com/github/codeql-action/pull/1729">#1729</a></li>
</ul>
<h2>2.3.6 - 01 Jun 2023</h2>
<ul>
<li>Update default CodeQL bundle version to 2.13.3. <a href="https://redirect.github.com/github/codeql-action/pull/1698">#1698</a></li>
</ul>
<h2>2.3.5 - 25 May 2023</h2>
<ul>
<li>Allow invalid URIs to be used as values to <code>artifactLocation.uri</code> properties. This reverses a change from <a href="https://redirect.github.com/github/codeql-action/pull/1668">#1668</a> that inadvertently led to stricter validation of some URI values. <a href="https://redirect.github.com/github/codeql-action/pull/1705">#1705</a></li>
<li>Gracefully handle invalid URIs when fingerprinting. <a href="https://redirect.github.com/github/codeql-action/pull/1694">#1694</a></li>
</ul>
<h2>2.3.4 - 24 May 2023</h2>
<ul>
<li>Updated the SARIF 2.1.0 JSON schema file to the latest from <a href="https://github.com/oasis-tcs/sarif-spec/blob/123e95847b13fbdd4cbe2120fa5e33355d4a042b/Schemata/sarif-schema-2.1.0.json">oasis-tcs/sarif-spec</a>. <a href="https://redirect.github.com/github/codeql-action/pull/1668">#1668</a></li>
<li>We are rolling out a feature in May 2023 that will disable Python dependency installation for new users of the CodeQL Action. This improves the speed of analysis while having only a very minor impact on results. <a href="https://redirect.github.com/github/codeql-action/pull/1676">#1676</a></li>
</ul>
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/github/codeql-action/commit/1813ca74c3faaa3a2da2070b9b8a0b3e7373a0d8"><code>1813ca7</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/1791">#1791</a> from github/update-v2.21.0-6ae46f7a9</li>
<li><a href="https://github.com/github/codeql-action/commit/684354087657f9de21799430ad93dbce751693fe"><code>6843540</code></a> Update changelog for v2.21.0</li>
<li><a href="https://github.com/github/codeql-action/commit/6ae46f7a92375136e54d98f1562e956ac595c7fc"><code>6ae46f7</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/1790">#1790</a> from github/henrymercer/aborted-user-error</li>
<li><a href="https://github.com/github/codeql-action/commit/0cae69e06273f42be35cb7080491d9f0a3ff62cf"><code>0cae69e</code></a> Report user errors in the abort stage appropriately</li>
<li><a href="https://github.com/github/codeql-action/commit/d2ed0a05b63da98c856e847eb1a2c07256508499"><code>d2ed0a0</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/1786">#1786</a> from github/dependabot/npm_and_yarn/npm-0a410f26d2</li>
<li><a href="https://github.com/github/codeql-action/commit/651d09131ae0a806606194b9be1ce5dd31548fa1"><code>651d091</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/1788">#1788</a> from github/henrymercer/fix-feature-flag-usage</li>
<li><a href="https://github.com/github/codeql-action/commit/e0f0892f83e1a0cc3252d7670b6f39a0c7b1ebb4"><code>e0f0892</code></a> Add tests for new analysis summary feature flag</li>
<li><a href="https://github.com/github/codeql-action/commit/27d3b2f85746a6ddec4aeadb033c7ebfc6465bdf"><code>27d3b2f</code></a> Fix scaling reserved RAM feature flag naming</li>
<li><a href="https://github.com/github/codeql-action/commit/da4e0a06c0f04ff404830612058d9e7477fabbf2"><code>da4e0a0</code></a> Fix CodeQL version checks</li>
<li><a href="https://github.com/github/codeql-action/commit/e266801e21b8b911929eb77e4c8493192846b843"><code>e266801</code></a> Update checked-in dependencies</li>
<li>Additional commits viewable in <a href="https://github.com/github/codeql-action/compare/489225d82a57396c6f426a40e66d461b16b3461d...1813ca74c3faaa3a2da2070b9b8a0b3e7373a0d8">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=github/codeql-action&package-manager=github_actions&previous-version=2.20.4&new-version=2.21.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

910e87eb

Add menu dismiss localization (#128613) · 258382c5

Greg Spencer authored Jul 19, 2023

## Description

Modifies the semantic label for popup and context menus to be "Dismiss menu" instead of just "Dismiss".

## Related Issues
 - Fixes https://github.com/flutter/flutter/issues/118994

## Tests
 - Updated tests

258382c5

Add implementation advice to debugTypicalAncestorWidgetClass (#130530) · 07cdf37c
Ian Hickson authored Jul 19, 2023
```
Fixes https://github.com/flutter/flutter/issues/56500
```
07cdf37c

Roll Flutter Engine from 6ea54eee0592 to 0af285219809 (4 revisions) (#130939) · 6cabe736

engine-flutter-autoroll authored Jul 19, 2023

https://github.com/flutter/engine/compare/6ea54eee0592...0af285219809

2023-07-19 skia-flutter-autoroll@skia.org Roll Skia from 650c980daa72 to 30d458aea0b9 (1 revision) (flutter/engine#43825)
2023-07-19 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from Iqf3gYJ8Vkq8k8l3O... to 7kGBjmX-zBXcg1svE... (flutter/engine#43823)
2023-07-19 flar@google.com fix handling of clipped rendering inside a layer that applies a filter (flutter/engine#43787)
2023-07-19 skia-flutter-autoroll@skia.org Roll Skia from 8d19d04472e1 to 650c980daa72 (6 revisions) (flutter/engine#43821)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from Iqf3gYJ8Vkq8 to 7kGBjmX-zBXc

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

6cabe736

Add support for M3 motion (#129942) · 0830a362

Pierre-Louis authored Jul 19, 2023

## Description

This adds support for M3 easing and duration tokens.

This PR includes these changes:
* Generation of duration and easing constants, in `Durations` and
`Easing`, respectively (`Curves` is already taken in the `animation`
library)
* Add 3 Dart fixes

Once this is merged, I'll migrate packages/plugins/customers and then
uncomment the deprecation notices for the 3 M2 curves, all of which have
1:1 replacements.

## Related Issues
 - Fixes https://github.com/flutter/flutter/issues/116525

## Tests
 - Added Dart fix tests

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat

0830a362

Roll Flutter Engine from 2fab8ab5ff7f to 6ea54eee0592 (2 revisions) (#130929) · b54e83e4

engine-flutter-autoroll authored Jul 19, 2023

https://github.com/flutter/engine/compare/2fab8ab5ff7f...6ea54eee0592

2023-07-19 skia-flutter-autoroll@skia.org Roll Dart SDK from a013e7bf089e to 936824d49aa7 (1 revision) (flutter/engine#43820)
2023-07-19 skia-flutter-autoroll@skia.org Roll Skia from a352521a3a7c to 8d19d04472e1 (1 revision) (flutter/engine#43818)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

b54e83e4

Roll Flutter Engine from 4b274b5c2c3a to 2fab8ab5ff7f (2 revisions) (#130920) · 8d3a5cf1

engine-flutter-autoroll authored Jul 19, 2023

https://github.com/flutter/engine/compare/4b274b5c2c3a...2fab8ab5ff7f

2023-07-19 skia-flutter-autoroll@skia.org Roll Skia from 4728980564b1 to a352521a3a7c (3 revisions) (flutter/engine#43816)
2023-07-19 bdero@google.com [Impeller] Disable color attachment on clip pipelines for Metal & Vulkan. (flutter/engine#43781)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

8d3a5cf1

Roll Flutter Engine from 9645d8e27b59 to 4b274b5c2c3a (3 revisions) (#130903) · ffa59533

engine-flutter-autoroll authored Jul 19, 2023

https://github.com/flutter/engine/compare/9645d8e27b59...4b274b5c2c3a

2023-07-19 skia-flutter-autoroll@skia.org Roll Skia from 16475d7aa315 to 4728980564b1 (1 revision) (flutter/engine#43815)
2023-07-19 jason-simmons@users.noreply.github.com Apply the offset to the child bounds of an ImageFilterLayer with no filter (flutter/engine#43783)
2023-07-19 skia-flutter-autoroll@skia.org Roll Skia from 1f175b7a2155 to 16475d7aa315 (1 revision) (flutter/engine#43812)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

ffa59533

Fix contradictory advice in "detach" docs; cut redundancy in "attach" (#130688) · f0039119

Greg Price authored Jul 19, 2023

Fixes #115525.

On [AbstractNode.detach] and its two progeny [RenderNode.detach]
and [Layer.detach], the docs said both to call the inherited method
before detaching children, and to end by doing so.  The former
advice is what's enforced by an assertion in the base implementation,
so cut out the other.

The corresponding [attach] methods redundantly said twice to
call the inherited method first, so cut the redundancy.
Leave in place the version more recently added (in #76021), because
that PR shows the old version must have been easy to overlook.

f0039119

Roll Flutter Engine from 076bd7b81d9c to 9645d8e27b59 (1 revision) (#130895) · ef43463c

engine-flutter-autoroll authored Jul 19, 2023

https://github.com/flutter/engine/compare/076bd7b81d9c...9645d8e27b59

2023-07-19 skia-flutter-autoroll@skia.org Roll Skia from e9409b832799 to 1f175b7a2155 (1 revision) (flutter/engine#43811)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

ef43463c

Roll Packages from 3e8b8130cda3 to 209db219ad73 (8 revisions) (#130894) · 56619889

engine-flutter-autoroll authored Jul 19, 2023

https://github.com/flutter/packages/compare/3e8b8130cda3...209db219ad73

2023-07-19 reidbaker@google.com [tooling] mark infra steps as infra steps in yaml files (flutter/packages#4473)
2023-07-19 engine-flutter-autoroll@skia.org Manual roll Flutter from f842ed91 to 6f09064e (11 revisions) (flutter/packages#4518)
2023-07-19 stuartmorgan@google.com [ci] Enable new sharding (flutter/packages#4515)
2023-07-19 stuartmorgan@google.com [flutter_markdown] Change the way tests get screen size (flutter/packages#4514)
2023-07-18 stuartmorgan@google.com [ci] Roll Flutter to f842ed91 (flutter/packages#4513)
2023-07-18 stuartmorgan@google.com [image_picker] Update Android example (flutter/packages#4504)
2023-07-18 43054281+camsim99@users.noreply.github.com [camerax] Fixes relistening to `onStreamedFrameAvailable`'s stream behavior (flutter/packages#4511)
2023-07-18 43054281+camsim99@users.noreply.github.com [various] Deletes deprecated splash screen meta-data element (flutter/packages#4501)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

56619889

Mark Windows_android channels_integration_test_win flaky (#130893) · 3b0b670d
Zachary Anderson authored Jul 19, 2023
```
For https://github.com/flutter/flutter/issues/130732
```
3b0b670d

Roll Flutter Engine from eb2285205f25 to 076bd7b81d9c (2 revisions) (#130891) · 305c36f3

engine-flutter-autoroll authored Jul 19, 2023

https://github.com/flutter/engine/compare/eb2285205f25...076bd7b81d9c

2023-07-19 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from ZABO4Om1vToxhI394... to -SNz0augjLKFVsUWn... (flutter/engine#43810)
2023-07-19 kjlubick@users.noreply.github.com Update legacy call to SkImage::makeSubset (flutter/engine#43786)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from ZABO4Om1vTox to -SNz0augjLKF

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

305c36f3

Roll Flutter Engine from 09389b16d684 to eb2285205f25 (3 revisions) (#130879) · d07e8aec

engine-flutter-autoroll authored Jul 19, 2023

https://github.com/flutter/engine/compare/09389b16d684...eb2285205f25

2023-07-19 skia-flutter-autoroll@skia.org Roll ANGLE from 255dec886475 to 4dcaad2a894d (1 revision) (flutter/engine#43809)
2023-07-19 skia-flutter-autoroll@skia.org Roll Skia from c03050eb2b65 to e9409b832799 (1 revision) (flutter/engine#43808)
2023-07-19 skia-flutter-autoroll@skia.org Roll Dart SDK from 9f5e86b4c108 to a013e7bf089e (1 revision) (flutter/engine#43805)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

d07e8aec

Roll Flutter Engine from 0293a7cb7887 to 09389b16d684 (5 revisions) (#130867) · 37ed50ac

engine-flutter-autoroll authored Jul 19, 2023

https://github.com/flutter/engine/compare/0293a7cb7887...09389b16d684

2023-07-19 skia-flutter-autoroll@skia.org Roll ANGLE from b32d661389a6 to 255dec886475 (1 revision) (flutter/engine#43804)
2023-07-19 jason-simmons@users.noreply.github.com Fix the rules for determining whether a blur image filter is valid (flutter/engine#43791)
2023-07-19 skia-flutter-autoroll@skia.org Roll Skia from 035b12a03918 to c03050eb2b65 (1 revision) (flutter/engine#43802)
2023-07-19 skia-flutter-autoroll@skia.org Roll Skia from 9062ca6a691c to 035b12a03918 (3 revisions) (flutter/engine#43801)
2023-07-19 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from SCshjyIlymHWD9W4D... to Iqf3gYJ8Vkq8k8l3O... (flutter/engine#43800)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from SCshjyIlymHW to Iqf3gYJ8Vkq8

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

37ed50ac

Move TapAndDragGestureRecognizer code under gestures (#119508) · e4e9dde4
Tomasz Gucio authored Jul 19, 2023

e4e9dde4

Roll Flutter Engine from 29de67c7d009 to 0293a7cb7887 (1 revision) (#130858) · 3213588c

engine-flutter-autoroll authored Jul 19, 2023

https://github.com/flutter/engine/compare/29de67c7d009...0293a7cb7887

2023-07-19 skia-flutter-autoroll@skia.org Roll Skia from caf0d191bd07 to 9062ca6a691c (1 revision) (flutter/engine#43799)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

3213588c

Roll Flutter Engine from 39d60be72ffb to 29de67c7d009 (4 revisions) (#130855) · a417a699

engine-flutter-autoroll authored Jul 19, 2023

https://github.com/flutter/engine/compare/39d60be72ffb...29de67c7d009

2023-07-19 skia-flutter-autoroll@skia.org Roll Dart SDK from c184cac2d22f to 9f5e86b4c108 (1 revision) (flutter/engine#43798)
2023-07-19 skia-flutter-autoroll@skia.org Roll Skia from d1d2b623799e to caf0d191bd07 (1 revision) (flutter/engine#43797)
2023-07-19 skia-flutter-autoroll@skia.org Roll ANGLE from 6eea5ff4db82 to b32d661389a6 (1 revision) (flutter/engine#43796)
2023-07-19 skia-flutter-autoroll@skia.org Roll Skia from 280fb8391187 to d1d2b623799e (1 revision) (flutter/engine#43795)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

a417a699

Roll Flutter Engine from b3bfc744bb61 to 39d60be72ffb (1 revision) (#130847) · 33d174d7

engine-flutter-autoroll authored Jul 19, 2023

https://github.com/flutter/engine/compare/b3bfc744bb61...39d60be72ffb

2023-07-19 skia-flutter-autoroll@skia.org Roll Dart SDK from ec95774043ec to c184cac2d22f (1 revision) (flutter/engine#43794)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

33d174d7

Roll Flutter Engine from adf6142f6738 to b3bfc744bb61 (7 revisions) (#130843) · 504c68ae

engine-flutter-autoroll authored Jul 19, 2023

https://github.com/flutter/engine/compare/adf6142f6738...b3bfc744bb61

2023-07-18 zanderso@users.noreply.github.com Increase engine v2 orchestrator timeouts (flutter/engine#43788)
2023-07-18 skia-flutter-autoroll@skia.org Roll Skia from dcc56df202cc to 280fb8391187 (1 revision) (flutter/engine#43793)
2023-07-18 zanderso@users.noreply.github.com Remove obsolete legacy engine builds from staging (flutter/engine#43790)
2023-07-18 skia-flutter-autoroll@skia.org Roll ANGLE from 52fe3116ead9 to 6eea5ff4db82 (1 revision) (flutter/engine#43789)
2023-07-18 bdero@google.com [Impeller] Fix GL_NUM_EXTENSIONS check for desktop GL (flutter/engine#43785)
2023-07-18 skia-flutter-autoroll@skia.org Roll Skia from 9a0f6d82a6f5 to dcc56df202cc (1 revision) (flutter/engine#43784)
2023-07-18 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from ixKM7wyMrqmPDaQ11... to ZABO4Om1vToxhI394... (flutter/engine#43782)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from ixKM7wyMrqmP to ZABO4Om1vTox

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

504c68ae

18 Jul, 2023 2 commits

Update app_builder_test.dart for M3 (#130794) · a4af12f4

Bruno Leroux authored Jul 18, 2023

This PR updates unit tests from app_builder_test.dart for M3 migration.

More info in https://github.com/flutter/flutter/issues/127064

In this particular case, I choose to make the tests Material-agnostic by removing the color theming which was not meaningful to what is tested here.

a4af12f4

Catch errors in loadStructuredData (#130748) · d2110922
Ian Hickson authored Jul 18, 2023
```
Fixes https://github.com/flutter/flutter/issues/42390
```
d2110922