• Greg Price's avatar
    Fix contradictory advice in "detach" docs; cut redundancy in "attach" (#130688) · f0039119
    Greg Price authored
    Fixes #115525.
    
    On [AbstractNode.detach] and its two progeny [RenderNode.detach]
    and [Layer.detach], the docs said both to call the inherited method
    before detaching children, and to end by doing so.  The former
    advice is what's enforced by an assertion in the base implementation,
    so cut out the other.
    
    The corresponding [attach] methods redundantly said twice to
    call the inherited method first, so cut the redundancy.
    Leave in place the version more recently added (in #76021), because
    that PR shows the old version must have been easy to overlook.
    f0039119
Name
Last commit
Last update
.github Loading commit data...
.vscode Loading commit data...
bin Loading commit data...
dev Loading commit data...
examples Loading commit data...
packages Loading commit data...
.ci.yaml Loading commit data...
.cirrus.yml Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
AUTHORS Loading commit data...
CODEOWNERS Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
CONTRIBUTING.md Loading commit data...
LICENSE Loading commit data...
PATENT_GRANT Loading commit data...
README.md Loading commit data...
TESTOWNERS Loading commit data...
analysis_options.yaml Loading commit data...
dartdoc_options.yaml Loading commit data...
flutter_console.bat Loading commit data...