- 20 Nov, 2019 1 commit
-
-
Ian Hickson authored
-
- 18 Nov, 2019 1 commit
-
-
Greg Spencer authored
This adds support for the command key for text selection/editing on macOS. I had ported the text editing code (in #42879), but forgot to add support for the command key itself. This also adds a test that tests the text editing on multiple platforms instead of just testing Android. There appears to still be a bug (filed #44135) where we're losing key events sometimes on macOS, leaving some keys "stuck" on, but this PR at least allows the right key combinations to be used.
-
- 16 Nov, 2019 1 commit
-
-
Ian Hickson authored
-
- 15 Nov, 2019 1 commit
-
-
LongCatIsLooong authored
Revert "Implement PageView using SliverLayoutBuilder, Deprecate RenderSliverFillViewport (#37024)" (#44778) * Revert "Implement PageView using SliverLayoutBuilder, Deprecate RenderSliverFillViewport (#37024)" This reverts commit 9aea03f4.
-
- 14 Nov, 2019 1 commit
-
-
Ian Hickson authored
-
- 13 Nov, 2019 1 commit
-
-
Tong Mu authored
* Add opaque to barriers * Detect opaque and test
-
- 11 Nov, 2019 1 commit
-
-
Mouad Debbar authored
-
- 05 Nov, 2019 1 commit
-
-
Kate Lovett authored
SliverAppBar - Configurable overscroll stretch with callback feature & FlexibleSpaceBar support (#42250)
-
- 28 Oct, 2019 1 commit
-
-
Albertus Angga Raharja authored
* Add structured errors in Animations, TabView, ChangeNotifier * Add structured error on MaterialPageRoute, BoxBorder, DecorationImagePainter, TextSpan * Add structured errors in Debug * Fix test errors * Add structured errors in Scaffold and Stepper * Add structured errors in part of Rendering Layer * Fix failing test due to FloatingPoint precision * Fix failing tests due to precision error and not using final * Fix failing test due to floating precision error with RegEx instead * Add structured error in CustomLayout and increase test coverage * Add structured error & its test in ListBody * Add structured error in ProxyBox and increase test coverage * Add structured error message in Viewport * Fix styles and add more assertions on ErrorHint and DiagnosticProperty * Add structured error in scheduler/binding and scheduler/ticker Signed-off-by:
Albertus Angga Raharja <albertusangga@google.com> * Add structured error in AssetBundle and TextInput Signed-off-by:
Albertus Angga Raharja <albertusangga@google.com> * Add structured errors in several widgets #1 Signed-off-by:
Albertus Angga Raharja <albertusangga@google.com> * Remove unused import Signed-off-by:
Albertus Angga Raharja <albertusangga@google.com> * Add assertions on hint messages Signed-off-by:
Albertus Angga Raharja <albertusangga@google.com> * Fix catch spacing Signed-off-by:
Albertus Angga Raharja <albertusangga@google.com> * Add structured error in several widgets part 2 and increase code coverage Signed-off-by:
Albertus Angga Raharja <albertusangga@google.com> * Add structured error in flutter_test/widget_tester * Fix floating precision accuracy by using RegExp Signed-off-by:
Albertus Angga Raharja <albertusangga@google.com> * Remove todo to add tests in Scaffold showBottomSheet Signed-off-by:
Albertus Angga Raharja <albertusangga@google.com> * Fix reviews by indenting lines and fixing the assertion orders Signed-off-by:
Albertus Angga Raharja <albertusangga@google.com> * Fix failing tests due to renaming class Signed-off-by:
Albertus Angga Raharja <albertusangga@google.com> * Try skipping the NetworkBundleTest Signed-off-by:
Albertus Angga Raharja <albertusangga@google.com> * Remove leading space in material/debug error hint Signed-off-by:
Albertus Angga Raharja <albertusangga@google.com>
-
- 18 Oct, 2019 1 commit
-
-
Tong Mu authored
* Replace hard break of Layer.find/All with findAllAnnotations * Deprecate findAll
-
- 17 Oct, 2019 2 commits
-
-
Jaumard authored
-
Greg Spencer authored
This re-implements keyboard text selection so that it will work on platforms other than Android (e.g. macOS, Linux, etc.). Also, fixed a number of bugs in editing selection via a hardware keyboard (unable to select backwards, incorrect conversion to ASCII when cutting to clipboard, lack of support for CTRL-SHIFT-ARROW word selection, etc.). Did not address the keyboard locale issues that remain, or add platform specific switches for the bindings. All that will need some more design work before implementing them. Related Issues Fixes #31951
-
- 15 Oct, 2019 2 commits
-
-
Jason Simmons authored
The _computeChildren[Width/Height]With[Min/Max]Intrinsics methods in RenderParagraph overwrite the text painter's placeholder dimensions in order to compute potential widths and heights for the paragraph. The placeholder dimensions should be restored to the values computed by _layoutChildren before painting the text.
-
Shi-Hao Hong authored
-
- 10 Oct, 2019 1 commit
-
-
Tong Mu authored
* Adds a new parameter bool opaque to MouseRegion * The same to RenderMouseRegion and AnnotatedRegionLayer * Add findAnnotations to Layer
-
- 09 Oct, 2019 2 commits
-
-
Greg Spencer authored
This adds a Semantics node to the Focus and FocusScope widgets, setting the focused and focusable attributes so that the accessibility subsystem can be told when a control has the input focus. Includes an engine roll to flutter/engine@77252d2, and the following 8 engine changes: flutter/engine@77252d2 Greg Spencer Add missing focusable testing info (flutter/engine#13013) flutter/engine@0e42a29 skia-flutter-.. Roll src/third_party/skia 54548626a977..e27a503a0a21 (1 commits) (flutter/engine#13024) flutter/engine@6b56ed7 gaaclarke Refactor: FlutterDartProject (flutter/engine#13006) flutter/engine@393480c skia-flutter-.. Roll src/third_party/skia 77dde599c98a..54548626a977 (1 commits) (flutter/engine#13023) flutter/engine@080b89d skia-flutter-.. Roll src/third_party/skia 2b1a25a4d324..77dde599c98a (1 commits) (flutter/engine#13021) flutter/engine@90b0f30 Ben Konyi Roll src/third_party/dart f4a72bfc64..bb04f145b2 (18 commits) (flutter/engine#13020) flutter/engine@049fb89 skia-flutter-.. Roll fuchsia/sdk/core/linux-amd64 from q_uYX... to cknsi... (flutter/engine#13019) flutter/engine@6925b2a skia-flutter-.. Roll fuchsia/sdk/core/mac-amd64 from wuAtw... to u0JpE... (flutter/engine#13018) Related Issues Addresses #40101 Landing on red in order to fix the build: it's red because of the needed engine roll.
-
Kate Lovett authored
-
- 08 Oct, 2019 1 commit
-
-
Kate Lovett authored
-
- 02 Oct, 2019 1 commit
-
-
Gary Qian authored
-
- 30 Sep, 2019 1 commit
-
-
Alexandre Ardhuin authored
* add missing trailing commas * add more missing trailing commas * add more and more missing trailing commas
-
- 28 Sep, 2019 1 commit
-
-
LongCatIsLooong authored
-
- 27 Sep, 2019 1 commit
-
-
LongCatIsLooong authored
-
- 26 Sep, 2019 1 commit
-
-
Greg Spencer authored
This fixes the mouse hover code to not schedule frames with every mouse move. Before this, it would schedule a post frame callback, and then schedule a frame immediately, even if there was nothing that needed to be updated. Now it will schedule checks for mouse position updates synchronously, unless there's a new annotation, and skip scheduling a new frame in all cases. It has to be async in the case of a new annotation (i.e. a new MouseRegion is added), since when the annotation is added, it hasn't yet painted, and it can't hit test against the new layer until after the paint, so in that case it schedules a post frame callback, but since it's already building a frame when it does that, it doesn't need to schedule a frame. The code also used to do mouse position checks for all mice if only one mouse changed position. I fixed this part too, so that it will only check position for the mouse that changed.
-
- 24 Sep, 2019 3 commits
-
-
chunhtai authored
* Implement system fonts system channel listener
-
Alexandre Ardhuin authored
-
Alexandre Ardhuin authored
-
- 19 Sep, 2019 1 commit
-
-
chunhtai authored
* Fixed Selectable text align is broken
-
- 18 Sep, 2019 1 commit
-
-
Michael Goderbauer authored
-
- 17 Sep, 2019 3 commits
-
-
Michael Goderbauer authored
This reverts commit 6ad88bd5.
-
Michael Goderbauer authored
-
Alexandre Ardhuin authored
-
- 16 Sep, 2019 1 commit
-
-
Simon Lightfoot authored
-
- 10 Sep, 2019 1 commit
-
-
Peter Lee authored
-
- 06 Sep, 2019 1 commit
-
-
Michael Goderbauer authored
-
- 03 Sep, 2019 2 commits
-
-
chunhtai authored
fix sliverfixedextent with sliverchildbuilderdelegate does not correct calculate max scroll extent (#39142)
-
Tom Robinson authored
-
- 29 Aug, 2019 1 commit
-
-
Tong Mu authored
* Add FlagsSummary and implement Listener
-
- 26 Aug, 2019 1 commit
-
-
Tom Robinson authored
Change SliverGeometry.maxScrollObstructionExtent for RenderSliverFloatingPersistentHeader to match docs (#39263) RenderSliverFloatingPersistentHeader does not pin to the leading edge of the viewport so the value of maxScrollObstructionExtent in it's SliverGeometry should be 0 per the docs at https://api.flutter.dev/flutter/rendering/SliverGeometry/maxScrollObstructionExtent.html.
-
- 23 Aug, 2019 1 commit
-
-
Greg Spencer authored
I noticed that we were pretty inconsistent with the way that we checked the value of clipBehavior in the framework, so I normalized the usages and updated docs where necessary. This is a breaking change if you used to pass null explicitly to FlatButton, OutlineButton or RaisedButton constructors, expecting to get Clip.none. It will now assert if you do that. Existing implementations that pass null implicitly by not specifying clipBehavior won't need to change their call sites. It always implicitly defaulted to Clip.none before, and it will continue to do that, it's only places where it was explicitly set to null in order to get the implicit default that it will fail.
-
- 21 Aug, 2019 1 commit
-
-
LongCatIsLooong authored
-