- 27 Sep, 2019 2 commits
-
-
Alexandre Ardhuin authored
-
Hans Muller authored
This reverts commit e47a1dc2.
-
- 26 Sep, 2019 3 commits
-
-
Greg Spencer authored
The proposed change will change focus handling when pushing and popping routes so that the FocusScopeNode for the route receives focus when pushed, and that the FocusScopeNode in the navigator receives focus when the route is popped. This means that the last setFirstFocus call on the scope is used to determine which control actually receives focus. When the focus scope receives focus, it traverses its children, trying to find a non-scope node that is the "first focus" of itself or a child node. This is a breaking change, because the focus behavior has changed. If you push a route after this change, and had a 'first focus' set on a widget via FocusScopeNode.setFirstFocus, it won't currently receive focus immediately, but after this change it will. Similarly, if you pop a route after this change, the focus will go back to where it was before the route was pushed, which is correct, but different from what happens now.
-
Greg Spencer authored
This fixes the mouse hover code to not schedule frames with every mouse move. Before this, it would schedule a post frame callback, and then schedule a frame immediately, even if there was nothing that needed to be updated. Now it will schedule checks for mouse position updates synchronously, unless there's a new annotation, and skip scheduling a new frame in all cases. It has to be async in the case of a new annotation (i.e. a new MouseRegion is added), since when the annotation is added, it hasn't yet painted, and it can't hit test against the new layer until after the paint, so in that case it schedules a post frame callback, but since it's already building a frame when it does that, it doesn't need to schedule a frame. The code also used to do mouse position checks for all mice if only one mouse changed position. I fixed this part too, so that it will only check position for the mouse that changed.
-
Hans Muller authored
-
- 24 Sep, 2019 5 commits
-
-
imzyy authored
-
Hans Muller authored
-
Alexandre Ardhuin authored
-
Greg Spencer authored
There were four or five different implementations in various tests for sendFakeKeyEvent, which roughly all did the same thing. I was going to add yet another one, and decided that it needed to be generalized and centralized. This replaces those instances with something that just takes a LogicalKeyboardKey so that it's self-documenting, and can be used with multiple platforms. This adds two functions to widget tester: sendKeyDownEvent and sendKeyUpEvent which simulate key up/down from a physical keyboard. It also adds global functions simulateKeyDownEvent and simulateKeyUpEvent that can be called without a widget tester. All are async functions protected by the async guard.
-
Alexandre Ardhuin authored
-
- 18 Sep, 2019 1 commit
-
-
Michael Goderbauer authored
-
- 17 Sep, 2019 6 commits
-
-
Michael Goderbauer authored
This reverts commit 6ad88bd5.
-
Michael Goderbauer authored
-
Anthony authored
Add the option to configure a chip check mark color
-
xster authored
-
Hans Muller authored
-
Alexandre Ardhuin authored
-
- 16 Sep, 2019 1 commit
-
-
Hans Muller authored
-
- 14 Sep, 2019 1 commit
-
-
Shi-Hao Hong authored
* Implement DropdownButton.selectedItemBuilder
-
- 13 Sep, 2019 2 commits
-
-
Michael Goderbauer authored
-
Shi-Hao Hong authored
* Add constraints property, updated default constraints for ToggleButtons to 48x48 * Add kMinInteractiveDimension constant to ToggleButtons
-
- 10 Sep, 2019 3 commits
-
-
Greg Spencer authored
Fixed passing autofocus to MaterialButton, and when rebuilding Focus widget, and added a test for Focus and MaterialButton to test that it works properly.
-
Sarbagya Dhaubanjar authored
* Added properties in DropdownFormField to match DropdownButton * Minor style guide related changes
-
Slade Capasso authored
-
- 06 Sep, 2019 1 commit
-
-
lisa-liao authored
-
- 05 Sep, 2019 2 commits
-
-
Shi-Hao Hong authored
* Improve finders throughout toggle_buttons_test.dart * Improve Material finders * Update toggle_buttons_theme_test.dart finders to be more precise * Refactor out textStyle and iconTheme finders * Refactor iconTheme and buttonTextTheme logic
-
- 04 Sep, 2019 2 commits
-
-
rami-a authored
-
Greg Spencer authored
* Automatic focus highlight mode for FocusManager This re-lands the highlight mode change. * Review Changes
-
- 03 Sep, 2019 2 commits
-
-
Greg Spencer authored
This changes the behavior of text fields, Material buttons, and Chips so that if they are disabled they lose focus. Before this change, it was possible to disable a control and then use focus traversal to reach it anyhow, and in the case of text fields, enter text into a disabled field. Fixes #33985
-
rami-a authored
-
- 02 Sep, 2019 1 commit
-
-
Anthony authored
Use the entire appBarTheme from the showSearch delegate for the search pages appBar theme, rather than just a select set of fields.
-
- 28 Aug, 2019 3 commits
-
-
Jonah Williams authored
This reverts commit ddd31bce.
-
Ian Hickson authored
-
Justin McCandless authored
-
- 26 Aug, 2019 1 commit
-
-
Hans Muller authored
* Co-authored-by: Brett Morgan <brettmorgan@google.com>
-
- 23 Aug, 2019 1 commit
-
-
Greg Spencer authored
I noticed that we were pretty inconsistent with the way that we checked the value of clipBehavior in the framework, so I normalized the usages and updated docs where necessary. This is a breaking change if you used to pass null explicitly to FlatButton, OutlineButton or RaisedButton constructors, expecting to get Clip.none. It will now assert if you do that. Existing implementations that pass null implicitly by not specifying clipBehavior won't need to change their call sites. It always implicitly defaulted to Clip.none before, and it will continue to do that, it's only places where it was explicitly set to null in order to get the implicit default that it will fail.
-
- 22 Aug, 2019 1 commit
-
-
lisa-liao authored
BottomSheetThemeData has an additional field modalElevation which makes it possible to set different elevations between persistent and modal bottom sheets.
-
- 21 Aug, 2019 2 commits
-
-
Hans Muller authored