- 11 Dec, 2023 1 commit
-
-
Greg Spencer authored
## Description This starts the deprecation of the `RawKeyEvent`/`RawKeyboard` event system that has been replaced by the `KeyEvent`/`HardwareKeyboard` event system. Migration guide is available here: https://docs.flutter.dev/release/breaking-changes/key-event-migration ## Related Issues - https://github.com/flutter/flutter/issues/136419 ## Related PRs - https://github.com/flutter/website/pull/9889
-
- 19 Oct, 2023 2 commits
-
-
Greg Spencer authored
-
auto-submit[bot] authored
Reverts flutter/flutter#136771 Initiated by: gspencergoog This change reverts the following previous change: Original Description: ## Description This adds code to make sure that grandchildren are removed from the `focusedChild` of a scope when the child is detached. ## Related Issues - Fixes https://github.com/flutter/flutter/issues/136758 ## Tests - Added regression test.
-
- 18 Oct, 2023 1 commit
-
-
Greg Spencer authored
## Description This adds code to make sure that grandchildren are removed from the `focusedChild` of a scope when the child is detached. ## Related Issues - Fixes https://github.com/flutter/flutter/issues/136758 ## Tests - Added regression test.
-
- 10 Oct, 2023 1 commit
-
-
Greg Spencer authored
## Description This adds a mechanism for listening to key events before or after focus traversal occurs. It adds four methods to the public `FocusManager` API: - `addEarlyKeyEventHandler` - Adds a handler that can handle events before they are given to the focus tree for handling. - `removeEarlyKeyEventHandler` - Removes an early event handler. - `addLateKeyEventHandler` - Adds a handler that can handle events if they have not been handled by anything in the focus tree. - `removeLateKeyEventHandler` - Removes a late event handler. This allows an app to get notified for a key anywhere, and prevent the focus tree from seeing that event if it handles it. For the menu system, this allows it to eat an escape key press and close all the open menus. ## Related Issues - https://github.com/flutter/flutter/issues/135334 ## Tests - Added tests for new functionality.
-
- 20 Sep, 2023 1 commit
-
-
Greg Spencer authored
## Description This removes all of the comments that are of the form "so-and-so (must not be null|can ?not be null|must be non-null)" from the cases where those values are defines as non-nullable values. This PR removes them from the widgets library. This was done by hand, since it really didn't lend itself to scripting, so it needs to be more than just spot-checked, I think. I was careful to leave any comment that referred to parameters that were nullable, but I may have missed some. In addition to being no longer relevant after null safety has been made the default, these comments were largely fragile, in that it was easy for them to get out of date, and not be accurate anymore anyhow. This did create a number of constructor comments which basically say "Creates a [Foo].", but I don't really know how to avoid that in a large scale change, since there's not much you can really say in a lot of cases. I think we might consider some leniency for constructors to the "Comment must be meaningful" style guidance (which we de facto have already, since there are a bunch of these). ## Related PRs - https://github.com/flutter/flutter/pull/134984 - https://github.com/flutter/flutter/pull/134991 - https://github.com/flutter/flutter/pull/134993 - https://github.com/flutter/flutter/pull/134994 ## Tests - Documentation only change.
-
- 19 Sep, 2023 1 commit
-
-
Polina Cherkasova authored
-
- 18 Sep, 2023 2 commits
-
-
Zachary Anderson authored
Reverts flutter/flutter#134953 Several failures on CI
-
Polina Cherkasova authored
-
- 28 Aug, 2023 3 commits
-
-
Polina Cherkasova authored
-
Victoria Ashworth authored
Reverts flutter/flutter#133352 Tree is failing on Mac and Linux customer_testing on this PR. https://ci.chromium.org/ui/p/flutter/builders/prod/Mac%20customer_testing/14646/overview https://ci.chromium.org/ui/p/flutter/builders/prod/Linux%20customer_testing/14974/overview
-
Polina Cherkasova authored
-
- 17 Aug, 2023 1 commit
-
-
- 20 Jul, 2023 1 commit
-
-
Greg Spencer authored
## Description This modifies the `MenuAnchor` `onPressed` activation to delay until after the current frame is built, and resolve any focus changes before it invokes the `onPressed`, so that actions that operate on the `primaryFocus` can have a chance of working on the focused item they were meant to work on. ## Related Issues - Fixes https://github.com/flutter/flutter/issues/118731 ## Tests - No tests yet (hence draft still)
-
- 09 May, 2023 1 commit
-
-
Bruno Leroux authored
## Description This PR adds some details in FocusNode documentation to explain more precisely when listeners are notified. ## Related Issue Fixes https://github.com/flutter/flutter/issues/126149 ## Tests Documentation only.
-
- 22 Mar, 2023 1 commit
-
-
Michael Goderbauer authored
Remove 1745 decorative breaks
-
- 17 Feb, 2023 1 commit
-
-
Ian Hickson authored
* lerp documentation * Remove Note, Note That from repo * Improve BorderSide documentation. * apply review comments
-
- 03 Feb, 2023 1 commit
-
-
Greg Spencer authored
* Make _focusDebug not interpolate in debug mode * Add test * Revert undesired change * Fix test to fail before too * Remove accidental skips * Switch to using a generating closure for arguments. * Remove a word
-
- 24 Jan, 2023 2 commits
-
-
Greg Spencer authored
* Add stack functionality to the FocusManager * Separate out the highlight manager from the focus manager * Revert more unrelated changes * Review Changes
-
Michael Goderbauer authored
* dart fix --apply * manual fixes
-
- 18 Jan, 2023 1 commit
-
-
Bruno Leroux authored
* Fix focus area documentation typos * Restore intentional spaces that illustrate bigger buttons
-
- 10 Jan, 2023 1 commit
-
-
Yegor authored
* allow focus to leave FlutterView * fix tests and docs * small doc update * fix analysis lint * use closed loop for dialogs * add tests for new API * address comments * test FocusScopeNode.traversalEdgeBehavior setter; reverse wrap-around * rename actionResult to invokeResult * address comments
-
- 12 Sep, 2022 1 commit
-
-
Greg Spencer authored
-
- 02 Sep, 2022 1 commit
-
-
Pierre-Louis authored
-
- 26 Jul, 2022 1 commit
-
-
Tong Mu authored
Explain the "patching" protocol in `KeyMessageManager.keyMessageHandler` and add an example (#105280)
-
- 26 May, 2022 1 commit
-
-
Pierre-Louis authored
* Use `curly_braces_in_flow_control_structures` for `widgets` * fix comments * fix comments
-
- 25 May, 2022 1 commit
-
-
Greg Spencer authored
A bunch of random cleanup things I found while doing MenuBar development. Changes an if test to an assert in binding.dart, since the if should always be true. Adds the default ShortcutRegistrar that should have been in the ShortcutRegistry PR. Moves a debug message in the FocusManager to print the result after the focus change instead of before. Reorders the test parameters in theme_data_test.dart to match the order of the theme data fields everywhere else.
-
- 14 Apr, 2022 1 commit
-
-
Michael Goderbauer authored
-
- 13 Apr, 2022 1 commit
-
-
Callum Moffat authored
* Implement trackpad gestures in framework * Touch and Pan/Zoom pointers have separate IDs now * Handle trackpad pointer device type * Respect supportedDevices for pan/zoom events * Update after rebase * Fix check failures * Avoid error with very short drags * Address feedback * Refactor drag event handler * Address more feedback * Add some missing punctuation
-
- 12 Apr, 2022 1 commit
-
-
Kate Lovett authored
-
- 06 Apr, 2022 1 commit
-
-
Dwayne Slater authored
-
- 24 Mar, 2022 1 commit
-
-
fzyzcjy authored
-
- 03 Feb, 2022 1 commit
-
-
Ian Hickson authored
-
- 01 Feb, 2022 1 commit
-
-
Callum Moffat authored
* PointerDeviceKind and ui.PointerChange forwards-compatibility * Add link to trackpad gestures issue * Add TODO
-
- 20 Jan, 2022 1 commit
-
-
Tong Mu authored
-
- 10 Jan, 2022 1 commit
-
-
Viren Khatri authored
-
- 08 Jan, 2022 1 commit
-
-
Greg Spencer authored
-
- 12 Dec, 2021 1 commit
-
-
Dan Field authored
-
- 07 Dec, 2021 1 commit
-
-
Dan Field authored
-
- 11 Oct, 2021 1 commit
-
-
Ian Hickson authored
-