1. 28 Feb, 2023 1 commit
  2. 27 Feb, 2023 2 commits
  3. 17 Feb, 2023 1 commit
  4. 13 Feb, 2023 1 commit
  5. 06 Feb, 2023 1 commit
  6. 20 Jan, 2023 1 commit
  7. 19 Jan, 2023 2 commits
    • Jenn Magder's avatar
      Revert "Support iOS wireless debugging (#118104)" (#118826) · cbf2e168
      Jenn Magder authored
      This reverts commit 5cd2d4c6.
      cbf2e168
    • Victoria Ashworth's avatar
      Support iOS wireless debugging (#118104) · 5cd2d4c6
      Victoria Ashworth authored
      * setup wireless debugging to use device IP
      
      * fix tests
      
      * fix unused var and missing annotation
      
      * remove unneeded try catch
      
      * remove commented out line, change null to package id
      
      * better way to get package id
      
      * update mDNS lookup to continously check for server, add messaging if takes too long to find observatory url, update flutter drive to enable publish-port if using network device
      
      * Refactor mDNS Discovery to poll for observatories and better handle multiple instances of the same app. Update drive command to make publish-port more stable. Update attach for iOS to only use Protocol Discovery if applicable, run mDNS and Protocol Discovery simultaneously, handle --debug-port/--debug-url/--device-vmservice-port, continously poll for obseravtories with mDNS, include port in error message when mutliple available
      
      * add and update comments, use logger spinner intead of timer in flutter attach, other small improvements
      
      * add newline to message so next log won't be on same line
      
      * fix install/waiting for permission status progress so it doens't double print the time it took.
      
      * only print backtrace if observatory times out on a physical usb connected device
      
      * fix test
      
      * Update related references from Observatory to Dart VM Service
      
      * fix test
      5cd2d4c6
  8. 13 Jan, 2023 1 commit
  9. 09 Nov, 2022 1 commit
    • Victoria Ashworth's avatar
      Add more supported simulator debugging options and improve tests (#114628) · 3a656b16
      Victoria Ashworth authored
      * add debugging options to simulator, test more debugging flags, add tests for other launch arguements
      
      * refactor iOS launch arguments to use one function for both simulator and physical devices
      
      * treat dart flags differently between physical and simulator
      
      * Simplify some flags between devices.
      
      Change --disable-service-auth-codes to not always be included for physical devices, only if disableServiceAuthCodes is true.
      Change --disable-observatory-publication to be used for simulator devices too.
      Change --enable-checked-mode & --verify-entry-points to be used if debuggingEnabled is true regardless of device type.
      Chnage --trace-startup to be used for simulator devices too.
      
      * fix ios release mode with buildable app startApp test
      
      * determine observatory-port from deviceVmServicePort and hostVmServicePort
      
      * add comments and remove hasObservatoryPort
      3a656b16
  10. 07 Nov, 2022 1 commit
    • Victoria Ashworth's avatar
      when getting xcworkspace, exclude hidden files (#114099) · 378387b1
      Victoria Ashworth authored
      * exclude xcworkspace that begins with a period
      
      * fix if spacing, add comment
      
      * add unit test for when no xcworkspace found
      
      * update to use xcodeWorkspace, make it nullable and refactor
      
      * check if hostAppRoot exists before trying to get xcworkspace
      
      * use local variables to take advantage of type promotion
      
      * only check if not null, don't need to check if exists
      
      * readd exist check for migrate
      
      * readd missing line at end of file
      378387b1
  11. 04 Nov, 2022 1 commit
  12. 27 Oct, 2022 2 commits
  13. 26 Oct, 2022 1 commit
  14. 25 Oct, 2022 2 commits
  15. 18 Oct, 2022 1 commit
  16. 17 Oct, 2022 1 commit
  17. 12 Oct, 2022 1 commit
  18. 05 Oct, 2022 1 commit
  19. 04 Oct, 2022 1 commit
  20. 08 Sep, 2022 1 commit
  21. 30 Jul, 2022 1 commit
  22. 26 Jul, 2022 3 commits
  23. 15 Jul, 2022 1 commit
  24. 14 Jul, 2022 1 commit
  25. 18 Jun, 2022 1 commit
  26. 16 Jun, 2022 1 commit
  27. 03 Jun, 2022 1 commit
  28. 24 May, 2022 1 commit
  29. 17 May, 2022 1 commit
    • Chris Bracken's avatar
      [tool] Consistent FakeProcessManager.run/runSync (#103947) · 928bb122
      Chris Bracken authored
      `FakeProcessManager` is a test-oriented implementation of `ProcessManager`
      that simulates launching processes and returning `ProcessResult` objects
      whose `exitCode`, `stdout`, `stderr` can be used to write platform-portable,
      hermetic tests that don't rely on actually launching processes from
      executables on disk. Its `run` and `runSync` methods provide asynchronous and
      synchronous variants of this functionality.
      
      Previously, the behaviour of `run` and `runSync` were inconsistent with
      regards to the treatment of the `stdoutEncoding` (similarly,
      `stderrEncoding`) parameters:
      
      `run`:
      * if the encoding was null, `ProcessResult.stdout` was returned as a
        String in UTF-8 encoding. This was incorrect. The behaviour as
        specified in `ProcessResult.stdout` is that in this case, a raw
        `List<int>` should be returned.
      * If the encoding was unspecified, `ProcessResult.stdout` was returned as
        a `String` in the `io.systemEncoding` encoding. This was correct.
      * If the encoding was non-null, `ProcessResult.stdout` was returned as a
        `String` in the specified encoding. This was correct.
      
      `runSync`:
      * if the encoding was null, `ProcessResult.stdout` was returned as a
        `List<int>` in UTF-8 encoding. This was incorrect. The behaviour as
        specified in `ProcessResult.stdout` is that in this case, a raw
        `List<int>` should be returned.
      * If the encoding was unspecified, `ProcessResult.stdout` was returned as
        `List<int>` in UTF-8 encoding. This was incorrect. The behaviour as
        specified in `ProcessResult.stdout` is that in this case, a String a
        `String` in the `io.systemEncoding` encoding should be returned.
      * if the encoding was non-null, `ProcessResult.stdout` was returned as a
        `String` in unknown (but probably UTF-8) encoding. This was incorrect.
        The behaviour as specified in `ProcessResult.stdout` is that in this
        case, a `String` in the specified encoding should be returned.
      
      `_FakeProcess`, from which we obtain the fake stdout and stderr values now
      holds these fields as raw `List<int>` of bytes rather than as `String`s. It
      is up to the user to supply values that can be decoded with the encoding
      passed to `run`/`runAsync`.
      
      `run` and `runAsync` have been updated to set stdout (likewise, stderr) as
      specified in the `ProcessResult` documentation.
      
      This is pre-factoring for #102451, in which the tool throws an exception
      when processing the JSON output from stdout of the `vswhere.exe` tool,
      whose output was found to include the `U+FFFD` Unicode replacement
      character during UTF-8 decoding, which triggers a `toolExit` exception
      when decoded using our [Utf8Decoder][decoder] configured with `reportErrors` =
      true. Because `FakeProcessManager.runAsync` did not previously invoke
      `utf8.decode` on its output (behaviour which differs from the non-fake
      implementation), it was impossible to write tests to verify the fix.
      
      Ref: https://api.flutter.dev/flutter/dart-io/ProcessResult/stdout.html
      
      Issue: https://github.com/flutter/flutter/issues/102451
      
      [decoder]: https://github.com/flutter/flutter/blob/fd312f1ccff909fde28d2247a489bf210bbc6c48/packages/flutter_tools/lib/src/convert.dart#L51-L60
      928bb122
  30. 07 May, 2022 2 commits
  31. 27 Apr, 2022 2 commits
  32. 15 Apr, 2022 1 commit