Unverified Commit 003f2b69 authored by Jenn Magder's avatar Jenn Magder Committed by GitHub

Pass run and drive --trace-systrace for iOS (#105321)

parent 0895130e
...@@ -112,7 +112,8 @@ abstract class RunCommandBase extends FlutterCommand with DeviceBasedDevelopment ...@@ -112,7 +112,8 @@ abstract class RunCommandBase extends FlutterCommand with DeviceBasedDevelopment
..addFlag('trace-systrace', ..addFlag('trace-systrace',
negatable: false, negatable: false,
help: 'Enable tracing to the system tracer. This is only useful on ' help: 'Enable tracing to the system tracer. This is only useful on '
'platforms where such a tracer is available (Android and Fuchsia).', 'platforms where such a tracer is available (Android, iOS, '
'macOS and Fuchsia).',
) )
..addFlag('trace-skia', ..addFlag('trace-skia',
negatable: false, negatable: false,
......
...@@ -361,6 +361,7 @@ class IOSDevice extends Device { ...@@ -361,6 +361,7 @@ class IOSDevice extends Device {
'--verify-entry-points', '--verify-entry-points',
], ],
if (debuggingOptions.enableSoftwareRendering) '--enable-software-rendering', if (debuggingOptions.enableSoftwareRendering) '--enable-software-rendering',
if (debuggingOptions.traceSystrace) '--trace-systrace',
if (debuggingOptions.skiaDeterministicRendering) '--skia-deterministic-rendering', if (debuggingOptions.skiaDeterministicRendering) '--skia-deterministic-rendering',
if (debuggingOptions.traceSkia) '--trace-skia', if (debuggingOptions.traceSkia) '--trace-skia',
if (debuggingOptions.traceAllowlist != null) '--trace-allowlist="${debuggingOptions.traceAllowlist}"', if (debuggingOptions.traceAllowlist != null) '--trace-allowlist="${debuggingOptions.traceAllowlist}"',
......
...@@ -224,6 +224,7 @@ void main() { ...@@ -224,6 +224,7 @@ void main() {
'--null-assertions', '--null-assertions',
'--native-null-assertions', '--native-null-assertions',
'--enable-impeller', '--enable-impeller',
'--trace-systrace',
'--enable-software-rendering', '--enable-software-rendering',
'--skia-deterministic-rendering', '--skia-deterministic-rendering',
]), throwsToolExit()); ]), throwsToolExit());
...@@ -238,6 +239,7 @@ void main() { ...@@ -238,6 +239,7 @@ void main() {
expect(options.nullAssertions, true); expect(options.nullAssertions, true);
expect(options.nativeNullAssertions, true); expect(options.nativeNullAssertions, true);
expect(options.enableImpeller, true); expect(options.enableImpeller, true);
expect(options.traceSystrace, true);
expect(options.enableSoftwareRendering, true); expect(options.enableSoftwareRendering, true);
expect(options.skiaDeterministicRendering, true); expect(options.skiaDeterministicRendering, true);
}, overrides: <Type, Generator>{ }, overrides: <Type, Generator>{
......
...@@ -734,6 +734,7 @@ void main() { ...@@ -734,6 +734,7 @@ void main() {
'--null-assertions', '--null-assertions',
'--native-null-assertions', '--native-null-assertions',
'--enable-impeller', '--enable-impeller',
'--trace-systrace',
'--enable-software-rendering', '--enable-software-rendering',
'--skia-deterministic-rendering', '--skia-deterministic-rendering',
]), throwsToolExit()); ]), throwsToolExit());
...@@ -748,6 +749,7 @@ void main() { ...@@ -748,6 +749,7 @@ void main() {
expect(options.verboseSystemLogs, true); expect(options.verboseSystemLogs, true);
expect(options.nullAssertions, true); expect(options.nullAssertions, true);
expect(options.nativeNullAssertions, true); expect(options.nativeNullAssertions, true);
expect(options.traceSystrace, true);
expect(options.enableImpeller, true); expect(options.enableImpeller, true);
expect(options.enableSoftwareRendering, true); expect(options.enableSoftwareRendering, true);
expect(options.skiaDeterministicRendering, true); expect(options.skiaDeterministicRendering, true);
......
...@@ -288,6 +288,7 @@ void main() { ...@@ -288,6 +288,7 @@ void main() {
'--enable-checked-mode', '--enable-checked-mode',
'--verify-entry-points', '--verify-entry-points',
'--enable-software-rendering', '--enable-software-rendering',
'--trace-systrace',
'--skia-deterministic-rendering', '--skia-deterministic-rendering',
'--trace-skia', '--trace-skia',
'--endless-trace-buffer', '--endless-trace-buffer',
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment