1. 10 May, 2018 4 commits
  2. 07 May, 2018 1 commit
    • Chris Bracken's avatar
      Mark integration_ui flaky (#17319) · 4509b15d
      Chris Bracken authored
      This test fails consistently on mac2 and mac3 with the attached Moto G4
      devices but passes consistently on other machines.
      
      Adding a delay of 1s right after driver.connect() in setUpAll() causes
      it to pass on the machines in question, which suggests a race condition.
      Specifically it looks like connect returns the moment Flutter Driver
      identifies that the isolate is up and running, but empirically it looks
      like we start running the first test before the UI is actually up. This
      triggers a failure wherein we start looking for elements before they're
      onstage.
      
      Link to viewport.dart:213 at HEAD:
      https://github.com/flutter/flutter/blob/b2b46659262c66ff13abc2b8016a94a47646eaad/packages/flutter/lib/src/widgets/viewport.dart#L213
      
      Stack trace:
      FlutterDriver waitFor should find text "present"
      
      ```
        DriverError: Error in Flutter application: Uncaught extension error while executing waitFor: NoSuchMethodError: The getter 'visible' was called on null.
        Receiver: null
        Tried calling: visible
        #0      Object.noSuchMethod (dart:core/runtime/libobject_patch.dart:46:5)
        #1      _ViewportElement.debugVisitOnstageChildren. (package:flutter/src/widgets/viewport.dart:213:36)
        #2      WhereIterator.moveNext (dart:_internal/iterable.dart:439:11)
        #3      Iterable.forEach (dart:core/iterable.dart)
        #4      _ViewportElement.debugVisitOnstageChildren (package:flutter/src/widgets/viewport.dart:214:8)
        #5      _DepthFirstChildIterator._reverseChildrenOf (package:flutter_test/src/all_elements.dart:54:15)
        #6      _DepthFirstChildIterator.moveNext (package:flutter_test/src/all_elements.dart:45:19)
        #7      CachingIterable._fillNext (package:flutter/src/foundation/basic_types.dart:252:27)
        #8      _LazyListIterator.moveNext (package:flutter/src/foundation/basic_types.dart:279:21)
        #9      WhereIterator.moveNext (dart:_internal/iterable.dart:438:22)
        #10     CachingIterable._fillNext (package:flutter/src/foundation/basic_types.dart:252:27)
        #11     _LazyListIterator.moveNext (package:flutter/src/foundation/basic_types.dart:279:21)
        #12     Iterable.isEmpty (dart:core/iterable.dart:449:33)
        #13     Iterable.isNotEmpty (dart:core/iterable.dart:456:27)
        #14     FlutterDriverExtension._waitForElement. (package:flutter_driver/src/extension/extension.dart:215:51)
        #15     FlutterDriverExtension._waitUntilFrame (package:flutter_driver/src/extension/extension.dart:197:19)
        #16     FlutterDriverExtension._waitForElement (package:flutter_driver/src/extension/extension.dart:215:11)
      
        #17     FlutterDriverExtension._waitFor (package:flutter_driver/src/extension/extension.dart:286:11)
      
        #18     FlutterDriverExtension.call (package:flutter_driver/src/extension/extension.dart:168:51)
      
        #19     BindingBase.registerServiceExtension. (package:flutter/src/foundation/binding.dart:370:32)
      ```
      
      Removes a previous hack that no longer appears to help (adding a 1
      second delay in setUpAll() does seem to work around this issue though).
      4509b15d
  3. 04 May, 2018 2 commits
  4. 26 Apr, 2018 1 commit
  5. 20 Apr, 2018 1 commit
  6. 17 Apr, 2018 2 commits
  7. 11 Apr, 2018 2 commits
  8. 10 Apr, 2018 2 commits
  9. 09 Apr, 2018 1 commit
  10. 04 Apr, 2018 1 commit
  11. 03 Apr, 2018 1 commit
  12. 29 Mar, 2018 1 commit
  13. 28 Mar, 2018 2 commits
  14. 24 Mar, 2018 1 commit
  15. 23 Mar, 2018 2 commits
  16. 22 Mar, 2018 2 commits
  17. 21 Mar, 2018 2 commits
  18. 19 Mar, 2018 1 commit
  19. 16 Mar, 2018 1 commit
  20. 15 Mar, 2018 1 commit
  21. 13 Mar, 2018 1 commit
  22. 12 Mar, 2018 5 commits
    • Alexander Aprelev's avatar
      Roll engine to b6df7a637498ca9beda1fa9cd7210e3202ea599f. (#15444) · 2f8474f9
      Alexander Aprelev authored
      * Roll engine to b6df7a637498ca9beda1fa9cd7210e3202ea599f.
      
      Changes since last roll:
      ```
      b6df7a637 Roll dart to 290c576264faa096a0b3206c71b2435309d9f904. (#4771)
      a6764dbd5 Add sources for Fuchsia target. (#4763)
      2d5900615 [fuchsia] Remove unused header file. (#4769)
      9717063b7 Revert "Roll dart to c080951d45e79cd25df98036c4be835b284a269c. (#4767)" (#4768)
      9a9814312 Roll dart to c080951d45e79cd25df98036c4be835b284a269c. (#4767)
      e74e8b35c [async] Update includes of async headers to new path (#4760)
      e2c4b2760 Use Dart 2 camel case constants in the engine Dart libraries (#4766)
      9c1e48434 Updates for Fuchsia roll. (#4765)
      14c940e27 Switch from fxl::Mutex to std::mutex (#4764)
      debf82c0b Roll Garnet (#4759)
      5bffdefbb Use weak pointers to the accesibility bridge from objects vended to the UIKit accessibility framework. (#4761)
      ```
      2f8474f9
    • Mikkel Nygaard Ravn's avatar
      Silence broken test (#15446) · a6159279
      Mikkel Nygaard Ravn authored
      * Silence broken test
      
      * Mark test as flaky instead
      a6159279
    • Danny Tuppeny's avatar
      Remove flaky flag from all tests that are green for the whole dashboard · 465929f7
      Danny Tuppeny authored
      Plus run_machine_concurrent_hot_reload which isn't all green, but is
      green since the fix was pushed.
      465929f7
    • Mikkel Nygaard Ravn's avatar
      658f9e6c
    • Siva's avatar
      Update dart-petitparser and dart-xml packages (#15376) · e5ba3041
      Siva authored
      * Update the following packages
      - dart-petitparser to 1.7.5
      - dart-xml to 3.0.3
      - image to 1.1.30
      These updates fix some of the strong mode errors we were encountering
      while running flutter tests.
      e5ba3041
  23. 09 Mar, 2018 1 commit
  24. 08 Mar, 2018 1 commit
  25. 07 Mar, 2018 1 commit