1. 13 Jul, 2019 1 commit
  2. 27 Feb, 2019 1 commit
    • liyuqian's avatar
      Add LICENSE test to presubmit checks (#28369) · dd5559a5
      liyuqian authored
      ## Description
      
      Also update the existing dart files with missing licenses.
      
      Without the fix, we'll emit the following error message
      ```
      License headers cannot be found at the beginning of the following files.
      
      /usr/local/google/home/liyuqian/flutter/flutter/packages/flutter/lib/src/animation/tween_sequence.dart
      /usr/local/google/home/liyuqian/flutter/flutter/packages/flutter/test/material/raw_material_button_test.dart
      /usr/local/google/home/liyuqian/flutter/flutter/packages/flutter/test/widgets/async_lifecycle_test.dart
      /usr/local/google/home/liyuqian/flutter/flutter/packages/flutter/test/widgets/sliver_constraints_test.dart
      /usr/local/google/home/liyuqian/flutter/flutter/packages/flutter/test/widgets/app_test.dart
      /usr/local/google/home/liyuqian/flutter/flutter/packages/flutter/test/widgets/test_border.dart
      /usr/local/google/home/liyuqian/flutter/flutter/packages/flutter/test/widgets/physical_model_test.dart
      /usr/local/google/home/liyuqian/flutter/flutter/packages/flutter/test/widgets/inherited_model.dart
      /usr/local/google/home/liyuqian/flutter/flutter/packages/flutter_tools/lib/src/base/user_messages.dart
      /usr/local/google/home/liyuqian/flutter/flutter/packages/flutter_tools/test/src/pubspec_schema.dart
      /usr/local/google/home/liyuqian/flutter/flutter/packages/flutter_tools/test/ios/simulators_test.dart
      ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
      ```
      
      ## Related Issues
      
      Fixes https://github.com/flutter/flutter/issues/28368
      
      ## Checklist
      
      Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (`[x]`). This will ensure a smooth and quick review process.
      
      - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
      - [x] My PR includes tests for *all* changed/updated/fixed behaviors (See [Test Coverage]).
      - [x] All existing and new tests are passing.
      - [x] I updated/added relevant documentation (doc comments with `///`).
      - [x] The analyzer (`flutter analyze --flutter-repo`) does not report any problems on my PR.
      - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
      - [x] I signed the [CLA].
      - [x] I am willing to follow-up on review comments in a timely manner.
      
      ## Breaking Change
      
      Does your PR require Flutter developers to manually update their apps to accommodate your change?
      
      - [ ] Yes, this is a breaking change (Please read [Handling breaking changes]).
      - [x] No, this is *not* a breaking change.
      
      <!-- Links -->
      [issue database]: https://github.com/flutter/flutter/issues
      [Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
      [Test Coverage]: https://github.com/flutter/flutter/wiki/Test-coverage-for-package%3Aflutter
      [Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
      [Features we expect every widget to implement]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
      [CLA]: https://cla.developers.google.com/
      [Handling breaking changes]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
      dd5559a5
  3. 21 Feb, 2019 1 commit
  4. 05 Oct, 2018 1 commit
  5. 04 Oct, 2018 1 commit
  6. 22 Sep, 2018 1 commit
    • Ian Hickson's avatar
      [H] Cleanup (#21542) · 989cf18b
      Ian Hickson authored
      * Improve documentation and clean up code.
      
      * Remove "Note that".
      
      The phrase "note that" is basically meaningless as a prefix to an
      otherwise fine sentence.
      989cf18b
  7. 12 Sep, 2018 1 commit
  8. 05 Sep, 2018 2 commits
  9. 31 Aug, 2018 1 commit
  10. 15 Aug, 2018 1 commit
    • Ian Hickson's avatar
      Shim package:test to avoid matcher issues (#20602) · 686d8f8a
      Ian Hickson authored
      * Upgrade everything except matcher.
      * Roll matcher (and test)
      * Adjust tests that depend on flutter:test directly to depend on a shim
      * Require use of package:test shim and remove other references to package:test
      686d8f8a
  11. 04 Aug, 2018 1 commit
  12. 27 Jun, 2018 1 commit
  13. 15 Jun, 2018 2 commits
  14. 22 Nov, 2017 1 commit
  15. 16 May, 2017 1 commit
    • Todd Volkert's avatar
      Fix race condition in protocol_discovery.dart (#10092) · 10decc7c
      Todd Volkert authored
      For some reaosn, when we discovered our URI, we were re-instantiating
      the `Completer` instance variable whose future we listen to in `nextUri()`.
      This led to a race between a caller calling `nextUri()` and us discovering
      the URI. If we happened to discover our URI before a caller called
      `nextUri()`, then they would be left waiting on a future from the newly
      allocated `Completer` (which would never complete).
      
      Fixes #10064
      10decc7c
  16. 04 Mar, 2017 1 commit
  17. 06 Dec, 2016 1 commit
    • Dan Rubel's avatar
      Cleanup common port forwarding code (#7142) · 93e662ab
      Dan Rubel authored
      This moves the various copies of port forwarding code in the Device subclasses into the ProtocolDiscovery class.
      
      * move port forwarding to a common location
      * throw exception if protocol Uri is not discovered or port forwarding fails
      * cancel discovery protocol subscriptions on iOS launches (wasn't happening before)
      * fix iOS port forwarding to match other implementations
      * add tests
      93e662ab
  18. 01 Dec, 2016 1 commit
  19. 28 Nov, 2016 2 commits
  20. 13 Sep, 2016 1 commit
  21. 13 May, 2016 1 commit
    • Devon Carew's avatar
      Consolidate observatory code (#3892) · 40c0d6ea
      Devon Carew authored
      * rename service_protocol.dart to protocol_discovery.dart
      
      * add a wrapper around the obs. protocol
      
      * use json-rpc in run
      
      * consolidate obs. code; implement flutter run --benchmark
      
      * review comments
      40c0d6ea
  22. 27 Apr, 2016 1 commit
    • Devon Carew's avatar
      Flutter run (#3553) · b0dca796
      Devon Carew authored
      * rework flutter run
      
      * fix npe with --debug-port
      
      * connect to obs and exit when that conneciton closes
      
      * update todos
      b0dca796
  23. 07 Apr, 2016 1 commit
  24. 17 Mar, 2016 1 commit
  25. 14 Mar, 2016 1 commit
  26. 10 Mar, 2016 1 commit
  27. 08 Mar, 2016 1 commit