- 23 Jan, 2024 1 commit
-
-
Lau Ching Jun authored
This is used when the native assets are built by a separate build system. Context: b/286799303
-
- 18 Jan, 2024 2 commits
-
-
auto-submit[bot] authored
Reverts flutter/flutter#137618 Initiated by: Jasguerrero This change reverts the following previous change: Original Description: It's now possible to natively compile a flutter app for windows-arm64. Cross-compilation is not yet implemented. Uses arm64 artifacts now available for Dart/Flutter. Platform detection is based on Abi class, provided by Dart. Depending if Dart is an arm64 or x64 binary, the Abi is set accordingly. Initial bootstrap of dart artifacts (update_dart_sdk.ps1) is checking PROCESSOR_ARCHITECTURE environment variable, which is the way to detect host architecture on Windows. This is available only for master channel (on other channels, it fallbacks to windows-x64). On windows-x64, it produces an x64 app. On windows-arm64, it produces an arm64 app.
-
Pierrick Bouvier authored
It's now possible to natively compile a flutter app for windows-arm64. Cross-compilation is not yet implemented. Uses arm64 artifacts now available for Dart/Flutter. Platform detection is based on Abi class, provided by Dart. Depending if Dart is an arm64 or x64 binary, the Abi is set accordingly. Initial bootstrap of dart artifacts (update_dart_sdk.ps1) is checking PROCESSOR_ARCHITECTURE environment variable, which is the way to detect host architecture on Windows. This is available only for master channel (on other channels, it fallbacks to windows-x64). On windows-x64, it produces an x64 app. On windows-arm64, it produces an arm64 app.
-
- 12 Jan, 2024 1 commit
-
-
Anis Alibegić authored
Fair amount of typos spotted and fixed. Some of them are in comments, some of them are in code and some of them are in nondart files. There is no need for issues since it's a typo fix. I have doubts about [packages/flutter_tools/lib/src/ios/core_devices.dart](https://github.com/flutter/flutter/compare/master...anisalibegic:flutter:master#diff-fdbc1496b4bbe7e2b445a567fd385677af861c0093774e3d8cc460fdd5b794fa), I have a feeling it might broke some things on the other end, even though it's a typo.
-
- 02 Jan, 2024 1 commit
-
-
Dan Field authored
Reverts flutter/flutter#123828 Fixes https://github.com/flutter/flutter/issues/140523
-
- 07 Dec, 2023 1 commit
-
-
Elias Yishak authored
Related to the tracker issue: - https://github.com/flutter/flutter/issues/128251 This PR migrates the `Usage.command` static method that sent custom dimensions for each command (if applicable). The screenshot below shows the different places where the `usageValues` getter is overwritten to return the necessary custom dimensions for that command. <img width="285" alt="image" src="https://github.com/flutter/flutter/assets/42216813/e32d5100-0e17-4a4d-8f21-327a8c113a19">
-
- 04 Dec, 2023 1 commit
-
-
Elias Yishak authored
Relanding based on this comment: - https://github.com/flutter/flutter/pull/139278#issuecomment-1832951108 Related to tracker issue: - https://github.com/flutter/flutter/issues/128251 <img width="278" alt="image" src="https://github.com/flutter/flutter/assets/42216813/cee7b9be-48d6-48e5-8c39-de28d0a1f0de"> The image above shows all of the instances where we have `sendTiming`. All of the call sites have been updated to use the new `Event.timing` event from `package:unified_analytics`.
-
- 30 Nov, 2023 1 commit
-
-
auto-submit[bot] authored
Reverts flutter/flutter#138896 Initiated by: CaseyHillers This change reverts the following previous change: Original Description: Related to tracker issue: - https://github.com/flutter/flutter/issues/128251 <img width="278" alt="image" src="https://github.com/flutter/flutter/assets/42216813/cee7b9be-48d6-48e5-8c39-de28d0a1f0de"> The image above shows all of the instances where we have `sendTiming`. All of the call sites have been updated to use the new `Event.timing` event from `package:unified_analytics`.
-
- 29 Nov, 2023 1 commit
-
-
Elias Yishak authored
Related to tracker issue: - https://github.com/flutter/flutter/issues/128251 <img width="278" alt="image" src="https://github.com/flutter/flutter/assets/42216813/cee7b9be-48d6-48e5-8c39-de28d0a1f0de"> The image above shows all of the instances where we have `sendTiming`. All of the call sites have been updated to use the new `Event.timing` event from `package:unified_analytics`.
-
- 22 Nov, 2023 1 commit
-
-
Elias Yishak authored
Add `commandHasTerminal` parameter + apple usage event + `sendException` events for `package:unified_analytics` (#138806) Relates to tracker issue: - https://github.com/flutter/flutter/issues/128251 This PR includes 3 major updates: - Adding the `commandHasTerminal` parameter for `Event.flutterCommandResult` - In `packages/flutter_tools/lib/src/runner/flutter_command.dart` - Adding the new event for `sendException` from package:usage to be `Event.exception` (this event can be used by all dash tools) - In `packages/flutter_tools/lib/runner.dart` - Migrating the generic `UsageEvent` which was only used for Apple related workflows for iOS and macOS. I did an initial analysis in this [sheet](https://docs.google.com/spreadsheets/d/11KJLkHXFpECMX7tw-trNkYSr5MHDG15XNGv6TgLjfQs/edit?resourcekey=0-j4qdvsOEEg3wQW79YlY1-g#gid=0) to identify all the call sites - Found in several files, highlighted in the sheet above
-
- 16 Nov, 2023 1 commit
-
-
Arpit Gandhi authored
*Pass locally generated certificate via command line* *Fixes: #60704* Added ARGS: - web-tls-cert-path - web-tls-cert-key-path Passing the path of local certificate and the key to cert will allow flutter tool to create a secure debugging session on chrome **Pre-launch Checklist** â I read the [Contributor Guide](https://github.com/flutter/flutter/wiki/Tree-hygiene#overview) and followed the process outlined there for submitting PRs. â I read the [Tree Hygiene](https://github.com/flutter/flutter/wiki/Tree-hygiene) wiki page, which explains my responsibilities. â I read and followed the [Flutter Style Guide](https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo), including [Features we expect every widget to implement](https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement). â I signed the [CLA](https://cla.developers.google.com/). â I listed at least one issue that this PR fixes in the description above. â I updated/added relevant documentation (doc comments with ///). â I added new tests to check the change I am making. â All existing and new tests are passing.
-
- 10 Nov, 2023 1 commit
-
-
Elias Yishak authored
Related to tracker issue: - https://github.com/flutter/flutter/issues/128251 This event was only called from one file (`flutter_command.dart`). With the previous implementation, we actually sent 2 events, one for the result of the `commandPath` and another containing the `maxRss` value from `ProcessInfo`. I have consolidated this down to just one event and used a function to safely get the `maxRss` value, or return null when if there was an error getting that integer value
-
- 07 Nov, 2023 1 commit
-
-
Christopher Fujino authored
Part of https://github.com/flutter/flutter/issues/130277 Without this, if a user runs an app that has plugins that call method channels with the `preview` device, the app will build successfully, however, they will get a runtime error when their dart code tries to call the method channel that does not exist in the native build (which was pre-built and thus does not include the plugin code). This change adds a validation when injecting plugins that will tool exit if the device-id is `preview` and their project contains plugins with method channels.
-
- 06 Nov, 2023 1 commit
-
-
Elias Yishak authored
Related to tracker issue: - https://github.com/flutter/flutter/issues/128251 For this migration, the `HotEvent` was being referenced in 2 additional files outside of `lib/src/reporting/events.dart`, shown below in the screenshot <img width="257" alt="image" src="https://github.com/flutter/flutter/assets/42216813/97986f89-2253-4db1-9deb-bbced6321a16">
-
- 26 Oct, 2023 1 commit
-
-
Elias Yishak authored
Related to tracking issue: - https://github.com/flutter/flutter/issues/128251 This PR sends analytic events for each of the doctor validators. This PR below will need to land first in `dart-lang/tools` before this merges.
-
- 19 Oct, 2023 1 commit
-
-
Andrew Kolos authored
do not include entries from `--dart-define-from-file` files in the gradle config or environment during build (#136865) Fixes https://github.com/flutter/flutter/issues/130599 and https://github.com/flutter/flutter/issues/136444
-
- 17 Oct, 2023 2 commits
-
-
Andrew Kolos authored
Fixes https://github.com/flutter/flutter/issues/134279. Changes: * Moves all tests of `--dart-define-from-file` behavior from `build_bundle_test.dart` and `assemble_test.dart` to `flutter_command_test.dart`. * Deletes a duplicate test of malformed JSON detection behavior. * Renames the `useDartDefineFromFileOption` method of `FlutterCommand` to `_usesDartDefineFromFileOption`. This 1) makes the name more consistent with the other `uses*Option` methods and 2) hides the method since it is not used outside of the file. * Renames several tests to better articulate what is under test and what the expected result is. * Adds a test for the case where a `.env` file with a malformed line is provided to `--dart-define-from-file`.
-
Aran Donohue authored
Adds support for a new --web-header option to flutter run. Creates a workaround for https://github.com/flutter/flutter/issues/127902 This PR allows adding additional headers for the flutter run web server. This is useful to add headers like Cross-Origin-Embedder-Policy and Cross-Origin-Opener-Policy without the use of a proxy server. These headers are required enable advanced web features. This approach provides flexibility to the developer to make use of the feature as they see fit and is backward-compatible. One tradeoff is that it increases the surface area to support for future changes to the flutter web server. https://github.com/flutter/flutter/issues/127902 is not fully addressed by this change. The solution for that task will be more opinionated. This PR creates a general-purpose workaround for anyone who needs a solution sooner while the bigger solution is developed.
-
- 28 Sep, 2023 1 commit
-
-
Andrew Kolos authored
Resolves #128046. Adds a services API that allows flutter app developers to write app code that determines `--flavor` the app was built with. This is implemented by having the tool adding the value of `--flavor` to its list of dart environment declarations, which will be available to the app at run time. Specifically,`FLUTTER_APP_FLAVOR` is set. I chose this implementation for its simplicity. There is some precedent for this, but only for web ([example](https://github.com/flutter/flutter/blob/cd2f3f5e78409027d3c9014172708e4dec7f2185/packages/flutter_tools/lib/src/runner/flutter_command.dart#L1231)).
-
- 21 Sep, 2023 1 commit
-
-
Derek Xu authored
-
- 12 Sep, 2023 1 commit
-
-
Elias Yishak authored
Fixes: - #132258
-
- 23 Aug, 2023 1 commit
-
-
Michael Goderbauer authored
Blocking issue (https://github.com/dart-lang/linter/issues/453) for this lint has been resolved.
-
- 22 Aug, 2023 1 commit
-
-
Matan Lurey authored
Closes #132245.
-
- 17 Aug, 2023 1 commit
-
-
Matan Lurey authored
Partial work towards https://github.com/flutter/flutter/issues/132245. The goal here is to "sniff" out any missing pieces that would block engine builds, rolls, benchmarks and so on before requiring humans to provide the parameter. The implementation is based on a [short discussion with @christopherfujino](https://discord.com/channels/608014603317936148/608022056616853515/1141503921546875110): @matanlurey: > Not sure whether to post here or â hackers-infra-ð¡ , but is there a way to (and is it advisable to) detect whether the tool is running in a CI environment? I'd like to "soft enforce" --local-engine-host being provided strictly on CI, make sure that lands well, and then "upgrade" it to being non-CI invocations as well (re: https://github.com/flutter/flutter/issues/132245). > > Also happy to get talked out of this idea ð @christopherfujino: > we have a check, lemme find it > whether or not it is advisable, idk > https://github.com/flutter/flutter/blob/flutter-3.14-candidate.0/packages/flutter_tools/lib/src/base/bot_detector.dart#L30 > > (...) > > is your desire to get early signal before enforcing t his for humans to prevent functionality churn of landing and reverting and re-landing? > > (yes) > > uhh, sure, that's advisable ð
-
- 10 Aug, 2023 1 commit
-
-
Matan Lurey authored
Closes https://github.com/flutter/flutter/issues/132162. I did a tiny bit of minor cleanup but didn't want to go
beyond the scope of this change. After it lands I'll update the Wiki. ## Before ```bash $ fl run \ --local-engine-src-path=$ENGINE \ --local-engine=android_debug_unopt_arm64 ``` ... would try to use `host_debug_unopt` (i.e. Rosetta). ## After ```bash $ fl run \ --local-engine-src-path=$ENGINE \ --local-engine=android_debug_unopt_arm64 \ --local-engine-host=host_debug_unopt_arm64 ``` ... uses `host_debug_unopt_arm64`, as specified. --- /cc @jonahwilliams @gaaclarke @zanderso
-
- 04 Aug, 2023 1 commit
-
-
Andrew Kolos authored
Fixes #130604
-
- 13 Jul, 2023 1 commit
-
-
Piotr FLEURY authored
Set `.env` regex list as constants. This pull request fixes the nit related in this comment: https://github.com/flutter/flutter/pull/128668#discussion_r1253377454
-
- 05 Jul, 2023 1 commit
-
-
Piotr FLEURY authored
# Proposal I suggest to make possible to specify .env files to the --dart-define-from-file in addition to the Json format. # Issue Close #128667
-
- 22 Jun, 2023 1 commit
-
-
Elias Yishak authored
Prevent the cli from crashing when a user selects a number that is not valid for `flutter run` device selection Fixes issue: - https://github.com/flutter/flutter/issues/129191 *If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
-
- 16 Jun, 2023 1 commit
-
-
- 15 Jun, 2023 1 commit
-
-
Christopher Fujino authored
Fixes https://github.com/flutter/flutter/issues/112833 Most of the actual changes here are in [packages/flutter_tools/lib/src/version.dart](https://github.com/flutter/flutter/pull/124558/files#diff-092e00109d9e1589fbc7c6de750e29a6ae512b2dd44e85d60028953561201605), while the rest is largely just addressing changes to the constructor of `FlutterVersion` which now has different dependencies. This change makes `FlutterVersion` an interface with two concrete implementations: 1. `_FlutterVersionGit` which is mostly the previous implementation, and 2. `_FlutterVersionFromFile` which will read a new `.version.json` file from the root of the repo The [`FlutterVersion` constructor](https://github.com/flutter/flutter/pull/124558/files#diff-092e00109d9e1589fbc7c6de750e29a6ae512b2dd44e85d60028953561201605R70) is now a factory that first checks if `.version.json` exists, and if so returns an instance of `_FlutterVersionFromGit` else it returns the fallback `_FlutterVersionGit` which will end up writing `.version.json` so that we don't need to re-calculate the version on the next invocation. `.version.json` will be deleted in the bash/batch entrypoints any time we need to rebuild he tool (this will usually be because the user did `flutter upgrade` or `flutter channel`, or manually changed the commit with git).
-
- 02 Jun, 2023 1 commit
-
-
Victoria Ashworth authored
Workaround solution for: https://github.com/flutter/flutter/issues/121231 See https://github.com/flutter/flutter/issues/120808#issuecomment-1551826299 Error Case 2 for more information. Sometimes the `ios-deploy` process does not return the logs from the application. We've been unable to figure out why. This is a solution to workaround that by using `idevicesyslog` alongside `ios-deploy` as a backup in getting the log for the Dart VM url. As explained in https://github.com/flutter/flutter/issues/120808#issuecomment-1551826299, when error case 2 happens, the `idevicesyslog` does successfully find the Dart VM. Also, in the comments of the code it mentions `syslog` is not written on iOS 13+, this was added in response to this issue: https://github.com/flutter/flutter/issues/41133. However, `idevicesyslog` does in fact work (at least for iOS 16), we use it to collect device logs for our CI tests already: https://github.com/flutter/flutter/blob/1dc26f80f04c1c1091a83c5fead9b3aa83483292/dev/devicelab/lib/framework/devices.dart#L998-L1006
-
- 22 May, 2023 1 commit
-
-
LouiseHsu authored
Show warning when attempting to flutter run on an ios device with developer mode turned off (#125710) This PR adds a warning when a user attempt to `flutter run -d <device id>` on a device without developer mode enabled. <img width="738" alt="Screenshot 2023-05-09 at 3 53 18 AM" src="https://github.com/flutter/flutter/assets/36148254/6f473a6a-5a0d-438b-9e6f-06d09eb1f3a9"> Also handles multiple partial matches. <img width="788" alt="Screenshot 2023-05-09 at 3 52 24 AM" src="https://github.com/flutter/flutter/assets/36148254/60c82b3c-d501-4a01-95ad-d6309fe39576"> Fixes https://github.com/flutter/flutter/issues/111988
-
- 16 May, 2023 1 commit
-
-
Michael Goderbauer authored
-
- 08 May, 2023 2 commits
-
-
Loïc Sharma authored
This change makes `flutter pub` show the help usage: ``` PS > flutter pub Commands for managing Flutter packages. Global options: -h, --help Print this usage information. -v, --verbose Noisy logging, including all shell commands executed. If used with "--help", shows hidden options. If used with "flutter doctor", shows additional diagnostic information. (Use "-vv" to force verbose logging in those cases.) -d, --device-id Target device id or name (prefixes allowed). --version Reports the version of this tool. --suppress-analytics Suppress analytics reporting for the current CLI invocation. --disable-telemetry Disable telemetry reporting when this command runs. Usage: flutter pub <subcommand> [arguments] -h, --help Print this usage information. Available subcommands: add Add a dependency to pubspec.yaml. cache Work with the Pub system cache. deps Print package dependencies. downgrade Downgrade packages in a Flutter project. get Get the current package's dependencies. global Work with Pub global packages. login Log into pub.dev. logout Log out of pub.dev. outdated Analyze dependencies to find which ones can be upgraded. pub Pass the remaining arguments to Dart's "pub" tool. publish Publish the current package to pub.dartlang.org. remove Removes a dependency from the current package. run Run an executable from a package. test Run the "test" package. token Manage authentication tokens for hosted pub repositories. upgrade Upgrade the current package's dependencies to latest versions. uploader Manage uploaders for a package on pub.dev. version Print Pub version. Run "flutter help" to see global options. ``` Previously it showed an error message: ``` PS > flutter pub Missing subcommand for "flutter pub". Run 'flutter -h' (or 'flutter <command> -h') for available flutter commands and options. ``` Addresses https://github.com/flutter/flutter/issues/110025
-
Elias Yishak authored
Fixes: - https://github.com/flutter/flutter/issues/124411 This PR is cleaning up the `--disable-telemetry` help message to make it clear that opting out will opt out of all telemetry collection for flutter and dart commands. It is also adding the opposite flag `--enable-telemetry` which will enable telemetry collection
-
- 19 Apr, 2023 4 commits
-
-
Victoria Ashworth authored
Rename variables, update comments, etc from `network` to `wireless` to keep it more uniform. Also, move non-overriden messages related to device selection into the file they're used. Part 7 in breakdown of https://github.com/flutter/flutter/pull/121262.
-
Elias Yishak authored
Relanding: https://github.com/flutter/flutter/pull/124810 Fixes: https://github.com/flutter/flutter/issues/124808
-
godofredoc authored
Reverts flutter/flutter#124810
-
Elias Yishak authored
Fixes: https://github.com/flutter/flutter/issues/124808
-