1. 06 Oct, 2018 1 commit
    • Greg Spencer's avatar
      Turn on line wrapping in usage and status messages, adds ANSI color to doctor... · e4386321
      Greg Spencer authored
      Turn on line wrapping in usage and status messages, adds ANSI color to doctor and analysis messages. (#22656)
      
      This turns on text wrapping for usage messages and status messages. When on a terminal, wraps to the width of the terminal. When writing to a non-terminal, wrap lines at a default column width (currently defined to be 100 chars). If --no-wrap is specified, then no wrapping occurs. If --wrap-column is specified, wraps to that column (if --wrap is on).
      
      Adds ANSI color to the doctor and analysis output on terminals. This is in this PR with the wrapping, since wrapping needs to know how to count visible characters in the presence of ANSI sequences. (This is just one more step towards re-implementing all of Curses for Flutter. :-)) Will not print ANSI sequences when sent to a non-terminal, or of --no-color is specified.
      
      Fixes ANSI color and bold sequences so that they can be combined (bold, colored text), and a small bug in indentation calculation for wrapping.
      
      Since wrapping is now turned on, also removed many redundant '\n's in the code.
      Unverified
      e4386321
  2. 05 Oct, 2018 4 commits
  3. 04 Oct, 2018 1 commit
  4. 03 Oct, 2018 3 commits
  5. 02 Oct, 2018 2 commits
  6. 01 Oct, 2018 2 commits
  7. 24 Sep, 2018 1 commit
  8. 23 Sep, 2018 1 commit
  9. 22 Sep, 2018 1 commit
    • Ian Hickson's avatar
      [H] Cleanup (#21542) · 989cf18b
      Ian Hickson authored
      * Improve documentation and clean up code.
      
      * Remove "Note that".
      
      The phrase "note that" is basically meaningless as a prefix to an
      otherwise fine sentence.
      Unverified
      989cf18b
  10. 19 Sep, 2018 1 commit
  11. 18 Sep, 2018 1 commit
  12. 14 Sep, 2018 1 commit
  13. 12 Sep, 2018 1 commit
  14. 07 Sep, 2018 2 commits
  15. 06 Sep, 2018 2 commits
    • TL Lee's avatar
      Add build test for Flutter codelabs (#19579) · e2167b9f
      TL Lee authored
      * Add build test for Flutter codelabs
      
      * Fix indentation in build test script
      
      * Correct filename for the codelabs build test run by travis
      
      * Change if statement to elif
      
      * Replace echo statements with set -x
      
      * Add BSD-style license
      
      * Add codelabs build test to Cirrus
      
      * Remove codelabs_build_test from Travis.
      
      * Remove codelabs_build_test from travis_script.sh
      
      * Update documentation for codelabs_build_test.sh
      
      * Update readme for build test
      
      * Add link to open a new issue to MDC-Flutter
      
      * Add phrase to address "if you think you really need to break this test, please escalate this"
      Unverified
      e2167b9f
    • Chris Bracken's avatar
      Do not pass --preview-dart-2 to Dart VM (#21455) · 3519eabe
      Chris Bracken authored
      --preview-dart-2 is no longer necessary as it is now the default for the
      standalone Dart VM.
      Unverified
      3519eabe
  16. 31 Aug, 2018 1 commit
  17. 30 Aug, 2018 2 commits
  18. 28 Aug, 2018 4 commits
  19. 24 Aug, 2018 1 commit
    • Greg Spencer's avatar
      Ignore pub-cache when analyzing (#20925) · 977da4fb
      Greg Spencer authored
      This adds ".pub-cache" to the list of directories to ignore when checking for dependence upon dart:test, since when people install a downloadable package, their pub cache is in the flutter directory.
      
      Also, I centralized the ANSI "red line" so that they would all use the same final string.
      Unverified
      977da4fb
  20. 23 Aug, 2018 2 commits
    • Danny Tuppeny's avatar
      Start logger in startProgress to avoid assertion failure (#20814) · dc5a5c18
      Danny Tuppeny authored
      * Start logger in startProgress to avoid assertion failure
      
      There are lots of places that create a Status() and all but two of them call ..start() immediately. This is one of the places that doesn't, which causes an assertion failure when running with --enable-asserts and the other is in the same file (I suspect it's also incorrect, but possibly it's never used - I'll look at that separately when I can trace some code that calls it).
      
      Fixes #20812.
      
      * Enable asserts for tools tests
      
      * Fix lint
      
      * Rename enableAsserts -> enableFlutterToolAsserts
      
      To make it clearer that it only enables asserts for flutter_tools when set.
      Unverified
      dc5a5c18
    • Jonah Williams's avatar
      Create flutter_driver infra for testing the Android AccessibilityNodeInfo... · 99b38295
      Jonah Williams authored
      Create flutter_driver infra for testing the Android AccessibilityNodeInfo generated by Flutter (#19700)
      
      Unverified
      99b38295
  21. 20 Aug, 2018 1 commit
    • Ian Hickson's avatar
      `flutter analyze` cleanup (#20490) · ad1eaff4
      Ian Hickson authored
      * `flutter analyze` cleanup
      
      * Make `--dartdocs` work in all modes.
      * Make `analyze-sample-code.dart` more resilient.
      * Add a test for `analyze-sample-code.dart`.
      * Minor cleanup in related code and files.
      
      * Apply review comments
      
      * Fix tests
      Unverified
      ad1eaff4
  22. 18 Aug, 2018 1 commit
    • Ian Hickson's avatar
      Fixes resulting from audit of issues links (#20772) · 8c79f40d
      Ian Hickson authored
      * Fixes resulting from audit of issues links
      
      I looked at every link to GitHub in our repo. For cases where we had a TODO that was waiting for a bug to be fixed, and the bug has now been fixed, I applied the pending change. For cases where the link was out of date, I updated the link.
      
      * Update run_test.dart
      
      skip this test again since it failed on linux and macos bots
      Unverified
      8c79f40d
  23. 17 Aug, 2018 1 commit
    • Ian Hickson's avatar
      Clean up usage of temporary directories (#20682) · 3dec6a69
      Ian Hickson authored
      All temporary directory start with `flutter_` and have their random component separated from the name by a period, as in `flutter_test_bundle.YFYQMY`.
      
      I've tried to find some of the places where we didn't cleanly delete temporary directories, too. This greatly reduces, though it does not entirely eliminate, the directories we leave behind when running tests, especially `flutter_tools` tests.
      
      While I was at it I standardized on `tempDir` as the variable name for temporary directories, since it was the most common, removing occurrences of `temp` and `tmp`, among others.
      
      Also I factored out some common code that used to catch exceptions that happen on Windows, and made more places use that pattern.
      Unverified
      3dec6a69
  24. 15 Aug, 2018 3 commits
    • Martin Kustermann's avatar
      Reland "Roll engine to version e3687f70c7ece72000b32ee1b3c02755ba5361ac (#20427)" (#20633) · 9299c02c
      Martin Kustermann authored
      * Reland "Roll engine to version b148e628ec86b3a9a0382e0bcfae73f0390a8232 (#20427)"
      
      This is a re-land with downgraded `package:flutter_gallery_assets`
      version.
      
      * Downgrade package:flutter_gallery_assets to 0.1.4
      
      * Change engine.version to 81baff97c29bb08cbf8453a3f9042c5813f84ad3 (which contains an additional fix)
      
      * Change engine.version to e3687f70c7ece72000b32ee1b3c02755ba5361ac (since mac tarballs are corrupted on earlier commit)
      9299c02c
    • Martin Kustermann's avatar
      Revert "Roll engine to version b148e628ec86b3a9a0382e0bcfae73f0390a8232 (#20427)" (#20631) · 515909ec
      Martin Kustermann authored
      Reason for revert: The package:flutter_gallery_assets has removed some images which are required for the examples/flutter_gallery, so the gallery build is failing (only discovered after landing, since gallery doesn't seem to get built during github PR presubmit checks)
      Unverified
      515909ec
    • Martin Kustermann's avatar
      Roll engine to version b148e628ec86b3a9a0382e0bcfae73f0390a8232 (#20427) · c7c493ea
      Martin Kustermann authored
      This CL
      
        * rolls `engine.version` to flutter/engine@b148e628 (which includes dart sdk 2.1.0-dev)
        * rolls `goldens.version` to flutter/goldens@6c45fafdf (which includes updates due to skia changes in engine)
        * changes `platform.dill` to `platform_strong.dill` in various places due to flutter/engine@a84b210b
        * adds explicit `environment: sdk: ">=2.0.0-dev.68 < 3.0.0"` constraints to `pubspec.yaml` and `pubspec.yaml.tmpl` files (since pub defaults to `<2.0.0` if omitted) 
        * upgrades to newer versions of various 3rd party packages (to ensure transitive dependencies have `<3.0.0` sdk constraint)
      Unverified
      c7c493ea