- 09 Oct, 2020 6 commits
-
-
James D. Lin authored
[flutter tools] Add a DelegatingLogger class Move most of `DelegateLogger` `from test/src/testbed.dart` to `lib/src/base/logger.dart` to better formalize the common practice of chaining `Logger`s together. I renamed the class since it isn't itself the delegate and to better match the `Delegating...` classes from `package:collection`. Additionally, add a freestanding `asLogger<T>` function to "cast" a `Logger` into a matching delegate if possible. This will allow `Logger` chains to be ordered a *bit* more freely (e.g. `NotifyingLogger` and `AppRunLogger` will no longer required to be at the end of the chain, an unwritten rule that has led to breakage in google3). Chain order still matters since lack of virtual dispatch means that parent `Logger`s can never invoke child methods, however. I made `asLogger<T>` a freestanding function because I didn't want to make it part of the `Logger` interface (and I thought that making it an extension method might be weird). Bonus cleanup: There no longer appears to be a way to construct an `AppRunLogger` with a null parent, so remove all of code paths for that case and make the `parent` construction parameter required.
-
Jonah Williams authored
If the vm of an attached device rejects a hot reload, pretty print the reason. Suggest a hot restart so that users are aware that they do not have to detach and rebuild. Also resets the last compilation time, so a subsequent restart would still apply the last change. Adds an integration test for the const field removal. Fixes #64027
-
Jonah Williams authored
The train command does nothing and was originally added to provide a no-output default for generating app-jit snapshots. The inject-plugins command is only for a repo-only analysis check, which is not necessary since we regenerate during pub get. #29805
-
Jonah Williams authored
[flutter_tools] remove globals from IntelliJ validator, refactor tests to remove dependency on JAR (#67240) Move the intellij validator to its own file, and split off the tests. Remove globals from each, and remove dependency on a real jar/filesystem by creating a minimal version of the manifest xml and setting it up in the memory file system. #47161
-
Jonah Williams authored
Do not upload all assets on initial devFS sync. This should increase the reliability of the initial connection, even in the face of flaky devfs behavior, in addition to a moderate perf improvement. Updates fast-start to build assets as part of the initial bundle Requires flutter/engine#21436 Requires flutter/engine#21586 Requires flutter/engine#21611
-
Jenn Magder authored
-
- 08 Oct, 2020 7 commits
-
-
Jenn Magder authored
-
Jonah Williams authored
-
Jonah Williams authored
* [flutter_tools] enable LocalDevFSWriter for desktop devices, iOS simulator * Update device.dart * Update desktop_device_test.dart * fix analysis errors
-
Christopher Fujino authored
We used to use zip to verify the integrity of downloaded zip archives, but we now use unzip. This removes the .zip method from OperatingSystemUtils.
-
Jonah Williams authored
Remove global variables from compile.dart and devices.dart (except for dds which needs more changes). #47161
-
Yegor authored
Work around the glibc bug that causes rare Chrome crashes
-
Dan Field authored
-
- 07 Oct, 2020 6 commits
-
-
Jonah Williams authored
-
Jonah Williams authored
This reverts commit 76cbc462.
-
Jonah Williams authored
There have been some more additional reports of a missing 'package:characters' import after upgrading flutter, as well as problems with detecting the correct language version. This has me concerned that our pub caching logic is incorrect. Instead of the tool attempting to guess when pub should be run, always delegate to pub.
-
Jenn Magder authored
-
Jonah Williams authored
Woops, this is breaking Dart's golem benchmarks
-
Jonah Williams authored
Split from #66776 Even if pub does not change the packge_config contents, it will still update a timestamp in one of the fields. This causes unnecessary rebuilds. To fix this, generate an additional file when running pub get that only contains the relevant fields and then update the KernelSnapshot rule to depend on it only.
-
- 06 Oct, 2020 7 commits
-
-
Jonah Williams authored
* [flutter_test] handle breaking change to test main . Fixes #67382
-
stuartmorgan authored
When the developer doesn't have permission to create symlinks, we display specific instructions, but they were only correct for recent versions of Windows 10. This improves them by: - Giving the correct instructions for older versions. - For recent versions, adds a command that will deep-link into the settings application so that developers don't have to figure out where/how to enable developer mode. Fixes https://github.com/flutter/flutter/issues/66973
-
Nate Bosch authored
Use the new single `src/platform.dart` import to pick up what is needed to implement a test platform from both `test_api` and `test_core`.
-
Jonah Williams authored
Many of the host only devicelab tests were relying on doctor to download android dependencies.
-
Jonah Williams authored
[flutter_tools] remove globals from FlutterValidator, add documentation and move tests to new file (#67234) Remove globals from the flutter validator class, and refactor the tests into a separate file. Applies some other cleanup like adding doc comments, and making the doctor validator work like it is documented to work - removing the gen_snapshot check if the artifact is not downloaded instead of downloading all android artifacts. #47161
-
Jonah Williams authored
Add some placeholder docs to the Cocoapods validator and Cocoapods class. Add the injected validator to globals. #47161
-
Jonah Williams authored
[flutter_tools] handle case where file is deleted by other program or running on read only volume (#66708) * [flutter_tools] handle case where file is deleted by other program * Add test cases * Update file_system.dart * Update file_system_test.dart * fix import * make a static on ErrorHandligFS * add support for no exit on failure * address comments * update doc comment to file or directory
-
- 05 Oct, 2020 9 commits
-
-
Jonah Williams authored
Make the logic for locating a local engine path part of its own class, add documentation, and update tests to cover engine source path locating too. #47161
-
Jonah Williams authored
Cleans up some undocumented classes and re-organizes the AndroidDevices class to avoid the need for the static testing only member. Adds a script for tracking globals.
-
Jonah Williams authored
Removes usage of global variables, expands documentation, and fixes some formatting inconsistencies. Increased test coverage for android plugin to prove it can determine the embedding version.
-
Jonah Williams authored
[flutter_tools] disable source maps by default for release builds, enable for run and with command line arg (#67331) Disables source map production by default for build web. For web builds performed as a part of flutter run --release, enable the source maps, or allow force enabling with --source-maps command line flag. fixes #67328
-
Dan Field authored
-
Jonah Williams authored
This functionality ultimately became the single widget reload optimization, which did not require a separate service protocol.
-
Jonah Williams authored
[flutter_tools] support all engine debugging options with FLUTTER_ENGINE_SWITCH environment variables (#67150) Allow providing all debugging options to the desktop engine via the FLUTTER_ENGINE_SWITCH_ environment variables. Fixes #66532 Fixes #46005 Fixes #58882 The underling engine changes have already landed for Windows, macOS, but linux is still in progress
-
Jonah Williams authored
Any File-derived IOSink may throw un-handleable async exceptions into the zone, see dart-lang/sdk#43663 . Instead, just write to a file with an append mode.
-
Danny Tuppeny authored
-
- 03 Oct, 2020 4 commits
-
-
Jesse authored
This PR changes the Config class in flutter_tools to use the XDG Base directory specification instead of putting files directly in the user's home directory. If those files are already present in the home directory, they are used instead.
-
Jonah Williams authored
Refactors the desktop devices and workflow to remove unnecessary usage of global variables. This should make it easier to test and continue enhancing the desktop functionality of the tooling #47161
-
Jonah Williams authored
[null-safety] add integration tests for sound null safety modes, add support for sound null safety in dart2js (#67171) Add integration tests to verify that ddc and dart2js can be built and run in sound mode. Updates dart2js compilation to insert a language version comment into the generated entrypoint if necessary. dart-lang/sdk#42253
-
Jonah Williams authored
Flutter logs should not attempt to filter the device list based on the current project, because it does not require a current project. Also fix disabled polling test Fixes #47996 Fixes #63550
-
- 02 Oct, 2020 1 commit
-
-
Jonah Williams authored
Force opt-in flutter test platform to null safety for repo testing
-