Commits · e12d1a798c4984c81de284bdef9ae6687624725f · abdullh.alsoleman / Front-End

29 Oct, 2023 1 commit

Reland `coverableLineCache` optimisation (#136851) (#137385) · e12d1a79

Liam Appelbe authored Oct 29, 2023

Relands #136851, which was rolled back in #137121

package:coverage has been rolled, so the breakages should be fixed.
Also, in this reland I've changed the `coverableLineCache` parameter to
be optional, which is safer.

e12d1a79

28 Oct, 2023 9 commits

Instrument RestorationBucket, _RouteEntry and DisposableBuildContext for leak tracking. (#137477) · f05bb9a1
Kostia Sokolovskyi authored Oct 28, 2023

f05bb9a1
BannerPainter should dispatch creation and disposal events. (#137472) · 50ecd570
Kostia Sokolovskyi authored Oct 28, 2023

50ecd570

Roll Flutter Engine from f5fbd9cd60c6 to 84dcb4fb9301 (1 revision) (#137468) · a4ec6278

engine-flutter-autoroll authored Oct 28, 2023

https://github.com/flutter/engine/compare/f5fbd9cd60c6...84dcb4fb9301

2023-10-28 skia-flutter-autoroll@skia.org Roll Skia from 60f985e90c5d to d29cc3fe182f (2 revisions) (flutter/engine#47419)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

a4ec6278

Roll Flutter Engine from 03de8a41995b to f5fbd9cd60c6 (2 revisions) (#137467) · 7ed6e29e

engine-flutter-autoroll authored Oct 28, 2023

https://github.com/flutter/engine/compare/03de8a41995b...f5fbd9cd60c6

2023-10-28 skia-flutter-autoroll@skia.org Roll Skia from 71449db76bef to 60f985e90c5d (2 revisions) (flutter/engine#47415)
2023-10-28 skia-flutter-autoroll@skia.org Roll Skia from 64f13d5be3f7 to 71449db76bef (1 revision) (flutter/engine#47413)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

7ed6e29e

Instrument more disposables. (#137309) · 65c71d42
Polina Cherkasova authored Oct 28, 2023

65c71d42
TextPainter should dispatch creation and disposal events. (#137416) · fea56130
Kostia Sokolovskyi authored Oct 28, 2023

fea56130

Roll Flutter Engine from a76821199d9d to 03de8a41995b (2 revisions) (#137464) · 14f95576

engine-flutter-autoroll authored Oct 28, 2023

https://github.com/flutter/engine/compare/a76821199d9d...03de8a41995b

2023-10-28 flar@google.com [Impeller] Rect getters (flutter/engine#47411)
2023-10-28 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from fw9lcUvz8S07_zaAj... to 9YSl2rN0sj5YpYNdQ... (flutter/engine#47409)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from fw9lcUvz8S07 to 9YSl2rN0sj5Y

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

14f95576

Roll Flutter Engine from f1e30b4b9f27 to a76821199d9d (3 revisions) (#137462) · efad4522

engine-flutter-autoroll authored Oct 28, 2023

https://github.com/flutter/engine/compare/f1e30b4b9f27...a76821199d9d

2023-10-28 32242716+ricardoamador@users.noreply.github.com Add Android Emulator dependencies as "test_dependencies" to Android tests (flutter/engine#47384)
2023-10-27 mdebbar@google.com [web] DomManager for each FlutterView (flutter/engine#47388)
2023-10-27 skia-flutter-autoroll@skia.org Roll Skia from 77abd518ad4a to 64f13d5be3f7 (2 revisions) (flutter/engine#47406)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

efad4522

Roll Flutter Engine from 7e2aa68b2f27 to f1e30b4b9f27 (2 revisions) (#137461) · 67c3147d

engine-flutter-autoroll authored Oct 28, 2023

https://github.com/flutter/engine/compare/7e2aa68b2f27...f1e30b4b9f27

2023-10-27 30870216+gaaclarke@users.noreply.github.com [Impeller] started scaling the gaussian blur sigma to match skia output (flutter/engine#47405)
2023-10-27 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from gPQSfYJVLOgXjxQce... to ESkamdoXWIwkdWdP-... (flutter/engine#47404)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from gPQSfYJVLOgX to ESkamdoXWIwk

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

67c3147d

27 Oct, 2023 28 commits

Roll Flutter Engine from 513e007ed682 to 7e2aa68b2f27 (1 revision) (#137460) · 2506e532

engine-flutter-autoroll authored Oct 27, 2023

https://github.com/flutter/engine/compare/513e007ed682...7e2aa68b2f27

2023-10-27 zanderso@users.noreply.github.com Remove //third_party/khronos (flutter/engine#47398)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

2506e532

Roll Flutter Engine from 32bb5b057c86 to 513e007ed682 (3 revisions) (#137457) · 100d5b94

engine-flutter-autoroll authored Oct 27, 2023

https://github.com/flutter/engine/compare/32bb5b057c86...513e007ed682

2023-10-27 skia-flutter-autoroll@skia.org Roll Skia from ccc3518a67b5 to 77abd518ad4a (5 revisions) (flutter/engine#47399)
2023-10-27 skia-flutter-autoroll@skia.org Roll Dart SDK from 360370ff93b0 to 5a666e8d8259 (15 revisions) (flutter/engine#47392)
2023-10-27 skia-flutter-autoroll@skia.org Roll Skia from ebb2a3d4699b to ccc3518a67b5 (1 revision) (flutter/engine#47394)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

100d5b94

Roll Flutter Engine from f2ec263cebf9 to 32bb5b057c86 (1 revision) (#137452) · 6b2e62f9

engine-flutter-autoroll authored Oct 27, 2023

https://github.com/flutter/engine/compare/f2ec263cebf9...32bb5b057c86

2023-10-27 zanderso@users.noreply.github.com Move gtest-parallel to flutter/third_party (flutter/engine#47393)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

6b2e62f9

Bump github/codeql-action from 2.22.4 to 2.22.5 (#137450) · ea6aea98

dependabot[bot] authored Oct 27, 2023

Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2.22.4 to 2.22.5.
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/github/codeql-action/blob/main/CHANGELOG.md">github/codeql-action's changelog</a>.</em></p>
<blockquote>
<h1>CodeQL Action Changelog</h1>
<p>See the <a href="https://github.com/github/codeql-action/releases">releases page</a> for the relevant changes to the CodeQL CLI and language packs.</p>
<h2>[UNRELEASED]</h2>
<p>No user facing changes.</p>
<h2>2.22.5 - 27 Oct 2023</h2>
<p>No user facing changes.</p>
<h2>2.22.4 - 20 Oct 2023</h2>
<ul>
<li>Update default CodeQL bundle version to 2.15.1. <a href="https://redirect.github.com/github/codeql-action/pull/1953">#1953</a></li>
<li>Users will begin to see warnings on Node.js 16 deprecation in their Actions logs on code scanning runs starting October 23, 2023.
<ul>
<li>All code scanning workflows should continue to succeed regardless of the warning.</li>
<li>The team at GitHub maintaining the CodeQL Action is aware of the deprecation timeline and actively working on creating another version of the CodeQL Action, v3, that will bump us to Node 20.</li>
<li>For more information, and to communicate with the maintaining team, please use <a href="https://redirect.github.com/github/codeql-action/issues/1959">this issue</a>.</li>
</ul>
</li>
</ul>
<h2>2.22.3 - 13 Oct 2023</h2>
<ul>
<li>Provide an authentication token when downloading the CodeQL Bundle from the API of a GitHub Enterprise Server instance. <a href="https://redirect.github.com/github/codeql-action/pull/1945">#1945</a></li>
</ul>
<h2>2.22.2 - 12 Oct 2023</h2>
<ul>
<li>Update default CodeQL bundle version to 2.15.0. <a href="https://redirect.github.com/github/codeql-action/pull/1938">#1938</a></li>
<li>Improve the log output when an error occurs in an invocation of the CodeQL CLI. <a href="https://redirect.github.com/github/codeql-action/pull/1927">#1927</a></li>
</ul>
<h2>2.22.1 - 09 Oct 2023</h2>
<ul>
<li>Add a workaround for Python 3.12, which is not supported in CodeQL CLI version 2.14.6 or earlier. If you are running an analysis on Windows and using Python 3.12 or later, the CodeQL Action will switch to running Python 3.11. In this case, if Python 3.11 is not found, then the workflow will fail. <a href="https://redirect.github.com/github/codeql-action/pull/1928">#1928</a></li>
</ul>
<h2>2.22.0 - 06 Oct 2023</h2>
<ul>
<li>The CodeQL Action now requires CodeQL version 2.10.5 or later. For more information, see the corresponding changelog entry for CodeQL Action version 2.21.8. <a href="https://redirect.github.com/github/codeql-action/pull/1907">#1907</a></li>
<li>The CodeQL Action no longer runs ML-powered queries. For more information, including details on our investment in AI-powered security technology, see <a href="https://github.blog/changelog/2023-09-29-codeql-code-scanning-deprecates-ml-powered-alerts/">&quot;CodeQL code scanning deprecates ML-powered alerts.&quot;</a> <a href="https://redirect.github.com/github/codeql-action/pull/1910">#1910</a></li>
<li>Fix a bug which prevented tracing of projects using Go 1.21 and above on Linux. <a href="https://redirect.github.com/github/codeql-action/pull/1909">#1909</a></li>
</ul>
<h2>2.21.9 - 27 Sep 2023</h2>
<ul>
<li>Update default CodeQL bundle version to 2.14.6. <a href="https://redirect.github.com/github/codeql-action/pull/1897">#1897</a></li>
<li>We are rolling out a feature in October 2023 that will improve the success rate of C/C++ autobuild. <a href="https://redirect.github.com/github/codeql-action/pull/1889">#1889</a></li>
<li>We are rolling out a feature in October 2023 that will provide specific file coverage information for C and C++, Java and Kotlin, and JavaScript and TypeScript. Currently file coverage information for each of these pairs of languages is grouped together. <a href="https://redirect.github.com/github/codeql-action/pull/1903">#1903</a></li>
<li>Add a warning to help customers avoid inadvertently analyzing the same CodeQL language in multiple matrix jobs. <a href="https://redirect.github.com/github/codeql-action/pull/1901">#1901</a></li>
</ul>
<h2>2.21.8 - 19 Sep 2023</h2>
<ul>
<li>Add a deprecation warning for customers using CodeQL version 2.10.4 and earlier. These versions of CodeQL were discontinued on 12 September 2023 alongside GitHub Enterprise Server 3.6, and will be unsupported by the next minor release of the CodeQL Action. <a href="https://redirect.github.com/github/codeql-action/pull/1884">#1884</a>
<ul>
<li>If you are using one of these versions, please update to CodeQL CLI version 2.10.5 or later. For instance, if you have specified a custom version of the CLI using the 'tools' input to the 'init' Action, you can remove this input to use the default version.</li>
</ul>
</li>
</ul>
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/github/codeql-action/commit/74483a38d39275f33fcff5f35b679b5ca4a26a99"><code>74483a3</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/1972">#1972</a> from github/update-v2.22.5-2d5ffa777</li>
<li><a href="https://github.com/github/codeql-action/commit/2ba6829f2be5b94619d62b0fa920cbceb03b4c25"><code>2ba6829</code></a> Update changelog for v2.22.5</li>
<li><a href="https://github.com/github/codeql-action/commit/2d5ffa7773a66e73dade704e35d2d50378caddac"><code>2d5ffa7</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/1970">#1970</a> from github/henrymercer/clean-up-init-logs</li>
<li><a href="https://github.com/github/codeql-action/commit/14d0fa93b407a5901c543d04d95cb7f47b64da50"><code>14d0fa9</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/1967">#1967</a> from github/henrymercer/enable-features-on-ghes</li>
<li><a href="https://github.com/github/codeql-action/commit/5744b13b669bded0635b39ab6bcfea7bd8aa81b2"><code>5744b13</code></a> Rebuild Action</li>
<li><a href="https://github.com/github/codeql-action/commit/f3b55862ea536f287e422fe679ff5a2d31ae22ee"><code>f3b5586</code></a> Check out the right branch in <code>rebuild.yml</code></li>
<li><a href="https://github.com/github/codeql-action/commit/95c219819daf2d5528ce5e88bd18d58ed97d1550"><code>95c2198</code></a> Add a log in the OK case</li>
<li><a href="https://github.com/github/codeql-action/commit/e8e83c3a56bd831d3e9bf6353a799842468c8299"><code>e8e83c3</code></a> Merge branch 'main' into henrymercer/enable-features-on-ghes</li>
<li><a href="https://github.com/github/codeql-action/commit/c7abe9ca5f33e2f7fa03694eef40bb97815c7250"><code>c7abe9c</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/1971">#1971</a> from github/henrymercer/bot-rebuild</li>
<li><a href="https://github.com/github/codeql-action/commit/3fc281e07926297f6a1415e70999053c90c5e329"><code>3fc281e</code></a> Add workflow to rebuild the Action on a label</li>
<li>Additional commits viewable in <a href="https://github.com/github/codeql-action/compare/49abf0ba24d0b7953cb586944e918a0b92074c80...74483a38d39275f33fcff5f35b679b5ca4a26a99">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=github/codeql-action&package-manager=github_actions&previous-version=2.22.4&new-version=2.22.5)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

ea6aea98

Roll Flutter Engine from 453a04dbf891 to f2ec263cebf9 (2 revisions) (#137449) · 40252cf9

engine-flutter-autoroll authored Oct 27, 2023

https://github.com/flutter/engine/compare/453a04dbf891...f2ec263cebf9

2023-10-27 zanderso@users.noreply.github.com Move flatbuffers to flutter/third_party (flutter/engine#47387)
2023-10-27 skia-flutter-autoroll@skia.org Roll Skia from ba3e1db468d0 to ebb2a3d4699b (10 revisions) (flutter/engine#47390)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

40252cf9

[web] Add 'nonce' prop to flutter.js loadEntrypoint (#137204) · 15ccf24d

David Iglesias authored Oct 27, 2023

## Description

This PR adds a `nonce` parameter to flutter.js' `loadEntrypoint` method.

When set, loadEntrypoint will add a `nonce` attribute to the `main.dart.js` script tag, which allows Flutter to run in environments slightly more restricted by CSP; those that don't add `'self'` as a valid source for `script-src`.

----

### CSP directive

After this change, the CSP directive for a Flutter Web index.html can be:

```
script-src 'nonce-YOUR_NONCE_VALUE' 'wasm-unsafe-eval';
font-src https://fonts.gstatic.com;
style-src 'nonce-YOUR_NONCE_VALUE';
```

When CSP is set via a `meta` tag (like in the test accompanying this change), and to use a service worker, the CSP needs an additional directive: [`worker-src 'self';`](https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Content-Security-Policy/worker-src)

When CSP set via response headers, the CSP that applies to `flutter_service_worker.js` is determined by its response headers. See **Web Workers API > [Content security policy](https://developer.mozilla.org/en-US/docs/Web/API/Web_Workers_API/Using_web_workers#content_security_policy)** in MDN.)

----

### Initialization

If the CSP is set to disallow `script-src 'self'`, a nonce needs to also be passed to `loadEntrypoint`:

```javascript
  _flutter.loader.loadEntrypoint({
    nonce: 'SOME_NONCE',
    onEntrypointLoaded: (engineInitializer) async {
      const appRunner = await engineInitializer.initializeEngine({
        nonce: 'SOME_NONCE',
      });
      appRunner.runApp();
    },
  });
```

(`nonce` shows twice for now, because the entrypoint loader script doesn't have direct access to the `initializeEngine` call.)

----

## Tests

* Added a smoke test to ensure an app configured as described above starts.

## Issues

* Fixes https://github.com/flutter/flutter/issues/126977

15ccf24d

Roll Flutter Engine from 1e66c0ae7bda to 453a04dbf891 (1 revision) (#137446) · 82288243

engine-flutter-autoroll authored Oct 27, 2023

https://github.com/flutter/engine/compare/1e66c0ae7bda...453a04dbf891

2023-10-27 skia-flutter-autoroll@skia.org Roll Skia from fe9959acc5e0 to ba3e1db468d0 (1 revision) (flutter/engine#47382)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

82288243

Provide exception for listing an issue. (#137092) · 76ef7af9

Michael Goderbauer authored Oct 27, 2023

Latest example of an issue about a typo: https://github.com/flutter/flutter/issues/137080. I don't think these are helpful, so we shouldn't be encouraging people to file these in order to submit a PR to fix 'em.

76ef7af9

Roll Flutter Engine from 0bba9eeb8f5d to 1e66c0ae7bda (1 revision) (#137442) · 3e6ddb62

engine-flutter-autoroll authored Oct 27, 2023

https://github.com/flutter/engine/compare/0bba9eeb8f5d...1e66c0ae7bda

2023-10-27 30870216+gaaclarke@users.noreply.github.com Made FlutterTaskQueue visible for Swift. (flutter/engine#47348)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

3e6ddb62

Roll Flutter Engine from a198ad4e740d to 0bba9eeb8f5d (1 revision) (#137437) · 5db4586b

engine-flutter-autoroll authored Oct 27, 2023

https://github.com/flutter/engine/compare/a198ad4e740d...0bba9eeb8f5d

2023-10-27 zanderso@users.noreply.github.com Move shaderc to flutter/third_party (flutter/engine#47383)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

5db4586b

Bump goldctl in .ci.yaml (#137441) · fbc14516
Kate Lovett authored Oct 27, 2023
```
Related to https://github.com/flutter/flutter/issues/137177
```
fbc14516

Add `isLogicalKeyPressed` to `KeyEvent` (#136856) · 5907c975

Greg Spencer authored Oct 27, 2023

## Description

Adds some convenience methods to `KeyEvent` that allow testing to see if a logical or physical key is pressed from the event object. These are similar to the ones already on `RawKeyEvent`, and will make migration the to `KeyEvent` easier (so it could more easily be a `flutter fix` migration).

Added:

- `bool isLogicalKeyPressed(LogicalKeyboardKey key)`
- `bool isPhysicalKeyPressed(PhysicalKeyboardKey key)`
- `bool get isControlPressed`
- `bool get isShiftPressed`
- `bool get isAltPressed`
- `bool get isMetaPressed`

## Related Issues
 - https://github.com/flutter/flutter/issues/136419

## Tests
 - Added tests for the new methods.

5907c975

Reverts "Ensure `flutter build apk --release` optimizes+shrinks platform code" (#137433) · 4cae1af4

auto-submit[bot] authored Oct 27, 2023

Reverts flutter/flutter#136880
Initiated by: camsim99
This change reverts the following previous change:
Original Description:
Since the original PR that supposedly enabled proguard, it was using the android proguard rules that disable optimizations. See initial PR in [0]

This PR changes the flutter gradle plugin to use the `proguard-android-optimize.txt` (instead of `proguard-android.txt`) which will enable optimizations/shrinking of platform code (i.e. java/kotlin).

For a simple flutter hello world this results in a 25% reduction in the resulting DEX file (`classes.dex` of the APK).

[0] f098de1f

Fixes https://github.com/flutter/flutter/issues/136879

4cae1af4

Roll Flutter Engine from bedc49efc85c to a198ad4e740d (20 revisions) (#137429) · 47c3c120

engine-flutter-autoroll authored Oct 27, 2023

https://github.com/flutter/engine/compare/bedc49efc85c...a198ad4e740d

2023-10-27 jonahwilliams@google.com [Impeller] Add present wait latch. (flutter/engine#47311)
2023-10-27 zanderso@users.noreply.github.com Move rapidjson to flutter/third_party (flutter/engine#47354)
2023-10-27 jason-simmons@users.noreply.github.com [Impeller] Enable GLES MSAA only if the multisampled_render_to_texture2 extension is available (flutter/engine#47364)
2023-10-27 jason-simmons@users.noreply.github.com [Impeller] Fix leak of framebuffers used in GLES MSAA rendering (flutter/engine#47362)
2023-10-27 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Manual roll Dart SDK from 360370ff93b0 to 18678a3eddb7 (9 revisions)" (flutter/engine#47380)
2023-10-27 skia-flutter-autoroll@skia.org Roll Skia from 0122c0e18d26 to fe9959acc5e0 (1 revision) (flutter/engine#47379)
2023-10-27 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from 1ngqKBnmTtmFM6aBD... to fw9lcUvz8S07_zaAj... (flutter/engine#47377)
2023-10-27 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 37VxdxlPfdkek7mwC... to gPQSfYJVLOgXjxQce... (flutter/engine#47375)
2023-10-27 skia-flutter-autoroll@skia.org Roll Skia from 22f5419438c4 to 0122c0e18d26 (1 revision) (flutter/engine#47373)
2023-10-27 skia-flutter-autoroll@skia.org Roll Skia from 5262cbff56b1 to 22f5419438c4 (1 revision) (flutter/engine#47372)
2023-10-27 skia-flutter-autoroll@skia.org Roll Skia from fe61b3467547 to 5262cbff56b1 (1 revision) (flutter/engine#47371)
2023-10-27 skia-flutter-autoroll@skia.org Roll Skia from fbdd7d97b26e to fe61b3467547 (1 revision) (flutter/engine#47370)
2023-10-27 skia-flutter-autoroll@skia.org Roll Skia from 2246f3473053 to fbdd7d97b26e (2 revisions) (flutter/engine#47369)
2023-10-27 skia-flutter-autoroll@skia.org Roll Skia from ec4c6b3a6690 to 2246f3473053 (1 revision) (flutter/engine#47366)
2023-10-27 flar@google.com [Impeller] Add FilterContents::GetSourceCoverage to enable filtered saveLayer clipping. (flutter/engine#47183)
2023-10-27 skia-flutter-autoroll@skia.org Roll Skia from bc8ca57868d2 to ec4c6b3a6690 (1 revision) (flutter/engine#47365)
2023-10-27 john@johnmccutchan.com Don't re-initialize the default RenderSurface when returning from hybrid composition mode (flutter/engine#47358)
2023-10-27 skia-flutter-autoroll@skia.org Manual roll Dart SDK from 360370ff93b0 to 18678a3eddb7 (9 revisions) (flutter/engine#47357)
2023-10-26 skia-flutter-autoroll@skia.org Roll Skia from 93a0ad4d7ca6 to bc8ca57868d2 (2 revisions) (flutter/engine#47359)
2023-10-26 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from YSn00b0Trsu2vdhIq... to 1ngqKBnmTtmFM6aBD... (flutter/engine#47363)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from 37VxdxlPfdke to gPQSfYJVLOgX
fuchsia/sdk/core/mac-amd64 from YSn00b0Trsu2 to fw9lcUvz8S07

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

47c3c120

Make `SemanticsNode.isMergedIntoParent` Readonly (#137304) · 7a3135b9
LongCatIsLooong authored Oct 27, 2023
```
Fixes https://github.com/flutter/flutter/issues/54665
```
7a3135b9

Manual roll Flutter Engine from bedc49efc85c to 71e1a0430232 (16 revisions) (#137422) · 3ef84471

engine-flutter-autoroll authored Oct 27, 2023

Manual roll requested by zra@google.com

https://github.com/flutter/engine/compare/bedc49efc85c...71e1a0430232

2023-10-27 98614782+auto-submit[bot]@users.noreply.github.com Reverts
"Manual roll Dart SDK from 360370ff93b0 to 18678a3eddb7 (9 revisions)"
(flutter/engine#47380)
2023-10-27 skia-flutter-autoroll@skia.org Roll Skia from 0122c0e18d26 to
fe9959acc5e0 (1 revision) (flutter/engine#47379)
2023-10-27 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from
1ngqKBnmTtmFM6aBD... to fw9lcUvz8S07_zaAj... (flutter/engine#47377)
2023-10-27 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from
37VxdxlPfdkek7mwC... to gPQSfYJVLOgXjxQce... (flutter/engine#47375)
2023-10-27 skia-flutter-autoroll@skia.org Roll Skia from 22f5419438c4 to
0122c0e18d26 (1 revision) (flutter/engine#47373)
2023-10-27 skia-flutter-autoroll@skia.org Roll Skia from 5262cbff56b1 to
22f5419438c4 (1 revision) (flutter/engine#47372)
2023-10-27 skia-flutter-autoroll@skia.org Roll Skia from fe61b3467547 to
5262cbff56b1 (1 revision) (flutter/engine#47371)
2023-10-27 skia-flutter-autoroll@skia.org Roll Skia from fbdd7d97b26e to
fe61b3467547 (1 revision) (flutter/engine#47370)
2023-10-27 skia-flutter-autoroll@skia.org Roll Skia from 2246f3473053 to
fbdd7d97b26e (2 revisions) (flutter/engine#47369)
2023-10-27 skia-flutter-autoroll@skia.org Roll Skia from ec4c6b3a6690 to
2246f3473053 (1 revision) (flutter/engine#47366)
2023-10-27 flar@google.com [Impeller] Add
FilterContents::GetSourceCoverage to enable filtered saveLayer clipping.
(flutter/engine#47183)
2023-10-27 skia-flutter-autoroll@skia.org Roll Skia from bc8ca57868d2 to
ec4c6b3a6690 (1 revision) (flutter/engine#47365)
2023-10-27 john@johnmccutchan.com Don't re-initialize the default
RenderSurface when returning from hybrid composition mode
(flutter/engine#47358)
2023-10-27 skia-flutter-autoroll@skia.org Manual roll Dart SDK from
360370ff93b0 to 18678a3eddb7 (9 revisions) (flutter/engine#47357)
2023-10-26 skia-flutter-autoroll@skia.org Roll Skia from 93a0ad4d7ca6 to
bc8ca57868d2 (2 revisions) (flutter/engine#47359)
2023-10-26 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from
YSn00b0Trsu2vdhIq... to 1ngqKBnmTtmFM6aBD... (flutter/engine#47363)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from 37VxdxlPfdke to gPQSfYJVLOgX
  fuchsia/sdk/core/mac-amd64 from YSn00b0Trsu2 to fw9lcUvz8S07

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the
revert to ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

3ef84471

Roll Packages from fea24c5b93b4 to 2af69541a214 (5 revisions) (#137421) · 8cfa9c47

engine-flutter-autoroll authored Oct 27, 2023

https://github.com/flutter/packages/compare/fea24c5b93b4...2af69541a214

2023-10-26 katelovett@google.com [two_dimensional_scrollables] Add TableSpanPadding (flutter/packages#5039)
2023-10-26 engine-flutter-autoroll@skia.org Roll Flutter (stable) from 6c4930c4ac86 to d211f4286035 (1 revision) (flutter/packages#5238)
2023-10-26 chrislangham@rightnow.org [url_launcher] migrating objc plugin to swift (flutter/packages#4753)
2023-10-26 ybz975218925@live.com [go_router_builder]Avoid losing NullabilitySuffix for typeArguments (flutter/packages#5215)
2023-10-26 engine-flutter-autoroll@skia.org Roll Flutter from 5dd2a4e0 to c555599f (14 revisions) (flutter/packages#5237)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

8cfa9c47

Run tests on either macOS 12 or 13 (#137365) · e75f85bf

Victoria Ashworth authored Oct 27, 2023

In preparation for migrating our fleet to macOS 13, we're updating tests to run on either macOS 12 or macOS 13.

I have run all tests on macOS 13: https://docs.google.com/spreadsheets/d/1-KOSOSF7uVA4KuqSMn9xz3IIJW78u8SXLYK2OAfe_Qg/edit?usp=sharing&resourcekey=0-df8Bj5PRS1IPBccPDdvRCQ

e75f85bf

Revert "Update `DataTable` test when data row is pressed for Material 3 (#137230)" (#137407) · eba149fc

Taha Tesser authored Oct 27, 2023

This reverts commit 64f31b2f.

*Replace this paragraph with a description of what this PR is changing
or adding, and why. Consider including before/after screenshots.*

*List which issues are fixed by this PR. You must list at least one
issue.*

*If you had to change anything in the [flutter/tests] repo, include a
link to the migration guide as per the [breaking change policy].*

## Pre-launch Checklist

- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat

eba149fc

Revert "Reland - Update `OutlinedButton` tests for Material 3 (#136809) (#137247)" (#137406) · a0e8b6ae

Taha Tesser authored Oct 27, 2023

…9) (#137247)"

This reverts commit 008a10f1.

*Replace this paragraph with a description of what this PR is changing
or adding, and why. Consider including before/after screenshots.*

*List which issues are fixed by this PR. You must list at least one
issue.*

*If you had to change anything in the [flutter/tests] repo, include a
link to the migration guide as per the [breaking change policy].*

## Pre-launch Checklist

- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat

a0e8b6ae

Ensure `flutter build apk --release` optimizes+shrinks platform code (#136880) · 1dd21f8d

Martin Kustermann authored Oct 27, 2023

Since the original PR that supposedly enabled proguard, it was using the
android proguard rules that disable optimizations. See initial PR in [0]

This PR changes the flutter gradle plugin to use the
`proguard-android-optimize.txt` (instead of `proguard-android.txt`)
which will enable optimizations/shrinking of platform code (i.e.
java/kotlin).

For a simple flutter hello world this results in a 25% reduction in the
resulting DEX file (`classes.dex` of the APK).

Note for users:

For some users this may result in issues because their java/kotlin code is
now better optimized & tree shaken and thereby symbols may be no longer
available or being obfuscated.

To fix those issues it's best to craft precise proguard rules describing the
extra symbols that are needed by the app (see [1]). But it's also possible to
opt out entirely of optimizations by using the unoptimized proguard rules.

To add custom proguard rules or use the unoptimized android rules, one can
update `android/app/build.gradle`:
```
android {
    ...
    buildTypes {
        release {
            ...
+            proguardFiles(
+                // Not ideal: Disables optimizations by using unoptimized android rules.
+                getDefaultProguardFile("proguard-android.txt"),
+
+                // Better: Have precise keep rules to only keep things that are needed.
+                "custom-rules.pro",
+            )
        }
    }
}
```


[0] f098de1f
[1] https://developer.android.com/build/shrink-code

Fixes https://github.com/flutter/flutter/issues/136879

1dd21f8d

Update `DataTable` test when data row is pressed for Material 3 (#137230) · 64f31b2f

Taha Tesser authored Oct 27, 2023

This updates one of them M3 test to use golden test from https://github.com/flutter/flutter/pull/135901
Keeping it consistent with this [update](https://github.com/flutter/flutter/pull/136809#discussion_r1365053630)

64f31b2f

Reland - Update `OutlinedButton` tests for Material 3 (#136809) (#137247) · 008a10f1

Taha Tesser authored Oct 27, 2023

This relands https://github.com/flutter/flutter/pull/136809 (it was reverted in https://github.com/flutter/flutter/pull/137242)
---

Updated unit tests for `CircleOutlinedButton` to have M2 and M3 versions.

More info in #127064

This also gets rid of unnecessary `fromSwatch` usage (part of https://github.com/flutter/flutter/issues/132584 documentation and test cleanup)

008a10f1

update asset manifest file name referenced in `WebServiceWorker` (#135954) · 42389741

Andrew Kolos authored Oct 27, 2023

Closes https://github.com/flutter/flutter/issues/130455.

Updates the name `WebServiceWorker` uses to reference the asset manifest file to the name of the new file generated since   https://github.com/flutter/flutter/pull/131382. This will make Flutter web apps correctly prefetch the asset manifest file.

42389741

give `throwsToolExit` a more useful description (#136694) · 1328997b

Andrew Kolos authored Oct 27, 2023

Fixes https://github.com/flutter/flutter/issues/136698.

Alters how `throwToolExit` creates its matcher. This results is an improved description of the matcher.

The mismatch description isn't improved by this, but I writing an entirely custom matcher to fix this isn't ideal either. We can instead mitigate the issue by augmenting the `toString` implementation of `ToolExit` to include the exit code, if it is non-null.

With these changes, the first few lines of output from a test would look like this:

```
Expected: throws <Instance of 'ToolExit'> with `exitCode`: <42> and `message`: contains 'message'
  Actual: <Closure: () => Never>
   Which: threw ToolExit:<Exit code: 41232. Error: message>
```

1328997b

Add ConstrainedLayoutBuilder.updateShouldRebuild() (#136691) · 37da62a6

Todd Volkert authored Oct 27, 2023

This method controls whether the builder needs to be called again again even if the layout constraints are the same.

By default, the builder will always be called when the widget is updated because the logic in the callback might have changed. However, there are cases where subclasses of ConstrainedLayoutBuilder know that certain property updates only affect paint and not build. In these cases, we lack a way of expressing that the builder callback is not needed -- and we end up doing superfluous work.

This PR gives subclasses the ability to know exactly when the callback needs to be called and when it can be skipped.

37da62a6

Fix. typos (#137325) · 9e04246c

Binni Goel authored Oct 27, 2023

## Description

This PR fixes typos in 
- `actions.dart`
- `app_bar.dart`
- `basic.dart`
- `button_bar_theme.dart`

9e04246c

Roll Flutter Engine from 87f384c2d70b to bedc49efc85c (1 revision) (#137382) · daec48d8

engine-flutter-autoroll authored Oct 27, 2023

https://github.com/flutter/engine/compare/87f384c2d70b...bedc49efc85c

2023-10-26 dkwingsmt@users.noreply.github.com Skip invalid renders in Dart (flutter/engine#47323)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

daec48d8

26 Oct, 2023 2 commits
- Fix Typos (#137292) · b62da791
  Tirth authored Oct 26, 2023
```
Fix Small Typos.
```
  b62da791
- AnimationController should dispatch creation in constructor. (#134839) · aeb500a0
  Kostia Sokolovskyi authored Oct 26, 2023
  
  aeb500a0