Commits · df8ee8d63a6e1d3c0a046ea1f3c11058fefd4b21 · abdullh.alsoleman / Front-End

01 Sep, 2023 23 commits

[Windows Arm64] Add first device lab test (#133895) · df8ee8d6

Loïc Sharma authored Sep 01, 2023

Adds the first Windows Arm64 devicelab test. The builder for this test won't be created until after this lands on master, so we can't actually test this until this is merged.

df8ee8d6

Revert "fix install checks in flavors devicelab tests" (#133894) · 5649161b
Victoria Ashworth authored Sep 01, 2023
```
Reverts flutter/flutter#133719

`Windows_android flavors_test_win` failed twice in a row in the tree
```
5649161b

Remove deprecated... · b1f691c9

Renzo Olivares authored Sep 01, 2023

Remove deprecated TestWindow.platformBrightnessTestValue/TestWindow.clearPlatformBrightnessTestValue (#133178)

Part of: https://github.com/flutter/flutter/issues/133171

b1f691c9

fix install checks in flavors devicelab tests (#133719) · a66eae17
Andrew Kolos authored Sep 01, 2023
```
Fixes #133713
```
a66eae17

Remove deprecated... · 959cdb79

Renzo Olivares authored Sep 01, 2023

Remove deprecated TestWindow.textScaleFactorTestValue/TestWindow.clearTextScaleFactorTestValue (#133176)

Part of: https://github.com/flutter/flutter/issues/133171

959cdb79

Roll Flutter Engine from ddd03f863897 to d00b69a438a6 (2 revisions) (#133873) · 8cbf42a7

engine-flutter-autoroll authored Sep 01, 2023

https://github.com/flutter/engine/compare/ddd03f863897...d00b69a438a6

2023-09-01 skia-flutter-autoroll@skia.org Roll ICU from de4ce0071eb4 to 985b9a6f70e1 (2 revisions) (flutter/engine#45382)
2023-09-01 brianosman@google.com Migrate Fuchsia VK calls of GrBackend* (flutter/engine#45380)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

8cbf42a7

Change android_virtual_device to version 34 (#133809) · 033274c6

Gray Mackall authored Sep 01, 2023

Change from AVD 33 to [AVD 34](https://chrome-infra-packages.appspot.com/p/chromium/tools/android/avd/linux-amd64) in CI. Only affects two tests.

We should also update the firebase virtual and physical devices when 34 is available there (for example [here](https://github.com/flutter/flutter/blob/e98d3929ca421ca11dcc7662f59e73e0a7d293bd/.ci.yaml#L441)), as that will allow us to update a lot more tests.

033274c6

Run Mac_arm64_ios run_debug_test_macos in presubmit (#133869) · 37c55bab

Victoria Ashworth authored Sep 01, 2023

Reland https://github.com/flutter/flutter/pull/133788.

Fixes https://github.com/flutter/flutter/issues/118830.
Fixes https://github.com/flutter/flutter/issues/125342.

37c55bab

Roll Flutter Engine from 4c085b883d6f to ddd03f863897 (1 revision) (#133868) · 16b9e770

engine-flutter-autoroll authored Sep 01, 2023

https://github.com/flutter/engine/compare/4c085b883d6f...ddd03f863897

2023-09-01 skia-flutter-autoroll@skia.org Roll Skia from 4eb9b17d8e84 to d6266ef14a7e (1 revision) (flutter/engine#45376)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

16b9e770

Test cover more tests with leak tracking. (#133828) · 78ff1226
Polina Cherkasova authored Sep 01, 2023

78ff1226

Adds a parent scope TraversalEdgeBehavior and fixes modal route to no… (#130841) · 0f3bd90d

chunhtai authored Sep 01, 2023

…t trap the focus

fixes https://github.com/flutter/flutter/issues/112567

Several things I done:

1. add new enum `parentScope`
2. refactor _sortAllDescendants so that it doesn't recursively looking
into its descendant when it encounter a FocusScopeNode.
3. When the nextFocus try to focus into a FocusScopeNode, it will try to
find the first focusable FocusNode in traversal order and focus it
instead if it doesn't have a first focus.
4. Change the default in Navigator to always be `parentScope`
5. Only the root navigator will use `leaveFlutterView` if platform is
web.


Previously 2 and 3 are not needed because once a focusscope trapped the
focus, there isn't a chance where the parent focusscope have to deal
with next focus.

If we don't do 2 and 3 after the change, it will cause it to stuck in
the current scope again. Because once the focus leave the current scope,
it needs to also remove the first focus in that scope (so that it can
start fresh when focus traversal back to the scope in the future). At
this point the current scope will have the primary focus without the
first focus. The parent scope will then try to find the next focus, and
it will place the focus to the first traversal child in the current
scope again.

## Pre-launch Checklist

- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat

0f3bd90d

Fixed `PaginatedDataTable` not using `dataRowMinHeight` and `dataRowMaxHeight` from Theme (#133634) · 1b1c8a16

Mark O'Sullivan authored Sep 01, 2023

`PaginatedDataTable` will now make use of `dataRowMinHeight` and `dataRowMaxHeight` from the Theme

*List which issues are fixed by this PR. You must list at least one issue.*

Resolves #133633

1b1c8a16

Roll Flutter Engine from ced8f1a71206 to 4c085b883d6f (2 revisions) (#133857) · eb77b525

engine-flutter-autoroll authored Sep 01, 2023

https://github.com/flutter/engine/compare/ced8f1a71206...4c085b883d6f

2023-09-01 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from _x3hf702RacYnw3E6... to sk7JBGzW1Jw10Wy-T... (flutter/engine#45372)
2023-09-01 leroux_bruno@yahoo.fr [Linux] Fix channel buffers control commands error handling (flutter/engine#45056)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from _x3hf702RacY to sk7JBGzW1Jw1

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

eb77b525

Add more documentation for SystemChannels.keyboard getKeyboardState (#133663) · e3261999

Bruno Leroux authored Sep 01, 2023

## Description

This PR adds some documentation to SystemChannels.keyboard getKeyboardState.
This method was added in https://github.com/flutter/flutter/pull/122885.

## Related Issue

Fixes https://github.com/flutter/flutter/issues/132938.

## Tests

Documentation only.

e3261999

Fix MaterialState.pressed is missing when pressing button with keyboard (#133558) · 510ecaa4

Bruno Leroux authored Sep 01, 2023

## Description

This PR fixes changes how `InkWell` reacts to keyboard activation. 

**Before**: the activation started a splash and immediately terminated it which did not let time for widgets that resolve material state properties to react (visually it also mean the splash does not have time to expand).

**After**: the activation starts and terminates after a delay (I arbitrary choose 200ms for the moment).

## Related Issue

Fixes https://github.com/flutter/flutter/issues/132377.

## Tests

Adds one test.

510ecaa4

Roll Flutter Engine from 09cb3d99f24e to ced8f1a71206 (1 revision) (#133844) · f0b682bc

engine-flutter-autoroll authored Sep 01, 2023

https://github.com/flutter/engine/compare/09cb3d99f24e...ced8f1a71206

2023-09-01 skia-flutter-autoroll@skia.org Roll Skia from 6d95a1db276d to 4eb9b17d8e84 (1 revision) (flutter/engine#45369)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

f0b682bc

Roll Flutter Engine from 0769aba5b7d8 to 09cb3d99f24e (1 revision) (#133842) · c141126d

engine-flutter-autoroll authored Sep 01, 2023

https://github.com/flutter/engine/compare/0769aba5b7d8...09cb3d99f24e

2023-09-01 skia-flutter-autoroll@skia.org Roll Skia from 2916365d0fa6 to 6d95a1db276d (1 revision) (flutter/engine#45368)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

c141126d

Roll Flutter Engine from a9ebed54c451 to 0769aba5b7d8 (2 revisions) (#133839) · 4324d211

engine-flutter-autoroll authored Sep 01, 2023

https://github.com/flutter/engine/compare/a9ebed54c451...0769aba5b7d8

2023-09-01 skia-flutter-autoroll@skia.org Roll Skia from e585fdc18134 to 2916365d0fa6 (1 revision) (flutter/engine#45366)
2023-09-01 jonahwilliams@google.com [Impeller] use correct blend mode for performance overlay (flutter/engine#45365)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

4324d211

Roll Flutter Engine from 01e74b252ee0 to a9ebed54c451 (2 revisions) (#133831) · e9448fdf

engine-flutter-autoroll authored Sep 01, 2023

https://github.com/flutter/engine/compare/01e74b252ee0...a9ebed54c451

2023-09-01 skia-flutter-autoroll@skia.org Roll Skia from 818f20f3f653 to e585fdc18134 (1 revision) (flutter/engine#45363)
2023-09-01 skia-flutter-autoroll@skia.org Roll Dart SDK from 9f9bd8cddfb0 to 0c121a6431cc (1 revision) (flutter/engine#45362)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

e9448fdf

Roll Flutter Engine from f28eb11e5bd4 to 01e74b252ee0 (1 revision) (#133830) · a3a651d8

engine-flutter-autoroll authored Sep 01, 2023

https://github.com/flutter/engine/compare/f28eb11e5bd4...01e74b252ee0

2023-09-01 bdero@google.com Bump impeller-cmake-example to head (flutter/engine#45359)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

a3a651d8

Roll Flutter Engine from 494fd7fe85a3 to f28eb11e5bd4 (1 revision) (#133825) · 0a305bbc

engine-flutter-autoroll authored Sep 01, 2023

https://github.com/flutter/engine/compare/494fd7fe85a3...f28eb11e5bd4

2023-08-31 jonahwilliams@google.com [Impeller] copy data out of DlVertices. (flutter/engine#45355)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

0a305bbc

Roll Flutter Engine from b867c4da54cc to 494fd7fe85a3 (1 revision) (#133823) · d67ec7c7

engine-flutter-autoroll authored Sep 01, 2023

https://github.com/flutter/engine/compare/b867c4da54cc...494fd7fe85a3

2023-08-31 skia-flutter-autoroll@skia.org Roll Skia from e1b27dcecd0a to 818f20f3f653 (2 revisions) (flutter/engine#45353)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

d67ec7c7

Add an example for `InputChip` generated by user input (#130645) · 400702d1

Andrea Cioni authored Sep 01, 2023

New example for `InputChip` that demonstrate how to create/delete them based on user text inputs.

The sample application shows a custom text area where user can enter text. After the user has typed and hits _Enter_ the text will be replaced with an `InputChip` that contains that text. Is it possible to continue typing and add more chips in this way. All of them will be placed in a scrollable horizontal row. Also is it possible to have suggestion displayed below the text input field in case the typed text match some of the available suggestions.

Issue I'm trying to solve:

- https://github.com/flutter/flutter/issues/128247

**Code structure:**

The example app is composed of 2 main components that find places inside `MainScreen`:

- `ChipsInput`
- `ListView`

`ChipsInput` emulates a `TextField` where you can enter text. This text field accepts also a list of values of generic type T (`Topping` in my example), that gets rendered as `InputChip` inside the text field, before the text inserted by the user. This widgets is basically an `InputDecorator` widget that implements `TextInputClient` to get `TextEditingValue` events from the user keyboard. At the end of the input field there is another component, the `TextCursor`, that is displayed just when the user give the focus to the field and emulates the carrets that `TextField` has.

There are also some available callbacks that the user can use to capture events in the `ChipsInput` field like: `onChanged`, `onChipTapped`, `onSubmitted` and `onTextChanged`. This last callback is used to build a list of suggestion that will be placed just below the `ChipsInput` field inside the `ListView`.

400702d1

31 Aug, 2023 17 commits

Roll Flutter Engine from 10e2df60b053 to b867c4da54cc (3 revisions) (#133820) · 62fb15a6

engine-flutter-autoroll authored Aug 31, 2023

https://github.com/flutter/engine/compare/10e2df60b053...b867c4da54cc

2023-08-31 sra@google.com [web] More efficient fallback font selection (flutter/engine#44526)
2023-08-31 skia-flutter-autoroll@skia.org Roll Dart SDK from ac3bc9f6351a to 9f9bd8cddfb0 (1 revision) (flutter/engine#45352)
2023-08-31 skia-flutter-autoroll@skia.org Roll Skia from bf6b239838d3 to e1b27dcecd0a (1 revision) (flutter/engine#45349)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

62fb15a6

Fix clipBehavior ignored in Scrollable of SingleChildScrollView (#133696) · cf051e7d

Kate Lovett authored Aug 31, 2023

Fixes https://github.com/flutter/flutter/issues/133330

The clipBehavior was not passed to the underlying Scrollable, which informs things like the clip on the StretchingOverscrollIndicator.

cf051e7d

Make Route dispatching memory events. (#133721) · 956999a4
Polina Cherkasova authored Aug 31, 2023

956999a4

Roll Flutter Engine from ca513c999257 to 10e2df60b053 (3 revisions) (#133815) · 727b9fd1

engine-flutter-autoroll authored Aug 31, 2023

https://github.com/flutter/engine/compare/ca513c999257...10e2df60b053

2023-08-31 ian@hixie.ch Avoid saying exactly who can give test exemptions (flutter/engine#45343)
2023-08-31 skia-flutter-autoroll@skia.org Roll Skia from 5d08dadd2ef4 to bf6b239838d3 (1 revision) (flutter/engine#45344)
2023-08-31 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from 7sFO_YvenNXCm6TdK... to _x3hf702RacYnw3E6... (flutter/engine#45348)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from 7sFO_YvenNXC to _x3hf702RacY

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

727b9fd1

Fix sample code crash, add test (#133812) · 5b6d748c

Kate Lovett authored Aug 31, 2023

Fixes https://github.com/flutter/flutter/issues/133402

On web `1 << 32` crashes, 31 is the maximum.

5b6d748c

Roll Flutter Engine from 51090e3cfe79 to ca513c999257 (15 revisions) (#133810) · 7ade1638

engine-flutter-autoroll authored Aug 31, 2023

https://github.com/flutter/engine/compare/51090e3cfe79...ca513c999257

2023-08-31 zanderso@users.noreply.github.com Revert "Reland "Build iOS unittest target in unopt builds" (#44356)"" (flutter/engine#45346)
2023-08-31 flar@google.com Lazily allocate RasterCacheItems only when caching is enabled (flutter/engine#45211)
2023-08-31 skia-flutter-autoroll@skia.org Roll Skia from 8ff4fd208c26 to 5d08dadd2ef4 (3 revisions) (flutter/engine#45340)
2023-08-31 ychris@google.com Reland "Build iOS unittest target in unopt builds" (#44356)" (flutter/engine#44821)
2023-08-31 yousefi@google.com Update comment const_finder.dart (flutter/engine#45180)
2023-08-31 dkwingsmt@users.noreply.github.com Replace an unnecessary util function with PostSync (flutter/engine#45190)
2023-08-31 skia-flutter-autoroll@skia.org Roll Skia from cda0cfaadfd7 to 8ff4fd208c26 (3 revisions) (flutter/engine#45337)
2023-08-31 skia-flutter-autoroll@skia.org Roll Dart SDK from 0cea73a8d3c3 to ac3bc9f6351a (4 revisions) (flutter/engine#45336)
2023-08-31 chris@bracken.jp [macOS] Link __availability_version_check (flutter/engine#45333)
2023-08-31 skia-flutter-autoroll@skia.org Roll Skia from 8c05d5103d6b to cda0cfaadfd7 (3 revisions) (flutter/engine#45334)
2023-08-31 zanderso@users.noreply.github.com Adds an --rbe option to tools/gn that works on Linux hosts (flutter/engine#45271)
2023-08-31 brianosman@google.com Migrate VK calls of GrBackend* (flutter/engine#45325)
2023-08-31 zanderso@users.noreply.github.com Roll buildroot (flutter/engine#45329)
2023-08-31 zanderso@users.noreply.github.com Revert dl split (flutter/engine#45326)
2023-08-31 skia-flutter-autoroll@skia.org Roll Skia from d113402de2ce to 8c05d5103d6b (4 revisions) (flutter/engine#45331)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

7ade1638

[flutter_tools] Fix flutter upgrade not finding git tags (#133778) · 33210218
Christopher Fujino authored Aug 31, 2023
```
Fixes https://github.com/flutter/flutter/issues/133441
```
33210218

Removes ios universal link vmservices and let xcodeproject to dump js… (#133709) · 0b3b8cd5

chunhtai authored Aug 31, 2023

â¦on file

The deeplink validation tool will become an static app so it can't no longer access vm services.

The goal will be then to turn them into flutter analyze command similar to `flutter analyze --android --[options]` that static app can use on.

This pr only removes vm services and turn the api to dump a output file instead of printing everything to stdout.

0b3b8cd5

Add MacOS AppKitView class. (#132583) · e6e44de3

yaakovschectman authored Aug 31, 2023

Add derived classes from the Darwin platform view base classes for
MacOS. Functionality is largely the same as the `UiKitView`, but the two
are decoupled and and can further diverge in the future as needed. Some
unit tests remain skipped for now as the gesture recognizers for MacOS
are not yet implemented.

https://github.com/flutter/flutter/issues/128519

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat

---------
Co-authored-by: Chris Bracken <chris@bracken.jp>

e6e44de3

Improve doctor output on incomplete Visual Studio installation (#133390) · b4753c32

Loïc Sharma authored Aug 31, 2023

Flutter doctor warns if the user is updating Visual Studio or has paused
a Visual Studio update. The current output recommends reinstalling
Visual Studio. This is unnecessary as the user should be able to use the
Visual Studio Installer app to complete the installation:


![image](https://github.com/flutter/flutter/assets/737941/49547413-ece1-4214-a971-f512bc39419f)

This message is covered by this existing test:


https://github.com/flutter/flutter/blob/229b74d987720a0437039b6e44e13f20fb94ad51/packages/flutter_tools/test/general.shard/windows/visual_studio_validator_test.dart#L68-L81

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat

b4753c32

Revert "Run Mac_arm64_ios run_debug_test_macos in presubmit" (#133808) · e98d3929

Victoria Ashworth authored Aug 31, 2023

Reverts flutter/flutter#133788

Something is wrong with bot https://chromium-swarm.appspot.com/bot?id=flutter-devicelab-mac-38, it's unable to open the project in Xcode. Failing consistently.

https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8771213845302282993/+/u/ios_debug_symbol_doctor/recover_with_120_second_timeout/stdout

So reverting until we can get the bot fixed.

e98d3929

give --task-args option in `test_runner` a help description (#133791) · c263c56d

Andrew Kolos authored Aug 31, 2023

Fixes https://github.com/flutter/flutter/issues/133790

Provides help text for the `--task-args` option of the `test_runner` devicelab command. The current help text is just copypasta from another option's help text

c263c56d

[flutter_tools] print out the unzipping method used by update_dart_sdk.ps1 (#133364) · 1519553b

Christopher Fujino authored Aug 31, 2023

in case there are future issues with unzipping the dart sdk, such as https://github.com/flutter/flutter/issues/132592, we should log out what tool we are using to try to extract the archive.

1519553b

Revert "Fixing memory leak in EditableTextState" (#133804) · acdcbae7
Renzo Olivares authored Aug 31, 2023
```
Reverts flutter/flutter#131377

reverting because of internal google testing failures b/298310760
```
acdcbae7

Fix `cursorColor` with an opacity is not respected (#133548) · f32b6fed

Taha Tesser authored Aug 31, 2023

fixes [`cursorColor` with an opacity  is not respected](https://github.com/flutter/flutter/issues/132886)

<details>
<summary>expand to view the code sample</summary> 

```dart
import "package:flutter/material.dart";
// import "package:flutter/scheduler.dart";

// final color = Colors.red;
const color = Color(0x55ff0000);

void main() {
  // timeDilation = 4;
  runApp(const MyApp());
}

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    return const MaterialApp(
      debugShowCheckedModeBanner: false,
      home: Example(),
    );
  }
}

class Example extends StatefulWidget {
  const Example({super.key});

  @override
  State<Example> createState() => _ExampleState();
}

class _ExampleState extends State<Example> {
  late FocusNode _focusNode;
  late TextEditingController _controller;

  @override
  void initState() {
    super.initState();
    _focusNode = FocusNode();
    _controller = TextEditingController(text: 'Hello World');
  }

  @override
  void dispose() {
    _focusNode.dispose();
    _controller.dispose();
    super.dispose();
  }

  @override
  Widget build(BuildContext context) {
    const bool cursorOpacityAnimates = false;
    double cursorWidth = 6;

    return Scaffold(

      body: Center(
        child: Padding(
          padding: const EdgeInsets.symmetric(
            horizontal: 16,
          ),
          child: Column(
            children: <Widget>[
              const Spacer(),
              const Text('EditableText'),
              const SizedBox(height: 8),
              InputDecorator(
                decoration: InputDecoration(
                  border: OutlineInputBorder(
                    borderRadius: BorderRadius.circular(8),
                  ),
                ),
                child: EditableText(
                  cursorColor: color,
                  cursorWidth: cursorWidth,
                  cursorOpacityAnimates: cursorOpacityAnimates,
                  focusNode: _focusNode,
                  controller: _controller,
                  style: Theme.of(context).textTheme.bodyLarge!,
                  backgroundCursorColor: Colors.amber,
                  onSubmitted: (String value) {
                    // Add your code here.
                  },
                ),
              ),
              const Spacer(),
              const Text('TextField'),
              const SizedBox(height: 8),
              TextField(
                cursorColor: color,
                cursorWidth: cursorWidth,
                cursorOpacityAnimates: cursorOpacityAnimates,
                controller: _controller,
                focusNode: _focusNode,
                onSubmitted: (String value) {
                  // Add your code here.
                },
              ),
              const Spacer(),
            ],
          ),
        ),
      ),
    );
  }
}
```

</details>

### Before

![Screenshot 2023-08-29 at 14 57 57](https://github.com/flutter/flutter/assets/48603081/cd55bb74-23b8-4980-915d-f13dee22a50f)

### After
![Screenshot 2023-08-29 at 14 58 20](https://github.com/flutter/flutter/assets/48603081/c94af4e3-f24b-44e7-bbed-7c6c21e90f2a)

f32b6fed

Run Mac_arm64_ios run_debug_test_macos in presubmit (#133788) · 8128b2e2
Victoria Ashworth authored Aug 31, 2023
```
Fixes https://github.com/flutter/flutter/issues/118830.
```
8128b2e2

Add benchmark for scrolling very long pictures (#133434) · b51859ec

Jim Graham authored Aug 31, 2023

This benchmark will track the performance of the RTree implementation to cull very large pictures down to just the portion visible on the screen.

b51859ec