- 17 Oct, 2018 1 commit
-
-
Alexandre Ardhuin authored
-
- 11 Oct, 2018 1 commit
-
-
Greg Spencer authored
This attempts to re-land #22656. There are two changes from the original: I turned off wrapping completely when not sending output to a terminal. Previously I had defaulted to wrapping at and arbitrary 100 chars in that case, just to keep long messages from being too long, but that turns out the be a bad idea because there are tests that are relying on the specific form of the output. It's also pretty arbitrary, and mostly people sending output to a non-terminal will want unwrapped text. I found a better way to terminate ANSI color/bold sequences, so that they can be embedded within each other without needed quite as complex a dance with removing redundant sequences. As part of these changes, I removed the Logger.supportsColor setter so that the one source of truth for color support is in AnsiTerminal.supportsColor. * Turn on line wrapping again in usage and status messages, adds ANSI color to doctor and analysis messages. (#22656) This turns on text wrapping for usage messages and status messages. When on a terminal, wraps to the width of the terminal. When writing to a non-terminal, wrap lines at a default column width (currently defined to be 100 chars). If --no-wrap is specified, then no wrapping occurs. If --wrap-column is specified, wraps to that column (if --wrap is on). Adds ANSI color to the doctor and analysis output on terminals. This is in this PR with the wrapping, since wrapping needs to know how to count visible characters in the presence of ANSI sequences. (This is just one more step towards re-implementing all of Curses for Flutter. :-)) Will not print ANSI sequences when sent to a non-terminal, or of --no-color is specified. Fixes ANSI color and bold sequences so that they can be combined (bold, colored text), and a small bug in indentation calculation for wrapping. Since wrapping is now turned on, also removed many redundant '\n's in the code.
-
- 05 Oct, 2018 2 commits
-
-
tonyzhao1 authored
-
Alexandre Ardhuin authored
-
- 04 Oct, 2018 2 commits
-
-
Greg Spencer authored
Apparently, this accounts for 13% of our crashes in Beta.
-
Alexandre Ardhuin authored
-
- 03 Oct, 2018 1 commit
-
-
Danny Tuppeny authored
* Block setting of fs.currentDirectory in tests This isn't perfect, it only covers tests using testUsingContext, but that is the huge majority of tests. * Tweak error message.
-
- 01 Oct, 2018 1 commit
-
-
Alexandre Ardhuin authored
-
- 19 Sep, 2018 1 commit
-
-
Greg Spencer authored
This adds support to AnsiTerminal for colored output, and makes all tool output written to stderr (with the printError function) colored red. No color codes are sent if the terminal doesn't support color (or isn't a terminal). Also makes "progress" output print the elapsed time when not connected to a terminal, so that redirected output and terminal output match (redirected output doesn't print the spinner, however). Addresses #17307
-
- 18 Sep, 2018 1 commit
-
-
Alexandre Ardhuin authored
-
- 14 Sep, 2018 1 commit
-
-
Alexandre Ardhuin authored
-
- 12 Sep, 2018 1 commit
-
-
Alexandre Ardhuin authored
* enable lint unnecessary_new * fix tests * fix tests * fix tests
-
- 05 Sep, 2018 1 commit
-
-
tonyzhao1 authored
* First step in Flutter Doctor refactor. Assigns categories to all validators. * Revert "Roll engine e54bc4ea1832..a84b210b3d26 (6 commits) (#20453)" This reverts commit 05c2880a. * Split iOS and Android workflows into workflow and validator classes. * Change ValidatorCategory to handle standalone validators that share a category (e.g. IntelliJ). Also make Android Studio and Android toolchain use separate categories. At this stage, flutter doctor output matches what it was previously. (The summary() method itself has not yet been changed ) * Change doctor summary code to support validator categories. Output is still unchanged. * Handle small formatting issues. * Flip Flutter category's isGroup field to false until it's actually needed. * Revert auto-generated formatting changes to keep those lines from muddying the pull. * Small fixes pointed out by analyzer. * Properly fix analyzer issues around const constructors. * Small changes to address comments. * Add tests to verify grouped validator behavior and validationtype merging. * Update doctor.dart * Add comments for clarification.
-
- 04 Sep, 2018 1 commit
-
-
Danny Tuppeny authored
* Change assert_bundle_package_font_test to memory file system This is to work towards being able to run the tests without `-j1` (#21113). These tests were using the real filesystem and setting/relying on fs.currentDirectory. There was a comment about this being because the memory provider didnt' support POSIX and Windows, however that seems to have changed since (and many other asset tests already do something similar to this). * Trim trailing whitespace * Add a workaround for Windows path slash directions Strictly this is correct, but the real FS can tolerate either path. The in-memory file system is more strict (see https://github.com/google/file.dart/issues/112). * Extract a helper for writing schema files in tests * Missed file when saving! * Remove redundant comment * Rename writeBasicSchema -> writeEmptySchema * Use the file we already have to write contents * Make comments more descriptive * Remove another dupe of writeSchema to use the shared one * Rename schema -> pubspec_schema * Trim whitespace
-
- 31 Aug, 2018 1 commit
-
-
Chris Bracken authored
DevFS.update only runs in Dart 2 mode when the generator parameter is supplied. In Dart 2 mode, both mainPath and pathToReload are required parameters; this patch marks them as such. generator is required for running in Dart 2. All call sites other than tests already explicitly set this value. Note the statements on line 510 and line 516 for why mainPath and pathToReload are required.
-
- 30 Aug, 2018 1 commit
-
-
Mikkel Nygaard Ravn authored
-
- 17 Aug, 2018 1 commit
-
-
Ian Hickson authored
All temporary directory start with `flutter_` and have their random component separated from the name by a period, as in `flutter_test_bundle.YFYQMY`. I've tried to find some of the places where we didn't cleanly delete temporary directories, too. This greatly reduces, though it does not entirely eliminate, the directories we leave behind when running tests, especially `flutter_tools` tests. While I was at it I standardized on `tempDir` as the variable name for temporary directories, since it was the most common, removing occurrences of `temp` and `tmp`, among others. Also I factored out some common code that used to catch exceptions that happen on Windows, and made more places use that pattern.
-
- 15 Aug, 2018 1 commit
-
-
Ian Hickson authored
* Upgrade everything except matcher. * Roll matcher (and test) * Adjust tests that depend on flutter:test directly to depend on a shim * Require use of package:test shim and remove other references to package:test
-
- 02 Aug, 2018 1 commit
-
-
Alexandre Ardhuin authored
-
- 27 Jul, 2018 1 commit
-
-
Todd Volkert authored
It was causing problems rolling Flutter into Fuchsia
-
- 23 Jul, 2018 1 commit
-
-
Alexandre Ardhuin authored
* re-enable lint unnecessary_const * remove trailling whitespaces * remove unnecessary const (after merge)
-
- 20 Jul, 2018 2 commits
-
-
Leaf Petersen authored
* Remove uses of deprecated constants * Change int.parse to int.tryParse where appropriate
-
Sigurd Meldgaard authored
With a fix of a path being printed relative instead of absolute.
-
- 16 Jul, 2018 4 commits
-
-
Ian Hickson authored
This reverts commit cc1cf13e.
-
Alexandre Ardhuin authored
-
Sigurd Meldgaard authored
This reverts commit 57d78cc7.
-
Sigurd Meldgaard authored
-
- 12 Jul, 2018 3 commits
-
-
Alexander Aprelev authored
Revert "Revert "Roll engine to fed2ea458ed49088d33eddabc546ba56d600c717 (includes dart roll) again (#19277)" (#19295)" (#19322) This reverts commit cc122f16.
-
Alexander Aprelev authored
Revert "Roll engine to fed2ea458ed49088d33eddabc546ba56d600c717 (includes dart roll) again (#19277)" (#19295) This reverts commit 700cb767 as it breaks Windows tests.
-
Alexander Aprelev authored
* Revert "Revert "Roll engine to fed2ea458ed49088d33eddabc546ba56d600c717 (includes dart roll) (#19044)" (#19276)" This reverts commit cf932490 as it also includes fix for type error that broke tests. * Add type cast for dart2 type checks. * Move up to latest goldens * Make inDirectory() type-parameterized. * Add typecasting to transitions_perf_test.dart and microbenchmarks. * Add boolean flag initialization in save_catalog_screenshots.dart * Add type conversion to gallery transition test
-
- 11 Jul, 2018 2 commits
-
-
Alexander Aprelev authored
Revert "Roll engine to fed2ea458ed49088d33eddabc546ba56d600c717 (includes dart roll) (#19044)" (#19276) This reverts commit f4a038da as it breaks microbenchmark tests.
-
Alexander Aprelev authored
* Roll engine to rolled dart Add connectionTimeout property to class that extends HttpOverrides. Upgrade packages. Add more type fixes. Update goldens hash. Add more type fixes. Upgrade packages. Fix tests. Remove strong-mode from analysis options yaml file. Increase dev/devicelab timeout from 2 to 10 seconds. Added getVM to waitForViews. Fix type errors in compileExpression. * Pick up engine revision with fix for microbenchmarks regression. Increase default timeout from 20/30 to 60s.
-
- 27 Jun, 2018 1 commit
-
-
Ian Hickson authored
This is an attempt to reland #18488 with less breakage on macOS.
-
- 20 Jun, 2018 1 commit
-
-
Ian Hickson authored
The new matcher package deprecates isInstanceOf which seems eggregious.
-
- 19 Jun, 2018 1 commit
-
-
Greg Spencer authored
-
- 15 Jun, 2018 2 commits
-
-
Ian Hickson authored
This reverts commit 77508722.
-
Ian Hickson authored
-
- 13 Jun, 2018 1 commit
-
-
Chris Bracken authored
fuchsia_tester.dart still assumes Dart 1. Previously, it ran tests directly from source, flutter_platform.dart automatically runs a kernel compile when operating in Dart 2 mode, but this assumes a functional Dart SDK is available in the artifacts directly, and fuchsia_tester.dart mocks out the artifacts directory with an empty temp dir. Remaining work is: 1. Get the frontend server building as a dependency on Fuchsia. 2. Patch fuchsia_tester.dart to use a valid Dart SDK and frontend server. This also reverts migration to Dart 2 typedef syntax. This reverts commit 6c56bb24. (#18362) This reverts commit 3daebd05. (#18316)
-
- 11 Jun, 2018 1 commit
-
-
Greg Spencer authored
Now that Dart 1 is turned off, reapplying my change to turn on the prefer_generic_function_type_aliases analysis option, and fix all the typedefs to Dart 2 preferred syntax. Also eliminated the unused analysis_options_repo.yaml file and turned on public_member_api_docs in analysys_options.yaml. No logic changes, just changing the typedef syntax for all typedefs, and updating analysis options.
-
- 05 Jun, 2018 1 commit
-
-
Alexandre Ardhuin authored
-