1. 17 Oct, 2018 1 commit
  2. 11 Oct, 2018 1 commit
    • Greg Spencer's avatar
      Re-land text wrapping/color PR (#22831) · 081d2a7a
      Greg Spencer authored
      This attempts to re-land #22656.
      
      There are two changes from the original:
      
      I turned off wrapping completely when not sending output to a terminal. Previously I had defaulted to wrapping at and arbitrary 100 chars in that case, just to keep long messages from being too long, but that turns out the be a bad idea because there are tests that are relying on the specific form of the output. It's also pretty arbitrary, and mostly people sending output to a non-terminal will want unwrapped text.
      
      I found a better way to terminate ANSI color/bold sequences, so that they can be embedded within each other without needed quite as complex a dance with removing redundant sequences.
      
      As part of these changes, I removed the Logger.supportsColor setter so that the one source of truth for color support is in AnsiTerminal.supportsColor.
      
      *     Turn on line wrapping again in usage and status messages, adds ANSI color to doctor and analysis messages. (#22656)
      
          This turns on text wrapping for usage messages and status messages. When on a terminal, wraps to the width of the terminal. When writing to a non-terminal, wrap lines at a default column width (currently defined to be 100 chars). If --no-wrap is specified, then no wrapping occurs. If --wrap-column is specified, wraps to that column (if --wrap is on).
      
          Adds ANSI color to the doctor and analysis output on terminals. This is in this PR with the wrapping, since wrapping needs to know how to count visible characters in the presence of ANSI sequences. (This is just one more step towards re-implementing all of Curses for Flutter. :-)) Will not print ANSI sequences when sent to a non-terminal, or of --no-color is specified.
      
          Fixes ANSI color and bold sequences so that they can be combined (bold, colored text), and a small bug in indentation calculation for wrapping.
      
          Since wrapping is now turned on, also removed many redundant '\n's in the code.
      081d2a7a
  3. 05 Oct, 2018 2 commits
  4. 04 Oct, 2018 2 commits
  5. 03 Oct, 2018 1 commit
  6. 01 Oct, 2018 1 commit
  7. 19 Sep, 2018 1 commit
    • Greg Spencer's avatar
      Added more extensive ANSI color printing support on terminals. (#20958) · 7caa6594
      Greg Spencer authored
      This adds support to AnsiTerminal for colored output, and makes all tool output written to stderr (with the printError function) colored red.
      
      No color codes are sent if the terminal doesn't support color (or isn't a terminal).
      
      Also makes "progress" output print the elapsed time when not connected to a terminal, so that redirected output and terminal output match (redirected output doesn't print the spinner, however).
      
      Addresses #17307
      7caa6594
  8. 18 Sep, 2018 1 commit
  9. 14 Sep, 2018 1 commit
  10. 12 Sep, 2018 1 commit
  11. 05 Sep, 2018 1 commit
    • tonyzhao1's avatar
      Create categories for doctor validators (#20758) · 58d98ce3
      tonyzhao1 authored
      * First step in Flutter Doctor refactor. Assigns categories to all validators.
      
      * Revert "Roll engine e54bc4ea1832..a84b210b3d26 (6 commits) (#20453)"
      
      This reverts commit 05c2880a.
      
      * Split iOS and Android workflows into workflow and validator classes.
      
      * Change ValidatorCategory to handle standalone validators that share a
      category (e.g. IntelliJ).
      
      Also make Android Studio and Android toolchain use separate categories.
      
      At this stage, flutter doctor output matches what it was previously.
      (The summary() method itself has not yet been changed )
      
      * Change doctor summary code to support validator categories.
      
      Output is still unchanged.
      
      * Handle small formatting issues.
      
      * Flip Flutter category's isGroup field to false until it's actually
      needed.
      
      * Revert auto-generated formatting changes to keep those lines from
      muddying the pull.
      
      * Small fixes pointed out by analyzer.
      
      * Properly fix analyzer issues around const constructors.
      
      * Small changes to address comments.
      
      * Add tests to verify grouped validator behavior and validationtype
      merging.
      
      * Update doctor.dart
      
      * Add comments for clarification.
      58d98ce3
  12. 04 Sep, 2018 1 commit
    • Danny Tuppeny's avatar
      Change asset_bundle_package_font_test to memory file system (#21114) · a74f591d
      Danny Tuppeny authored
      * Change assert_bundle_package_font_test to memory file system
      
      This is to work towards being able to run the tests without `-j1` (#21113). These tests were using the real filesystem and setting/relying on fs.currentDirectory. There was a comment about this being because the memory provider didnt' support POSIX and Windows, however that seems to have changed since (and many other asset tests already do something similar to this).
      
      * Trim trailing whitespace
      
      * Add a workaround for Windows path slash directions
      
      Strictly this is correct, but the real FS can tolerate either path. The in-memory file system is more strict (see https://github.com/google/file.dart/issues/112).
      
      * Extract a helper for writing schema files in tests
      
      * Missed file when saving!
      
      * Remove redundant comment
      
      * Rename writeBasicSchema -> writeEmptySchema
      
      * Use the file we already have to write contents
      
      * Make comments more descriptive
      
      * Remove another dupe of writeSchema to use the shared one
      
      * Rename schema -> pubspec_schema
      
      * Trim whitespace
      a74f591d
  13. 31 Aug, 2018 1 commit
    • Chris Bracken's avatar
      Migrate devfs tests to Dart 2 (#21285) · 251e82d2
      Chris Bracken authored
      DevFS.update only runs in Dart 2 mode when the generator parameter is
      supplied. In Dart 2 mode, both mainPath and pathToReload are required
      parameters; this patch marks them as such.
      
      generator is required for running in Dart 2. All call sites other than tests already explicitly set this value.
      
      Note the statements on line 510 and line 516 for why mainPath and pathToReload are required.
      251e82d2
  14. 30 Aug, 2018 1 commit
  15. 17 Aug, 2018 1 commit
    • Ian Hickson's avatar
      Clean up usage of temporary directories (#20682) · 3dec6a69
      Ian Hickson authored
      All temporary directory start with `flutter_` and have their random component separated from the name by a period, as in `flutter_test_bundle.YFYQMY`.
      
      I've tried to find some of the places where we didn't cleanly delete temporary directories, too. This greatly reduces, though it does not entirely eliminate, the directories we leave behind when running tests, especially `flutter_tools` tests.
      
      While I was at it I standardized on `tempDir` as the variable name for temporary directories, since it was the most common, removing occurrences of `temp` and `tmp`, among others.
      
      Also I factored out some common code that used to catch exceptions that happen on Windows, and made more places use that pattern.
      3dec6a69
  16. 15 Aug, 2018 1 commit
    • Ian Hickson's avatar
      Shim package:test to avoid matcher issues (#20602) · 686d8f8a
      Ian Hickson authored
      * Upgrade everything except matcher.
      * Roll matcher (and test)
      * Adjust tests that depend on flutter:test directly to depend on a shim
      * Require use of package:test shim and remove other references to package:test
      686d8f8a
  17. 02 Aug, 2018 1 commit
  18. 27 Jul, 2018 1 commit
  19. 23 Jul, 2018 1 commit
  20. 20 Jul, 2018 2 commits
  21. 16 Jul, 2018 4 commits
  22. 12 Jul, 2018 3 commits
  23. 11 Jul, 2018 2 commits
  24. 27 Jun, 2018 1 commit
  25. 20 Jun, 2018 1 commit
  26. 19 Jun, 2018 1 commit
  27. 15 Jun, 2018 2 commits
  28. 13 Jun, 2018 1 commit
    • Chris Bracken's avatar
      Revert elimination of Dart 1 (#18460) · 2ae48845
      Chris Bracken authored
      fuchsia_tester.dart still assumes Dart 1. Previously, it ran tests directly
      from source, flutter_platform.dart automatically runs a kernel compile when
      operating in Dart 2 mode, but this assumes a functional Dart SDK is available
      in the artifacts directly, and fuchsia_tester.dart mocks out the artifacts
      directory with an empty temp dir.
      
      Remaining work is:
      1. Get the frontend server building as a dependency on Fuchsia.
      2. Patch fuchsia_tester.dart to use a valid Dart SDK and frontend server.
      
      This also reverts migration to Dart 2 typedef syntax.
      
      This reverts commit 6c56bb24. (#18362)
      This reverts commit 3daebd05. (#18316)
      2ae48845
  29. 11 Jun, 2018 1 commit
    • Greg Spencer's avatar
      Update typedef syntax to use Function notation and turn on lint for old notation. (#18362) · 6c56bb24
      Greg Spencer authored
      Now that Dart 1 is turned off, reapplying my change to turn on the prefer_generic_function_type_aliases analysis option, and fix all the typedefs to Dart 2 preferred syntax.
      
      Also eliminated the unused analysis_options_repo.yaml file and turned on public_member_api_docs in analysys_options.yaml.
      
      No logic changes, just changing the typedef syntax for all typedefs, and updating analysis options.
      6c56bb24
  30. 05 Jun, 2018 1 commit