- 12 Oct, 2023 1 commit
-
-
Bryan Olivares authored
SearchBar should listen to changes to the SearchController and update suggestions on change (#134337) This PR is adding a listener to the `SearchController`, so that the `suggestionBuilder` can be updated when the `SearchController` changes. Another method we can possibly do is have an update method on `SearchController`, so that the user can manually update the suggestions instead of us doing it automatically. Fixes #132161
-
- 11 Oct, 2023 33 commits
-
-
Kevin Moore authored
* Allow latest pkg:material_color_utilities * Bump other dependencies to their latest - including pkg:web
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/8bf1460892c6...05e26c1b2c79 2023-10-11 jason-simmons@users.noreply.github.com Run the binary size treemap script from the buildroot directory (flutter/engine#46740) 2023-10-11 dnfield@google.com [Impeller] flutter_tester --enable-impeller (flutter/engine#46389) 2023-10-11 jacksongardner@google.com Switch to Chrome For Testing instead of Chromium (flutter/engine#46683) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Kevin Chisholm authored
In order to better track features, I propose that we have a unified template for creating Umbrella issues. This is not required to create umbrella issue to add to the feature tracker, however for those who would like a more fleshed out format, this will serve the purpose. Fixes: https://github.com/flutter/flutter/issues/134234
-
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/2b1b4b97f787...8bf1460892c6 2023-10-11 34871572+gmackall@users.noreply.github.com Revert "[Android] Add support for text processing actions (#44579)" (flutter/engine#46788) 2023-10-11 danchevalier@google.com [web] Adds Noto Music fallback font (flutter/engine#46720) 2023-10-11 jason-simmons@users.noreply.github.com Fix some image_external_texture entries in the license golden file (flutter/engine#46790) 2023-10-11 john@johnmccutchan.com Rename HardwareBufferExternalTexture* to ImageExternalTexture* (flutter/engine#46786) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/5fcc16772cdd...2b1b4b97f787 2023-10-11 skia-flutter-autoroll@skia.org Roll Skia from 6cc9f73ea54e to 2459d71707e0 (1 revision) (flutter/engine#46787) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Jackson Gardner authored
This switches over to using Chrome for Testing instead of Chromium. This should ensure that we are consistently using an official and consistent build of Chrome on all platforms, rather than whatever we can get from the continuous builds archive, which can potentially put platforms out of sync with each other.
-
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/4b02631b59bf...5fcc16772cdd 2023-10-11 john@johnmccutchan.com Fix 303652511 and add a regression test (flutter/engine#46743) 2023-10-11 skia-flutter-autoroll@skia.org Roll Skia from bfd9af01b785 to 6cc9f73ea54e (1 revision) (flutter/engine#46784) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Kate Lovett authored
This fixes/notates a few deprecations from an audit for the next tech debt cycle. - ThemeData errorColor and backgroundColor are notated as deprecated in multiple places, but one usage had a different version tag. Updated to match the rest. - ThemeData.copyWith useMaterial3 was deprecated because it did not do what developers expected - it did not automatically reassign all of the color values and such. (confirmed with @HansMuller) I added a note so that when we later remove it we don't introduce a bug. - the describeEnum deprecation was tagged wrong, it was a very long PR so by the time it merged the version it was finally tagged with was much later. (https://github.com/flutter/flutter/pull/125016)
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/ed67e8aa9aba...4b02631b59bf 2023-10-11 bdero@google.com [Impeller] Avoid invalid GL depth calls on macOS desktop. (flutter/engine#46758) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
droidbg authored
-
Loïc Sharma authored
This removes the `Windows_arm64 plugin_test` as Devicelab tests aren't able to target Android from a Windows Arm64 host yet. I opened https://github.com/flutter/flutter/issues/136378 to track this work.
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/68a8ff743539...ed67e8aa9aba 2023-10-11 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from mLc-VlVTg-p18HjiP... to Qjz4zE4Oe0AO_7T3f... (flutter/engine#46778) 2023-10-11 zanderso@users.noreply.github.com Roll goldctl forward (flutter/engine#46771) Also rolling transitive DEPS: fuchsia/sdk/core/mac-amd64 from mLc-VlVTg-p1 to Qjz4zE4Oe0AO If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
-
Kenzie Davisson authored
We will expose this from a button in DevTools. https://github.com/flutter/devtools/issues/6166
-
Maximilian Fischer authored
This PR includes the `widthFactor` and `heightFactor` when computing the intrinsic size of a `RenderPositionedBox`. <details><summary>Code sample</summary> Red should have a height of 100, blue one of 200. ```dart import 'package:flutter/material.dart'; import 'package:flutter/rendering.dart'; void main() { runApp(const MyApp()); } class MyApp extends StatelessWidget { const MyApp({super.key}); @override Widget build(BuildContext context) { return MaterialApp( title: 'Intrinsic Bug', theme: ThemeData( colorScheme: ColorScheme.fromSeed(seedColor: Colors.deepPurple), useMaterial3: true, ), home: Scaffold( body: Row( crossAxisAlignment: CrossAxisAlignment.start, children: [ Expanded( child: IntrinsicHeight( child: Align( heightFactor: 0.5, child: Container( height: 200, color: Colors.red, ), ), ), ), Expanded( child: Container( height: 200, color: Colors.blue, ), ), ], ), ), ); } } ``` </details> Before:  After:  Fix #135822 -
Zachary Anderson authored
These tests have been skipped due to flakiness for a long time. Closes https://github.com/dart-lang/webdev/issues/1562 Closes https://github.com/flutter/flutter/issues/124214
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/ec1d0d69fcf1...68a8ff743539 2023-10-11 skia-flutter-autoroll@skia.org Roll Skia from 60d51fd2c6bd to bfd9af01b785 (2 revisions) (flutter/engine#46774) 2023-10-11 skia-flutter-autoroll@skia.org Roll Skia from c05effecb081 to 60d51fd2c6bd (3 revisions) (flutter/engine#46772) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Loïc Sharma authored
Part of: https://github.com/flutter/flutter/issues/129806 Test runs kicked off using `led`: * â [hot_mode_dev_cycle_win_target__benchmark](https://ci.chromium.org/raw/build/logs.chromium.org/flutter/led/loicsharma_google.com/2079b030acdb59e82e1798a81a22ba06ebbb29d5fdd4e7ab55e95930037bdd2a/+/build.proto?server=chromium-swarm.appspot.com) * â [windows_home_scroll_perf__timeline_summary](https://ci.chromium.org/raw/build/logs.chromium.org/flutter/led/loicsharma_google.com/56a3b258e4abb451240a4942d337db60de293ff116ad372358e3fa1da941bc83/+/build.proto?server=chromium-swarm.appspot.com) * â [flutter_tool_startup](https://ci.chromium.org/raw/build/logs.chromium.org/flutter/led/loicsharma_google.com/fa6a1056fc447817cea54cac4ca5c4588fbece1a948d30fc03e41fbadd3d4c97/+/build.proto?server=chromium-swarm.appspot.com) /cc @pbo-linaro
-
Kostia Sokolovskyi authored
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/bddb34b09ce9...ec1d0d69fcf1 2023-10-11 skia-flutter-autoroll@skia.org Roll Skia from e00577618d81 to c05effecb081 (1 revision) (flutter/engine#46770) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/d93fe2367d21...bddb34b09ce9 2023-10-11 skia-flutter-autoroll@skia.org Roll Skia from 11e41e0e2f9f to e00577618d81 (1 revision) (flutter/engine#46763) 2023-10-11 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from FX5YzwP_ZEnPP0b3v... to hMA99PoacaRZVXHgr... (flutter/engine#46762) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from FX5YzwP_ZEnP to hMA99PoacaRZ If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/cb0dabd3b33c...d93fe2367d21 2023-10-11 leroux_bruno@yahoo.fr [Android] Add support for text processing actions (flutter/engine#44579) 2023-10-11 skia-flutter-autoroll@skia.org Roll Skia from 4935bed4260d to 11e41e0e2f9f (3 revisions) (flutter/engine#46759) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Taha Tesser authored
fixes [`flexible_space_bar.dart': Failed assertion: line 475 pos 12: 'needsCompositing': is not true.` is thrown when scrolling down in the list and then up](https://github.com/flutter/flutter/issues/135698)
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/0d86d529bb7e...cb0dabd3b33c 2023-10-11 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from oTiMPVe_PvyCYnlqR... to mLc-VlVTg-p18HjiP... (flutter/engine#46754) Also rolling transitive DEPS: fuchsia/sdk/core/mac-amd64 from oTiMPVe_PvyC to mLc-VlVTg-p1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/80868149792f...0d86d529bb7e 2023-10-11 bdero@google.com [Impeller] Allow pipeline variant sets to have differing defaults. (flutter/engine#46751) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/ea275c3d27d3...80868149792f 2023-10-11 matanlurey@users.noreply.github.com Remove support for `Paint.enableDithering=false` in `dart:ui`. (flutter/engine#46745) 2023-10-11 chris@bracken.jp Move //third_party/glfw to //flutter/third_party/glfw (flutter/engine#46733) 2023-10-11 skia-flutter-autoroll@skia.org Roll Skia from 06145491fd17 to 4935bed4260d (3 revisions) (flutter/engine#46748) 2023-10-11 bdero@google.com [Impeller] Guard calls to extension proc DebugMessageControlKHR. (flutter/engine#46747) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Polina Cherkasova authored
Fix flakiness: finalize dropped gestures in tests to release resources, and update doc-comment. (#136136)
-
Valentin Vignal authored
Fixes https://github.com/flutter/flutter/issues/134654
-
Matan Lurey authored
Work towards https://github.com/flutter/flutter/issues/112498. Behaviorally the same, except doesn't care if `dither: ...` shows up, or not (it won't when https://github.com/flutter/flutter/issues/112498 is fixed).
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/4a4d9de43848...ea275c3d27d3 2023-10-10 jonahwilliams@google.com [Impeller] log specific framebuffer incomplete error. (flutter/engine#46692) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
- 10 Oct, 2023 6 commits
-
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/bdeb53455f7c...4a4d9de43848 2023-10-10 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from dCjN58uZQBmAFWSxN... to FX5YzwP_ZEnPP0b3v... (flutter/engine#46734) 2023-10-10 bdero@google.com [Impeller] Don't cull readbacks outside the damage rect. (flutter/engine#46705) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from dCjN58uZQBmA to FX5YzwP_ZEnP If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Greg Spencer authored
## Description This adds a mechanism for listening to key events before or after focus traversal occurs. It adds four methods to the public `FocusManager` API: - `addEarlyKeyEventHandler` - Adds a handler that can handle events before they are given to the focus tree for handling. - `removeEarlyKeyEventHandler` - Removes an early event handler. - `addLateKeyEventHandler` - Adds a handler that can handle events if they have not been handled by anything in the focus tree. - `removeLateKeyEventHandler` - Removes a late event handler. This allows an app to get notified for a key anywhere, and prevent the focus tree from seeing that event if it handles it. For the menu system, this allows it to eat an escape key press and close all the open menus. ## Related Issues - https://github.com/flutter/flutter/issues/135334 ## Tests - Added tests for new functionality.
-
-
Camille Simon authored
Specifies that compatible Java range stated in warning when Java version is incompatible with our template AGP & Gradle versions notes an exclusive upper bound Java version. This was a bug from https://github.com/flutter/flutter/pull/131444, and I will file a CP request to stable once this lands. The warning uses [`getJavaVersionFor`](https://github.com/flutter/flutter/blob/b5c8fd11e4906d900039584b4f67c9753327060c/packages/flutter_tools/lib/src/android/gradle_utils.dart#L606), which returns an exclusive upper bound, which is why this fix is necessary.
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/702f366b1c5d...bdeb53455f7c 2023-10-10 john@johnmccutchan.com Fix high FPS screen flicker of Platform Views when using ImageReaderPlatformViewRenderTarget (flutter/engine#46724) 2023-10-10 matanlurey@users.noreply.github.com Prepare to move new folders into `third_party/` by adding a `.gitignore`. (flutter/engine#46729) 2023-10-10 godofredoc@google.com Use x86 machines for ios builds. (flutter/engine#46726) 2023-10-10 chinmaygarde@google.com Remove workaround for older versions of MSVC. (flutter/engine#46689) 2023-10-10 skia-flutter-autoroll@skia.org Roll Skia from 475286f0f6f1 to 06145491fd17 (1 revision) (flutter/engine#46728) 2023-10-10 jonahwilliams@google.com [Impeller] Implement framebuffer fetch support for OpenGLES. (flutter/engine#46585) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Jonah Williams authored
In the past I switched the implementation of the zoom page transition because the performance of the old transition was terrible, but I'm hopeful that with Impeller we'll be able to identify and fix the issues that made it so slow. In order to evaluate this though, we need to be able to opt into the old transition for benchmarks on CI. https://github.com/flutter/flutter/issues/129742 https://github.com/flutter/flutter/issues/121325
-
