Commits · d87656559c88c594f7a56d3d1beb973ccf0c0f09 · abdullh.alsoleman / Front-End

06 Jun, 2023 2 commits

[web] Use 'Uri' instead of 'dart:html' to extract pathname (#127983) · d8765655

Mouad Debbar authored Jun 06, 2023

- Use `Uri.parse()` to extract pathname.
- Remove unused code from `utils.dart`.
- Add test for URL encoding.

(need to wait for https://github.com/flutter/flutter/pull/126851 to make it into Google3)

d8765655

Roll Flutter Engine from 2b353ae90731 to aaa7574375a6 (4 revisions) (#128301) · 97532239

engine-flutter-autoroll authored Jun 06, 2023

https://github.com/flutter/engine/compare/2b353ae90731...aaa7574375a6

2023-06-06 skia-flutter-autoroll@skia.org Roll Skia from 7db361be474b to e8a71c76b88f (4 revisions) (flutter/engine#42582)
2023-06-05 goderbauer@google.com Remove onSemanticsAction (flutter/engine#42579)
2023-06-05 godofredoc@google.com Use the arm64 dsymutil on Mac M1 machines (flutter/engine#42533)
2023-06-05 skia-flutter-autoroll@skia.org Roll Skia from a226cfbd6cc7 to 7db361be474b (14 revisions) (flutter/engine#42578)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

97532239

05 Jun, 2023 12 commits

Roll Flutter Engine from 220ece4d9faa to 2b353ae90731 (1 revision) (#128293) · a89d475c

engine-flutter-autoroll authored Jun 05, 2023

https://github.com/flutter/engine/compare/220ece4d9faa...2b353ae90731

2023-06-05 bdero@google.com [Impeller] Reland: Add Impeller Metal support in the embedder API (#42411) (flutter/engine#42545)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

a89d475c

Bump actions/labeler from 4.0.4 to 4.1.0 (#128290) · c792a172

dependabot[bot] authored Jun 05, 2023

Bumps [actions/labeler](https://github.com/actions/labeler) from 4.0.4 to 4.1.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/actions/labeler/releases">actions/labeler's releases</a>.</em></p>
<blockquote>
<h2>v4.1.0</h2>
<h2>What's Changed</h2>
<p>In scope of this release, the <code>dot</code> input was added by <a href="https://github.com/kachkaev"><code>@âkachkaev</code></a> in <a href="https://redirect.github.com/actions/labeler/pull/316">actions/labeler#316</a>. It allows patterns to match paths starting with a period. This input is set to <code>false</code> by default.</p>
<h3>Usage</h3>
<pre lang="yml"><code>name: &quot;Pull Request Labeler&quot;
on:
- pull_request_target
<p>jobs:
triage:
permissions:
contents: read
pull-requests: write
runs-on: ubuntu-latest
steps:
- uses: actions/labeler@v4
with:
dot: true
</code></pre></p>
<p>This release also includes the following changes:</p>
<ul>
<li>Simplify globbing examples in README by <a href="https://github.com/Youssef1313"><code>@âYoussef1313</code></a> in <a href="https://redirect.github.com/actions/labeler/pull/451">actions/labeler#451</a></li>
<li>Bump <code>@âtypescript-eslint/parser</code> from 5.59.7 to 5.59.8 by <a href="https://github.com/dependabot"><code>@âdependabot</code></a> in <a href="https://redirect.github.com/actions/labeler/pull/577">actions/labeler#577</a></li>
<li>Bump <code>@âtypescript-eslint/eslint-plugin</code> from 5.59.7 to 5.59.8 by <a href="https://github.com/dependabot"><code>@âdependabot</code></a> in <a href="https://redirect.github.com/actions/labeler/pull/578">actions/labeler#578</a></li>
</ul>
<h2>New Contributors</h2>
<ul>
<li><a href="https://github.com/Youssef1313"><code>@âYoussef1313</code></a> made their first contribution in <a href="https://redirect.github.com/actions/labeler/pull/451">actions/labeler#451</a></li>
<li><a href="https://github.com/kachkaev"><code>@âkachkaev</code></a> made their first contribution in <a href="https://redirect.github.com/actions/labeler/pull/316">actions/labeler#316</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/actions/labeler/compare/v4...v4.1.0">https://github.com/actions/labeler/compare/v4...v4.1.0</a></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/actions/labeler/commit/9fcb2c2f5584144ca754f8bfe8c6f81e77753375"><code>9fcb2c2</code></a> Merge pull request <a href="https://redirect.github.com/actions/labeler/issues/578">#578</a> from actions/dependabot/npm_and_yarn/typescript-eslin...</li>
<li><a href="https://github.com/actions/labeler/commit/0d06c504350cdc97e82c323547d28b981e2698ec"><code>0d06c50</code></a> Bump <code>@âtypescript-eslint/eslint-plugin</code> from 5.59.7 to 5.59.8</li>
<li><a href="https://github.com/actions/labeler/commit/1d399c3ab6911b4a72b5219cb0f283080456c866"><code>1d399c3</code></a> Merge pull request <a href="https://redirect.github.com/actions/labeler/issues/577">#577</a> from actions/dependabot/npm_and_yarn/typescript-eslin...</li>
<li><a href="https://github.com/actions/labeler/commit/82a4f6fc258f3df5a7b4e3ea7c4076397f45b7f2"><code>82a4f6f</code></a> Merge pull request <a href="https://redirect.github.com/actions/labeler/issues/316">#316</a> from kachkaev/dot-option</li>
<li><a href="https://github.com/actions/labeler/commit/d40596e5db2302f8bd180870610f0059a6e3ace2"><code>d40596e</code></a> micromatch â minimatch</li>
<li><a href="https://github.com/actions/labeler/commit/3cbc54c641133d82f4d5f2bc850c8feff279337c"><code>3cbc54c</code></a> Merge pull request <a href="https://redirect.github.com/actions/labeler/issues/451">#451</a> from Youssef1313/patch-1</li>
<li><a href="https://github.com/actions/labeler/commit/639ba81ab1bba531e30a7d24861c54eb53982160"><code>639ba81</code></a> Rebuild</li>
<li><a href="https://github.com/actions/labeler/commit/71d2484daaf26523ee79447d458c78a3a1b122ee"><code>71d2484</code></a> Address review comment</li>
<li><a href="https://github.com/actions/labeler/commit/59d3310a72970937ed9bbdc21c5d457d287fb50e"><code>59d3310</code></a> Rebuild</li>
<li><a href="https://github.com/actions/labeler/commit/a78a6c7eb7714f46ddda8e1f2c243abd28ce713d"><code>a78a6c7</code></a> Update README.md</li>
<li>Additional commits viewable in <a href="https://github.com/actions/labeler/compare/0776a679364a9a16110aac8d0f40f5e11009e327...9fcb2c2f5584144ca754f8bfe8c6f81e77753375">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=actions/labeler&package-manager=github_actions&previous-version=4.0.4&new-version=4.1.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

c792a172

Roll Flutter Engine from 7f12e3497428 to 220ece4d9faa (6 revisions) (#128282) · 68b18918

engine-flutter-autoroll authored Jun 05, 2023

https://github.com/flutter/engine/compare/7f12e3497428...220ece4d9faa

2023-06-05 zanderso@users.noreply.github.com Ensure Dart roll script picks up udpates to dart-sdk/tools (flutter/engine#42576)
2023-06-05 chillers@google.com Run dependabot in off peak hours (flutter/engine#42572)
2023-06-05 flar@google.com fix bounds of inverted rendered rectangles (flutter/engine#42556)
2023-06-05 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from fgfgAhpxFpse7Xi4i... to tCxDcZ3yi0rnKGVHt... (flutter/engine#42574)
2023-06-05 kjlubick@users.noreply.github.com Add missing #include of SkCFObject.h (flutter/engine#42573)
2023-06-05 matej.knopp@gmail.com Improve getting non-overlapping rectangles from RTree (flutter/engine#42399)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from fgfgAhpxFpse to tCxDcZ3yi0rn

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

68b18918

[framework] attempt non-key solution (#128273) · 9881aa69

Jonah Williams authored Jun 05, 2023

Adds a special opacity widget that does not act like a repaint boundary.

Better solution for https://github.com/flutter/flutter/pull/128138

9881aa69

[labeler] Fix adding labels when name is directory (#128243) · 2be476d4
Casey Hillers authored Jun 05, 2023
```
https://github.com/flutter/flutter/issues/126002
```
2be476d4

Remove scrollbar deprecations isAlwaysShown and hoverThickness (#127351) · a3ddead1

Kate Lovett authored Jun 05, 2023

The deprecated `[RawScrollbar/Scrollbar/CupertinoScrollbar/ScrollbarThemeData].isAlwaysShown` has expired and is removed in thi PR.
Also, `Scrollbar.hoverThickness` is also removed after having expired.

The replacement for `isAlwaysShown` is `thumbVisibility`. This deprecation was introduced in #96957. The name change came from new behaviors like a track that is conditionally visible. Since the original API only referred to the thumb, the name was changed to reflect this intention. This change is supported by dart fix. â

The replacement for `hoverThickness` is `ScrollbarThemeData.thickness`, which is a MaterialStateProperty that allows for the thickness to respond to multiple states including hover. This deprecation was introduced in #97173. This change is not supported by dart fix. ð

Part of https://github.com/flutter/flutter/issues/127042

a3ddead1

Fix update drag error that made NestedScrollView un-scrollable (#127718) · 9a263466

Kate Lovett authored Jun 05, 2023

#### (plus some more docs)

Fixes https://github.com/flutter/flutter/issues/76760
Fixes https://github.com/flutter/flutter/issues/82391
Fixes https://github.com/flutter/flutter/issues/45619
Fixes #117316
Fixes #110956
Fixes #127282 
Fixes #32563
Fixes #46089 
Fixes #79077
Part of fixing #62833

This fixes (a bunch of) issues that have been reported differently over the years, but all have the same root cause. Sometimes the NestedScrollView would incorrectly calculate whether or not there is enough content to allow scrolling. This would only apply to drag scrolling (not mouse wheel scrolling for example). This did not relate to how the extent of the NestedScrollView is computed, but just the logic that enabled the actual drag gestures. This fixes that. :)

9a263466

Roll Flutter Engine from f9f72388a4da to 7f12e3497428 (4 revisions) (#128271) · 270b3d48

engine-flutter-autoroll authored Jun 05, 2023

https://github.com/flutter/engine/compare/f9f72388a4da...7f12e3497428

2023-06-05 matej.knopp@gmail.com Fix clang tidy error and crash (flutter/engine#42564)
2023-06-05 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from gp1k1agqxQIz0oTXV... to vAwdggqMrL1yoH_Zn... (flutter/engine#42570)
2023-06-05 zanderso@users.noreply.github.com Revert Dart SDK to 3.1.0-163.0.dev for branch alignment (flutter/engine#42569)
2023-06-05 zanderso@users.noreply.github.com Check more optional accesses (flutter/engine#42528)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from gp1k1agqxQIz to vAwdggqMrL1y

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

270b3d48

Migrate SemanticsBinding to onSemanticsActionEvent (#128254) · 17f86df8
Michael Goderbauer authored Jun 05, 2023
```
Follow-up to https://github.com/flutter/engine/pull/42493.
```
17f86df8

Roll Flutter Engine from c838a1b05924 to f9f72388a4da (19 revisions) (#128252) · 130e84ec

engine-flutter-autoroll authored Jun 05, 2023

https://github.com/flutter/engine/compare/c838a1b05924...f9f72388a4da

2023-06-05 zanderso@users.noreply.github.com Revert Dart SDK to
3.1.0-166.0.dev (flutter/engine#42568)
2023-06-05 skia-flutter-autoroll@skia.org Roll Skia from a10e944601cf to
a226cfbd6cc7 (1 revision) (flutter/engine#42562)
2023-06-05 kjlubick@users.noreply.github.com Add missing includes of
GrBackendSurface.h (flutter/engine#42563)
2023-06-05 49699333+dependabot[bot]@users.noreply.github.com Bump
github/codeql-action from 2.3.5 to 2.3.6 (flutter/engine#42561)
2023-06-05 skia-flutter-autoroll@skia.org Roll Skia from 210ad9cde42b to
a10e944601cf (3 revisions) (flutter/engine#42560)
2023-06-05 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from
sk-SFXAARqkT7wGmf... to fgfgAhpxFpse7Xi4i... (flutter/engine#42558)
2023-06-05 skia-flutter-autoroll@skia.org Manual roll Dart SDK from
d00a370c1fd3 to 5144119b99c8 (2 revisions) (flutter/engine#42557)
2023-06-05 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from
839LDf0p1Q4wyszA5... to gp1k1agqxQIz0oTXV... (flutter/engine#42553)
2023-06-04 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from
5pFMQIRHNENhekRDO... to sk-SFXAARqkT7wGmf... (flutter/engine#42551)
2023-06-04 skia-flutter-autoroll@skia.org Roll Skia from 8ca7bad9158f to
210ad9cde42b (1 revision) (flutter/engine#42549)
2023-06-04 skia-flutter-autoroll@skia.org Roll Skia from 611132d6ab8c to
8ca7bad9158f (1 revision) (flutter/engine#42548)
2023-06-04 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from
Bb9z8SjSCzRN6SVee... to 839LDf0p1Q4wyszA5... (flutter/engine#42544)
2023-06-04 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from
vVgQ12wNh2DIT_hV7... to 5pFMQIRHNENhekRDO... (flutter/engine#42543)
2023-06-03 skia-flutter-autoroll@skia.org Roll Skia from 0e80a97ccee3 to
611132d6ab8c (2 revisions) (flutter/engine#42542)
2023-06-03 skia-flutter-autoroll@skia.org Roll Skia from 98da8d7a299d to
0e80a97ccee3 (1 revision) (flutter/engine#42541)
2023-06-03 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from
VtLnfLmVda1_h1AtM... to Bb9z8SjSCzRN6SVee... (flutter/engine#42538)
2023-06-03 skia-flutter-autoroll@skia.org Roll Skia from 656de7fc6994 to
98da8d7a299d (1 revision) (flutter/engine#42537)
2023-06-03 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from
gcm-vsCu6IPUZZnN0... to vVgQ12wNh2DIT_hV7... (flutter/engine#42536)
2023-06-03 skia-flutter-autoroll@skia.org Manual roll Dart SDK from
d198f84f5e4e to d00a370c1fd3 (3 revisions) (flutter/engine#42535)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from VtLnfLmVda1_ to gp1k1agqxQIz
  fuchsia/sdk/core/mac-amd64 from gcm-vsCu6IPU to fgfgAhpxFpse

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on
the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

130e84ec

[framework] force flexible space background to rebuild. (#128138) · b3f32004

Jonah Williams authored Jun 05, 2023

Fixes https://github.com/flutter/flutter/issues/127836

The flexible scroll bar needs to rebuild even if the child/opacity hasn't changed. Force this with a value key.

b3f32004

Roll Packages from 75085edb54fe to db4e5c26ed3f (4 revisions) (#128246) · 1e70c52b

engine-flutter-autoroll authored Jun 05, 2023

https://github.com/flutter/packages/compare/75085edb54fe...db4e5c26ed3f

2023-06-05 engine-flutter-autoroll@skia.org Roll Flutter from 3db9504d to 0b741535 (108 revisions) (flutter/packages#4135)
2023-06-05 engine-flutter-autoroll@skia.org Roll Flutter (stable) from 9cd3d0d9ff05 to f92f44110e87 (4 revisions) (flutter/packages#4133)
2023-06-02 engine-flutter-autoroll@skia.org Roll Flutter from ee162e4b to 3db9504d (31 revisions) (flutter/packages#4098)
2023-06-02 43054281+camsim99@users.noreply.github.com [many] Bump most robolectric dependencies to version 4.10.3 (flutter/packages#4128)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

1e70c52b

03 Jun, 2023 3 commits

Roll Flutter Engine from 54293721816a to c838a1b05924 (2 revisions) (#128161) · 0b741535

engine-flutter-autoroll authored Jun 03, 2023

https://github.com/flutter/engine/compare/54293721816a...c838a1b05924

2023-06-03 skia-flutter-autoroll@skia.org Roll Skia from daf2219fec54 to 656de7fc6994 (23 revisions) (flutter/engine#42534)
2023-06-03 bdero@google.com Revert "[Impeller] Add Impeller Metal support in the embedder API (#42411)" (flutter/engine#42532)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

0b741535

Roll Flutter Engine from 8769e9ce3a90 to 54293721816a (8 revisions) (#128158) · 39adf1b3

engine-flutter-autoroll authored Jun 03, 2023

https://github.com/flutter/engine/compare/8769e9ce3a90...54293721816a

2023-06-03 jonahwilliams@google.com [Impeller] Fix 1-d grid computation
for compute (flutter/engine#42516)
2023-06-02 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from
PuYA-6NVHeHPlkCdk... to VtLnfLmVda1_h1AtM... (flutter/engine#42529)
2023-06-02 chris@bracken.jp [macOS] Top-left origin for PlatformView
container (flutter/engine#42523)
2023-06-02 skia-flutter-autoroll@skia.org Manual roll Dart SDK from
9d8df2a5210b to d198f84f5e4e (1 revision) (flutter/engine#42527)
2023-06-02 flar@google.com Revert "Reland "add non-rendering operation
culling to DisplayListBuilder" (#41463)" (flutter/engine#42525)
2023-06-02 godofredoc@google.com Move benchmarks no upload to staging.
(flutter/engine#42524)
2023-06-02 mdebbar@google.com [web] Support platform view creation
params (flutter/engine#42255)
2023-06-02 goderbauer@google.com MultiView changes for dart:ui
(flutter/engine#42493)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from PuYA-6NVHeHP to VtLnfLmVda1_

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on
the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

39adf1b3

Prefix for dart:ui multiview change (#128152) · dffd0c3a
Michael Goderbauer authored Jun 03, 2023
```
For https://github.com/flutter/engine/pull/42493.
```
dffd0c3a

02 Jun, 2023 20 commits

Roll dds dependency to 2.8.3 for expression evaluation upcoming fixes. (#128124) · 581ebe29

Alexander Aprelev authored Jun 02, 2023

The fix is coming as part of https://dart-review.git.corp.google.com/c/sdk/+/306908 dart sdk roll as well as https://github.com/flutter/flutter/pull/128084.

BUG=https://github.com/dart-lang/sdk/issues/52522

581ebe29

Roll Flutter Engine from f3f6a020595d to 8769e9ce3a90 (3 revisions) (#128149) · af5a9614

engine-flutter-autoroll authored Jun 02, 2023

https://github.com/flutter/engine/compare/f3f6a020595d...8769e9ce3a90

2023-06-02 godofredoc@google.com Use json for json blocks in docs. (flutter/engine#42521)
2023-06-02 mdebbar@google.com [web] New platform view API to get view by ID (flutter/engine#41784)
2023-06-02 jason-simmons@users.noreply.github.com Generate a unique temporary directory name in the iOS scenario test script (flutter/engine#42520)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

af5a9614

Roll Flutter Engine from b4250acbf3ca to f3f6a020595d (3 revisions) (#128147) · 6b69a74d

engine-flutter-autoroll authored Jun 02, 2023

https://github.com/flutter/engine/compare/b4250acbf3ca...f3f6a020595d

2023-06-02 jason-simmons@users.noreply.github.com Wrap concurrent message loop tasks in an autorelease pool on iOS/Mac platforms (flutter/engine#42459)
2023-06-02 godofredoc@google.com Update engine build config docs. (flutter/engine#41468)
2023-06-02 43054281+camsim99@users.noreply.github.com [Android] Bump unit test robolectric version to 4.10.3 (flutter/engine#42454)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

6b69a74d

Reland "Remove obsolete drawShadow bounds workaround (#127052)" (#127231) · 6f661135

Jim Graham authored Jun 02, 2023

This workaround was created 6 years ago with no links to bug databases to track. As best we can determine, the issue is no longer present in SkPicture or DisplayList and is most likely obsolete. More importantly, though, non-rendering primitives are ignored by the DisplayList construction and so this workaround will just be ignored anyway. If a problem surfaces about this issue that we haven't discovered by a thorough code search of the current code base, then workarounds should be installed within the relevant implementation modules rather than in the framework (and documented with bugs filed in either or both of Flutter's github repos, and/or the Skia issue database).

Workaround originally created in this PR: https://github.com/flutter/flutter/pull/9654

6f661135

Roll Flutter Engine from c6e9383f2143 to b4250acbf3ca (8 revisions) (#128142) · 0845d0d7

engine-flutter-autoroll authored Jun 02, 2023

https://github.com/flutter/engine/compare/c6e9383f2143...b4250acbf3ca

2023-06-02 737941+loic-sharma@users.noreply.github.com Manually roll ANGLE (flutter/engine#42169)
2023-06-02 jason-simmons@users.noreply.github.com [Impeller] Fix a bugprone-unchecked-optional-access warning in SurfaceMTL (flutter/engine#42518)
2023-06-02 amyles@google.com [web] Move announcement live elements to the end of the DOM and make them `div`s instead of `label`s. (flutter/engine#42432)
2023-06-02 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from JQRQ1nH1ILNA--N_b... to gcm-vsCu6IPUZZnN0... (flutter/engine#42515)
2023-06-02 godofredoc@google.com Add cpu as drone dimension to mac ios build. (flutter/engine#42514)
2023-06-02 godofredoc@google.com Move benchmarks no upload to a test. (flutter/engine#42356)
2023-06-02 43054281+camsim99@users.noreply.github.com [Android] Change Linux Android Emulator Tests to run on a device running API 33 (flutter/engine#42492)
2023-06-02 skia-flutter-autoroll@skia.org Roll Skia from 47b0db43f6a4 to daf2219fec54 (1 revision) (flutter/engine#42513)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from JQRQ1nH1ILNA to gcm-vsCu6IPU

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

0845d0d7

Pre-migration for dart:ui multi view changes (#128092) · e50b2507
Michael Goderbauer authored Jun 02, 2023
```
For https://github.com/flutter/engine/pull/42493.
```
e50b2507

Remove LiveTestRenderView (#127882) · 4cf89cc2

Michael Goderbauer authored Jun 02, 2023

In the multi view world, `RenderViews` are created by the `View` widget and no longer owned by the binding. Prior to this change, the `LiveTestWidgetsFlutterBinding` owned and managed a special subclass of `RenderView`, the `_LiveTestRenderView`. In the new world, where `RenderView`s can be created anywhere in the widget tree where a `View` widget is used, this setup is no longer feasible. This change removes this special `_LiveTestRenderView` and instead adds debug hocks to `RenderView` to allow the `LiveTestWidgetsFlutterBinding` to draw a debug overlay on top of the content of any `RenderView`.

4cf89cc2

Roll Flutter Engine from 02d6fbb68b69 to c6e9383f2143 (15 revisions) (#128119) · 6f8ef1a1

engine-flutter-autoroll authored Jun 02, 2023

https://github.com/flutter/engine/compare/02d6fbb68b69...c6e9383f2143

2023-06-02 jason-simmons@users.noreply.github.com [Impeller] clang-tidy fixes (flutter/engine#42503)
2023-06-02 103135467+sealesj@users.noreply.github.com Allow for optional label to trigger vuln scan on patch PRs (flutter/engine#42494)
2023-06-02 skia-flutter-autoroll@skia.org Roll Skia from 881a8df6f9e9 to 47b0db43f6a4 (1 revision) (flutter/engine#42512)
2023-06-02 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from X4Pkixxtt3BkjRW9P... to PuYA-6NVHeHPlkCdk... (flutter/engine#42511)
2023-06-02 skia-flutter-autoroll@skia.org Roll Skia from 7777ee2bf7ef to 881a8df6f9e9 (1 revision) (flutter/engine#42510)
2023-06-02 skia-flutter-autoroll@skia.org Roll Dart SDK from 3d4d29d8f16b to 9d8df2a5210b (2 revisions) (flutter/engine#42509)
2023-06-02 skia-flutter-autoroll@skia.org Roll Skia from 02e706e9761b to 7777ee2bf7ef (2 revisions) (flutter/engine#42508)
2023-06-02 skia-flutter-autoroll@skia.org Roll Skia from 0c75f1877b37 to 02e706e9761b (2 revisions) (flutter/engine#42506)
2023-06-02 dkwingsmt@users.noreply.github.com Revert "[Rasterizer] Make resubmit information temporary" (flutter/engine#42455)
2023-06-02 skia-flutter-autoroll@skia.org Roll Skia from f4854a3d009d to 0c75f1877b37 (1 revision) (flutter/engine#42505)
2023-06-02 skia-flutter-autoroll@skia.org Roll Dart SDK from 0d3c310fd6d9 to 3d4d29d8f16b (3 revisions) (flutter/engine#42502)
2023-06-02 skia-flutter-autoroll@skia.org Roll Skia from 082a7d1f72f7 to f4854a3d009d (4 revisions) (flutter/engine#42500)
2023-06-01 godofredoc@google.com Do not retry lint or clang tidy tests. (flutter/engine#42498)
2023-06-01 dnfield@google.com [Impeller] Compute in Vulkan (flutter/engine#42294)
2023-06-01 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from yqJfBsLdfLP4_vbFu... to JQRQ1nH1ILNA--N_b... (flutter/engine#42499)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from X4Pkixxtt3Bk to PuYA-6NVHeHP
fuchsia/sdk/core/mac-amd64 from yqJfBsLdfLP4 to JQRQ1nH1ILNA

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

6f8ef1a1

Tiny remove unnecessary method in text_selection.dart (#127480) · de368fca

fzyzcjy authored Jun 02, 2023

I come across this when migrating my codebase. There is indeed a linter rule for it: unnecessary_overrides (see screenshot below for an example). I can help enabling the rule (as well as other rules, and/or dart formatter, etc) for Flutter codebase if needed.

![image](https://github.com/flutter/flutter/assets/5236035/3fe8fa32-cde2-45a9-901a-a383e8457fa1)

de368fca

Workaround for Dart VM timeout (#127875) · cd18c8c0

Victoria Ashworth authored Jun 02, 2023

Workaround solution for: https://github.com/flutter/flutter/issues/121231
See https://github.com/flutter/flutter/issues/120808#issuecomment-1551826299 Error Case 2 for more information.

Sometimes the `ios-deploy` process does not return the logs from the application. We've been unable to figure out why. This is a solution to workaround that by using `idevicesyslog` alongside `ios-deploy` as a backup in getting the log for the Dart VM url. As explained in https://github.com/flutter/flutter/issues/120808#issuecomment-1551826299, when error case 2 happens, the `idevicesyslog` does successfully find the Dart VM.

Also, in the comments of the code it mentions `syslog` is not written on iOS 13+, this was added in response to this issue: https://github.com/flutter/flutter/issues/41133.

However, `idevicesyslog` does in fact work (at least for iOS 16), we use it to collect device logs for our CI tests already: https://github.com/flutter/flutter/blob/1dc26f80f04c1c1091a83c5fead9b3aa83483292/dev/devicelab/lib/framework/devices.dart#L998-L1006

cd18c8c0

Make --flutter-repo analyze whole repo (#127990) · 95cd3c03
Michael Goderbauer authored Jun 02, 2023
```
Fixes https://github.com/flutter/flutter/issues/127989.
```
95cd3c03

Roll Packages from f0513ae199e1 to 75085edb54fe (3 revisions) (#128121) · 7febf62c

engine-flutter-autoroll authored Jun 02, 2023

https://github.com/flutter/packages/compare/f0513ae199e1...75085edb54fe

2023-06-02 43054281+camsim99@users.noreply.github.com [camerax] Mock `InstanceManager` in unit tests (flutter/packages#4121)
2023-06-01 49699333+dependabot[bot]@users.noreply.github.com [image_picker]: Bump androidx.core:core from 1.9.0 to 1.10.1 in /packages/image_picker/image_picker_android/android (flutter/packages#3991)
2023-06-01 49699333+dependabot[bot]@users.noreply.github.com [image_picker]: Bump org.jetbrains.kotlin:kotlin-bom from 1.8.10 to 1.8.21 in /packages/image_picker/image_picker_android/android (flutter/packages#4054)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

7febf62c

[Refactor] fix quote style in template (#127762) · 87324ec0

Midori authored Jun 02, 2023

*Just replaced double quote to single.*

*this looks weird to me.*
![screenshot](https://github.com/flutter/flutter/assets/50433979/0bed4730-7fce-411e-b12f-24d478be13c3)

87324ec0

Roll Flutter Engine from 3a453f2ccb77 to 02d6fbb68b69 (14 revisions) (#128089) · 5e5966d8

engine-flutter-autoroll authored Jun 02, 2023

https://github.com/flutter/engine/compare/3a453f2ccb77...02d6fbb68b69

2023-06-01 jonahwilliams@google.com [Impeller] Emplace directly into host buffer (avoid VBB) for text data (flutter/engine#42484)
2023-06-01 john@johnmccutchan.com Ensure PlatformView engine life cycle callbacks are invoked (flutter/engine#42491)
2023-06-01 skia-flutter-autoroll@skia.org Roll Skia from c408e8e9cc96 to 082a7d1f72f7 (8 revisions) (flutter/engine#42496)
2023-06-01 leroux_bruno@yahoo.fr [Windows - TextInput] Insert new line only when TextInputAction.newline (flutter/engine#42244)
2023-06-01 zanderso@users.noreply.github.com Revert "Move clang tidy v2 build to prod." (flutter/engine#42495)
2023-06-01 linxunfeng@yeah.net Add myself to AUTHORS (flutter/engine#42406)
2023-06-01 bdero@google.com [Impeller] Add Impeller Metal support in the embedder API (flutter/engine#42411)
2023-06-01 jinhe.zjh@alibaba-inc.com Support DisposalMethod::kRestorePrevious in MultiFrameCodec and fix the apng problem. (flutter/engine#42153)
2023-06-01 smartercallum@gmail.com Fix crash getting spell-check suggestions (flutter/engine#42466)
2023-06-01 bdero@google.com Fix lint in rectangle packer (flutter/engine#42489)
2023-06-01 jason-simmons@users.noreply.github.com Wait for GL command completion in the ExternalTextureGLRefreshedTooOften test (flutter/engine#42438)
2023-06-01 mdebbar@google.com Reland "[web] Remove the JS API for url strategy (#42134)" (flutter/engine#42486)
2023-06-01 skia-flutter-autoroll@skia.org Roll Skia from f5bc3d12f0eb to c408e8e9cc96 (9 revisions) (flutter/engine#42487)
2023-06-01 kjlubick@users.noreply.github.com Clean up Skia includes around SkSurfaceCharacterization (flutter/engine#42485)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

5e5966d8

Fix typos in labels (#128093) · 5bbd8667
Michael Goderbauer authored Jun 02, 2023

5bbd8667

Revert "Fix issue where DevTools would not be immediately available when using... · fdb71de7

Zachary Anderson authored Jun 02, 2023

Revert "Fix issue where DevTools would not be immediately available when using --start-paused" (#128117)

Reverts flutter/flutter#126698

There are a bunch of tool crashes on CI that start with this commit. I'm
not sure this PR is the cause because there is no backtrace from the
tool on the crashes. The only error message is `Oops; flutter has exited
unexpectedly: "Null check operator used on a null value`.

fdb71de7

Sync Lints (#127976) · 60a87d07

Michael Goderbauer authored Jun 02, 2023

Syncs our lints with https://github.com/dart-lang/linter/blob/master/example/all.yaml:
* removed the deprecated `iterable_contains_unrelated_type` and `list_remove_unrelated_type` lints (their replacement `collection_methods_unrelated_type` was already enabled for us)
* enabled the new `no_self_assignments` and fixed one issue triggered by the lint.

60a87d07

Updated TabBar and ToggleButtons examples (#128088) · 4464d09d

Hans Muller authored Jun 02, 2023

Updated the ToggleButtons example and test to M3.

Updated the nested tabs test to avoid warnings like:
```
Warning: A call to tap() with finder "exactly one widget with type "Tab" which is an ancestor of text "Explore": Tab(text: "Explore", icon: Icon)" derived an Offset (Offset(666.7, 92.0)) that would not hit test on the specified widget.
```

4464d09d

Text should still be centered when search bar height is less than 48 (#128068) · ab70aea3

Qun Cheng authored Jun 02, 2023

Fixes #127092

This fix can solve the alignment issue in `SearchBar` but we still need to investigate the root cause for the `TextField`. The
text baseline of `TextField` doesn't change when the height is less than 48 and greater than 40. The problem should be related to the `minContainerHeight` which is 48 by default but the `contentHeight` has become smaller than this min value already. Setting `isDense`/`isCollapsed` to true gives the `minContainerHeight` a smaller number which is 0.0: https://github.com/flutter/flutter/blob/ff33555b239de4c17e7149db17eb70bcf5dee215/packages/flutter/lib/src/material/input_decorator.dart#L1086

Since [`isDense`](https://github.com/flutter/flutter/blob/ff33555b239de4c17e7149db17eb70bcf5dee215/packages/flutter/lib/src/material/input_decorator.dart#L3907) is used for the case where the text field has less vertical space, I just use this property in SearchBar.

https://github.com/flutter/flutter/assets/36861262/6ddc8e90-1b47-4dd5-9a57-59b86cafec6d

This is a demo to show the text baseline that doesn't change when we set the text field height under 48.
https://github.com/flutter/flutter/assets/36861262/ce2ee815-f1f5-493a-930e-0540a627bec8

ab70aea3

Roll pub packages (#128053) · 4a8780d2
Flutter GitHub Bot authored Jun 02, 2023
```
This PR was generated by `flutter update-packages --force-upgrade`.
```
4a8780d2

01 Jun, 2023 3 commits

Add `FilterChip.elevated`, `ChoiceChip.elevated`, & `ActionChip.elevated` variants (#128049) · 513ff44b
Taha Tesser authored Jun 01, 2023

513ff44b
Updated custom ListTile examples (#128071) · 14136ae3
Hans Muller authored Jun 01, 2023

14136ae3

Fix issue where DevTools would not be immediately available when using --start-paused (#126698) · 35174cc2

Ben Konyi authored Jun 01, 2023

Service extensions are unable to handle requests when the isolate they were registered on is paused. The DevTools launcher logic was waiting for some service extension invocations to complete before advertising the already active DevTools instance, but when --start-paused was provided these requests would never complete, preventing users from using DevTools to resume the paused isolate.

Fixes https://github.com/flutter/flutter/issues/126691

35174cc2