- 15 Sep, 2023 1 commit
-
-
chunhtai authored
â¦k settings the show build settings xcode command can only accept one of the target or scheme flag. Therefore I make them optional.
-
- 08 Sep, 2023 1 commit
-
-
chunhtai authored
ios version of https://github.com/flutter/flutter/pull/131009/files
-
- 31 Aug, 2023 1 commit
-
-
chunhtai authored
â¦on file The deeplink validation tool will become an static app so it can't no longer access vm services. The goal will be then to turn them into flutter analyze command similar to `flutter analyze --android --[options]` that static app can use on. This pr only removes vm services and turn the api to dump a output file instead of printing everything to stdout.
-
- 31 Jul, 2023 1 commit
-
-
gmackall authored
Partially fixes/related to: https://github.com/flutter/flutter/issues/131425
-
- 01 Jun, 2023 1 commit
-
-
Andrew Kolos authored
Fixes #124252, finishing work on the umbrella tracking issue, #126126. Essentially, after this PR, no (non-test) code should be be referencing/invoking the java home or binary paths.
-
- 20 May, 2023 1 commit
-
-
Andrew Kolos authored
Relands #126086, which was reverted by #126569.
-
- 11 May, 2023 2 commits
-
-
Andrew Kolos authored
Reverts flutter/flutter#126086. This PR changed the interfaces of some classes, namely `AndroidSdk`, and deleted a global. These classes had custom overrides in g3 that were not updated with a g3fix, so this PR has broken tests. See https://b.corp.google.com/issues/281945232 (non-public link)
-
Andrew Kolos authored
This is the first step in unifying Java-finding logic across the tool. If curious, see #126029 for an example of what all the changes will probably entail. Moves java-related functionality like `AndroidSdk.findJavaHome` to a new class, `Java`. See tracking issue https://github.com/flutter/flutter/issues/126126 for more.
-
- 04 May, 2023 1 commit
-
-
chunhtai authored
fixes https://github.com/flutter/flutter/issues/120405
-
- 05 Apr, 2023 1 commit
-
-
Reid Baker authored
https://github.com/flutter/flutter/issues/123917 Doc covering a broad set of issues related to android studio updating. https://docs.google.com/document/d/1hTXkjbUrBnXgu8NQsth1c3aEqo77rWoEj8CcsQ39wwQ/edit?pli=1# Specifically this pr: - Adds new functions to find a projects AGP, Gradle and java versions, and tests. - Adds new functions that take versions and parse if the versions are compatible with each other, and tests. - Adds validator for `flutter analyze --suggestions` that evaluates the java/gradle/agp versions and checks if they are compatible, and integration test. - Updates the version of gradle used by dev/integration_tests/flutter_gallery/ to the minimum supported by java 18 so that the integration tests pass (It is unknown why the java version is 18.9 instead of 11) - Moves `isWithinVersionRange` to version.dart, and tests. - Adds FakeAndroidStudio to fakes to be used in multiple tests but does not remove existing copies. Metrics will be included as part of the definition of done for this bug but not as part of this cl. It is already too big. Known work still left in this pr: * Understand why analyze integration tests are failing. Example output if Java and gradle are not compatible: ``` ┌───────────────────────────────────────────────────────────────────┐ │ General Info │ │ [✓] App Name: espresso_example │ │ [✓] Supported Platforms: android │ │ [✓] Is Flutter Package: yes │ │ [✓] Uses Material Design: yes │ │ [✓] Is Plugin: no │ │ [✗] Java/Gradle/Android Gradle Plugin: │ │ │ │ Incompatible Java/Gradle versions. │ │ │ │ Java Version: 17.0.6, Gradle Version: 7.0.2 │ │ │ │ See the link below for more information. │ │ https://docs.gradle.org/current/userguide/compatibility.html#java │ │ │ └───────────────────────────────────────────────────────────────────┘ ``` Example output if Gradle and AGP are not compatible ``` ┌─────────────────────────────────────────────────────────────────────────────┐ │ General Info │ │ [✓] App Name: espresso_example │ │ [✓] Supported Platforms: android │ │ [✓] Is Flutter Package: yes │ │ [✓] Uses Material Design: yes │ │ [✓] Is Plugin: no │ │ [✗] Java/Gradle/Android Gradle Plugin: Incompatible Gradle/AGP versions. │ │ │ │ Gradle Version: 7.0.2, AGP Version: 7.4.2 │ │ │ │ Update gradle to at least "7.5". │ │ See the link below for more information: │ │ https://developer.android.com/studio/releases/gradle-plugin#updating-gradle │ │ │ │ Incompatible Java/Gradle versions. │ │ │ │ Java Version: 17.0.6, Gradle Version: 7.0.2 │ │ │ │ See the link below for more information: │ │ https://docs.gradle.org/current/userguide/compatibility.html#java │ │ │ └─────────────────────────────────────────────────────────────────────────────┘ ``` Example output if Java/Gradle/Agp are not compatible. ``` ┌─────────────────────────────────────────────────────────────────────────────┐ │ General Info │ │ [✓] App Name: espresso_example │ │ [✓] Supported Platforms: android │ │ [✓] Is Flutter Package: yes │ │ [✓] Uses Material Design: yes │ │ [✓] Is Plugin: no │ │ [✗] Java/Gradle/Android Gradle Plugin: Incompatible Gradle/AGP versions. │ │ │ │ Gradle Version: 7.0.2, AGP Version: 7.4.2 │ │ │ │ Update gradle to at least "7.5". │ │ See the link below for more information: │ │ https://developer.android.com/studio/releases/gradle-plugin#updating-gradle │ │ │ │ Incompatible Java/Gradle versions. │ │ │ │ Java Version: 17.0.6, Gradle Version: 7.0.2 │ │ │ │ See the link below for more information: │ │ https://docs.gradle.org/current/userguide/compatibility.html#java │ │ │ └─────────────────────────────────────────────────────────────────────────────┘ ``` Commit messages - Add function to gradle_utils.dart that gets the gradle version from wrapper or system and add a test for each situation - Add method to get agp version, add method to validate agp against gradle version, update documentation, add tests for agp validation. - Update dart doc for validateGradleAndAgp to describe where the info came from and corner case behavior, create function to validate java and gradle and hardcode return to false - Fill out and test java gradle compatibility function in gradle_utils - Hook up java gradle evaluateion to hasValidJavaGradleAgpVersions with hardcoded java version - Add java --version output parsing and tests - Add getJavaBinary test - Update comment in android_sdk for mac behavior with java_home -v ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [ ] All existing and new tests are passing.
-
- 07 Nov, 2022 1 commit
-
-
Victoria Ashworth authored
* exclude xcworkspace that begins with a period * fix if spacing, add comment * add unit test for when no xcworkspace found * update to use xcodeWorkspace, make it nullable and refactor * check if hostAppRoot exists before trying to get xcworkspace * use local variables to take advantage of type promotion * only check if not null, don't need to check if exists * readd exist check for migrate * readd missing line at end of file
-
- 27 Oct, 2022 1 commit
-
-
Victoria Ashworth authored
-
- 25 Oct, 2022 3 commits
-
-
Jenn Magder authored
This reverts commit e1337218.
-
Victoria Ashworth authored
-
Alex Wallen authored
-
- 29 Aug, 2022 1 commit
-
-
Jonah Williams authored
-
- 29 Jul, 2022 1 commit
-
-
Gary Qian authored
-
- 13 Jul, 2022 1 commit
-
-
Christopher Fujino authored
-
- 12 Jul, 2022 1 commit
-
-
Anurag Roy authored
-
- 03 Jun, 2022 1 commit
-
-
Jenn Magder authored
-
- 02 May, 2022 1 commit
-
-
Jenn Magder authored
-
- 27 Apr, 2022 1 commit
-
-
Alexandre Ardhuin authored
-
- 02 Feb, 2022 1 commit
-
-
Lau Ching Jun authored
-
- 25 Jan, 2022 1 commit
-
-
stuartmorgan authored
The code to generate platform files used to use the presence of an 'example' folder to determine whether or not a project was a plugin (in which case that generation is bypassed). Later, robust detection was added based on the pubspec.yaml `plugin` key, but the old check was left in place. This creates false positives where people who add an example folder to their app project start getting mysterious failures. Since the pubspec check is definitive, there's no reason to continue to use the presence of `example` as an indicator at all. Fixes https://github.com/flutter/flutter/issues/87007
-
- 05 Jan, 2022 1 commit
-
-
Jenn Magder authored
-
- 07 Dec, 2021 1 commit
-
-
Gary Qian authored
-
- 06 Dec, 2021 1 commit
-
-
Gary Qian authored
-
- 20 Nov, 2021 1 commit
-
-
Andrei Diaconu authored
-
- 12 Nov, 2021 2 commits
-
-
Gary Qian authored
-
- 11 Nov, 2021 2 commits
-
-
Gary Qian authored
-
Greg Spencer authored
-
- 10 Nov, 2021 2 commits
-
-
Zachary Anderson authored
This reverts commit 6153bbef.
-
Gary Qian authored
-
- 07 Nov, 2021 1 commit
-
-
Zachary Anderson authored
This reverts commit 9038fac9.
-
- 05 Nov, 2021 3 commits
-
-
Andrei Diaconu authored
-
Zachary Anderson authored
This reverts commit 058dfd49.
-
Andrei Diaconu authored
-
- 02 Nov, 2021 1 commit
-
-
Jenn Magder authored
-
- 08 Oct, 2021 1 commit
-
-
Majid Hajian authored
-