Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
92d8b04b
Unverified
Commit
92d8b04b
authored
Oct 25, 2022
by
Alex Wallen
Committed by
GitHub
Oct 25, 2022
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
[macOS] Flavors project throws `no flavor specified` for creating a project. (#113979)
parent
b373be88
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
21 additions
and
3 deletions
+21
-3
project.dart
packages/flutter_tools/lib/src/project.dart
+10
-3
project_test.dart
packages/flutter_tools/test/general.shard/project_test.dart
+11
-0
No files found.
packages/flutter_tools/lib/src/project.dart
View file @
92d8b04b
...
...
@@ -138,9 +138,16 @@ class FlutterProject {
// Don't require iOS build info, this method is only
// used during create as best-effort, use the
// default target bundle identifier.
final
String
?
bundleIdentifier
=
await
ios
.
productBundleIdentifier
(
null
);
if
(
bundleIdentifier
!=
null
)
{
candidates
.
add
(
bundleIdentifier
);
try
{
final
String
?
bundleIdentifier
=
await
ios
.
productBundleIdentifier
(
null
);
if
(
bundleIdentifier
!=
null
)
{
candidates
.
add
(
bundleIdentifier
);
}
}
on
ToolExit
{
// It's possible that while parsing the build info for the ios project
// that the bundleIdentifier can't be resolve. However, we would like
// skip parsing that id in favor of searching in other place. We can
// consider a tool exit in this case to be non fatal for the program.
}
}
if
(
android
.
existsSync
())
{
...
...
packages/flutter_tools/test/general.shard/project_test.dart
View file @
92d8b04b
...
...
@@ -509,6 +509,17 @@ apply plugin: 'kotlin-android'
expect
(
await
project
.
ios
.
productBundleIdentifier
(
null
),
'io.flutter.someProject.suffix'
);
});
testWithMocks
(
'Always pass parsing org on ios project with flavors'
,
()
async
{
final
FlutterProject
project
=
await
someProject
();
addIosProjectFile
(
project
.
directory
,
projectFileContent:
()
{
return
projectFileWithBundleId
(
'io.flutter.someProject'
,
qualifier:
"'"
);
});
project
.
ios
.
xcodeProject
.
createSync
();
xcodeProjectInterpreter
.
xcodeProjectInfo
=
XcodeProjectInfo
(<
String
>[],
<
String
>[],
<
String
>[
'free'
,
'paid'
],
logger
);
expect
(
await
project
.
organizationNames
,
<
String
>[]);
});
testWithMocks
(
'fails with no flavor and defined schemes'
,
()
async
{
final
FlutterProject
project
=
await
someProject
();
project
.
ios
.
xcodeProject
.
createSync
();
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment