- 18 Jun, 2015 4 commits
-
-
Adam Barth authored
We can't have two copies of |embedder.dart| or |shell.dart| because they take ownership of some underlying Mojo handles. Instead of duplicating the code, this CL makes the old locations just export all the symbols from the new location. I've also done the same with fetch.dart to avoid code duplication. Finally, I've removed image_cache.dart in the old location because the only clients already live in the new world and ought to use the new location. TBR=ianh@google.com Review URL: https://codereview.chromium.org/1179923004.
-
Hixie authored
Some files are moved by this: Copy framework/node.dart into types/ - preparing for framework/'s decomissioning. Move app/scheduler.dart into sky/scheduler.dart - "app" doesn't really make sense. As part of the SkyBinding cleanup, I made the hit-testing less RenderBox-specific, by having the HitTestEntry.target member be a HitTestTarget, which is an interface with the handleEvent() function, which is then implemented by RenderBox. In theory, someone could now extend hit testing from the RenderBox world into their own tree of nodes, and take part in all the same dispatch logic automatically. This involved moving all the hit testing type definitions into a new sky/hittest.dart file. Renamed SkyBinding._app to SkyBinding._instance for clarity. Moved code around in SkyBinding so that related things are together. Made WidgetSkyBinding use the existing SkyBinding.instance singleton logic rather than having its own copy. I also added some stub README.md files that describe dependencies. R=abarth@chromium.org Review URL: https://codereview.chromium.org/1187393002.
-
Hixie authored
Move app/view.dart to rendering/sky_binding.dart since it's part of the RenderObject API, really (it knows about RenderView intimately). The tests pass. I didn't check every last example. R=abarth@chromium.org Review URL: https://codereview.chromium.org/1183913006.
-
Adam Barth authored
Also, trim the redundant |Mode| suffix from the TransferMode names. R=ianh@google.com Review URL: https://codereview.chromium.org/1188003006.
-
- 17 Jun, 2015 10 commits
-
-
Adam Barth authored
Buttons and menu items use onPressed. Also, don't pass along the sky.Event because that's a lower-level concept. I've also reordered parameter lists to put the |child| argument last in a number of places. Also, fixed a bug where FloatingActionButton was missing syncFields. R=ianh@google.com Review URL: https://codereview.chromium.org/1188993003.
-
Hans Muller authored
Defined constants for all 9 CSS font-weight values with conventional names from the "Common weight name mapping" section of https://developer.mozilla.org/en-US/docs/Web/CSS/font-weight. The FontWeight enum now just enumerates the actual CSS weight values. I've moved the TextStyle class into its own file. R=ianh@google.com Review URL: https://codereview.chromium.org/1173323004.
-
Hixie authored
This also moves the test for stocks into a new tests/examples/ directory, where we can put tests that test the examples. TBR=abarth Review URL: https://codereview.chromium.org/1182223004.
-
Hixie authored
TBR=abarth Review URL: https://codereview.chromium.org/1194473004.
-
Hixie authored
This removes the requirement that things with the same type things have unique keys. Now, anything without a key is assumed to be interchangeable. R=abarth@chromium.org Review URL: https://codereview.chromium.org/1178723010.
-
Collin Jackson authored
R=ianh@google.com TBR=hixie Review URL: https://codereview.chromium.org/1185283004.
-
Adam Barth authored
The underlying problem is that we lacked a RenderObjectWrapper for the RenderView, which meant we couldn't handle changing the RenderObject that was the root of the RenderView. This CL introduces a RenderViewWrapper and uses it in a new AppContainer widget root. This change allows us to make App a non-magical Component that is inserted into the AppContainer in the newly introduced runApp function. R=ianh@google.com Review URL: https://codereview.chromium.org/1184823006.
-
Collin Jackson authored
R=abarth@chromium.org, abarth Review URL: https://codereview.chromium.org/1195493002.
-
Collin Jackson authored
This fixes the test TBR=abarth Review URL: https://codereview.chromium.org/1192533002.
-
Collin Jackson authored
R=abarth@chromium.org, abarth Review URL: https://codereview.chromium.org/1191863002.
-
- 16 Jun, 2015 10 commits
-
-
Hans Muller authored
This is a completion of Eric's WIP patch: https://codereview.chromium.org/1179663005/ Low level support for creating a paragraph that contains runs of styled text. The styles may be nested. The Paragraph and RenderParagraph classes have been replaced by Inline and RenderInline. Styled text is defined with a tree of InlineText and InlineStyle objects. R=abarth@chromium.org Review URL: https://codereview.chromium.org/1177833012.
-
Collin Jackson authored
R=abarth@chromium.org, abarth, hixie Review URL: https://codereview.chromium.org/1181773006.
-
Hixie authored
Also, move a widget example from examples/raw/ to examples/widgets/ R=abarth@chromium.org Review URL: https://codereview.chromium.org/1190793002.
-
Viktor Lidholt authored
R=abarth@chromium.org Review URL: https://codereview.chromium.org/1187153002.
-
Collin Jackson authored
R=abarth@chromium.org, abarth, hixie Review URL: https://codereview.chromium.org/1186273002.
-
Hixie authored
TBR=abarth Review URL: https://codereview.chromium.org/1187463013.
-
Hixie authored
Create an example app that demonstrates interactive coordination of an fn tree and a raw RenderObject tree. Sector changes: - implement the intrinsic sizing box API on RenderBoxToRenderSectorAdapter - remove some debug print statements - fix getIntrinsicDimensions() on RenderSolidColor to return true values - factor out the default demo RenderObject changes: - BoxConstraints.isInfinite() now returns true only if both dimensions are infinite fn changes: - implement UINodeToRenderBoxAdapter - rename RenderObjectToUINodeAdapter to RenderBoxToUINodeAdapter Tests: - add a test for sector layout - make TestRenderView support being run without the unit test framework R=abarth@chromium.org Review URL: https://codereview.chromium.org/1175423007.
-
Adam Barth authored
We need the key to be a String even though we claimed we could support any Object. Also, clean up some style nits including shortening the |root| getters on OneChildRenderNodeWrappers. Fixes https://github.com/domokit/sky_sdk/issues/26. TBR=ianh@google.com Review URL: https://codereview.chromium.org/1173293005.
-
Adam Barth authored
FlexExpandingChild -> Flexible StackPositionedChild -> Positioned Also, name the child argument |child| for consistency. TBR=ianh@google.com Review URL: https://codereview.chromium.org/1179763009.
-
Hixie authored
R=jackson@google.com Review URL: https://codereview.chromium.org/1179943005.
-
- 15 Jun, 2015 5 commits
-
-
Hixie authored
Make old users of RenderSizedBox use RenderConstrainedBox. Change the semantics of BoxDecoration.apply* to actually apply the provided constraints to the current constraints, rather than the previous behaviour of merging them neutrally. R=abarth@chromium.org Review URL: https://codereview.chromium.org/1189603003.
-
Collin Jackson authored
R=ianh@google.com, hixie Review URL: https://codereview.chromium.org/1190573002.
-
Collin Jackson authored
TBR=hixie Review URL: https://codereview.chromium.org/1188573004.
-
Hans Muller authored
Make stock2 exactly match the original stock demo. R=ianh@google.com Review URL: https://codereview.chromium.org/1187563006.
-
Viktor Lidholt authored
Deletes old test game Demo game is now playable Updates demo game with steering and changes in sprites Fixes smaller bugs in sprites Refactor class names in game demo Strips Box2D from game Fixes ordering in game node Adds frameRate property to SpriteBox and improves update methods. Fixes node to box transformations for hit tests Fixes minor code issues R=abarth@chromium.org Review URL: https://codereview.chromium.org/1179333002.
-
- 13 Jun, 2015 3 commits
-
-
Adam Barth authored
This CL moves the bulk of the SkyView code out of the |framework| directory because the |framework| directory was redundant in Dart package import declarations. TBR=ianh@google.com Review URL: https://codereview.chromium.org/1177383006.
-
Adam Barth authored
Although the basic widgets are wrappers, that's an implementation detail and shouldn't be encoded in the name of the library. TBR=ianh@google.com Review URL: https://codereview.chromium.org/1182983002.
-
Hixie authored
Verify that callers correctly set parentUsesSize if they use the child's size (and fix a few cases that didn't). This introduces a bunch of code that should only run in debug builds, but we don't have #ifdefs yet. R=abarth@chromium.org Review URL: https://codereview.chromium.org/1182933003.
-
- 12 Jun, 2015 5 commits
-
-
Adam Barth authored
R=ianh@google.com, eseidel@chromium.org Review URL: https://codereview.chromium.org/1178293004.
-
Hixie authored
Make it easier to debug examples/widgets/container.dart, since it is currently showing a crazy clipping/transform bug. TBR=abarth Review URL: https://codereview.chromium.org/1186653003.
-
Adam Barth authored
We can use these intents to move the demo launcher to the new world. R=eseidel@chromium.org Review URL: https://codereview.chromium.org/1187583002.
-
Eric Seidel authored
This is a completion of Hans's WIP patch: https://codereview.chromium.org/1176133002/ Makes it possible for us to style text in fn2 apps. The title style in the toolbar doesn't look quite right but as far as I can tell its the same color as the old typography code produced. Will need further investigation. Fixes #213 R=abarth@chromium.org, jackson@google.com Review URL: https://codereview.chromium.org/1178913003.
-
Hixie authored
Make Material actually create material, with opinions about what that means. Make FloatingActionButton use this. Make Scrollable use this. Make BoxDecoration support drawing a circle instead of a rectangle, so that floating action button doesn't need a custom painter. Implement RaisedButton (and remove button.dart, since there's no "button" in Material Design). Make InkWell have a "child" argument instead of "children", and not have it introduce a Flex into the hierarchy. Update container.dart example. Clean up some imports. R=abarth@chromium.org Review URL: https://codereview.chromium.org/1179713004.
-
- 11 Jun, 2015 3 commits
-
-
Hixie authored
Make it possible to test that the stock app doesn't crash on startup and paints the basic scaffold more or less correctly. R=abarth@chromium.org Review URL: https://codereview.chromium.org/1177043008.
-
Eric Seidel authored
I also removed the leading /, so it is now possible to use shelldb start sky/sky_home to test. Also fixed touch_demo.dart and sector layout to work and not crash. R=ianh@google.com Review URL: https://codereview.chromium.org/1177343002.
-
Adam Barth authored
The back button now triggers an event of type |back|. R=eseidel@chromium.org, jackson@chromium.org Review URL: https://codereview.chromium.org/1176373004.
-