1. 13 Nov, 2019 1 commit
  2. 10 Oct, 2019 1 commit
    • Greg Spencer's avatar
      Re-land keyboard traversal PRs (#42278) · ce150971
      Greg Spencer authored
      This attempts to reland #40186 and #41220, that were reverted in #41945.
      
      The main modifications from the original PRs are that I predefine the shortcuts and actions maps instead of defining them inline in the build function, and I use a new mapEquals to do a deep comparison so that we don't rebuild modified things if the contents of the map haven't changed.
      
      I also eliminated an operator== and hashCode that were defined on the Actions widget, since widgets shouldn't have those. (it's too bad though: I get an 85% speedup if we leave this in! Too bad it prevents rebuilding of the children...)
      
      Fixes #40101
      ce150971
  3. 02 Oct, 2019 1 commit
  4. 30 Sep, 2019 1 commit
  5. 24 Sep, 2019 1 commit
  6. 25 Jun, 2019 1 commit
  7. 13 Jun, 2019 1 commit
  8. 10 May, 2019 1 commit
  9. 04 May, 2019 1 commit
  10. 03 May, 2019 1 commit
  11. 29 Apr, 2019 2 commits
  12. 23 Apr, 2019 1 commit
  13. 22 Apr, 2019 1 commit
  14. 10 Apr, 2019 1 commit
  15. 01 Mar, 2019 1 commit
    • Alexandre Ardhuin's avatar
      Add missing trailing commas (#28673) · 387f8854
      Alexandre Ardhuin authored
      * add trailing commas on list/map/parameters
      
      * add trailing commas on Invocation with nb of arg>1
      
      * add commas for widget containing widgets
      
      * add trailing commas if instantiation contains trailing comma
      
      * revert bad change
      387f8854
  16. 21 Feb, 2019 1 commit
  17. 06 Feb, 2019 1 commit
  18. 04 Feb, 2019 1 commit
    • Ian Hickson's avatar
      [H] Tabs (#27477) · 7b618005
      Ian Hickson authored
      * Crash when a TabBar is put in a BottomAppBar.
      
      * Tabs bugs (e.g. crash on transparent material)
      
      - Tabs would crash when placed on transparent Materials
      - Tabs would fail to render the child if an icon was specified
      7b618005
  19. 15 Dec, 2018 1 commit
  20. 13 Dec, 2018 1 commit
  21. 11 Dec, 2018 1 commit
  22. 19 Nov, 2018 1 commit
  23. 01 Oct, 2018 1 commit
  24. 14 Sep, 2018 1 commit
  25. 13 Sep, 2018 1 commit
  26. 12 Sep, 2018 1 commit
  27. 11 Sep, 2018 1 commit
    • Dan Field's avatar
      Fix keepalive for large jumps on tabs and lists. (#21350) · 98ad574d
      Dan Field authored
      * Ensure that the _childElements map is properly traversed as a sparse list and not inflated with garbage collected children.
      
      * Add tests to ensure Lists/Tabs with KeepAlive children can make large jumps, don't lose children (including after rebuild).
      98ad574d
  28. 22 Aug, 2018 1 commit
  29. 02 Aug, 2018 1 commit
  30. 27 Jul, 2018 1 commit
  31. 23 Jul, 2018 1 commit
  32. 16 Jul, 2018 2 commits
  33. 03 Jul, 2018 1 commit
    • Greg Price's avatar
      Round properly to nearest page in TabBarView. (#16868) · 84f5b1cb
      Greg Price authored
      This logic is described in the test as looking for a scroll ending
      very close to a new page, but in fact its behavior is more like
      "very close to a page to the right": if we're not very, very close
      to any page, it will pick the page to the left, not an old page.
      
      There's no reason this should be left-right asymmetrical.
      Instead, pick the nearest page.
      
      In practice, the case where this makes a difference never arises when
      the scroll runs undisturbed to completion; but when the user taps on
      the page to hold or drag, the scroll will be interrupted before it
      gets within tolerance of a particular page, and this case does arise.
      
      This fixes a glitch that is hard to trigger without time dilation,
      but is quite conspicuous with it:
      
       * Open a tab view with at least 4 tabs, e.g. the Buttons screen
         of the gallery (with "Animate Slowly" on.)
       * Starting at tab 0, tap tab 2.
       * When the animation is nearly complete, tap the page a couple
         of times, as if to drag it around to scroll.  Then let the
         page view settle ballistically toward page 2.
       * Before it finishes, tap tab 3.
       * Suddenly page 1 fills the view, replacing page 2, before we
         scroll from there to page 3.
      
      With this fix, the animation in the last step moves smoothly from
      where we are when it starts onward to page 3.
      84f5b1cb
  34. 13 Jun, 2018 1 commit
    • Chris Bracken's avatar
      Revert elimination of Dart 1 (#18460) · 2ae48845
      Chris Bracken authored
      fuchsia_tester.dart still assumes Dart 1. Previously, it ran tests directly
      from source, flutter_platform.dart automatically runs a kernel compile when
      operating in Dart 2 mode, but this assumes a functional Dart SDK is available
      in the artifacts directly, and fuchsia_tester.dart mocks out the artifacts
      directory with an empty temp dir.
      
      Remaining work is:
      1. Get the frontend server building as a dependency on Fuchsia.
      2. Patch fuchsia_tester.dart to use a valid Dart SDK and frontend server.
      
      This also reverts migration to Dart 2 typedef syntax.
      
      This reverts commit 6c56bb24. (#18362)
      This reverts commit 3daebd05. (#18316)
      2ae48845
  35. 11 Jun, 2018 1 commit
    • Greg Spencer's avatar
      Update typedef syntax to use Function notation and turn on lint for old notation. (#18362) · 6c56bb24
      Greg Spencer authored
      Now that Dart 1 is turned off, reapplying my change to turn on the prefer_generic_function_type_aliases analysis option, and fix all the typedefs to Dart 2 preferred syntax.
      
      Also eliminated the unused analysis_options_repo.yaml file and turned on public_member_api_docs in analysys_options.yaml.
      
      No logic changes, just changing the typedef syntax for all typedefs, and updating analysis options.
      6c56bb24
  36. 05 Jun, 2018 1 commit
  37. 30 May, 2018 2 commits